From: Philipp Zabel <p.zabel@pengutronix.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Richard Zhu <hongxing.zhu@nxp.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Jingoo Han <jingoohan1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support
Date: Fri, 05 Oct 2018 12:59:16 +0200 [thread overview]
Message-ID: <1538737156.3545.22.camel@pengutronix.de> (raw)
In-Reply-To: <20181005102906.GA25651@red-moon>
Hi Lorenzo,
On Fri, 2018-10-05 at 11:29 +0100, Lorenzo Pieralisi wrote:
> On Thu, Oct 04, 2018 at 04:34:30PM +0000, Leonard Crestez wrote:
> > When the root complex suspends it must send a PME_Turn_Off TLP.
> > Implement this by asserting the "turnoff" reset.
> >
> > On imx7d this functionality is part of the SRC and exposed through the
> > linux reset-controller subsystem. On imx6 equivalent bits are in the
> > IOMUXC GPR area which the imx6-pcie driver accesses directly.
>
> Nit: I am merging the series, please define what SRC and GPR are so
> that I can update the commit log accordingly, it must be clear to
> anyone reading it.
SRC is the System Reset Controller, which controls reset signals to all
kinds of devices, among them the PCIe PHY.
IOMUXC GPR is a General Purpose Register range in the IOMUXC (pinmux
controller) that is used to control various signals all over the SoC.
regards
Philipp
next prev parent reply other threads:[~2018-10-05 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 16:34 [PATCH v2 0/4] PCI: imx: Add PME_Turn_Off support Leonard Crestez
2018-10-04 16:34 ` [PATCH v2 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF Leonard Crestez
2018-10-04 16:47 ` Philipp Zabel
2018-10-04 17:08 ` Lorenzo Pieralisi
2018-10-04 20:41 ` Leonard Crestez
2018-10-04 16:34 ` [PATCH v2 2/4] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d Leonard Crestez
2018-10-04 16:34 ` [PATCH v2 3/4] ARM: dts: imx7d: Add turnoff reset Leonard Crestez
2018-10-04 16:34 ` [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support Leonard Crestez
2018-10-04 16:44 ` Lucas Stach
2018-10-05 10:29 ` Lorenzo Pieralisi
2018-10-05 10:59 ` Philipp Zabel [this message]
2018-10-05 11:08 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538737156.3545.22.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@nxp.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.