All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
@ 2018-10-05 22:26 clinton.a.taylor
  2018-10-06  0:17 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 18+ messages in thread
From: clinton.a.taylor @ 2018-10-05 22:26 UTC (permalink / raw)
  To: Intel-gfx

From: Clint Taylor <clinton.a.taylor@intel.com>

HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N
value mode instead of HDMI specification values.

Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 769f3f5..4b8f6f6 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -144,6 +144,8 @@ struct dp_aud_n_m {
 /* HDMI N/CTS table */
 #define TMDS_297M 297000
 #define TMDS_296M 296703
+#define TMDS_594M 594000
+#define TMDS_593M 593407
 static const struct {
 	int sample_rate;
 	int clock;
@@ -164,6 +166,20 @@ struct dp_aud_n_m {
 	{ 176400, TMDS_297M, 18816, 247500 },
 	{ 192000, TMDS_296M, 23296, 281250 },
 	{ 192000, TMDS_297M, 20480, 247500 },
+	{ 44100, TMDS_593M, 8918, 937500 },
+	{ 44100, TMDS_594M, 9408, 990000 },
+	{ 48000, TMDS_593M, 5824, 562500 },
+	{ 48000, TMDS_594M, 6144, 594000 },
+	{ 32000, TMDS_593M, 5824, 843750 },
+	{ 32000, TMDS_594M, 3072, 445500 },
+	{ 88200, TMDS_593M, 17836, 937500 },
+	{ 88200, TMDS_594M, 9408, 990000 },
+	{ 96000, TMDS_593M, 11648, 562500 },
+	{ 96000, TMDS_594M, 12288, 594000 },
+	{ 176400, TMDS_593M, 35672, 937500 },
+	{ 176400, TMDS_594M, 37632, 990000 },
+	{ 192000, TMDS_593M, 23296, 562500 },
+	{ 192000, TMDS_594M, 24576, 594000 },
 };
 
 /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
@ 2018-10-06  0:17 ` Patchwork
  2018-10-06  8:11 ` ✓ Fi.CI.IGT: " Patchwork
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-10-06  0:17 UTC (permalink / raw)
  To: clinton.a.taylor; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
URL   : https://patchwork.freedesktop.org/series/50649/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4945 -> Patchwork_10384 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50649/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10384 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-bdw-samus:       NOTRUN -> INCOMPLETE (fdo#107773)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       INCOMPLETE (fdo#107773) -> PASS

    igt@kms_flip@basic-flip-vs-dpms:
      fi-hsw-4770r:       DMESG-WARN (fdo#105602) -> PASS

    
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773


== Participating hosts (44 -> 39) ==

  Additional (1): fi-glk-j4005 
  Missing    (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-snb-2520m fi-ctg-p8600 


== Build changes ==

    * Linux: CI_DRM_4945 -> Patchwork_10384

  CI_DRM_4945: d9b2bbbdba15cadca76ffd3ff0476e71222d671b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4671: b121f7d42c260ae3a050c3f440d1c11f7cff7d1a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10384: a2d11757d7ee70d9dc36dd6161ccffd9744b5a8e @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

a2d11757d7ee drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10384/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* ✓ Fi.CI.IGT: success for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
  2018-10-06  0:17 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-06  8:11 ` Patchwork
  2018-10-15 11:24 ` [PATCH] " Jani Nikula
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-10-06  8:11 UTC (permalink / raw)
  To: clinton.a.taylor; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
URL   : https://patchwork.freedesktop.org/series/50649/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4945_full -> Patchwork_10384_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_10384_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10384_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10384_full:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_10384_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_cpu_reloc@full:
      shard-skl:          NOTRUN -> INCOMPLETE (fdo#108073)

    igt@gem_exec_schedule@pi-ringfull-blt:
      shard-skl:          NOTRUN -> FAIL (fdo#103158) +1
      shard-apl:          NOTRUN -> FAIL (fdo#103158)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL (fdo#106641)

    igt@kms_busy@extended-modeset-hang-newfb-render-c:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
      shard-apl:          NOTRUN -> DMESG-WARN (fdo#107956) +3

    igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
      shard-apl:          NOTRUN -> FAIL (fdo#105458, fdo#106510)
      shard-skl:          NOTRUN -> FAIL (fdo#105458)

    igt@kms_cursor_crc@cursor-128x128-onscreen:
      shard-apl:          PASS -> FAIL (fdo#103232)

    igt@kms_cursor_crc@cursor-128x128-random:
      shard-skl:          NOTRUN -> FAIL (fdo#103232)

    igt@kms_cursor_crc@cursor-256x256-random:
      shard-glk:          PASS -> FAIL (fdo#103232)

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#106538, fdo#105763)

    igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
      shard-glk:          PASS -> DMESG-FAIL (fdo#103167, fdo#106538)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
      shard-apl:          PASS -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-skl:          NOTRUN -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL (fdo#103167) +6

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#106885)

    {igt@kms_plane_alpha_blend@pipe-a-alpha-7efc}:
      shard-skl:          NOTRUN -> FAIL (fdo#108145) +5

    {igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max}:
      shard-glk:          PASS -> FAIL (fdo#108145) +1

    {igt@kms_plane_alpha_blend@pipe-a-coverage-7efc}:
      shard-glk:          PASS -> DMESG-FAIL (fdo#106538)

    {igt@kms_plane_alpha_blend@pipe-b-alpha-7efc}:
      shard-apl:          NOTRUN -> FAIL (fdo#108146) +1

    {igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb}:
      shard-apl:          NOTRUN -> FAIL (fdo#108145) +1

    {igt@kms_plane_alpha_blend@pipe-c-alpha-7efc}:
      shard-kbl:          NOTRUN -> FAIL (fdo#108146)
      shard-skl:          NOTRUN -> FAIL (fdo#108146) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          PASS -> FAIL (fdo#103166)
      shard-apl:          PASS -> FAIL (fdo#103166)

    igt@kms_setmode@basic:
      shard-snb:          NOTRUN -> FAIL (fdo#99912)

    igt@kms_sysfs_edid_timing:
      shard-skl:          NOTRUN -> FAIL (fdo#100047)

    igt@kms_universal_plane@universal-plane-pipe-c-functional:
      shard-apl:          NOTRUN -> FAIL (fdo#103166)

    
    ==== Possible fixes ====

    igt@kms_color@pipe-b-legacy-gamma:
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-256x256-dpms:
      shard-glk:          FAIL (fdo#103232) -> PASS +2

    igt@kms_cursor_crc@cursor-64x21-random:
      shard-apl:          FAIL (fdo#103232) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-apl:          FAIL (fdo#103167) -> PASS +2

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
      shard-glk:          FAIL (fdo#103167) -> PASS +7

    igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
      shard-apl:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
  fdo#105458 https://bugs.freedesktop.org/show_bug.cgi?id=105458
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106510 https://bugs.freedesktop.org/show_bug.cgi?id=106510
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 6) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4945 -> Patchwork_10384

  CI_DRM_4945: d9b2bbbdba15cadca76ffd3ff0476e71222d671b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4671: b121f7d42c260ae3a050c3f440d1c11f7cff7d1a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10384: a2d11757d7ee70d9dc36dd6161ccffd9744b5a8e @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10384/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
  2018-10-06  0:17 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-10-06  8:11 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-15 11:24 ` Jani Nikula
  2018-10-15 11:31   ` Jani Nikula
  2018-10-25 18:51 ` [PATCH 0/2] HDMI 2.0 clock recovery values clinton.a.taylor
                   ` (4 subsequent siblings)
  7 siblings, 1 reply; 18+ messages in thread
From: Jani Nikula @ 2018-10-15 11:24 UTC (permalink / raw)
  To: clinton.a.taylor, Intel-gfx

On Fri, 05 Oct 2018, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N
> value mode instead of HDMI specification values.
>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_audio.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 769f3f5..4b8f6f6 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -144,6 +144,8 @@ struct dp_aud_n_m {
>  /* HDMI N/CTS table */
>  #define TMDS_297M 297000
>  #define TMDS_296M 296703
> +#define TMDS_594M 594000
> +#define TMDS_593M 593407
>  static const struct {
>  	int sample_rate;
>  	int clock;
> @@ -164,6 +166,20 @@ struct dp_aud_n_m {
>  	{ 176400, TMDS_297M, 18816, 247500 },
>  	{ 192000, TMDS_296M, 23296, 281250 },
>  	{ 192000, TMDS_297M, 20480, 247500 },
> +	{ 44100, TMDS_593M, 8918, 937500 },
> +	{ 44100, TMDS_594M, 9408, 990000 },
> +	{ 48000, TMDS_593M, 5824, 562500 },
> +	{ 48000, TMDS_594M, 6144, 594000 },
> +	{ 32000, TMDS_593M, 5824, 843750 },
> +	{ 32000, TMDS_594M, 3072, 445500 },
> +	{ 88200, TMDS_593M, 17836, 937500 },
> +	{ 88200, TMDS_594M, 9408, 990000 },

The N here should be 18816. The rest looks good.

BR,
Jani.

> +	{ 96000, TMDS_593M, 11648, 562500 },
> +	{ 96000, TMDS_594M, 12288, 594000 },
> +	{ 176400, TMDS_593M, 35672, 937500 },
> +	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 192000, TMDS_593M, 23296, 562500 },
> +	{ 192000, TMDS_594M, 24576, 594000 },
>  };
>  
>  /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-15 11:24 ` [PATCH] " Jani Nikula
@ 2018-10-15 11:31   ` Jani Nikula
  2018-10-25 18:56     ` Clint Taylor
  0 siblings, 1 reply; 18+ messages in thread
From: Jani Nikula @ 2018-10-15 11:31 UTC (permalink / raw)
  To: clinton.a.taylor, Intel-gfx

On Mon, 15 Oct 2018, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Fri, 05 Oct 2018, clinton.a.taylor@intel.com wrote:
>> From: Clint Taylor <clinton.a.taylor@intel.com>
>>
>> HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N
>> value mode instead of HDMI specification values.
>>
>> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_audio.c | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>> index 769f3f5..4b8f6f6 100644
>> --- a/drivers/gpu/drm/i915/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>> @@ -144,6 +144,8 @@ struct dp_aud_n_m {
>>  /* HDMI N/CTS table */
>>  #define TMDS_297M 297000
>>  #define TMDS_296M 296703
>> +#define TMDS_594M 594000
>> +#define TMDS_593M 593407
>>  static const struct {
>>  	int sample_rate;
>>  	int clock;
>> @@ -164,6 +166,20 @@ struct dp_aud_n_m {
>>  	{ 176400, TMDS_297M, 18816, 247500 },
>>  	{ 192000, TMDS_296M, 23296, 281250 },
>>  	{ 192000, TMDS_297M, 20480, 247500 },
>> +	{ 44100, TMDS_593M, 8918, 937500 },
>> +	{ 44100, TMDS_594M, 9408, 990000 },
>> +	{ 48000, TMDS_593M, 5824, 562500 },
>> +	{ 48000, TMDS_594M, 6144, 594000 },
>> +	{ 32000, TMDS_593M, 5824, 843750 },
>> +	{ 32000, TMDS_594M, 3072, 445500 },
>> +	{ 88200, TMDS_593M, 17836, 937500 },
>> +	{ 88200, TMDS_594M, 9408, 990000 },
>
> The N here should be 18816. The rest looks good.

PS. This should probably have Cc: stable.

Could I persuade you to write a cleanup patch on top to re-arrange the
array in groups:

	/* multiples of 32 kHz */
	/* multiples of 44.1 kHz */
	/* multiples of 48 kHz */

with each group in increasing audio sample frequency, I'll review it in
same go. Otherwise, I'll write the patch myself. The current ordering is
a PITA to review against the spec...

BR,
Jani.

>
> BR,
> Jani.
>
>> +	{ 96000, TMDS_593M, 11648, 562500 },
>> +	{ 96000, TMDS_594M, 12288, 594000 },
>> +	{ 176400, TMDS_593M, 35672, 937500 },
>> +	{ 176400, TMDS_594M, 37632, 990000 },
>> +	{ 192000, TMDS_593M, 23296, 562500 },
>> +	{ 192000, TMDS_594M, 24576, 594000 },
>>  };
>>  
>>  /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 0/2] HDMI 2.0 clock recovery values
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
                   ` (2 preceding siblings ...)
  2018-10-15 11:24 ` [PATCH] " Jani Nikula
@ 2018-10-25 18:51 ` clinton.a.taylor
  2018-10-25 18:52   ` [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
  2018-10-25 18:52   ` [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
  2018-10-25 19:27 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2) Patchwork
                   ` (3 subsequent siblings)
  7 siblings, 2 replies; 18+ messages in thread
From: clinton.a.taylor @ 2018-10-25 18:51 UTC (permalink / raw)
  To: Intel-gfx

From: Clint Taylor <clinton.a.taylor@intel.com>

Added HDMI 2.0 N and CTS values for 594 Pixel clock modes. Reorganized
structure to group by Audio Sample Frequency

Clint Taylor (2):
  drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  drm/i915/hdmi: Reorder structure to match specification

 drivers/gpu/drm/i915/intel_audio.c | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-25 18:51 ` [PATCH 0/2] HDMI 2.0 clock recovery values clinton.a.taylor
@ 2018-10-25 18:52   ` clinton.a.taylor
  2018-10-26  7:04       ` Jani Nikula
  2018-10-25 18:52   ` [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
  1 sibling, 1 reply; 18+ messages in thread
From: clinton.a.taylor @ 2018-10-25 18:52 UTC (permalink / raw)
  To: Intel-gfx; +Cc: Clint Taylor, Jani Nikula, stable

From: Clint Taylor <clinton.a.taylor@intel.com>

HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N value
mode instead of HDMI specification values.

V2: Fix 88.2 Hz N value

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 769f3f5..ee3ca2d 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -144,6 +144,9 @@ struct dp_aud_n_m {
 /* HDMI N/CTS table */
 #define TMDS_297M 297000
 #define TMDS_296M 296703
+#define TMDS_594M 594000
+#define TMDS_593M 593407
+
 static const struct {
 	int sample_rate;
 	int clock;
@@ -164,6 +167,20 @@ struct dp_aud_n_m {
 	{ 176400, TMDS_297M, 18816, 247500 },
 	{ 192000, TMDS_296M, 23296, 281250 },
 	{ 192000, TMDS_297M, 20480, 247500 },
+	{ 44100, TMDS_593M, 8918, 937500 },
+	{ 44100, TMDS_594M, 9408, 990000 },
+	{ 48000, TMDS_593M, 5824, 562500 },
+	{ 48000, TMDS_594M, 6144, 594000 },
+	{ 32000, TMDS_593M, 5824, 843750 },
+	{ 32000, TMDS_594M, 3072, 445500 },
+	{ 88200, TMDS_593M, 17836, 937500 },
+	{ 88200, TMDS_594M, 18816, 990000 },
+	{ 96000, TMDS_593M, 11648, 562500 },
+	{ 96000, TMDS_594M, 12288, 594000 },
+	{ 176400, TMDS_593M, 35672, 937500 },
+	{ 176400, TMDS_594M, 37632, 990000 },
+	{ 192000, TMDS_593M, 23296, 562500 },
+	{ 192000, TMDS_594M, 24576, 594000 },
 };
 
 /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification
  2018-10-25 18:51 ` [PATCH 0/2] HDMI 2.0 clock recovery values clinton.a.taylor
  2018-10-25 18:52   ` [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
@ 2018-10-25 18:52   ` clinton.a.taylor
  2018-10-26 10:23       ` Jani Nikula
  1 sibling, 1 reply; 18+ messages in thread
From: clinton.a.taylor @ 2018-10-25 18:52 UTC (permalink / raw)
  To: Intel-gfx; +Cc: Clint Taylor, Jani Nikula, stable

From: Clint Taylor <clinton.a.taylor@intel.com>

reorder structure of 297, 594 N values to group Audio Sample Frequencies
together to make updating from HDMI specification easier.

V2: Match patch 1/2 version

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: stable@vger.kernel.org

Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index ee3ca2d..47caecb 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -153,32 +153,32 @@ struct dp_aud_n_m {
 	int n;
 	int cts;
 } hdmi_aud_ncts[] = {
-	{ 44100, TMDS_296M, 4459, 234375 },
-	{ 44100, TMDS_297M, 4704, 247500 },
-	{ 48000, TMDS_296M, 5824, 281250 },
-	{ 48000, TMDS_297M, 5120, 247500 },
 	{ 32000, TMDS_296M, 5824, 421875 },
 	{ 32000, TMDS_297M, 3072, 222750 },
+	{ 44100, TMDS_296M, 4459, 234375 },
+	{ 44100, TMDS_297M, 4704, 247500 },
 	{ 88200, TMDS_296M, 8918, 234375 },
 	{ 88200, TMDS_297M, 9408, 247500 },
-	{ 96000, TMDS_296M, 11648, 281250 },
-	{ 96000, TMDS_297M, 10240, 247500 },
 	{ 176400, TMDS_296M, 17836, 234375 },
 	{ 176400, TMDS_297M, 18816, 247500 },
+	{ 48000, TMDS_296M, 5824, 281250 },
+	{ 48000, TMDS_297M, 5120, 247500 },
+	{ 96000, TMDS_296M, 11648, 281250 },
+	{ 96000, TMDS_297M, 10240, 247500 },
 	{ 192000, TMDS_296M, 23296, 281250 },
 	{ 192000, TMDS_297M, 20480, 247500 },
-	{ 44100, TMDS_593M, 8918, 937500 },
-	{ 44100, TMDS_594M, 9408, 990000 },
-	{ 48000, TMDS_593M, 5824, 562500 },
-	{ 48000, TMDS_594M, 6144, 594000 },
 	{ 32000, TMDS_593M, 5824, 843750 },
 	{ 32000, TMDS_594M, 3072, 445500 },
+	{ 44100, TMDS_593M, 8918, 937500 },
+	{ 44100, TMDS_594M, 9408, 990000 },
 	{ 88200, TMDS_593M, 17836, 937500 },
 	{ 88200, TMDS_594M, 18816, 990000 },
-	{ 96000, TMDS_593M, 11648, 562500 },
-	{ 96000, TMDS_594M, 12288, 594000 },
 	{ 176400, TMDS_593M, 35672, 937500 },
 	{ 176400, TMDS_594M, 37632, 990000 },
+	{ 48000, TMDS_593M, 5824, 562500 },
+	{ 48000, TMDS_594M, 6144, 594000 },
+	{ 96000, TMDS_593M, 11648, 562500 },
+	{ 96000, TMDS_594M, 12288, 594000 },
 	{ 192000, TMDS_593M, 23296, 562500 },
 	{ 192000, TMDS_594M, 24576, 594000 },
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-15 11:31   ` Jani Nikula
@ 2018-10-25 18:56     ` Clint Taylor
  0 siblings, 0 replies; 18+ messages in thread
From: Clint Taylor @ 2018-10-25 18:56 UTC (permalink / raw)
  To: Jani Nikula, Intel-gfx



On 10/15/2018 04:31 AM, Jani Nikula wrote:
> On Mon, 15 Oct 2018, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>> On Fri, 05 Oct 2018, clinton.a.taylor@intel.com wrote:
>>> From: Clint Taylor <clinton.a.taylor@intel.com>
>>>
>>> HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N
>>> value mode instead of HDMI specification values.
>>>
>>> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/intel_audio.c | 16 ++++++++++++++++
>>>   1 file changed, 16 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>>> index 769f3f5..4b8f6f6 100644
>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>> @@ -144,6 +144,8 @@ struct dp_aud_n_m {
>>>   /* HDMI N/CTS table */
>>>   #define TMDS_297M 297000
>>>   #define TMDS_296M 296703
>>> +#define TMDS_594M 594000
>>> +#define TMDS_593M 593407
>>>   static const struct {
>>>   	int sample_rate;
>>>   	int clock;
>>> @@ -164,6 +166,20 @@ struct dp_aud_n_m {
>>>   	{ 176400, TMDS_297M, 18816, 247500 },
>>>   	{ 192000, TMDS_296M, 23296, 281250 },
>>>   	{ 192000, TMDS_297M, 20480, 247500 },
>>> +	{ 44100, TMDS_593M, 8918, 937500 },
>>> +	{ 44100, TMDS_594M, 9408, 990000 },
>>> +	{ 48000, TMDS_593M, 5824, 562500 },
>>> +	{ 48000, TMDS_594M, 6144, 594000 },
>>> +	{ 32000, TMDS_593M, 5824, 843750 },
>>> +	{ 32000, TMDS_594M, 3072, 445500 },
>>> +	{ 88200, TMDS_593M, 17836, 937500 },
>>> +	{ 88200, TMDS_594M, 9408, 990000 },
>> The N here should be 18816. The rest looks good.
Good catch. I'll make the change in v2.
> PS. This should probably have Cc: stable.
Done
>
> Could I persuade you to write a cleanup patch on top to re-arrange the
> array in groups:
>
> 	/* multiples of 32 kHz */
> 	/* multiples of 44.1 kHz */
> 	/* multiples of 48 kHz */
>
> with each group in increasing audio sample frequency, I'll review it in
> same go. Otherwise, I'll write the patch myself. The current ordering is
> a PITA to review against the spec...
patch 2/2 send with structure reorganized by Sample Frequency.

TODO: add N/CTS values for 30 and 36 bit 297Mhz modes.

-Clint

>
> BR,
> Jani.
>
>> BR,
>> Jani.
>>
>>> +	{ 96000, TMDS_593M, 11648, 562500 },
>>> +	{ 96000, TMDS_594M, 12288, 594000 },
>>> +	{ 176400, TMDS_593M, 35672, 937500 },
>>> +	{ 176400, TMDS_594M, 37632, 990000 },
>>> +	{ 192000, TMDS_593M, 23296, 562500 },
>>> +	{ 192000, TMDS_594M, 24576, 594000 },
>>>   };
>>>   
>>>   /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2)
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
                   ` (3 preceding siblings ...)
  2018-10-25 18:51 ` [PATCH 0/2] HDMI 2.0 clock recovery values clinton.a.taylor
@ 2018-10-25 19:27 ` Patchwork
  2018-10-25 19:50 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-10-25 19:27 UTC (permalink / raw)
  To: Clint Taylor; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2)
URL   : https://patchwork.freedesktop.org/series/50649/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e2ad180a5f8f drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N value

total: 0 errors, 1 warnings, 0 checks, 29 lines checked
bd7c3e303cda drm/i915/hdmi: Reorder structure to match specification

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2)
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
                   ` (4 preceding siblings ...)
  2018-10-25 19:27 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2) Patchwork
@ 2018-10-25 19:50 ` Patchwork
  2018-10-26  2:07 ` ✓ Fi.CI.IGT: " Patchwork
  2018-10-31 20:54 ` [PATCH v3] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
  7 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-10-25 19:50 UTC (permalink / raw)
  To: Clint Taylor; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2)
URL   : https://patchwork.freedesktop.org/series/50649/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5037 -> Patchwork_10584 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50649/revisions/2/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10584 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_sanitycheck:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#107726)

    
    ==== Possible fixes ====

    igt@kms_busy@basic-flip-c:
      fi-glk-j4005:       DMESG-WARN (fdo#106000) -> PASS

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      DMESG-WARN (fdo#105998) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-glk-j4005:       FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@pm_rpm@module-reload:
      fi-glk-j4005:       DMESG-WARN (fdo#107726) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726


== Participating hosts (46 -> 44) ==

  Additional (1): fi-icl-u 
  Missing    (3): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan 


== Build changes ==

    * Linux: CI_DRM_5037 -> Patchwork_10584

  CI_DRM_5037: e11750586cb6054bd319ad217cecd045febaacc5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4694: ff8d1156723f235e82cb4fcfd2cd6e5a5bb211fa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10584: bd7c3e303cdaf8ecf19136ef1135f517e3b9c7c4 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

bd7c3e303cda drm/i915/hdmi: Reorder structure to match specification
e2ad180a5f8f drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10584/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* ✓ Fi.CI.IGT: success for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2)
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
                   ` (5 preceding siblings ...)
  2018-10-25 19:50 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-10-26  2:07 ` Patchwork
  2018-10-31 20:54 ` [PATCH v3] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
  7 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-10-26  2:07 UTC (permalink / raw)
  To: Clint Taylor; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2)
URL   : https://patchwork.freedesktop.org/series/50649/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5037_full -> Patchwork_10584_full =

== Summary - SUCCESS ==

  No regressions found.

  

== Known issues ==

  Here are the changes found in Patchwork_10584_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@pi-ringfull-blt:
      shard-skl:          NOTRUN -> FAIL (fdo#103158)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-skl:          NOTRUN -> TIMEOUT (fdo#108039)

    igt@gem_userptr_blits@readonly-unsync:
      shard-skl:          PASS -> INCOMPLETE (fdo#108074)

    igt@kms_busy@extended-modeset-hang-newfb-render-b:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_color@pipe-c-legacy-gamma:
      shard-apl:          PASS -> FAIL (fdo#104782)

    igt@kms_cursor_crc@cursor-256x256-dpms:
      shard-glk:          PASS -> FAIL (fdo#103232) +4

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#106538, fdo#105763) +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-glk:          PASS -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-apl:          PASS -> FAIL (fdo#103167) +4

    igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
      shard-skl:          NOTRUN -> FAIL (fdo#108146)

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          PASS -> FAIL (fdo#108145) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-apl:          PASS -> FAIL (fdo#103166) +1

    igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
      shard-glk:          PASS -> FAIL (fdo#103166) +2

    igt@kms_setmode@basic:
      shard-skl:          NOTRUN -> FAIL (fdo#99912)

    igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
      shard-apl:          PASS -> DMESG-FAIL (fdo#108549) +1

    igt@kms_vblank@pipe-c-wait-busy-hang:
      shard-apl:          PASS -> DMESG-WARN (fdo#108549) +24

    igt@pm_rpm@system-suspend-devices:
      shard-skl:          NOTRUN -> INCOMPLETE (fdo#107807)

    
    ==== Possible fixes ====

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
      shard-apl:          DMESG-FAIL (fdo#108549) -> PASS +3

    igt@kms_atomic_transition@plane-all-modeset-transition:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          FAIL (fdo#106641) -> PASS

    igt@kms_color@pipe-b-ctm-blue-to-red:
      shard-apl:          DMESG-WARN (fdo#108549) -> PASS +21

    igt@kms_color@pipe-c-degamma:
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-apl:          FAIL (fdo#103232) -> PASS +3

    igt@kms_cursor_crc@cursor-256x256-random:
      shard-glk:          FAIL (fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
      shard-glk:          FAIL (fdo#103167) -> PASS +4

    igt@kms_frontbuffer_tracking@fbc-badstride:
      shard-skl:          FAIL (fdo#105682) -> PASS

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
      shard-skl:          FAIL (fdo#103167) -> PASS +1

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
      shard-skl:          FAIL (fdo#103166) -> PASS

    igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
      shard-glk:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          FAIL (fdo#103166) -> PASS +1

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
  fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
  fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
  fdo#108549 https://bugs.freedesktop.org/show_bug.cgi?id=108549
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (6 -> 6) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_5037 -> Patchwork_10584

  CI_DRM_5037: e11750586cb6054bd319ad217cecd045febaacc5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4694: ff8d1156723f235e82cb4fcfd2cd6e5a5bb211fa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10584: bd7c3e303cdaf8ecf19136ef1135f517e3b9c7c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10584/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
  2018-10-25 18:52   ` [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
@ 2018-10-26  7:04       ` Jani Nikula
  0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2018-10-26  7:04 UTC (permalink / raw)
  To: clinton.a.taylor, Intel-gfx; +Cc: Clint Taylor, stable

On Thu, 25 Oct 2018, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N value
> mode instead of HDMI specification values.
>
> V2: Fix 88.2 Hz N value
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>

Pushed to dinq, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/intel_audio.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 769f3f5..ee3ca2d 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -144,6 +144,9 @@ struct dp_aud_n_m {
>  /* HDMI N/CTS table */
>  #define TMDS_297M 297000
>  #define TMDS_296M 296703
> +#define TMDS_594M 594000
> +#define TMDS_593M 593407
> +
>  static const struct {
>  	int sample_rate;
>  	int clock;
> @@ -164,6 +167,20 @@ struct dp_aud_n_m {
>  	{ 176400, TMDS_297M, 18816, 247500 },
>  	{ 192000, TMDS_296M, 23296, 281250 },
>  	{ 192000, TMDS_297M, 20480, 247500 },
> +	{ 44100, TMDS_593M, 8918, 937500 },
> +	{ 44100, TMDS_594M, 9408, 990000 },
> +	{ 48000, TMDS_593M, 5824, 562500 },
> +	{ 48000, TMDS_594M, 6144, 594000 },
> +	{ 32000, TMDS_593M, 5824, 843750 },
> +	{ 32000, TMDS_594M, 3072, 445500 },
> +	{ 88200, TMDS_593M, 17836, 937500 },
> +	{ 88200, TMDS_594M, 18816, 990000 },
> +	{ 96000, TMDS_593M, 11648, 562500 },
> +	{ 96000, TMDS_594M, 12288, 594000 },
> +	{ 176400, TMDS_593M, 35672, 937500 },
> +	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 192000, TMDS_593M, 23296, 562500 },
> +	{ 192000, TMDS_594M, 24576, 594000 },
>  };
>  
>  /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values
@ 2018-10-26  7:04       ` Jani Nikula
  0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2018-10-26  7:04 UTC (permalink / raw)
  To: Intel-gfx; +Cc: Clint Taylor, stable

On Thu, 25 Oct 2018, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> HDMI 2.0 594Mhz modes were incorrectly selecting 25.200Mhz Automatic N value
> mode instead of HDMI specification values.
>
> V2: Fix 88.2 Hz N value
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>

Pushed to dinq, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/intel_audio.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 769f3f5..ee3ca2d 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -144,6 +144,9 @@ struct dp_aud_n_m {
>  /* HDMI N/CTS table */
>  #define TMDS_297M 297000
>  #define TMDS_296M 296703
> +#define TMDS_594M 594000
> +#define TMDS_593M 593407
> +
>  static const struct {
>  	int sample_rate;
>  	int clock;
> @@ -164,6 +167,20 @@ struct dp_aud_n_m {
>  	{ 176400, TMDS_297M, 18816, 247500 },
>  	{ 192000, TMDS_296M, 23296, 281250 },
>  	{ 192000, TMDS_297M, 20480, 247500 },
> +	{ 44100, TMDS_593M, 8918, 937500 },
> +	{ 44100, TMDS_594M, 9408, 990000 },
> +	{ 48000, TMDS_593M, 5824, 562500 },
> +	{ 48000, TMDS_594M, 6144, 594000 },
> +	{ 32000, TMDS_593M, 5824, 843750 },
> +	{ 32000, TMDS_594M, 3072, 445500 },
> +	{ 88200, TMDS_593M, 17836, 937500 },
> +	{ 88200, TMDS_594M, 18816, 990000 },
> +	{ 96000, TMDS_593M, 11648, 562500 },
> +	{ 96000, TMDS_594M, 12288, 594000 },
> +	{ 176400, TMDS_593M, 35672, 937500 },
> +	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 192000, TMDS_593M, 23296, 562500 },
> +	{ 192000, TMDS_594M, 24576, 594000 },
>  };
>  
>  /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification
  2018-10-25 18:52   ` [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
@ 2018-10-26 10:23       ` Jani Nikula
  0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2018-10-26 10:23 UTC (permalink / raw)
  To: clinton.a.taylor, Intel-gfx; +Cc: Clint Taylor, stable

On Thu, 25 Oct 2018, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> reorder structure of 297, 594 N values to group Audio Sample Frequencies
> together to make updating from HDMI specification easier.

Communication is hard...

I was looking for sorting the entire table first by sample_rate
multiples, then by clock, just like in the HDMI 2.0 tables 9-5 and
on. First sample rates 32 kHz, then 44.1/88.2/176.4 kHz, then
48/96/192/384 kHz. Within each group (table), sort by TMDS rate.

> V2: Match patch 1/2 version
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: stable@vger.kernel.org

This one doesn't need to be cc: stable.

BR,
Jani.

>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_audio.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index ee3ca2d..47caecb 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -153,32 +153,32 @@ struct dp_aud_n_m {
>  	int n;
>  	int cts;
>  } hdmi_aud_ncts[] = {
> -	{ 44100, TMDS_296M, 4459, 234375 },
> -	{ 44100, TMDS_297M, 4704, 247500 },
> -	{ 48000, TMDS_296M, 5824, 281250 },
> -	{ 48000, TMDS_297M, 5120, 247500 },
>  	{ 32000, TMDS_296M, 5824, 421875 },
>  	{ 32000, TMDS_297M, 3072, 222750 },
> +	{ 44100, TMDS_296M, 4459, 234375 },
> +	{ 44100, TMDS_297M, 4704, 247500 },
>  	{ 88200, TMDS_296M, 8918, 234375 },
>  	{ 88200, TMDS_297M, 9408, 247500 },
> -	{ 96000, TMDS_296M, 11648, 281250 },
> -	{ 96000, TMDS_297M, 10240, 247500 },
>  	{ 176400, TMDS_296M, 17836, 234375 },
>  	{ 176400, TMDS_297M, 18816, 247500 },
> +	{ 48000, TMDS_296M, 5824, 281250 },
> +	{ 48000, TMDS_297M, 5120, 247500 },
> +	{ 96000, TMDS_296M, 11648, 281250 },
> +	{ 96000, TMDS_297M, 10240, 247500 },
>  	{ 192000, TMDS_296M, 23296, 281250 },
>  	{ 192000, TMDS_297M, 20480, 247500 },
> -	{ 44100, TMDS_593M, 8918, 937500 },
> -	{ 44100, TMDS_594M, 9408, 990000 },
> -	{ 48000, TMDS_593M, 5824, 562500 },
> -	{ 48000, TMDS_594M, 6144, 594000 },
>  	{ 32000, TMDS_593M, 5824, 843750 },
>  	{ 32000, TMDS_594M, 3072, 445500 },
> +	{ 44100, TMDS_593M, 8918, 937500 },
> +	{ 44100, TMDS_594M, 9408, 990000 },
>  	{ 88200, TMDS_593M, 17836, 937500 },
>  	{ 88200, TMDS_594M, 18816, 990000 },
> -	{ 96000, TMDS_593M, 11648, 562500 },
> -	{ 96000, TMDS_594M, 12288, 594000 },
>  	{ 176400, TMDS_593M, 35672, 937500 },
>  	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 48000, TMDS_593M, 5824, 562500 },
> +	{ 48000, TMDS_594M, 6144, 594000 },
> +	{ 96000, TMDS_593M, 11648, 562500 },
> +	{ 96000, TMDS_594M, 12288, 594000 },
>  	{ 192000, TMDS_593M, 23296, 562500 },
>  	{ 192000, TMDS_594M, 24576, 594000 },
>  };

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification
@ 2018-10-26 10:23       ` Jani Nikula
  0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2018-10-26 10:23 UTC (permalink / raw)
  To: Intel-gfx; +Cc: Clint Taylor, stable

On Thu, 25 Oct 2018, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> reorder structure of 297, 594 N values to group Audio Sample Frequencies
> together to make updating from HDMI specification easier.

Communication is hard...

I was looking for sorting the entire table first by sample_rate
multiples, then by clock, just like in the HDMI 2.0 tables 9-5 and
on. First sample rates 32 kHz, then 44.1/88.2/176.4 kHz, then
48/96/192/384 kHz. Within each group (table), sort by TMDS rate.

> V2: Match patch 1/2 version
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: stable@vger.kernel.org

This one doesn't need to be cc: stable.

BR,
Jani.

>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_audio.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index ee3ca2d..47caecb 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -153,32 +153,32 @@ struct dp_aud_n_m {
>  	int n;
>  	int cts;
>  } hdmi_aud_ncts[] = {
> -	{ 44100, TMDS_296M, 4459, 234375 },
> -	{ 44100, TMDS_297M, 4704, 247500 },
> -	{ 48000, TMDS_296M, 5824, 281250 },
> -	{ 48000, TMDS_297M, 5120, 247500 },
>  	{ 32000, TMDS_296M, 5824, 421875 },
>  	{ 32000, TMDS_297M, 3072, 222750 },
> +	{ 44100, TMDS_296M, 4459, 234375 },
> +	{ 44100, TMDS_297M, 4704, 247500 },
>  	{ 88200, TMDS_296M, 8918, 234375 },
>  	{ 88200, TMDS_297M, 9408, 247500 },
> -	{ 96000, TMDS_296M, 11648, 281250 },
> -	{ 96000, TMDS_297M, 10240, 247500 },
>  	{ 176400, TMDS_296M, 17836, 234375 },
>  	{ 176400, TMDS_297M, 18816, 247500 },
> +	{ 48000, TMDS_296M, 5824, 281250 },
> +	{ 48000, TMDS_297M, 5120, 247500 },
> +	{ 96000, TMDS_296M, 11648, 281250 },
> +	{ 96000, TMDS_297M, 10240, 247500 },
>  	{ 192000, TMDS_296M, 23296, 281250 },
>  	{ 192000, TMDS_297M, 20480, 247500 },
> -	{ 44100, TMDS_593M, 8918, 937500 },
> -	{ 44100, TMDS_594M, 9408, 990000 },
> -	{ 48000, TMDS_593M, 5824, 562500 },
> -	{ 48000, TMDS_594M, 6144, 594000 },
>  	{ 32000, TMDS_593M, 5824, 843750 },
>  	{ 32000, TMDS_594M, 3072, 445500 },
> +	{ 44100, TMDS_593M, 8918, 937500 },
> +	{ 44100, TMDS_594M, 9408, 990000 },
>  	{ 88200, TMDS_593M, 17836, 937500 },
>  	{ 88200, TMDS_594M, 18816, 990000 },
> -	{ 96000, TMDS_593M, 11648, 562500 },
> -	{ 96000, TMDS_594M, 12288, 594000 },
>  	{ 176400, TMDS_593M, 35672, 937500 },
>  	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 48000, TMDS_593M, 5824, 562500 },
> +	{ 48000, TMDS_594M, 6144, 594000 },
> +	{ 96000, TMDS_593M, 11648, 562500 },
> +	{ 96000, TMDS_594M, 12288, 594000 },
>  	{ 192000, TMDS_593M, 23296, 562500 },
>  	{ 192000, TMDS_594M, 24576, 594000 },
>  };

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v3] drm/i915/hdmi: Reorder structure to match specification
  2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
                   ` (6 preceding siblings ...)
  2018-10-26  2:07 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-31 20:54 ` clinton.a.taylor
  2018-11-15 14:04   ` Jani Nikula
  7 siblings, 1 reply; 18+ messages in thread
From: clinton.a.taylor @ 2018-10-31 20:54 UTC (permalink / raw)
  To: Intel-gfx

From: Clint Taylor <clinton.a.taylor@intel.com>

reorder structure of 297, 594 N values to group Audio Sample Frequencies
together to make updating from HDMI specification easier.

V2: Match patch 1/2 version
V3: Arrange by sample freq, then pixel clock.

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index ccd88da..ae55a68 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -153,32 +153,32 @@ struct dp_aud_n_m {
 	int n;
 	int cts;
 } hdmi_aud_ncts[] = {
-	{ 44100, TMDS_296M, 4459, 234375 },
-	{ 44100, TMDS_297M, 4704, 247500 },
-	{ 48000, TMDS_296M, 5824, 281250 },
-	{ 48000, TMDS_297M, 5120, 247500 },
 	{ 32000, TMDS_296M, 5824, 421875 },
 	{ 32000, TMDS_297M, 3072, 222750 },
+	{ 32000, TMDS_593M, 5824, 843750 },
+	{ 32000, TMDS_594M, 3072, 445500 },
+	{ 44100, TMDS_296M, 4459, 234375 },
+	{ 44100, TMDS_297M, 4704, 247500 },
+	{ 44100, TMDS_593M, 8918, 937500 },
+	{ 44100, TMDS_594M, 9408, 990000 },
 	{ 88200, TMDS_296M, 8918, 234375 },
 	{ 88200, TMDS_297M, 9408, 247500 },
-	{ 96000, TMDS_296M, 11648, 281250 },
-	{ 96000, TMDS_297M, 10240, 247500 },
+	{ 88200, TMDS_593M, 17836, 937500 },
+	{ 88200, TMDS_594M, 18816, 990000 },
 	{ 176400, TMDS_296M, 17836, 234375 },
 	{ 176400, TMDS_297M, 18816, 247500 },
-	{ 192000, TMDS_296M, 23296, 281250 },
-	{ 192000, TMDS_297M, 20480, 247500 },
-	{ 44100, TMDS_593M, 8918, 937500 },
-	{ 44100, TMDS_594M, 9408, 990000 },
+	{ 176400, TMDS_593M, 35672, 937500 },
+	{ 176400, TMDS_594M, 37632, 990000 },
+	{ 48000, TMDS_296M, 5824, 281250 },
+	{ 48000, TMDS_297M, 5120, 247500 },
 	{ 48000, TMDS_593M, 5824, 562500 },
 	{ 48000, TMDS_594M, 6144, 594000 },
-	{ 32000, TMDS_593M, 5824, 843750 },
-	{ 32000, TMDS_594M, 3072, 445500 },
-	{ 88200, TMDS_593M, 17836, 937500 },
-	{ 88200, TMDS_594M, 18816, 990000 },
+	{ 96000, TMDS_296M, 11648, 281250 },
+	{ 96000, TMDS_297M, 10240, 247500 },
 	{ 96000, TMDS_593M, 11648, 562500 },
 	{ 96000, TMDS_594M, 12288, 594000 },
-	{ 176400, TMDS_593M, 35672, 937500 },
-	{ 176400, TMDS_594M, 37632, 990000 },
+	{ 192000, TMDS_296M, 23296, 281250 },
+	{ 192000, TMDS_297M, 20480, 247500 },
 	{ 192000, TMDS_593M, 23296, 562500 },
 	{ 192000, TMDS_594M, 24576, 594000 },
 };
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH v3] drm/i915/hdmi: Reorder structure to match specification
  2018-10-31 20:54 ` [PATCH v3] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
@ 2018-11-15 14:04   ` Jani Nikula
  0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2018-11-15 14:04 UTC (permalink / raw)
  To: clinton.a.taylor, Intel-gfx

On Wed, 31 Oct 2018, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> reorder structure of 297, 594 N values to group Audio Sample Frequencies
> together to make updating from HDMI specification easier.
>
> V2: Match patch 1/2 version
> V3: Arrange by sample freq, then pixel clock.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>

Pushed, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/intel_audio.c | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index ccd88da..ae55a68 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -153,32 +153,32 @@ struct dp_aud_n_m {
>  	int n;
>  	int cts;
>  } hdmi_aud_ncts[] = {
> -	{ 44100, TMDS_296M, 4459, 234375 },
> -	{ 44100, TMDS_297M, 4704, 247500 },
> -	{ 48000, TMDS_296M, 5824, 281250 },
> -	{ 48000, TMDS_297M, 5120, 247500 },
>  	{ 32000, TMDS_296M, 5824, 421875 },
>  	{ 32000, TMDS_297M, 3072, 222750 },
> +	{ 32000, TMDS_593M, 5824, 843750 },
> +	{ 32000, TMDS_594M, 3072, 445500 },
> +	{ 44100, TMDS_296M, 4459, 234375 },
> +	{ 44100, TMDS_297M, 4704, 247500 },
> +	{ 44100, TMDS_593M, 8918, 937500 },
> +	{ 44100, TMDS_594M, 9408, 990000 },
>  	{ 88200, TMDS_296M, 8918, 234375 },
>  	{ 88200, TMDS_297M, 9408, 247500 },
> -	{ 96000, TMDS_296M, 11648, 281250 },
> -	{ 96000, TMDS_297M, 10240, 247500 },
> +	{ 88200, TMDS_593M, 17836, 937500 },
> +	{ 88200, TMDS_594M, 18816, 990000 },
>  	{ 176400, TMDS_296M, 17836, 234375 },
>  	{ 176400, TMDS_297M, 18816, 247500 },
> -	{ 192000, TMDS_296M, 23296, 281250 },
> -	{ 192000, TMDS_297M, 20480, 247500 },
> -	{ 44100, TMDS_593M, 8918, 937500 },
> -	{ 44100, TMDS_594M, 9408, 990000 },
> +	{ 176400, TMDS_593M, 35672, 937500 },
> +	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 48000, TMDS_296M, 5824, 281250 },
> +	{ 48000, TMDS_297M, 5120, 247500 },
>  	{ 48000, TMDS_593M, 5824, 562500 },
>  	{ 48000, TMDS_594M, 6144, 594000 },
> -	{ 32000, TMDS_593M, 5824, 843750 },
> -	{ 32000, TMDS_594M, 3072, 445500 },
> -	{ 88200, TMDS_593M, 17836, 937500 },
> -	{ 88200, TMDS_594M, 18816, 990000 },
> +	{ 96000, TMDS_296M, 11648, 281250 },
> +	{ 96000, TMDS_297M, 10240, 247500 },
>  	{ 96000, TMDS_593M, 11648, 562500 },
>  	{ 96000, TMDS_594M, 12288, 594000 },
> -	{ 176400, TMDS_593M, 35672, 937500 },
> -	{ 176400, TMDS_594M, 37632, 990000 },
> +	{ 192000, TMDS_296M, 23296, 281250 },
> +	{ 192000, TMDS_297M, 20480, 247500 },
>  	{ 192000, TMDS_593M, 23296, 562500 },
>  	{ 192000, TMDS_594M, 24576, 594000 },
>  };

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2018-11-15 14:04 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 22:26 [PATCH] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
2018-10-06  0:17 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-06  8:11 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-15 11:24 ` [PATCH] " Jani Nikula
2018-10-15 11:31   ` Jani Nikula
2018-10-25 18:56     ` Clint Taylor
2018-10-25 18:51 ` [PATCH 0/2] HDMI 2.0 clock recovery values clinton.a.taylor
2018-10-25 18:52   ` [PATCH v2 1/2] drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values clinton.a.taylor
2018-10-26  7:04     ` Jani Nikula
2018-10-26  7:04       ` Jani Nikula
2018-10-25 18:52   ` [PATCH v2 2/2] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
2018-10-26 10:23     ` Jani Nikula
2018-10-26 10:23       ` Jani Nikula
2018-10-25 19:27 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdmi: Add HDMI 2.0 audio clock recovery N values (rev2) Patchwork
2018-10-25 19:50 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-26  2:07 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-31 20:54 ` [PATCH v3] drm/i915/hdmi: Reorder structure to match specification clinton.a.taylor
2018-11-15 14:04   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.