From: Johannes Berg <johannes@sipsolutions.net>
To: Ajay Singh <ajay.kathat@microchip.com>, linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org, gregkh@linuxfoundation.org,
ganesh.krishna@microchip.com, aditya.shankar@microchip.com,
venkateswara.kaja@microchip.com, claudiu.beznea@microchip.com,
adham.abozaeid@microchip.com
Subject: Re: [PATCH 03/19] wilc: add host_interface.h
Date: Mon, 08 Oct 2018 16:20:17 +0200 [thread overview]
Message-ID: <1539008417.3687.57.camel@sipsolutions.net> (raw)
In-Reply-To: <1537957525-11467-4-git-send-email-ajay.kathat@microchip.com> (sfid-20180926_122543_439724_F85DD368)
On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote:
> +#include <linux/ieee80211.h>
you include it
> +#include "coreconfigurator.h"
> +
> +#define IDLE_MODE 0x00
> +#define AP_MODE 0x01
> +#define STATION_MODE 0x02
> +#define GO_MODE 0x03
> +#define CLIENT_MODE 0x04
> +#define ACTION 0xD0
> +#define PROBE_REQ 0x40
> +#define PROBE_RESP 0x50
please use it too.
> +#define ACTION_FRM_IDX 0
> +#define PROBE_REQ_IDX 1
> +#define MAX_NUM_STA 9
> +#define ACTIVE_SCAN_TIME 10
> +#define PASSIVE_SCAN_TIME 1200
> +#define MIN_SCAN_TIME 10
> +#define MAX_SCAN_TIME 1200
> +#define DEFAULT_SCAN 0
> +#define USER_SCAN BIT(0)
> +#define OBSS_PERIODIC_SCAN BIT(1)
> +#define OBSS_ONETIME_SCAN BIT(2)
> +#define GTK_RX_KEY_BUFF_LEN 24
> +#define ADDKEY 0x1
> +#define REMOVEKEY 0x2
> +#define DEFAULTKEY 0x4
> +#define ADDKEY_AP 0x8
> +#define MAX_NUM_SCANNED_NETWORKS 100
> +#define MAX_NUM_SCANNED_NETWORKS_SHADOW 130
> +#define MAX_NUM_PROBED_SSID 10
> +#define CHANNEL_SCAN_TIME 250
> +
> +#define TX_MIC_KEY_LEN 8
> +#define RX_MIC_KEY_LEN 8
> +#define PTK_KEY_LEN 16
> +
> +#define TX_MIC_KEY_MSG_LEN 26
> +#define RX_MIC_KEY_MSG_LEN 48
> +#define PTK_KEY_MSG_LEN 39
> +
> +#define PMKSA_KEY_LEN 22
> +#define ETH_ALEN 6
umm?
> +#define PMKID_LEN 16
??
> +#define WILC_MAX_NUM_PMKIDS 16
> +#define WILC_ADD_STA_LENGTH 40
> +#define NUM_CONCURRENT_IFC 2
> +#define DRV_HANDLER_SIZE 5
> +#define DRV_HANDLER_MASK 0x000000FF
Also this file is strangely mixing
* 802.11 constants (that you shouldn't have anyway)
* driver constants/structs
* hardware/firmware-related things (at least it seems like - e.g. the
"REMOVEKEY" constant)
Please clean that up, separate the things, and pick a better
namespace... just having "REMOVEKEY" is probably not a good idea.
> +typedef void (*wilc_remain_on_chan_expired)(void *, u32);
> +typedef void (*wilc_remain_on_chan_ready)(void *);
Please no typedefs.
> +struct rcvd_net_info {
> + u8 *buffer;
> + u32 len;
> +};
> +
> +struct hidden_net_info {
> + u8 *ssid;
> + u8 ssid_len;
> +};
> +
> +struct hidden_network {
> + struct hidden_net_info *net_info;
> + u8 n_ssids;
> +};
This seems really odd - what part doesn't cfg80211 already handle?
johannes
next prev parent reply other threads:[~2018-10-08 14:20 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 10:25 [RFC 00/19] wilc: added driver for wilc module Ajay Singh
2018-09-26 10:25 ` [PATCH 01/19] wilc: add coreconfigurator.h Ajay Singh
2018-09-26 10:25 ` [PATCH 02/19] wilc: add coreconfigurator.c Ajay Singh
2018-10-08 14:16 ` Johannes Berg
2018-10-09 9:42 ` Ajay Singh
2018-10-09 10:05 ` Johannes Berg
2018-09-26 10:25 ` [PATCH 03/19] wilc: add host_interface.h Ajay Singh
2018-10-08 14:20 ` Johannes Berg [this message]
2018-10-09 10:34 ` Ajay Singh
2018-10-09 10:36 ` Johannes Berg
2018-10-09 11:44 ` Ajay Singh
2018-10-09 11:46 ` Johannes Berg
2018-10-09 12:18 ` Ajay Singh
2018-10-09 18:36 ` Adham.Abozaeid
2018-10-09 19:14 ` Johannes Berg
2018-10-09 20:01 ` Adham.Abozaeid
2018-10-09 20:02 ` Johannes Berg
2018-10-09 20:06 ` Adham.Abozaeid
2018-10-29 14:56 ` Kalle Valo
2018-10-30 3:20 ` Ajay.Kathat
2018-09-26 10:25 ` [PATCH 04/19] wilc: add host_interface.c Ajay Singh
2018-10-08 14:31 ` Johannes Berg
2018-10-10 20:06 ` Adham.Abozaeid
2018-10-11 7:01 ` Johannes Berg
2018-10-12 22:08 ` Adham.Abozaeid
2018-10-18 8:23 ` Johannes Berg
2018-10-18 18:30 ` Adham.Abozaeid
2018-10-19 7:02 ` Johannes Berg
2018-10-19 20:53 ` Adham.Abozaeid
2018-10-29 20:10 ` Johannes Berg
2018-10-29 21:32 ` Adham.Abozaeid
2018-10-29 21:33 ` Johannes Berg
2018-10-11 6:57 ` Ajay Singh
2018-10-10 20:14 ` Johannes Berg
2018-10-12 21:55 ` Adham.Abozaeid
2018-10-18 8:23 ` Johannes Berg
2018-09-26 10:25 ` [PATCH 05/19] wilc: add wilc_wlan_if.h Ajay Singh
2018-10-08 14:33 ` Johannes Berg
2018-10-11 6:59 ` Ajay Singh
2018-09-26 10:25 ` [PATCH 06/19] wilc: add wilc_wlan_cfg.h Ajay Singh
2018-09-26 10:25 ` [PATCH 07/19] wilc: add wilc_wlan_cfg.c Ajay Singh
2018-09-26 10:25 ` [PATCH 08/19] wilc: add wilc_wlan.h Ajay Singh
2018-09-26 10:25 ` [PATCH 09/19] wilc: add wilc_wlan.c Ajay Singh
2018-09-26 10:25 ` [PATCH 10/19] wilc: add wilc_wfi_netdevice.h Ajay Singh
2018-09-26 10:25 ` [PATCH 11/19] wilc: add wilc_wfi_cfgoperations.h Ajay Singh
2018-09-26 10:25 ` [PATCH 12/19] wilc: add wilc_wfi_cfgoperations.c Ajay Singh
2018-10-08 14:57 ` Johannes Berg
2018-10-09 4:23 ` Adham.Abozaeid
2018-10-09 7:55 ` Johannes Berg
2018-10-09 17:15 ` Adham.Abozaeid
2018-10-19 21:47 ` Adham.Abozaeid
2018-10-29 20:11 ` Johannes Berg
2018-10-29 21:43 ` Adham.Abozaeid
2018-09-26 10:25 ` [PATCH 13/19] wilc: add linux_wlan.c Ajay Singh
2018-10-08 14:41 ` Johannes Berg
2018-10-11 7:00 ` Ajay Singh
2018-10-11 7:03 ` Johannes Berg
2018-10-11 7:26 ` Ajay Singh
2018-09-26 10:25 ` [PATCH 14/19] wilc: add linux_mon.c Ajay Singh
2018-10-08 14:44 ` Johannes Berg
2018-10-11 7:12 ` Ajay Singh
2018-10-11 7:15 ` Johannes Berg
2018-09-26 10:25 ` [PATCH 15/19] wilc: add wilc_spi.c Ajay Singh
2018-09-26 10:25 ` [PATCH 16/19] wilc: add wilc_sdio.c Ajay Singh
2018-09-26 10:25 ` [PATCH 17/19] wilc: updated DT device binding for wilc device Ajay Singh
2018-09-26 10:25 ` [PATCH 18/19] wilc: add Makefile and Kconfig files for wilc compilation Ajay Singh
2018-09-26 10:25 ` [PATCH 19/19] wilc: added wilc module compilation in wireless Makefile & Kconfig Ajay Singh
2018-10-06 12:45 ` [RFC 00/19] wilc: added driver for wilc module Kalle Valo
2018-10-08 5:17 ` Ajay Singh
2018-10-08 7:38 ` Kalle Valo
2018-10-08 18:34 ` Adham.Abozaeid
2018-11-15 14:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539008417.3687.57.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.