Re: [PATCH 02/19] wilc: add coreconfigurator.c

From: Johannes Berg <johannes@sipsolutions.net>
To: Ajay Singh <ajay.kathat@microchip.com>, linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org, gregkh@linuxfoundation.org,
	ganesh.krishna@microchip.com, aditya.shankar@microchip.com,
	venkateswara.kaja@microchip.com, claudiu.beznea@microchip.com,
	adham.abozaeid@microchip.com
Subject: Re: [PATCH 02/19] wilc: add coreconfigurator.c
Date: Tue, 09 Oct 2018 12:05:29 +0200	[thread overview]
Message-ID: <1539079529.3687.107.camel@sipsolutions.net> (raw)
In-Reply-To: <99c3417a-7e7b-ed55-6ab4-66bf56b4c449@microchip.com>

On Tue, 2018-10-09 at 15:12 +0530, Ajay Singh wrote:

> > > +static inline enum sub_frame_type get_sub_type(u8 *header)
> > > +{
> > > +	return ((enum sub_frame_type)(header[0] & 0xFC));
> > > +}
> > 
> > remove, use include/linux/ieee80211.h.
> > 
> 
> Did you mean to use '& IEEE80211_FCTL_STYPE' to get the frame sub type,
> instead of adding this API.

Perhaps, but I suspect you can do mostly with ieee80211_is_probe_resp()
and friends.

> > > +static inline u8 get_to_ds(u8 *header)
> > > +{
> > > +	return (header[1] & 0x01);
> > > +}
> > > +
> > > +static inline u8 get_from_ds(u8 *header)
> > > +{
> > > +	return ((header[1] & 0x02) >> 1);
> > > +}
> > 
> > dito
> > 
> 
> Ack.  

For this you have ieee80211_has_tods()/_fromds()/_a4() instead.

johannes