* [Qemu-devel] [PATCH] target/cris/translate: Get rid of qemu_log_separate()
@ 2018-10-09 7:46 Thomas Huth
2018-10-09 7:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2018-10-09 7:46 UTC (permalink / raw)
To: qemu-devel, Edgar E. Iglesias; +Cc: qemu-trivial
The gen_BUG() function calls already cpu_abort(), which prints the
information to stderr and the log already. So instead of additionally
printing the dc->pc via fprintf() and qemu_log here, too, we can
simply pass this information to cpu_abort() instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/cris/translate.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/cris/translate.c b/target/cris/translate.c
index 4ae1c04..0ee2c5d 100644
--- a/target/cris/translate.c
+++ b/target/cris/translate.c
@@ -137,11 +137,7 @@ typedef struct DisasContext {
static void gen_BUG(DisasContext *dc, const char *file, int line)
{
- fprintf(stderr, "BUG: pc=%x %s %d\n", dc->pc, file, line);
- if (qemu_log_separate()) {
- qemu_log("BUG: pc=%x %s %d\n", dc->pc, file, line);
- }
- cpu_abort(CPU(dc->cpu), "%s:%d\n", file, line);
+ cpu_abort(CPU(dc->cpu), "%s:%d dc->pc=%x\n", file, line, dc->pc);
}
static const char *regnames_v32[] =
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] target/cris/translate: Get rid of qemu_log_separate()
2018-10-09 7:46 [Qemu-devel] [PATCH] target/cris/translate: Get rid of qemu_log_separate() Thomas Huth
@ 2018-10-09 7:55 ` Philippe Mathieu-Daudé
2018-10-10 7:06 ` [Qemu-devel] [PATCH v2] " Thomas Huth
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-09 7:55 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Edgar E. Iglesias; +Cc: qemu-trivial
Hi Thomas,
On 09/10/2018 09:46, Thomas Huth wrote:
> The gen_BUG() function calls already cpu_abort(), which prints the
> information to stderr and the log already. So instead of additionally
> printing the dc->pc via fprintf() and qemu_log here, too, we can
> simply pass this information to cpu_abort() instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/cris/translate.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index 4ae1c04..0ee2c5d 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -137,11 +137,7 @@ typedef struct DisasContext {
>
> static void gen_BUG(DisasContext *dc, const char *file, int line)
> {
> - fprintf(stderr, "BUG: pc=%x %s %d\n", dc->pc, file, line);
> - if (qemu_log_separate()) {
> - qemu_log("BUG: pc=%x %s %d\n", dc->pc, file, line);
> - }
> - cpu_abort(CPU(dc->cpu), "%s:%d\n", file, line);
> + cpu_abort(CPU(dc->cpu), "%s:%d dc->pc=%x\n", file, line, dc->pc);
I'd use a simpler format (why display internal "dc->"?):
cpu_abort(CPU(dc->cpu), "%s:%d BUG: pc=%x\n", ...
> }
>
> static const char *regnames_v32[] =
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH v2] target/cris/translate: Get rid of qemu_log_separate()
2018-10-09 7:55 ` Philippe Mathieu-Daudé
@ 2018-10-10 7:06 ` Thomas Huth
2018-10-10 9:04 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2018-10-10 7:06 UTC (permalink / raw)
To: qemu-devel, Edgar E. Iglesias; +Cc: qemu-trivial, philmd
The gen_BUG() function calls already cpu_abort(), which prints the
information to stderr and the log already. So instead of additionally
printing the dc->pc via fprintf() and qemu_log here, too, we can
simply pass this information to cpu_abort() instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
v2: Use "pc=" instead of "dc->pc=" in the string as suggested by Phil
target/cris/translate.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/cris/translate.c b/target/cris/translate.c
index 4ae1c04..11b2c11 100644
--- a/target/cris/translate.c
+++ b/target/cris/translate.c
@@ -137,11 +137,7 @@ typedef struct DisasContext {
static void gen_BUG(DisasContext *dc, const char *file, int line)
{
- fprintf(stderr, "BUG: pc=%x %s %d\n", dc->pc, file, line);
- if (qemu_log_separate()) {
- qemu_log("BUG: pc=%x %s %d\n", dc->pc, file, line);
- }
- cpu_abort(CPU(dc->cpu), "%s:%d\n", file, line);
+ cpu_abort(CPU(dc->cpu), "%s:%d pc=%x\n", file, line, dc->pc);
}
static const char *regnames_v32[] =
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] target/cris/translate: Get rid of qemu_log_separate()
2018-10-10 7:06 ` [Qemu-devel] [PATCH v2] " Thomas Huth
@ 2018-10-10 9:04 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-10 9:04 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Edgar E. Iglesias; +Cc: qemu-trivial
On 10/10/2018 09:06, Thomas Huth wrote:
> The gen_BUG() function calls already cpu_abort(), which prints the
> information to stderr and the log already. So instead of additionally
> printing the dc->pc via fprintf() and qemu_log here, too, we can
> simply pass this information to cpu_abort() instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Use "pc=" instead of "dc->pc=" in the string as suggested by Phil
Thanks.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> target/cris/translate.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index 4ae1c04..11b2c11 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -137,11 +137,7 @@ typedef struct DisasContext {
>
> static void gen_BUG(DisasContext *dc, const char *file, int line)
> {
> - fprintf(stderr, "BUG: pc=%x %s %d\n", dc->pc, file, line);
> - if (qemu_log_separate()) {
> - qemu_log("BUG: pc=%x %s %d\n", dc->pc, file, line);
> - }
> - cpu_abort(CPU(dc->cpu), "%s:%d\n", file, line);
> + cpu_abort(CPU(dc->cpu), "%s:%d pc=%x\n", file, line, dc->pc);
> }
>
> static const char *regnames_v32[] =
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-10 9:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 7:46 [Qemu-devel] [PATCH] target/cris/translate: Get rid of qemu_log_separate() Thomas Huth
2018-10-09 7:55 ` Philippe Mathieu-Daudé
2018-10-10 7:06 ` [Qemu-devel] [PATCH v2] " Thomas Huth
2018-10-10 9:04 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.