* [PATCH] PCI:mobiveil: fix multi function endpoint failures
@ 2018-10-09 11:08 Subrahmanya Lingappa
2018-10-11 14:20 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Subrahmanya Lingappa @ 2018-10-09 11:08 UTC (permalink / raw)
To: linux-pci, bhelgaas, lorenzo.pieralisi; +Cc: Subrahmanya Lingappa
The fix enables mobiveil pcie controller to detect more than one
functions per device.
Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
---
drivers/pci/controller/pcie-mobiveil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
index a939e8d3..9acb81a 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -174,7 +174,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
* Do not read more than one device on the bus directly
* attached to RC
*/
- if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
+ if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
return false;
return true;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI:mobiveil: fix multi function endpoint failures
2018-10-09 11:08 [PATCH] PCI:mobiveil: fix multi function endpoint failures Subrahmanya Lingappa
@ 2018-10-11 14:20 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2018-10-11 14:20 UTC (permalink / raw)
To: Subrahmanya Lingappa; +Cc: linux-pci, bhelgaas
On Tue, Oct 09, 2018 at 07:08:45AM -0400, Subrahmanya Lingappa wrote:
> The fix enables mobiveil pcie controller to detect more than one
> functions per device.
Please read:
https://marc.info/?l=linux-pci&m=150905742808166&w=2
and use it as a checklist.
Please run:
git log --oneline drivers/pci/controller/pcie-mobiveil.c
Check the result and compare it to your patch $SUBJECT, you will
notice that this patch style differs so rewrite the $SUBJECT accordingly.
Please add a Fixes: tag to define what commit you are fixing.
Thanks,
Lorenzo
> Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> ---
> drivers/pci/controller/pcie-mobiveil.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
> index a939e8d3..9acb81a 100644
> --- a/drivers/pci/controller/pcie-mobiveil.c
> +++ b/drivers/pci/controller/pcie-mobiveil.c
> @@ -174,7 +174,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
> * Do not read more than one device on the bus directly
> * attached to RC
> */
> - if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
> + if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
> return false;
>
> return true;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 11:08 [PATCH] PCI:mobiveil: fix multi function endpoint failures Subrahmanya Lingappa
2018-10-11 14:20 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.