* [PATCH net-next] rxrpc: Remove set but not used variable 'nowj'
@ 2018-08-02 3:36 ` Wei Yongjun
0 siblings, 0 replies; 20+ messages in thread
From: Wei Yongjun @ 2018-08-02 3:36 UTC (permalink / raw)
To: David Howells; +Cc: Wei Yongjun, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/proc.c: In function 'rxrpc_call_seq_show':
net/rxrpc/proc.c:66:29: warning:
variable 'nowj' set but not used [-Wunused-but-set-variable]
unsigned long timeout = 0, nowj;
^
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/rxrpc/proc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rxrpc/proc.c b/net/rxrpc/proc.c
index 163d05d..9805e3b 100644
--- a/net/rxrpc/proc.c
+++ b/net/rxrpc/proc.c
@@ -63,7 +63,7 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
struct rxrpc_peer *peer;
struct rxrpc_call *call;
struct rxrpc_net *rxnet = rxrpc_net(seq_file_net(seq));
- unsigned long timeout = 0, nowj;
+ unsigned long timeout = 0;
rxrpc_seq_t tx_hard_ack, rx_hard_ack;
char lbuff[50], rbuff[50];
@@ -97,7 +97,6 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
if (call->state != RXRPC_CALL_SERVER_PREALLOC) {
timeout = READ_ONCE(call->expect_rx_by);
- nowj = jiffies;
timeout -= jiffies;
}
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH net-next] rxrpc: Remove set but not used variable 'nowj'
@ 2018-08-02 3:36 ` Wei Yongjun
0 siblings, 0 replies; 20+ messages in thread
From: Wei Yongjun @ 2018-08-02 3:36 UTC (permalink / raw)
To: David Howells; +Cc: Wei Yongjun, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/proc.c: In function 'rxrpc_call_seq_show':
net/rxrpc/proc.c:66:29: warning:
variable 'nowj' set but not used [-Wunused-but-set-variable]
unsigned long timeout = 0, nowj;
^
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/rxrpc/proc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rxrpc/proc.c b/net/rxrpc/proc.c
index 163d05d..9805e3b 100644
--- a/net/rxrpc/proc.c
+++ b/net/rxrpc/proc.c
@@ -63,7 +63,7 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
struct rxrpc_peer *peer;
struct rxrpc_call *call;
struct rxrpc_net *rxnet = rxrpc_net(seq_file_net(seq));
- unsigned long timeout = 0, nowj;
+ unsigned long timeout = 0;
rxrpc_seq_t tx_hard_ack, rx_hard_ack;
char lbuff[50], rbuff[50];
@@ -97,7 +97,6 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
if (call->state != RXRPC_CALL_SERVER_PREALLOC) {
timeout = READ_ONCE(call->expect_rx_by);
- nowj = jiffies;
timeout -= jiffies;
}
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
2018-08-02 3:36 ` Wei Yongjun
@ 2018-10-09 2:31 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-09 2:31 UTC (permalink / raw)
To: David Howells, davem; +Cc: YueHaibing, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
variable 'ioc' set but not used [-Wunused-but-set-variable]
It never used since introduction in
commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rxrpc/output.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index e8fb892..f3ed16a 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -524,7 +524,7 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
struct kvec iov[2];
size_t size;
__be32 code;
- int ret, ioc;
+ int ret;
_enter("%d", local->debug_id);
@@ -548,13 +548,11 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
case RXRPC_SKB_MARK_REJECT_BUSY:
whdr.type = RXRPC_PACKET_TYPE_BUSY;
size = sizeof(whdr);
- ioc = 1;
break;
case RXRPC_SKB_MARK_REJECT_ABORT:
whdr.type = RXRPC_PACKET_TYPE_ABORT;
code = htonl(skb->priority);
size = sizeof(whdr) + sizeof(code);
- ioc = 2;
break;
default:
rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
@ 2018-10-09 2:31 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-09 2:31 UTC (permalink / raw)
To: David Howells, davem; +Cc: YueHaibing, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
variable 'ioc' set but not used [-Wunused-but-set-variable]
It never used since introduction in
commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rxrpc/output.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index e8fb892..f3ed16a 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -524,7 +524,7 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
struct kvec iov[2];
size_t size;
__be32 code;
- int ret, ioc;
+ int ret;
_enter("%d", local->debug_id);
@@ -548,13 +548,11 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
case RXRPC_SKB_MARK_REJECT_BUSY:
whdr.type = RXRPC_PACKET_TYPE_BUSY;
size = sizeof(whdr);
- ioc = 1;
break;
case RXRPC_SKB_MARK_REJECT_ABORT:
whdr.type = RXRPC_PACKET_TYPE_ABORT;
code = htonl(skb->priority);
size = sizeof(whdr) + sizeof(code);
- ioc = 2;
break;
default:
rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
2018-10-09 2:31 ` YueHaibing
@ 2018-10-09 10:13 ` David Howells
-1 siblings, 0 replies; 20+ messages in thread
From: David Howells @ 2018-10-09 10:13 UTC (permalink / raw)
To: YueHaibing; +Cc: dhowells, davem, linux-afs, netdev, kernel-janitors
YueHaibing <yuehaibing@huawei.com> wrote:
> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> net/rxrpc/output.c:527:11: warning:
> variable 'ioc' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
I wonder why my compiler doesn't show this warning.
Anyway, NAK: just removing the variable is the wrong fix - you need to look at
the code more closely. The actual fix is to pass it to kernel_sendmsg()
instead of 2.
But thanks anyway! Do you want to respin your patch?
> commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
to go to net, not net-next.
David
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
@ 2018-10-09 10:13 ` David Howells
0 siblings, 0 replies; 20+ messages in thread
From: David Howells @ 2018-10-09 10:13 UTC (permalink / raw)
To: YueHaibing; +Cc: dhowells, davem, linux-afs, netdev, kernel-janitors
YueHaibing <yuehaibing@huawei.com> wrote:
> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> net/rxrpc/output.c:527:11: warning:
> variable 'ioc' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
I wonder why my compiler doesn't show this warning.
Anyway, NAK: just removing the variable is the wrong fix - you need to look at
the code more closely. The actual fix is to pass it to kernel_sendmsg()
instead of 2.
But thanks anyway! Do you want to respin your patch?
> commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
to go to net, not net-next.
David
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
2018-10-09 10:13 ` David Howells
@ 2018-10-09 12:04 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-09 12:04 UTC (permalink / raw)
To: David Howells; +Cc: davem, linux-afs, netdev, kernel-janitors
On 2018/10/9 18:13, David Howells wrote:
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
>> net/rxrpc/output.c:527:11: warning:
>> variable 'ioc' set but not used [-Wunused-but-set-variable]
>>
>> It never used since introduction in
>
> I wonder why my compiler doesn't show this warning.
Just use make W=1
>
> Anyway, NAK: just removing the variable is the wrong fix - you need to look at
> the code more closely. The actual fix is to pass it to kernel_sendmsg()
> instead of 2.
I didn't notice this, Thank you for correction.
>
> But thanks anyway! Do you want to respin your patch?
Sure, I will fix it.
>
>> commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
>
> Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
> to go to net, not net-next.
>
> David
>
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
@ 2018-10-09 12:04 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-09 12:04 UTC (permalink / raw)
To: David Howells; +Cc: davem, linux-afs, netdev, kernel-janitors
On 2018/10/9 18:13, David Howells wrote:
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
>> net/rxrpc/output.c:527:11: warning:
>> variable 'ioc' set but not used [-Wunused-but-set-variable]
>>
>> It never used since introduction in
>
> I wonder why my compiler doesn't show this warning.
Just use make W=1
>
> Anyway, NAK: just removing the variable is the wrong fix - you need to look at
> the code more closely. The actual fix is to pass it to kernel_sendmsg()
> instead of 2.
I didn't notice this, Thank you for correction.
>
> But thanks anyway! Do you want to respin your patch?
Sure, I will fix it.
>
>> commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
>
> Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
> to go to net, not net-next.
>
> David
>
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
2018-10-09 2:31 ` YueHaibing
@ 2018-10-09 14:15 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-09 14:15 UTC (permalink / raw)
To: David Howells, davem; +Cc: YueHaibing, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
variable 'ioc' set but not used [-Wunused-but-set-variable]
'ioc' is the correct kvec num while send response packet.
Fixes: commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rxrpc/output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index e8fb892..a141ee3 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -572,7 +572,8 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
whdr.flags ^= RXRPC_CLIENT_INITIATED;
whdr.flags &= RXRPC_CLIENT_INITIATED;
- ret = kernel_sendmsg(local->socket, &msg, iov, 2, size);
+ ret = kernel_sendmsg(local->socket, &msg,
+ iov, ioc, size);
if (ret < 0)
trace_rxrpc_tx_fail(local->debug_id, 0, ret,
rxrpc_tx_point_reject);
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
@ 2018-10-09 14:15 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-09 14:15 UTC (permalink / raw)
To: David Howells, davem; +Cc: YueHaibing, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
variable 'ioc' set but not used [-Wunused-but-set-variable]
'ioc' is the correct kvec num while send response packet.
Fixes: commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rxrpc/output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index e8fb892..a141ee3 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -572,7 +572,8 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
whdr.flags ^= RXRPC_CLIENT_INITIATED;
whdr.flags &= RXRPC_CLIENT_INITIATED;
- ret = kernel_sendmsg(local->socket, &msg, iov, 2, size);
+ ret = kernel_sendmsg(local->socket, &msg,
+ iov, ioc, size);
if (ret < 0)
trace_rxrpc_tx_fail(local->debug_id, 0, ret,
rxrpc_tx_point_reject);
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
2018-10-09 14:15 ` YueHaibing
@ 2018-10-09 15:34 ` Sergei Shtylyov
-1 siblings, 0 replies; 20+ messages in thread
From: Sergei Shtylyov @ 2018-10-09 15:34 UTC (permalink / raw)
To: YueHaibing, David Howells, davem; +Cc: linux-afs, netdev, kernel-janitors
On 10/09/2018 05:15 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> net/rxrpc/output.c:527:11: warning:
> variable 'ioc' set but not used [-Wunused-but-set-variable]
>
> 'ioc' is the correct kvec num while send response packet.
>
> Fixes: commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than
ABORTs")
"commit" not needed here.
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
@ 2018-10-09 15:34 ` Sergei Shtylyov
0 siblings, 0 replies; 20+ messages in thread
From: Sergei Shtylyov @ 2018-10-09 15:34 UTC (permalink / raw)
To: YueHaibing, David Howells, davem; +Cc: linux-afs, netdev, kernel-janitors
On 10/09/2018 05:15 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> net/rxrpc/output.c:527:11: warning:
> variable 'ioc' set but not used [-Wunused-but-set-variable]
>
> 'ioc' is the correct kvec num while send response packet.
>
> Fixes: commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than
ABORTs")
"commit" not needed here.
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
2018-10-09 15:34 ` Sergei Shtylyov
@ 2018-10-10 1:19 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-10 1:19 UTC (permalink / raw)
To: Sergei Shtylyov, David Howells, davem; +Cc: linux-afs, netdev, kernel-janitors
On 2018/10/9 23:34, Sergei Shtylyov wrote:
> On 10/09/2018 05:15 PM, YueHaibing wrote:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
>> net/rxrpc/output.c:527:11: warning:
>> variable 'ioc' set but not used [-Wunused-but-set-variable]
>>
>> 'ioc' is the correct kvec num while send response packet.
>>
>> Fixes: commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than
> ABORTs")
>
> "commit" not needed here.
Thank you for review.
>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> [...]
>
> MBR, Sergei
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
@ 2018-10-10 1:19 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-10 1:19 UTC (permalink / raw)
To: Sergei Shtylyov, David Howells, davem; +Cc: linux-afs, netdev, kernel-janitors
On 2018/10/9 23:34, Sergei Shtylyov wrote:
> On 10/09/2018 05:15 PM, YueHaibing wrote:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
>> net/rxrpc/output.c:527:11: warning:
>> variable 'ioc' set but not used [-Wunused-but-set-variable]
>>
>> 'ioc' is the correct kvec num while send response packet.
>>
>> Fixes: commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than
> ABORTs")
>
> "commit" not needed here.
Thank you for review.
>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> [...]
>
> MBR, Sergei
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v3] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
2018-10-09 14:15 ` YueHaibing
@ 2018-10-10 2:06 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-10 1:55 UTC (permalink / raw)
To: David Howells, davem; +Cc: YueHaibing, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
variable 'ioc' set but not used [-Wunused-but-set-variable]
'ioc' is the correct kvec num while send response packet.
Fixes: ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v3: remove 'commit' from Fixes info.
v2: use 'ioc' rather than remove it.
---
net/rxrpc/output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index e8fb892..a141ee3 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -572,7 +572,8 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
whdr.flags ^= RXRPC_CLIENT_INITIATED;
whdr.flags &= RXRPC_CLIENT_INITIATED;
- ret = kernel_sendmsg(local->socket, &msg, iov, 2, size);
+ ret = kernel_sendmsg(local->socket, &msg,
+ iov, ioc, size);
if (ret < 0)
trace_rxrpc_tx_fail(local->debug_id, 0, ret,
rxrpc_tx_point_reject);
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v3] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets
@ 2018-10-10 2:06 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-10-10 2:06 UTC (permalink / raw)
To: David Howells, davem; +Cc: YueHaibing, linux-afs, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
variable 'ioc' set but not used [-Wunused-but-set-variable]
'ioc' is the correct kvec num while send response packet.
Fixes: ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v3: remove 'commit' from Fixes info.
v2: use 'ioc' rather than remove it.
---
net/rxrpc/output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index e8fb892..a141ee3 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -572,7 +572,8 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
whdr.flags ^= RXRPC_CLIENT_INITIATED;
whdr.flags &= RXRPC_CLIENT_INITIATED;
- ret = kernel_sendmsg(local->socket, &msg, iov, 2, size);
+ ret = kernel_sendmsg(local->socket, &msg,
+ iov, ioc, size);
if (ret < 0)
trace_rxrpc_tx_fail(local->debug_id, 0, ret,
rxrpc_tx_point_reject);
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
2018-10-09 10:13 ` David Howells
@ 2018-10-11 8:38 ` Dan Carpenter
-1 siblings, 0 replies; 20+ messages in thread
From: Dan Carpenter @ 2018-10-11 8:38 UTC (permalink / raw)
To: David Howells; +Cc: YueHaibing, davem, linux-afs, netdev, kernel-janitors
On Tue, Oct 09, 2018 at 11:13:16AM +0100, David Howells wrote:
> YueHaibing <yuehaibing@huawei.com> wrote:
>
> > net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> > net/rxrpc/output.c:527:11: warning:
> > variable 'ioc' set but not used [-Wunused-but-set-variable]
> >
> > It never used since introduction in
>
> I wonder why my compiler doesn't show this warning.
>
> Anyway, NAK: just removing the variable is the wrong fix - you need to look at
> the code more closely. The actual fix is to pass it to kernel_sendmsg()
> instead of 2.
>
> But thanks anyway! Do you want to respin your patch?
>
> > commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
>
> Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
> to go to net, not net-next.
I told him to do that because it wasn't a bugfix... Probably just Fixes
is the right thing to use though.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
@ 2018-10-11 8:38 ` Dan Carpenter
0 siblings, 0 replies; 20+ messages in thread
From: Dan Carpenter @ 2018-10-11 8:38 UTC (permalink / raw)
To: David Howells; +Cc: YueHaibing, davem, linux-afs, netdev, kernel-janitors
On Tue, Oct 09, 2018 at 11:13:16AM +0100, David Howells wrote:
> YueHaibing <yuehaibing@huawei.com> wrote:
>
> > net/rxrpc/output.c: In function 'rxrpc_reject_packets':
> > net/rxrpc/output.c:527:11: warning:
> > variable 'ioc' set but not used [-Wunused-but-set-variable]
> >
> > It never used since introduction in
>
> I wonder why my compiler doesn't show this warning.
>
> Anyway, NAK: just removing the variable is the wrong fix - you need to look at
> the code more closely. The actual fix is to pass it to kernel_sendmsg()
> instead of 2.
>
> But thanks anyway! Do you want to respin your patch?
>
> > commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
>
> Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
> to go to net, not net-next.
I told him to do that because it wasn't a bugfix... Probably just Fixes
is the right thing to use though.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
2018-10-09 10:13 ` David Howells
@ 2018-10-11 20:38 ` David Howells
-1 siblings, 0 replies; 20+ messages in thread
From: David Howells @ 2018-10-11 20:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: dhowells, YueHaibing, davem, linux-afs, netdev, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> I told him to do that because it wasn't a bugfix... Probably just Fixes
> is the right thing to use though.
But the correct fix *is* a bug fix.
David
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'
@ 2018-10-11 20:38 ` David Howells
0 siblings, 0 replies; 20+ messages in thread
From: David Howells @ 2018-10-11 20:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: dhowells, YueHaibing, davem, linux-afs, netdev, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> I told him to do that because it wasn't a bugfix... Probably just Fixes
> is the right thing to use though.
But the correct fix *is* a bug fix.
David
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2018-10-12 4:07 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 2:31 [PATCH net-next] rxrpc: Remove set but not used variable 'ioc' YueHaibing
2018-10-09 2:31 ` YueHaibing
2018-10-09 10:13 ` David Howells
2018-10-09 10:13 ` David Howells
2018-10-09 12:04 ` YueHaibing
2018-10-09 12:04 ` YueHaibing
2018-10-11 8:38 ` Dan Carpenter
2018-10-11 8:38 ` Dan Carpenter
2018-10-11 20:38 ` David Howells
2018-10-11 20:38 ` David Howells
2018-10-09 14:15 ` [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets YueHaibing
2018-10-09 14:15 ` YueHaibing
2018-10-09 15:34 ` Sergei Shtylyov
2018-10-09 15:34 ` Sergei Shtylyov
2018-10-10 1:19 ` YueHaibing
2018-10-10 1:19 ` YueHaibing
2018-10-10 1:55 ` [PATCH v3] " YueHaibing
2018-10-10 2:06 ` YueHaibing
-- strict thread matches above, loose matches on Subject: below --
2018-08-02 3:36 [PATCH net-next] rxrpc: Remove set but not used variable 'nowj' Wei Yongjun
2018-08-02 3:36 ` Wei Yongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.