From: Andrew Murray <andrew.murray@arm.com> To: Will Deacon <will.deacon@arm.com>, Robin Murphy <robin.murphy@arm.com> Cc: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] iommu/arm-smmu-v3: Remove unnecessary wrapper function Date: Wed, 10 Oct 2018 11:29:27 +0100 [thread overview] Message-ID: <1539167367-20471-3-git-send-email-andrew.murray@arm.com> (raw) In-Reply-To: <1539167367-20471-1-git-send-email-andrew.murray@arm.com> Simplify the code by removing an unnecessary wrapper function. This was left behind by commit 2f657add07a8 ("iommu/arm-smmu-v3: Specialise CMD_SYNC handling") Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- drivers/iommu/arm-smmu-v3.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index c7bd18e..6947ccf 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -1371,15 +1371,11 @@ static irqreturn_t arm_smmu_combined_irq_handler(int irq, void *dev) } /* IO_PGTABLE API */ -static void __arm_smmu_tlb_sync(struct arm_smmu_device *smmu) -{ - arm_smmu_cmdq_issue_sync(smmu); -} - static void arm_smmu_tlb_sync(void *cookie) { struct arm_smmu_domain *smmu_domain = cookie; - __arm_smmu_tlb_sync(smmu_domain->smmu); + + arm_smmu_cmdq_issue_sync(smmu_domain->smmu); } static void arm_smmu_tlb_inv_context(void *cookie) @@ -1404,7 +1400,7 @@ static void arm_smmu_tlb_inv_context(void *cookie) * to guarantee those are observed before the TLBI. Do be careful, 007. */ arm_smmu_cmdq_issue_cmd(smmu, &cmd); - __arm_smmu_tlb_sync(smmu); + arm_smmu_cmdq_issue_sync(smmu); } static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size, @@ -1793,7 +1789,7 @@ static void arm_smmu_iotlb_sync(struct iommu_domain *domain) struct arm_smmu_device *smmu = to_smmu_domain(domain)->smmu; if (smmu) - __arm_smmu_tlb_sync(smmu); + arm_smmu_cmdq_issue_sync(smmu); } static phys_addr_t -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: andrew.murray@arm.com (Andrew Murray) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] iommu/arm-smmu-v3: Remove unnecessary wrapper function Date: Wed, 10 Oct 2018 11:29:27 +0100 [thread overview] Message-ID: <1539167367-20471-3-git-send-email-andrew.murray@arm.com> (raw) In-Reply-To: <1539167367-20471-1-git-send-email-andrew.murray@arm.com> Simplify the code by removing an unnecessary wrapper function. This was left behind by commit 2f657add07a8 ("iommu/arm-smmu-v3: Specialise CMD_SYNC handling") Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- drivers/iommu/arm-smmu-v3.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index c7bd18e..6947ccf 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -1371,15 +1371,11 @@ static irqreturn_t arm_smmu_combined_irq_handler(int irq, void *dev) } /* IO_PGTABLE API */ -static void __arm_smmu_tlb_sync(struct arm_smmu_device *smmu) -{ - arm_smmu_cmdq_issue_sync(smmu); -} - static void arm_smmu_tlb_sync(void *cookie) { struct arm_smmu_domain *smmu_domain = cookie; - __arm_smmu_tlb_sync(smmu_domain->smmu); + + arm_smmu_cmdq_issue_sync(smmu_domain->smmu); } static void arm_smmu_tlb_inv_context(void *cookie) @@ -1404,7 +1400,7 @@ static void arm_smmu_tlb_inv_context(void *cookie) * to guarantee those are observed before the TLBI. Do be careful, 007. */ arm_smmu_cmdq_issue_cmd(smmu, &cmd); - __arm_smmu_tlb_sync(smmu); + arm_smmu_cmdq_issue_sync(smmu); } static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size, @@ -1793,7 +1789,7 @@ static void arm_smmu_iotlb_sync(struct iommu_domain *domain) struct arm_smmu_device *smmu = to_smmu_domain(domain)->smmu; if (smmu) - __arm_smmu_tlb_sync(smmu); + arm_smmu_cmdq_issue_sync(smmu); } static phys_addr_t -- 2.7.4
next prev parent reply other threads:[~2018-10-10 10:29 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-10 10:29 [PATCH 0/2] iommu/arm-smmu-v3: Miscellaneous clean up Andrew Murray 2018-10-10 10:29 ` Andrew Murray [not found] ` <1539167367-20471-1-git-send-email-andrew.murray-5wv7dgnIgG8@public.gmane.org> 2018-10-10 10:29 ` [PATCH 1/2] iommu/arm-smmu-v3: Add SPDX header Andrew Murray 2018-10-10 10:29 ` Andrew Murray [not found] ` <1539167367-20471-2-git-send-email-andrew.murray-5wv7dgnIgG8@public.gmane.org> 2018-10-10 10:37 ` Robin Murphy 2018-10-10 10:37 ` Robin Murphy 2018-10-10 14:49 ` [PATCH 0/2] iommu/arm-smmu-v3: Miscellaneous clean up Will Deacon 2018-10-10 14:49 ` Will Deacon [not found] ` <20181010144948.GA17340-5wv7dgnIgG8@public.gmane.org> 2018-10-10 16:10 ` Joerg Roedel 2018-10-10 16:10 ` Joerg Roedel [not found] ` <20181010161032.beqw2izwrulg2ehy-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> 2018-10-10 16:28 ` Will Deacon 2018-10-10 16:28 ` Will Deacon 2018-10-10 10:29 ` Andrew Murray [this message] 2018-10-10 10:29 ` [PATCH 2/2] iommu/arm-smmu-v3: Remove unnecessary wrapper function Andrew Murray [not found] ` <1539167367-20471-3-git-send-email-andrew.murray-5wv7dgnIgG8@public.gmane.org> 2018-10-10 10:42 ` Robin Murphy 2018-10-10 10:42 ` Robin Murphy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1539167367-20471-3-git-send-email-andrew.murray@arm.com \ --to=andrew.murray@arm.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=robin.murphy@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.