From: Stephen Boyd <sboyd@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/16] clk: at91: Rework DT bindings
Date: Fri, 12 Oct 2018 12:50:43 -0700 [thread overview]
Message-ID: <153937384305.5275.9319960324791639711@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181012184017.GH2843@piout.net>
Quoting Alexandre Belloni (2018-10-12 11:40:17)
> On 12/10/2018 11:28:06-0700, Stephen Boyd wrote:
> > Quoting Stephen Boyd (2018-08-31 10:45:30)
> > > Quoting Alexandre Belloni (2018-08-16 04:47:55)
> > > > On 27/07/2018 10:03:22-0700, Stephen Boyd wrote:
> > > > > Quoting Alexandre Belloni (2018-07-17 15:27:41)
> > > > > > This is the promised rework of the at91 PMC clocks driver. It is mainly
> > > > > > necessary to remove the DTC warnings but it also complies with the CCF
> > > > > > rule that there should be one node per controller instead of one node
> > > > > > per clock.
> > > > > >
> > > > > > This only handles the PMC, I'm planning to also rework the SCKC bindings
> > > > > > later (without breaking the DT ABI).
> > > > > >
> > > > > > The series is based on top of clk-next plus at91-dt so I don't think it
> > > > > > is convenient to have it this cycle. However, I would really like to
> > > > > > ensure we agree on the new bindings this cycle before converting all the
> > > > > > other platforms as this is a bit tedious.
> > > > > >
> > > > > > The first two patches are actually fixes and may be considered for this
> > > > > > cycle.
> > > > > >
> > > > > > One nice note:
> > > > > > at91-sama5d2_xplained.dtb goes from 29351 bytes to 22082 bytes
> > > > >
> > > > > Patches look mostly good. Rob is happy with the bindings and so am I.
> > > > >
> > > > > One general question is why the drivers can't be moved to real platform
> > > > > drivers instead of using OF_CLK_DECLARE?
> > > > >
> > > >
> > > > I tried, this makes the clocksource drivers fail with -EPROBE_DEFER and
> > > > so the kernel just stops there.
> > > >
> > >
> > > Ok. We have CLK_OF_DECLARE_DRIVER for that. Can you use that?
> > >
> >
> > I assume this will be resent. I haven't seen anything yet though.
> >
>
> It will, would you be willing to take it for this cycle if I manage to
> send it on Monday? (it seems that we will have an -rc8).
>
Well there are fixes to be made, so go at your own pace and don't stress
yourself to deliver it on Monday. I plan to stop picking most things
early next week.
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@kernel.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/16] clk: at91: Rework DT bindings
Date: Fri, 12 Oct 2018 12:50:43 -0700 [thread overview]
Message-ID: <153937384305.5275.9319960324791639711@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181012184017.GH2843@piout.net>
Quoting Alexandre Belloni (2018-10-12 11:40:17)
> On 12/10/2018 11:28:06-0700, Stephen Boyd wrote:
> > Quoting Stephen Boyd (2018-08-31 10:45:30)
> > > Quoting Alexandre Belloni (2018-08-16 04:47:55)
> > > > On 27/07/2018 10:03:22-0700, Stephen Boyd wrote:
> > > > > Quoting Alexandre Belloni (2018-07-17 15:27:41)
> > > > > > This is the promised rework of the at91 PMC clocks driver. It is mainly
> > > > > > necessary to remove the DTC warnings but it also complies with the CCF
> > > > > > rule that there should be one node per controller instead of one node
> > > > > > per clock.
> > > > > >
> > > > > > This only handles the PMC, I'm planning to also rework the SCKC bindings
> > > > > > later (without breaking the DT ABI).
> > > > > >
> > > > > > The series is based on top of clk-next plus at91-dt so I don't think it
> > > > > > is convenient to have it this cycle. However, I would really like to
> > > > > > ensure we agree on the new bindings this cycle before converting all the
> > > > > > other platforms as this is a bit tedious.
> > > > > >
> > > > > > The first two patches are actually fixes and may be considered for this
> > > > > > cycle.
> > > > > >
> > > > > > One nice note:
> > > > > > at91-sama5d2_xplained.dtb goes from 29351 bytes to 22082 bytes
> > > > >
> > > > > Patches look mostly good. Rob is happy with the bindings and so am I.
> > > > >
> > > > > One general question is why the drivers can't be moved to real platform
> > > > > drivers instead of using OF_CLK_DECLARE?
> > > > >
> > > >
> > > > I tried, this makes the clocksource drivers fail with -EPROBE_DEFER and
> > > > so the kernel just stops there.
> > > >
> > >
> > > Ok. We have CLK_OF_DECLARE_DRIVER for that. Can you use that?
> > >
> >
> > I assume this will be resent. I haven't seen anything yet though.
> >
>
> It will, would you be willing to take it for this cycle if I manage to
> send it on Monday? (it seems that we will have an -rc8).
>
Well there are fixes to be made, so go at your own pace and don't stress
yourself to deliver it on Monday. I plan to stop picking most things
early next week.
next prev parent reply other threads:[~2018-10-12 19:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:27 [PATCH 00/16] clk: at91: Rework DT bindings Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 01/16] clk: at91: audio-pll: fix audio pmc type Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 02/16] clk: at91: generated: SSCs don't have a gclk Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 03/16] clk: at91: h32mx: separate registration from DT parsing Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 04/16] clk: at91: audio-pll: " Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 05/16] clk: at91: generated: set audio_pll_allowed in at91_clk_register_generated() Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 06/16] clk: at91: allow clock registration from C code Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 07/16] clk: at91: add pmc_data struct and helpers Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 08/16] dt-bindings: clk: at91: Document new PMC binding Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-25 19:09 ` Rob Herring
2018-07-25 19:09 ` Rob Herring
2018-07-17 22:27 ` [PATCH 09/16] clk: at91: add new DT lookup function Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-25 19:10 ` Rob Herring
2018-07-25 19:10 ` Rob Herring
2018-07-17 22:27 ` [PATCH 10/16] clk: at91: add sama5d4 pmc driver Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 11/16] clk: at91: add sama5d2 PMC driver Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 12/16] clk: at91: add at91sam9x5 PMCs driver Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 13/16] clk: at91: move DT compatibility code to its own file Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 14/16] ARM: dts: at91: sama5d4: switch to new clock bindings Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 15/16] ARM: dts: at91: sama5d2: switch to new binding Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-17 22:27 ` [PATCH 16/16] ARM: dts: at91: at91sam9x5: switch to new clock bindings Alexandre Belloni
2018-07-17 22:27 ` Alexandre Belloni
2018-07-27 17:03 ` [PATCH 00/16] clk: at91: Rework DT bindings Stephen Boyd
2018-07-27 17:03 ` Stephen Boyd
2018-07-27 17:03 ` Stephen Boyd
2018-07-27 17:03 ` Stephen Boyd
2018-07-27 20:02 ` Alexandre Belloni
2018-07-27 20:02 ` Alexandre Belloni
2018-08-16 11:47 ` Alexandre Belloni
2018-08-16 11:47 ` Alexandre Belloni
2018-08-31 17:45 ` Stephen Boyd
2018-08-31 17:45 ` Stephen Boyd
2018-08-31 17:45 ` Stephen Boyd
2018-10-12 18:28 ` Stephen Boyd
2018-10-12 18:28 ` Stephen Boyd
2018-10-12 18:40 ` Alexandre Belloni
2018-10-12 18:40 ` Alexandre Belloni
2018-10-12 19:50 ` Stephen Boyd [this message]
2018-10-12 19:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153937384305.5275.9319960324791639711@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.