From: Stephen Boyd <sboyd@kernel.org>
To: gregkh@linuxfoundation.org
Cc: msavaliy@codeaurora.org, linux-arm-msm@vger.kernel.org,
alokc@codeaurora.org, mka@chromium.org, evgreen@chromium.org,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
Date: Tue, 16 Oct 2018 13:53:33 -0700 [thread overview]
Message-ID: <153972321308.5275.4720449474527347628@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181015204425.84537-1-dianders@chromium.org>
Quoting Douglas Anderson (2018-10-15 13:44:24)
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
>
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
>
> This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
> to 1 for the console port.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Douglas Anderson <dianders@chromium.org>, gregkh@linuxfoundation.org
Cc: msavaliy@codeaurora.org, linux-arm-msm@vger.kernel.org,
alokc@codeaurora.org, mka@chromium.org, evgreen@chromium.org,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
Date: Tue, 16 Oct 2018 13:53:33 -0700 [thread overview]
Message-ID: <153972321308.5275.4720449474527347628@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181015204425.84537-1-dianders@chromium.org>
Quoting Douglas Anderson (2018-10-15 13:44:24)
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
>
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
>
> This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
> to 1 for the console port.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2018-10-16 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 20:44 [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb Douglas Anderson
2018-10-16 20:53 ` Stephen Boyd [this message]
2018-10-16 20:53 ` Stephen Boyd
2018-10-17 7:34 ` msavaliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153972321308.5275.4720449474527347628@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=alokc@codeaurora.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.