All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.ibm.com>
To: YueHaibing <yuehaibing@huawei.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	David Howells <dhowells@redhat.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 -next] KEYS: trusted: remove set but not used variable 'keyhndl'
Date: Fri, 19 Oct 2018 16:30:23 +0000	[thread overview]
Message-ID: <1539966623.2819.3.camel@linux.ibm.com> (raw)
In-Reply-To: <1539949699-74650-1-git-send-email-yuehaibing@huawei.com>

On Fri, 2018-10-19 at 11:48 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> security/keys/trusted.c: In function 'tpm_unseal':
> security/keys/trusted.c:592:11: warning:
>  variable 'keyhndl' set but not used [-Wunused-but-set-variable]
>   uint32_t keyhndl;
> 
> It never used since introduction in 
> commit d00a1c72f7f4 ("keys: add new trusted key-type")

This triggered an "er, shouldn't we be using the SRK parent by
default?"  search through the code, but it turns out that's all taken
care of in trusted_options_alloc() where we'll set up the SRK as parent
with well known auth and unless overridden on the command line, that's
what we use, so I'm happy this is simply left over code from a
different implementation of that use case.

James

WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <jejb@linux.ibm.com>
To: YueHaibing <yuehaibing@huawei.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	David Howells <dhowells@redhat.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 -next] KEYS: trusted: remove set but not used variable 'keyhndl'
Date: Fri, 19 Oct 2018 09:30:23 -0700	[thread overview]
Message-ID: <1539966623.2819.3.camel@linux.ibm.com> (raw)
In-Reply-To: <1539949699-74650-1-git-send-email-yuehaibing@huawei.com>

On Fri, 2018-10-19 at 11:48 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> security/keys/trusted.c: In function 'tpm_unseal':
> security/keys/trusted.c:592:11: warning:
>  variable 'keyhndl' set but not used [-Wunused-but-set-variable]
>   uint32_t keyhndl;
> 
> It never used since introduction in 
> commit d00a1c72f7f4 ("keys: add new trusted key-type")

This triggered an "er, shouldn't we be using the SRK parent by
default?"  search through the code, but it turns out that's all taken
care of in trusted_options_alloc() where we'll set up the SRK as parent
with well known auth and unless overridden on the command line, that's
what we use, so I'm happy this is simply left over code from a
different implementation of that use case.

James


  reply	other threads:[~2018-10-19 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  6:56 [PATCH -next] KEYS: trusted: remove set but not used variable '' YueHaibing
2018-10-11  7:06 ` YueHaibing
2018-10-19 11:48 ` [PATCH v2 -next] KEYS: trusted: remove set but not used variable 'keyhndl' YueHaibing
2018-10-19 11:48   ` YueHaibing
2018-10-19 16:30   ` James Bottomley [this message]
2018-10-19 16:30     ` James Bottomley
2018-10-21  9:00     ` YueHaibing
2018-10-21  9:00       ` YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539966623.2819.3.camel@linux.ibm.com \
    --to=jejb@linux.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=yuehaibing@huawei.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.