* [PATCH V1 net-next] net: ena: fix compilation error in xtensa architecture
@ 2018-10-21 15:07 akiyano
2018-10-23 2:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akiyano @ 2018-10-21 15:07 UTC (permalink / raw)
To: davem, netdev
Cc: Arthur Kiyanovski, dwmw, zorik, matua, saeedb, msw, aliguori,
nafea, gtzalik, netanel, alisaidi
From: Arthur Kiyanovski <akiyano@amazon.com>
linux/prefetch.h is never explicitly included in ena_com, although
functions from it, such as prefetchw(), are used throughout ena_com.
This is an inclusion bug, and we fix it here by explicitly including
linux/prefetch.h. The bug was exposed when the driver was compiled
for the xtensa architecture.
Fixes: 689b2bdaaa14 ("net: ena: add functions for handling Low Latency Queues in ena_com")
Fixes: 8c590f977638 ("ena: Fix Kconfig dependency on X86")
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
---
drivers/net/ethernet/amazon/ena/ena_com.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
index ae8b485..078d6f2 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.h
+++ b/drivers/net/ethernet/amazon/ena/ena_com.h
@@ -38,6 +38,7 @@
#include <linux/dma-mapping.h>
#include <linux/gfp.h>
#include <linux/io.h>
+#include <linux/prefetch.h>
#include <linux/sched.h>
#include <linux/sizes.h>
#include <linux/spinlock.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V1 net-next] net: ena: fix compilation error in xtensa architecture
2018-10-21 15:07 [PATCH V1 net-next] net: ena: fix compilation error in xtensa architecture akiyano
@ 2018-10-23 2:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-23 2:48 UTC (permalink / raw)
To: akiyano
Cc: netdev, dwmw, zorik, matua, saeedb, msw, aliguori, nafea,
gtzalik, netanel, alisaidi
From: <akiyano@amazon.com>
Date: Sun, 21 Oct 2018 18:07:14 +0300
> From: Arthur Kiyanovski <akiyano@amazon.com>
>
> linux/prefetch.h is never explicitly included in ena_com, although
> functions from it, such as prefetchw(), are used throughout ena_com.
> This is an inclusion bug, and we fix it here by explicitly including
> linux/prefetch.h. The bug was exposed when the driver was compiled
> for the xtensa architecture.
>
> Fixes: 689b2bdaaa14 ("net: ena: add functions for handling Low Latency Queues in ena_com")
> Fixes: 8c590f977638 ("ena: Fix Kconfig dependency on X86")
> Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-23 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-21 15:07 [PATCH V1 net-next] net: ena: fix compilation error in xtensa architecture akiyano
2018-10-23 2:48 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.