From: Nguyen An Hoan <na-hoan@jinso.co.jp> To: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be Cc: laurent.pinchart@ideasonboard.com, kuninori.morimoto.gx@renesas.com, yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp, nv-dung@jinso.co.jp, cv-dong@jinso.co.jp, na-hoan@jinso.co.jp Subject: [PATCH] drm: rcar-du: Re-update the DSYSR register value for start/stop Date: Mon, 22 Oct 2018 15:30:54 +0900 [thread overview] Message-ID: <1540189854-14726-1-git-send-email-na-hoan@jinso.co.jp> (raw) From: Hoan Nguyen An <na-hoan@jinso.co.jp> >From previous commit 0521ccb "drm: rcar-du: Cache DSYSR value to ensure known initial value" We only need to update DSYSR0, DSYSR2 for start/stop. So using rgrp-> mmio_offset is enough, the change back from rcar_du_crtc -> rcar_du_group -> rcar_du_crtc leading to mmio addresses for DSYSR may be different. Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp> --- drivers/gpu/drm/rcar-du/rcar_du_group.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_group.c b/drivers/gpu/drm/rcar-du/rcar_du_group.c index d85f0a1..a5f7eed 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_group.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_group.c @@ -202,10 +202,9 @@ void rcar_du_group_put(struct rcar_du_group *rgrp) static void __rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start) { - struct rcar_du_crtc *rcrtc = &rgrp->dev->crtcs[rgrp->index * 2]; - - rcar_du_crtc_dsysr_clr_set(rcrtc, DSYSR_DRES | DSYSR_DEN, - start ? DSYSR_DEN : DSYSR_DRES); + rcar_du_group_write(rgrp, DSYSR, + (rcar_du_group_read(rgrp, DSYSR) & ~(DSYSR_DRES | DSYSR_DEN)) | + (start ? DSYSR_DEN : DSYSR_DRES)); } void rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start) -- 2.7.4
next reply other threads:[~2018-10-22 14:48 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-22 6:30 Nguyen An Hoan [this message] 2018-10-22 8:21 ` Sergei Shtylyov 2018-10-23 0:59 ` Hoan 2018-10-22 11:23 ` Laurent Pinchart 2018-10-23 1:01 ` Hoan 2018-11-22 23:29 ` Laurent Pinchart 2018-10-23 10:10 ` Hoan 2018-10-24 0:16 ` Hoan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1540189854-14726-1-git-send-email-na-hoan@jinso.co.jp \ --to=na-hoan@jinso.co.jp \ --cc=cv-dong@jinso.co.jp \ --cc=geert+renesas@glider.be \ --cc=h-inayoshi@jinso.co.jp \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=nv-dung@jinso.co.jp \ --cc=yoshihiro.shimoda.uh@renesas.com \ --subject='Re: [PATCH] drm: rcar-du: Re-update the DSYSR register value for start/stop' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.