All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hoan <na-hoan@jinso.co.jp>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be
Cc: kuninori.morimoto.gx@renesas.com,
	yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
	nv-dung@jinso.co.jp, cv-dong@jinso.co.jp
Subject: Re: [PATCH] drm: rcar-du: Re-update the DSYSR register value for start/stop
Date: Tue, 23 Oct 2018 09:59:55 +0900	[thread overview]
Message-ID: <d98f256c-5445-f33f-fdd7-da13d923ce2b@jinso.co.jp> (raw)
In-Reply-To: <41a8932e-74a3-3225-5243-11df5c3923c8@cogentembedded.com>

Dear Sergei Shtylyov-san

On 2018/10/22 17:21, Sergei Shtylyov wrote:
> Hello!
>
> On 22.10.2018 9:30, Nguyen An Hoan wrote:
>
>> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
>>
>> From previous commit 0521ccb "drm: rcar-du: Cache DSYSR value to 
>> ensure known initial value"
>
>    When you cite an commit, at least 12 digits of SHA1 are needed, and 
> the summary needs to enclosed in (""), no just "".
>
>> We only need to update DSYSR0, DSYSR2 for start/stop. So using rgrp-> 
>> mmio_offset is enough,
>> the change back from rcar_du_crtc -> rcar_du_group -> rcar_du_crtc 
>> leading to
>> mmio addresses for DSYSR may be different.
>>
>> Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
>> ---
>>  drivers/gpu/drm/rcar-du/rcar_du_group.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_group.c 
>> b/drivers/gpu/drm/rcar-du/rcar_du_group.c
>> index d85f0a1..a5f7eed 100644
>> --- a/drivers/gpu/drm/rcar-du/rcar_du_group.c
>> +++ b/drivers/gpu/drm/rcar-du/rcar_du_group.c
>> @@ -202,10 +202,9 @@ void rcar_du_group_put(struct rcar_du_group *rgrp)
>>
>>  static void __rcar_du_group_start_stop(struct rcar_du_group *rgrp, 
>> bool start)
>>  {
>> -    struct rcar_du_crtc *rcrtc = &rgrp->dev->crtcs[rgrp->index * 2];
>> -
>> -    rcar_du_crtc_dsysr_clr_set(rcrtc, DSYSR_DRES | DSYSR_DEN,
>> -                   start ? DSYSR_DEN : DSYSR_DRES);
>
>    The continuation line indentation style used above is different 
> from yours below.
> would be preferable to keep the existing style...

Thank you for the comments, and the notes to me about code rules.
I note and improve for the next time, thank you!

Hoan.

>
>> +    rcar_du_group_write(rgrp, DSYSR,
>> +            (rcar_du_group_read(rgrp, DSYSR) & ~(DSYSR_DRES | 
>> DSYSR_DEN)) |
>> +            (start ? DSYSR_DEN : DSYSR_DRES));
>>  }
>>
>>  void rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start)
>
> MBR, Sergei
>
>

  reply	other threads:[~2018-10-23  9:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22  6:30 Nguyen An Hoan
2018-10-22  8:21 ` Sergei Shtylyov
2018-10-23  0:59   ` Hoan [this message]
2018-10-22 11:23 ` Laurent Pinchart
2018-10-23  1:01   ` Hoan
2018-11-22 23:29     ` Laurent Pinchart
2018-10-23 10:10   ` Hoan
2018-10-24  0:16   ` Hoan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d98f256c-5445-f33f-fdd7-da13d923ce2b@jinso.co.jp \
    --to=na-hoan@jinso.co.jp \
    --cc=cv-dong@jinso.co.jp \
    --cc=geert+renesas@glider.be \
    --cc=h-inayoshi@jinso.co.jp \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=nv-dung@jinso.co.jp \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    --subject='Re: [PATCH] drm: rcar-du: Re-update the DSYSR register value for start/stop' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.