All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
@ 2018-10-26  8:48 Biju Das
  2018-10-26  8:48 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0 Biju Das
  2018-10-26  9:48   ` Fabrizio Castro
  0 siblings, 2 replies; 10+ messages in thread
From: Biju Das @ 2018-10-26  8:48 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland
  Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro

Add CMT[01] support to r8a77470 SoC DT.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
This patch is tested against renesas-dev
---
 arch/arm/boot/dts/r8a77470.dtsi | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 74ca5d3..e40f5a9 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -710,6 +710,38 @@
 			compatible = "renesas,prr";
 			reg = <0 0xff000044 0 4>;
 		};
+
+		cmt0: timer@ffca0000 {
+			compatible = "renesas,r8a77470-cmt0",
+				     "renesas,rcar-gen2-cmt0";
+			reg = <0 0xffca0000 0 0x1004>;
+			interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 124>;
+			clock-names = "fck";
+			power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+			resets = <&cpg 124>;
+			status = "disabled";
+		};
+
+		cmt1: timer@e6130000 {
+			compatible = "renesas,r8a77470-cmt1",
+				     "renesas,rcar-gen2-cmt1";
+			reg = <0 0xe6130000 0 0x1004>;
+			interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 329>;
+			clock-names = "fck";
+			power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+			resets = <&cpg 329>;
+			status = "disabled";
+		};
 	};
 
 	timer {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
  2018-10-26  8:48 [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support Biju Das
@ 2018-10-26  8:48 ` Biju Das
  2018-10-26  9:48     ` Fabrizio Castro
  2018-10-30 15:51   ` Simon Horman
  2018-10-26  9:48   ` Fabrizio Castro
  1 sibling, 2 replies; 10+ messages in thread
From: Biju Das @ 2018-10-26  8:48 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland
  Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro

This patch enables cmt0 support on the iWave iwg23s sbc.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index 518b0c0..6277571 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -73,6 +73,10 @@
 	};
 };
 
+&cmt0 {
+	status = "okay";
+};
+
 &ehci1 {
 	status = "okay";
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* RE: [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
  2018-10-26  8:48 [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support Biju Das
@ 2018-10-26  9:48   ` Fabrizio Castro
  2018-10-26  9:48   ` Fabrizio Castro
  1 sibling, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26  9:48 UTC (permalink / raw)
  To: Biju Das, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, linux-renesas-soc, devicetree,
	Geert Uytterhoeven, Chris Paterson

> Subject: [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
>
> Add CMT[01] support to r8a77470 SoC DT.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

> ---
> This patch is tested against renesas-dev
> ---
>  arch/arm/boot/dts/r8a77470.dtsi | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> index 74ca5d3..e40f5a9 100644
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -710,6 +710,38 @@
>  compatible = "renesas,prr";
>  reg = <0 0xff000044 0 4>;
>  };
> +
> +cmt0: timer@ffca0000 {
> +compatible = "renesas,r8a77470-cmt0",
> +     "renesas,rcar-gen2-cmt0";
> +reg = <0 0xffca0000 0 0x1004>;
> +interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> +clocks = <&cpg CPG_MOD 124>;
> +clock-names = "fck";
> +power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +resets = <&cpg 124>;
> +status = "disabled";
> +};
> +
> +cmt1: timer@e6130000 {
> +compatible = "renesas,r8a77470-cmt1",
> +     "renesas,rcar-gen2-cmt1";
> +reg = <0 0xe6130000 0 0x1004>;
> +interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> +clocks = <&cpg CPG_MOD 329>;
> +clock-names = "fck";
> +power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +resets = <&cpg 329>;
> +status = "disabled";
> +};
>  };
>
>  timer {
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
@ 2018-10-26  9:48   ` Fabrizio Castro
  0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26  9:48 UTC (permalink / raw)
  To: Biju Das, Rob Herring, Mark Rutland
  Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson

> Subject: [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
>
> Add CMT[01] support to r8a77470 SoC DT.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

> ---
> This patch is tested against renesas-dev
> ---
>  arch/arm/boot/dts/r8a77470.dtsi | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> index 74ca5d3..e40f5a9 100644
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -710,6 +710,38 @@
>  compatible = "renesas,prr";
>  reg = <0 0xff000044 0 4>;
>  };
> +
> +cmt0: timer@ffca0000 {
> +compatible = "renesas,r8a77470-cmt0",
> +     "renesas,rcar-gen2-cmt0";
> +reg = <0 0xffca0000 0 0x1004>;
> +interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> +clocks = <&cpg CPG_MOD 124>;
> +clock-names = "fck";
> +power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +resets = <&cpg 124>;
> +status = "disabled";
> +};
> +
> +cmt1: timer@e6130000 {
> +compatible = "renesas,r8a77470-cmt1",
> +     "renesas,rcar-gen2-cmt1";
> +reg = <0 0xe6130000 0 0x1004>;
> +interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> +     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> +clocks = <&cpg CPG_MOD 329>;
> +clock-names = "fck";
> +power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +resets = <&cpg 329>;
> +status = "disabled";
> +};
>  };
>
>  timer {
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
  2018-10-26  8:48 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0 Biju Das
@ 2018-10-26  9:48     ` Fabrizio Castro
  2018-10-30 15:51   ` Simon Horman
  1 sibling, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26  9:48 UTC (permalink / raw)
  To: Biju Das, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, linux-renesas-soc, devicetree,
	Geert Uytterhoeven, Chris Paterson

> Subject: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
>
> This patch enables cmt0 support on the iWave iwg23s sbc.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

> ---
>  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index 518b0c0..6277571 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -73,6 +73,10 @@
>  };
>  };
>
> +&cmt0 {
> +status = "okay";
> +};
> +
>  &ehci1 {
>  status = "okay";
>  };
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
@ 2018-10-26  9:48     ` Fabrizio Castro
  0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26  9:48 UTC (permalink / raw)
  To: Biju Das, Rob Herring, Mark Rutland
  Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson

> Subject: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
>
> This patch enables cmt0 support on the iWave iwg23s sbc.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

> ---
>  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index 518b0c0..6277571 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -73,6 +73,10 @@
>  };
>  };
>
> +&cmt0 {
> +status = "okay";
> +};
> +
>  &ehci1 {
>  status = "okay";
>  };
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
  2018-10-26  9:48   ` Fabrizio Castro
  (?)
@ 2018-10-30 15:45   ` Simon Horman
  -1 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-10-30 15:45 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Biju Das, Rob Herring, Mark Rutland, Magnus Damm,
	linux-renesas-soc, devicetree, Geert Uytterhoeven,
	Chris Paterson

On Fri, Oct 26, 2018 at 09:48:33AM +0000, Fabrizio Castro wrote:
> > Subject: [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support
> >
> > Add CMT[01] support to r8a77470 SoC DT.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks, applied for v4.21.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
  2018-10-26  8:48 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0 Biju Das
  2018-10-26  9:48     ` Fabrizio Castro
@ 2018-10-30 15:51   ` Simon Horman
  2018-10-30 16:48     ` Biju Das
  1 sibling, 1 reply; 10+ messages in thread
From: Simon Horman @ 2018-10-30 15:51 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro

On Fri, Oct 26, 2018 at 09:48:29AM +0100, Biju Das wrote:
> This patch enables cmt0 support on the iWave iwg23s sbc.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Thanks, I applied this for v4.21, resolving a conflict.
The result is as follows:

From: Biju Das <biju.das@bp.renesas.com>
Date: Fri, 26 Oct 2018 09:48:29 +0100
Subject: [PATCH] ARM: dts: iwg23s-sbc: Enable cmt0

This patch enables cmt0 support on the iWave iwg23s sbc.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index ffd8216f28c3..295f11afac21 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -77,6 +77,10 @@
 	clock-frequency = <20000000>;
 };
 
+&cmt0 {
+	status = "okay";
+};
+
 &pfc {
 	mmc_pins_uhs: mmc_uhs {
 		groups = "mmc_data8", "mmc_ctrl";
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* RE: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
  2018-10-30 15:51   ` Simon Horman
@ 2018-10-30 16:48     ` Biju Das
  2018-10-31 12:50       ` Simon Horman
  0 siblings, 1 reply; 10+ messages in thread
From: Biju Das @ 2018-10-30 16:48 UTC (permalink / raw)
  To: Simon Horman
  Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro

Hi Simon,

Thanks for the feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
>
> On Fri, Oct 26, 2018 at 09:48:29AM +0100, Biju Das wrote:
> > This patch enables cmt0 support on the iWave iwg23s sbc.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Thanks, I applied this for v4.21, resolving a conflict.
> The result is as follows:
>
> From: Biju Das <biju.das@bp.renesas.com>
> Date: Fri, 26 Oct 2018 09:48:29 +0100
> Subject: [PATCH] ARM: dts: iwg23s-sbc: Enable cmt0
>
> This patch enables cmt0 support on the iWave iwg23s sbc.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index ffd8216f28c3..295f11afac21 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -77,6 +77,10 @@
>  clock-frequency = <20000000>;
>  };
>
> +&cmt0 {
> +status = "okay";
> +};

I believe as per our process, the nodes should be in alphabetical order,
If it is the case, it should be above  extal_clk

&extal_clk {
        clock-frequency = <20000000>;
};

>  &pfc {
>  mmc_pins_uhs: mmc_uhs {
>  groups = "mmc_data8", "mmc_ctrl";
> --

regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
  2018-10-30 16:48     ` Biju Das
@ 2018-10-31 12:50       ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-10-31 12:50 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
	devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro

On Tue, Oct 30, 2018 at 04:48:30PM +0000, Biju Das wrote:
> Hi Simon,
> 
> Thanks for the feedback.
> 
> > Subject: Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0
> >
> > On Fri, Oct 26, 2018 at 09:48:29AM +0100, Biju Das wrote:
> > > This patch enables cmt0 support on the iWave iwg23s sbc.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Thanks, I applied this for v4.21, resolving a conflict.
> > The result is as follows:
> >
> > From: Biju Das <biju.das@bp.renesas.com>
> > Date: Fri, 26 Oct 2018 09:48:29 +0100
> > Subject: [PATCH] ARM: dts: iwg23s-sbc: Enable cmt0
> >
> > This patch enables cmt0 support on the iWave iwg23s sbc.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > index ffd8216f28c3..295f11afac21 100644
> > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> > @@ -77,6 +77,10 @@
> >  clock-frequency = <20000000>;
> >  };
> >
> > +&cmt0 {
> > +status = "okay";
> > +};
> 
> I believe as per our process, the nodes should be in alphabetical order,
> If it is the case, it should be above  extal_clk
> 
> &extal_clk {
>         clock-frequency = <20000000>;
> };
> 
> >  &pfc {
> >  mmc_pins_uhs: mmc_uhs {
> >  groups = "mmc_data8", "mmc_ctrl";

Yes, indeed. That was my intention but I messed things up.
I've updated the patch accordingly.


From: Biju Das <biju.das@bp.renesas.com>
Date: Fri, 26 Oct 2018 09:48:29 +0100
Subject: [PATCH] ARM: dts: iwg23s-sbc: Enable cmt0

This patch enables cmt0 support on the iWave iwg23s sbc.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index ffd8216f28c3..18d22631e188 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -73,6 +73,10 @@
 	};
 };
 
+&cmt0 {
+	status = "okay";
+};
+
 &extal_clk {
 	clock-frequency = <20000000>;
 };
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-10-31 12:50 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26  8:48 [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support Biju Das
2018-10-26  8:48 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable cmt0 Biju Das
2018-10-26  9:48   ` Fabrizio Castro
2018-10-26  9:48     ` Fabrizio Castro
2018-10-30 15:51   ` Simon Horman
2018-10-30 16:48     ` Biju Das
2018-10-31 12:50       ` Simon Horman
2018-10-26  9:48 ` [PATCH 1/2] ARM: dts: r8a77470: Add CMT SoC specific support Fabrizio Castro
2018-10-26  9:48   ` Fabrizio Castro
2018-10-30 15:45   ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.