All of lore.kernel.org
 help / color / mirror / Atom feed
* [4.9-rc1] warnings at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
       [not found] <1952839951.373177.1476822106754.JavaMail.zimbra@redhat.com>
@ 2016-10-18 20:25 ` CAI Qian
  2016-10-18 20:38   ` Jeff Layton
  0 siblings, 1 reply; 3+ messages in thread
From: CAI Qian @ 2016-10-18 20:25 UTC (permalink / raw)
  To: linux-fsdevel; +Cc: Jeff Layton, J. Bruce Fields

Reproducible warnings while running the LTP tests fcntl33 and fcntl33_64. Never saw it
in v4.8 if I remember correctly. Not sure if something could cause problems later on.

https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fcntl/fcntl33.c

[ 1593.912336] WARNING: CPU: 3 PID: 22443 at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
[ 1593.921570] Modules linked in:[ 1593.924811]  loop veth ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 xt_addrtype iptable_filter xt_conntrack nf_nat nf_conntrack br_netfilter bridge stp llc overlay intel_rapl sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw gf128mul glue_helper ablk_helper cryptd iTCO_wdt iTCO_vendor_support pcspkr i2c_i801 i2c_smbus sg lpc_ich mei_me mei shpchp mxm_wmi ipmi_ssif ipmi_si ipmi_msghandler wmi acpi_power_meter acpi_pad nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs libcrc32c sr_mod sd_mod cdrom mgag200 i2c_algo_bit drm_kms_helper crc32c_intel syscopyarea sysfillrect sysimgblt fb_sys_fops serio_raw ttm ixgbe drm ahci libahci libata mdio ptp i2c_core pps_core dca fjes dm_mirror dm_region_hash dm_log dm_mod
[ 1594.009470] CPU: 3 PID: 22443 Comm: fcntl33 Tainted: G        W       4.9.0-rc1-yuncore #45
[ 1594.018782] Hardware name: Intel Corporation S2600WTT/S2600WTT, BIOS GRRFSDP1.86B.0271.R00.1510301446 10/30/2015
[ 1594.030138]  ffff88080ef57bd8 ffffffff81d43634 0000000041b58ab3 ffffffff8335078f
[ 1594.038434]  ffffffff81d43574 ffff88080ef57b00 ffff88083bca0cd0 977468135b731612
[ 1594.046729]  00000000c38a36a8 ffff88085ac58a18 0000000000000003 00000000000057ab
[ 1594.055025] Call Trace:
[ 1594.057757]  [<ffffffff81d43634>] dump_stack+0xc0/0x12c
[ 1594.063589]  [<ffffffff81d43574>] ? _atomic_dec_and_lock+0xc4/0xc4
[ 1594.070488]  [<ffffffff811d0aee>] __warn+0x19e/0x1d0
[ 1594.076018]  [<ffffffff811d0d0d>] warn_slowpath_null+0x1d/0x20
[ 1594.082527]  [<ffffffff819db1e0>] locks_unlink_lock_ctx+0x350/0x4f0
[ 1594.089520]  [<ffffffff819dae90>] ? locks_wake_up_blocks+0x1d0/0x1d0
[ 1594.096614]  [<ffffffff82c964e1>] ? _raw_spin_unlock+0x31/0x50
[ 1594.103127]  [<ffffffff818d9efd>] ? fasync_remove_entry+0x9d/0x1d0
[ 1594.110023]  [<ffffffff819db397>] locks_delete_lock_ctx+0x17/0x70
[ 1594.116824]  [<ffffffff819ddf87>] lease_modify+0x1e7/0x2c0
[ 1594.122946]  [<ffffffff819eaa46>] locks_remove_file+0x2c6/0x490
[ 1594.129550]  [<ffffffff819ea780>] ? fcntl_setlk+0xef0/0xef0
[ 1594.135770]  [<ffffffff81278195>] ? __might_sleep+0x65/0x260
[ 1594.142087]  [<ffffffff8189900e>] __fput+0x20e/0x880
[ 1594.147627]  [<ffffffff818040c3>] ? kfree+0x3f3/0x620
[ 1594.153264]  [<ffffffff818996fe>] ____fput+0xe/0x10
[ 1594.158707]  [<ffffffff812502e0>] task_work_run+0xd0/0x1a0
[ 1594.164829]  [<ffffffff81004c8b>] exit_to_usermode_loop+0xfb/0x140
[ 1594.171727]  [<ffffffff81009455>] do_syscall_64+0x3a5/0x540
[ 1594.177944]  [<ffffffff82c96f24>] entry_SYSCALL64_slow_path+0x25/0x25
[ 1594.185181] ---[ end trace f7fe67b590690a05 ]---
[ 1594.240757] ------------[ cut here ]------------
[ 1594.245918] WARNING: CPU: 54 PID: 22451 at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
[ 1594.255247] Modules linked in:[ 1594.258469]  loop veth ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 xt_addrtype iptable_filter xt_conntrack nf_nat nf_conntrack br_netfilter bridge stp llc overlay intel_rapl sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw gf128mul glue_helper ablk_helper cryptd iTCO_wdt iTCO_vendor_support pcspkr i2c_i801 i2c_smbus sg lpc_ich mei_me mei shpchp mxm_wmi ipmi_ssif ipmi_si ipmi_msghandler wmi acpi_power_meter acpi_pad nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs libcrc32c sr_mod sd_mod cdrom mgag200 i2c_algo_bit drm_kms_helper crc32c_intel syscopyarea sysfillrect sysimgblt fb_sys_fops serio_raw ttm ixgbe drm ahci libahci libata mdio ptp i2c_core pps_core dca fjes dm_mirror dm_region_hash dm_log dm_mod
[ 1594.343233] CPU: 54 PID: 22451 Comm: fcntl33_64 Tainted: G        W       4.9.0-rc1-yuncore #45
[ 1594.352942] Hardware name: Intel Corporation S2600WTT/S2600WTT, BIOS GRRFSDP1.86B.0271.R00.1510301446 10/30/2015
[ 1594.364298]  ffff88080ef57bd8 ffffffff81d43634 0000000041b58ab3 ffffffff8335078f
[ 1594.372589]  ffffffff81d43574 ffff88080ef57b00 ffff88083bca3150 977468135b731612
[ 1594.380881]  000000003f001529 ffff88085e658a18 0000000000000036 00000000000057b3
[ 1594.389184] Call Trace:
[ 1594.391913]  [<ffffffff81d43634>] dump_stack+0xc0/0x12c
[ 1594.397744]  [<ffffffff81d43574>] ? _atomic_dec_and_lock+0xc4/0xc4
[ 1594.404640]  [<ffffffff811d0aee>] __warn+0x19e/0x1d0
[ 1594.410179]  [<ffffffff811d0d0d>] warn_slowpath_null+0x1d/0x20
[ 1594.416688]  [<ffffffff819db1e0>] locks_unlink_lock_ctx+0x350/0x4f0
[ 1594.423682]  [<ffffffff819dae90>] ? locks_wake_up_blocks+0x1d0/0x1d0
[ 1594.430773]  [<ffffffff82c964e1>] ? _raw_spin_unlock+0x31/0x50
[ 1594.437282]  [<ffffffff818d9efd>] ? fasync_remove_entry+0x9d/0x1d0
[ 1594.444178]  [<ffffffff819db397>] locks_delete_lock_ctx+0x17/0x70
[ 1594.450978]  [<ffffffff819ddf87>] lease_modify+0x1e7/0x2c0
[ 1594.457099]  [<ffffffff819eaa46>] locks_remove_file+0x2c6/0x490
[ 1594.463704]  [<ffffffff819ea780>] ? fcntl_setlk+0xef0/0xef0
[ 1594.469922]  [<ffffffff81278195>] ? __might_sleep+0x65/0x260
[ 1594.476237]  [<ffffffff8189900e>] __fput+0x20e/0x880
[ 1594.481777]  [<ffffffff818040c3>] ? kfree+0x3f3/0x620
[ 1594.487414]  [<ffffffff818996fe>] ____fput+0xe/0x10
[ 1594.492856]  [<ffffffff812502e0>] task_work_run+0xd0/0x1a0
[ 1594.498978]  [<ffffffff81004c8b>] exit_to_usermode_loop+0xfb/0x140
[ 1594.505877]  [<ffffffff81009455>] do_syscall_64+0x3a5/0x540
[ 1594.512098]  [<ffffffff82c96f24>] entry_SYSCALL64_slow_path+0x25/0x25
[ 1594.519318] ---[ end trace f7fe67b590690a06 ]---

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [4.9-rc1] warnings at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
  2016-10-18 20:25 ` [4.9-rc1] warnings at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0 CAI Qian
@ 2016-10-18 20:38   ` Jeff Layton
  2016-10-18 21:23     ` CAI Qian
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2016-10-18 20:38 UTC (permalink / raw)
  To: CAI Qian, linux-fsdevel; +Cc: J. Bruce Fields, Peter Zijlstra

On Tue, 2016-10-18 at 16:25 -0400, CAI Qian wrote:
> Reproducible warnings while running the LTP tests fcntl33 and fcntl33_64. Never saw it
> in v4.8 if I remember correctly. Not sure if something could cause problems later on.
> 
> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fcntl/fcntl33.c
> 
> [ 1593.912336] WARNING: CPU: 3 PID: 22443 at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
> [ 1593.921570] Modules linked in:[ 1593.924811]  loop veth ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 xt_addrtype iptable_filter xt_conntrack nf_nat nf_conntrack br_netfilter bridge stp llc overlay intel_rapl sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw gf128mul glue_helper ablk_helper cryptd iTCO_wdt iTCO_vendor_support pcspkr i2c_i801 i2c_smbus sg lpc_ich mei_me mei shpchp mxm_wmi ipmi_ssif ipmi_si ipmi_msghandler wmi acpi_power_meter acpi_pad nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs libcrc32c sr_mod sd_mod cdrom mgag200 i2c_algo_bit drm_kms_helper crc32c_intel syscopyarea sysfillrect sysimgblt fb_sys_fops serio_raw ttm ixgbe drm ahci libahci libata mdio ptp i2c_core pps_core dca fjes dm_mirror dm_region_hash dm_log dm_mod
> [ 1594.009470] CPU: 3 PID: 22443 Comm: fcntl33 Tainted: G        W       4.9.0-rc1-yuncore #45
> [ 1594.018782] Hardware name: Intel Corporation S2600WTT/S2600WTT, BIOS GRRFSDP1.86B.0271.R00.1510301446 10/30/2015
> [ 1594.030138]  ffff88080ef57bd8 ffffffff81d43634 0000000041b58ab3 ffffffff8335078f
> [ 1594.038434]  ffffffff81d43574 ffff88080ef57b00 ffff88083bca0cd0 977468135b731612
> [ 1594.046729]  00000000c38a36a8 ffff88085ac58a18 0000000000000003 00000000000057ab
> [ 1594.055025] Call Trace:
> [ 1594.057757]  [<ffffffff81d43634>] dump_stack+0xc0/0x12c
> [ 1594.063589]  [<ffffffff81d43574>] ? _atomic_dec_and_lock+0xc4/0xc4
> [ 1594.070488]  [<ffffffff811d0aee>] __warn+0x19e/0x1d0
> [ 1594.076018]  [<ffffffff811d0d0d>] warn_slowpath_null+0x1d/0x20
> [ 1594.082527]  [<ffffffff819db1e0>] locks_unlink_lock_ctx+0x350/0x4f0
> [ 1594.089520]  [<ffffffff819dae90>] ? locks_wake_up_blocks+0x1d0/0x1d0
> [ 1594.096614]  [<ffffffff82c964e1>] ? _raw_spin_unlock+0x31/0x50
> [ 1594.103127]  [<ffffffff818d9efd>] ? fasync_remove_entry+0x9d/0x1d0
> [ 1594.110023]  [<ffffffff819db397>] locks_delete_lock_ctx+0x17/0x70
> [ 1594.116824]  [<ffffffff819ddf87>] lease_modify+0x1e7/0x2c0
> [ 1594.122946]  [<ffffffff819eaa46>] locks_remove_file+0x2c6/0x490
> [ 1594.129550]  [<ffffffff819ea780>] ? fcntl_setlk+0xef0/0xef0
> [ 1594.135770]  [<ffffffff81278195>] ? __might_sleep+0x65/0x260
> [ 1594.142087]  [<ffffffff8189900e>] __fput+0x20e/0x880
> [ 1594.147627]  [<ffffffff818040c3>] ? kfree+0x3f3/0x620
> [ 1594.153264]  [<ffffffff818996fe>] ____fput+0xe/0x10
> [ 1594.158707]  [<ffffffff812502e0>] task_work_run+0xd0/0x1a0
> [ 1594.164829]  [<ffffffff81004c8b>] exit_to_usermode_loop+0xfb/0x140
> [ 1594.171727]  [<ffffffff81009455>] do_syscall_64+0x3a5/0x540
> [ 1594.177944]  [<ffffffff82c96f24>] entry_SYSCALL64_slow_path+0x25/0x25
> [ 1594.185181] ---[ end trace f7fe67b590690a05 ]---
> [ 1594.240757] ------------[ cut here ]------------
> [ 1594.245918] WARNING: CPU: 54 PID: 22451 at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
> [ 1594.255247] Modules linked in:[ 1594.258469]  loop veth ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 xt_addrtype iptable_filter xt_conntrack nf_nat nf_conntrack br_netfilter bridge stp llc overlay intel_rapl sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw gf128mul glue_helper ablk_helper cryptd iTCO_wdt iTCO_vendor_support pcspkr i2c_i801 i2c_smbus sg lpc_ich mei_me mei shpchp mxm_wmi ipmi_ssif ipmi_si ipmi_msghandler wmi acpi_power_meter acpi_pad nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs libcrc32c sr_mod sd_mod cdrom mgag200 i2c_algo_bit drm_kms_helper crc32c_intel syscopyarea sysfillrect sysimgblt fb_sys_fops serio_raw ttm ixgbe drm ahci libahci libata mdio ptp i2c_core pps_core dca fjes dm_mirror dm_region_hash dm_log dm_mod
> [ 1594.343233] CPU: 54 PID: 22451 Comm: fcntl33_64 Tainted: G        W       4.9.0-rc1-yuncore #45
> [ 1594.352942] Hardware name: Intel Corporation S2600WTT/S2600WTT, BIOS GRRFSDP1.86B.0271.R00.1510301446 10/30/2015
> [ 1594.364298]  ffff88080ef57bd8 ffffffff81d43634 0000000041b58ab3 ffffffff8335078f
> [ 1594.372589]  ffffffff81d43574 ffff88080ef57b00 ffff88083bca3150 977468135b731612
> [ 1594.380881]  000000003f001529 ffff88085e658a18 0000000000000036 00000000000057b3
> [ 1594.389184] Call Trace:
> [ 1594.391913]  [<ffffffff81d43634>] dump_stack+0xc0/0x12c
> [ 1594.397744]  [<ffffffff81d43574>] ? _atomic_dec_and_lock+0xc4/0xc4
> [ 1594.404640]  [<ffffffff811d0aee>] __warn+0x19e/0x1d0
> [ 1594.410179]  [<ffffffff811d0d0d>] warn_slowpath_null+0x1d/0x20
> [ 1594.416688]  [<ffffffff819db1e0>] locks_unlink_lock_ctx+0x350/0x4f0
> [ 1594.423682]  [<ffffffff819dae90>] ? locks_wake_up_blocks+0x1d0/0x1d0
> [ 1594.430773]  [<ffffffff82c964e1>] ? _raw_spin_unlock+0x31/0x50
> [ 1594.437282]  [<ffffffff818d9efd>] ? fasync_remove_entry+0x9d/0x1d0
> [ 1594.444178]  [<ffffffff819db397>] locks_delete_lock_ctx+0x17/0x70
> [ 1594.450978]  [<ffffffff819ddf87>] lease_modify+0x1e7/0x2c0
> [ 1594.457099]  [<ffffffff819eaa46>] locks_remove_file+0x2c6/0x490
> [ 1594.463704]  [<ffffffff819ea780>] ? fcntl_setlk+0xef0/0xef0
> [ 1594.469922]  [<ffffffff81278195>] ? __might_sleep+0x65/0x260
> [ 1594.476237]  [<ffffffff8189900e>] __fput+0x20e/0x880
> [ 1594.481777]  [<ffffffff818040c3>] ? kfree+0x3f3/0x620
> [ 1594.487414]  [<ffffffff818996fe>] ____fput+0xe/0x10
> [ 1594.492856]  [<ffffffff812502e0>] task_work_run+0xd0/0x1a0
> [ 1594.498978]  [<ffffffff81004c8b>] exit_to_usermode_loop+0xfb/0x140
> [ 1594.505877]  [<ffffffff81009455>] do_syscall_64+0x3a5/0x540
> [ 1594.512098]  [<ffffffff82c96f24>] entry_SYSCALL64_slow_path+0x25/0x25
> [ 1594.519318] ---[ end trace f7fe67b590690a06 ]---


This looks like the problem that Peter Z. just recently fixed in the
file locking code. Does the kernel you're testing have
commit 5f43086bb9224987010460dcf3dee68fbd4f574d ?

-- 
Jeff Layton <jlayton@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [4.9-rc1] warnings at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0
  2016-10-18 20:38   ` Jeff Layton
@ 2016-10-18 21:23     ` CAI Qian
  0 siblings, 0 replies; 3+ messages in thread
From: CAI Qian @ 2016-10-18 21:23 UTC (permalink / raw)
  To: Jeff Layton; +Cc: linux-fsdevel, J. Bruce Fields, Peter Zijlstra


> 
> This looks like the problem that Peter Z. just recently fixed in the
> file locking code. Does the kernel you're testing have
> commit 5f43086bb9224987010460dcf3dee68fbd4f574d ?
No. It works fine now on a newer kernel after a fresh git pull. Guess
the commit is the fix then.
    CAI Qian

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-18 21:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1952839951.373177.1476822106754.JavaMail.zimbra@redhat.com>
2016-10-18 20:25 ` [4.9-rc1] warnings at fs/locks.c:615 locks_unlink_lock_ctx+0x350/0x4f0 CAI Qian
2016-10-18 20:38   ` Jeff Layton
2016-10-18 21:23     ` CAI Qian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.