* [PATCH] clk: boston: fix possible memory leak in clk_boston_setup()
@ 2018-10-29 8:04 Yi Wang
2018-10-29 8:06 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Yi Wang @ 2018-10-29 8:04 UTC (permalink / raw)
To: paul.burton
Cc: mturquette, sboyd, linux-mips, linux-clk, linux-kernel,
zhong.weidong, Yi Wang
'onecell' is malloced in clk_boston_setup(), but not be freed
before leaving from the error handling cases.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
drivers/clk/imgtec/clk-boston.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/imgtec/clk-boston.c b/drivers/clk/imgtec/clk-boston.c
index 15af423..f5d54a6 100644
--- a/drivers/clk/imgtec/clk-boston.c
+++ b/drivers/clk/imgtec/clk-boston.c
@@ -73,27 +73,32 @@ static void __init clk_boston_setup(struct device_node *np)
hw = clk_hw_register_fixed_rate(NULL, "input", NULL, 0, in_freq);
if (IS_ERR(hw)) {
pr_err("failed to register input clock: %ld\n", PTR_ERR(hw));
- return;
+ goto error;
}
onecell->hws[BOSTON_CLK_INPUT] = hw;
hw = clk_hw_register_fixed_rate(NULL, "sys", "input", 0, sys_freq);
if (IS_ERR(hw)) {
pr_err("failed to register sys clock: %ld\n", PTR_ERR(hw));
- return;
+ goto error;
}
onecell->hws[BOSTON_CLK_SYS] = hw;
hw = clk_hw_register_fixed_rate(NULL, "cpu", "input", 0, cpu_freq);
if (IS_ERR(hw)) {
pr_err("failed to register cpu clock: %ld\n", PTR_ERR(hw));
- return;
+ goto error;
}
onecell->hws[BOSTON_CLK_CPU] = hw;
err = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, onecell);
if (err)
pr_err("failed to add DT provider: %d\n", err);
+
+ return;
+
+error:
+ kfree(onecell);
}
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: boston: fix possible memory leak in clk_boston_setup()
2018-10-29 8:04 [PATCH] clk: boston: fix possible memory leak in clk_boston_setup() Yi Wang
@ 2018-10-29 8:06 ` Sergei Shtylyov
2018-10-29 8:24 ` wang.yi59
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2018-10-29 8:06 UTC (permalink / raw)
To: Yi Wang, paul.burton
Cc: mturquette, sboyd, linux-mips, linux-clk, linux-kernel, zhong.weidong
Hello!
On 10/29/2018 11:04 AM, Yi Wang wrote:
> 'onecell' is malloced in clk_boston_setup(), but not be freed
Is not freed.
> before leaving from the error handling cases.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: boston: fix possible memory leak inclk_boston_setup()
@ 2018-10-29 8:24 ` wang.yi59
0 siblings, 0 replies; 4+ messages in thread
From: wang.yi59 @ 2018-10-29 8:24 UTC (permalink / raw)
To: sergei.shtylyov
Cc: paul.burton, mturquette, sboyd, linux-mips, linux-clk,
linux-kernel, zhong.weidong
[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]
Hi Sergei,
> Hello!
>
> On 10/29/2018 11:04 AM, Yi Wang wrote:
>
> > 'onecell' is malloced in clk_boston_setup(), but not be freed
>
> Is not freed.
Thanks a lot, I will send a v2 patch.
>
> > before leaving from the error handling cases.
> >
> > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> [...]
>
> MBR, Sergei
---
Best wishes
Yi Wang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: boston: fix possible memory leak inclk_boston_setup()
@ 2018-10-29 8:24 ` wang.yi59
0 siblings, 0 replies; 4+ messages in thread
From: wang.yi59 @ 2018-10-29 8:24 UTC (permalink / raw)
To: sergei.shtylyov
Cc: paul.burton, mturquette, sboyd, linux-mips, linux-clk,
linux-kernel, zhong.weidong
[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]
Hi Sergei,
> Hello!
>
> On 10/29/2018 11:04 AM, Yi Wang wrote:
>
> > 'onecell' is malloced in clk_boston_setup(), but not be freed
>
> Is not freed.
Thanks a lot, I will send a v2 patch.
>
> > before leaving from the error handling cases.
> >
> > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> [...]
>
> MBR, Sergei
---
Best wishes
Yi Wang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-29 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29 8:04 [PATCH] clk: boston: fix possible memory leak in clk_boston_setup() Yi Wang
2018-10-29 8:06 ` Sergei Shtylyov
2018-10-29 8:24 ` [PATCH] clk: boston: fix possible memory leak inclk_boston_setup() wang.yi59
2018-10-29 8:24 ` wang.yi59
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.