* [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
@ 2013-07-16 0:10 Laurent Pinchart
2013-07-18 1:24 ` Laurent Pinchart
` (7 more replies)
0 siblings, 8 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-07-16 0:10 UTC (permalink / raw)
To: linux-sh
Hello,
Here's the second version of a patch series that cleans up and refactors the
sh-pfc driver to add support for pins with no associated GPIO port.
Most configurable pins in SuperH and SH Mobile devices can be used as a GPIO.
However, some of them have selectable functions but are not associated with a
GPIO. Those pins must be defined in the pinmux pins array but not registered
in the GPIOs ranges.
The series first cleans up the sh-pfc driver by removing unused features (01
to 13) and then gradually refactors the code (14 to 21) to add pin numbers to
the sh_pfc_pin structure (22 to 24). It finally computes pin ranges
automatically (26) and adds support for pins without a GPIO port (27).
The patches have been compiled for all supported SoCs and tested on the KZM9G
board (SH73A0) with a hack to add I2C4 pins that have no GPIO port. I'm
lacking hardware to test R8A7778 which would be a good test candidate.
The patches are based on v3.11-rc1.
Changes since v1:
- Split patch 01/19 into per-SoC patches smaller than the vger limit
Laurent Pinchart (27):
sh-pfc: sh7720: Remove unused input_pu range
sh-pfc: sh7722: Remove unused input_pd and input_pu ranges
sh-pfc: sh7723: Remove unused input_pu range
sh-pfc: sh7724: Remove unused input_pu range
sh-pfc: sh7757: Remove unused input_pu range
sh-pfc: sh7785: Remove unused input_pu range
sh-pfc: sh7786: Remove unused input_pu range
sh-pfc: shx3: Remove unused input_pu range
sh-pfc: Remove unused input_pd and input_pu ranges
sh-pfc: Remove unused PORT_DATA_* macros
sh-pfc: Remove unused macro and enum entries
sh-pfc: Remove unneeded const keywords
sh-pfc: Remove unused GPIO_PORT_ALL macro
sh-pfc: Don't overallocate memory for the GPIO chip pins array
sh-pfc: Replace pinmux_enum_id typedef with u16
sh-pfc: Rename gpio arguments to be consistent with the rest of the
code
sh-pfc: Consolidate PFC SoC data macros
sh-pfc: Consolidate pin definition macros
sh-pfc: sh7734: Use the common GP port style macros
sh-pfc: shx3: Remove shx3_ prefix from static symbols
sh-pfc: Don't duplicate argument to PINMUX_GPIO macro
sh-pfc: Add port numbers to the CPU_ALL_PORT macro
sh-pfc: Pass the pin number down to the port function macro
sh-pfc: Add pin number to struct sh_pfc_pin
sh-pfc: Rename struct sh_pfc nr_pins field to nr_gpio_pins
sh-pfc: Compute pin ranges automatically
sh-pfc: Support pins not associated with a GPIO port
drivers/pinctrl/sh-pfc/core.c | 99 ++-
drivers/pinctrl/sh-pfc/core.h | 10 +-
drivers/pinctrl/sh-pfc/gpio.c | 45 +-
drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 157 ++---
drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 47 +-
drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 55 +-
drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 63 +-
drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 59 +-
drivers/pinctrl/sh-pfc/pfc-sh7203.c | 202 ++++---
drivers/pinctrl/sh-pfc/pfc-sh7264.c | 246 ++++----
drivers/pinctrl/sh-pfc/pfc-sh7269.c | 285 +++++----
drivers/pinctrl/sh-pfc/pfc-sh7372.c | 53 +-
drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 104 ++--
drivers/pinctrl/sh-pfc/pfc-sh7720.c | 701 +++++++++++-----------
drivers/pinctrl/sh-pfc/pfc-sh7722.c | 747 +++++++++++------------
drivers/pinctrl/sh-pfc/pfc-sh7723.c | 381 ++++++------
drivers/pinctrl/sh-pfc/pfc-sh7724.c | 1093 ++++++++++++++++------------------
drivers/pinctrl/sh-pfc/pfc-sh7734.c | 60 +-
drivers/pinctrl/sh-pfc/pfc-sh7757.c | 709 +++++++++++-----------
drivers/pinctrl/sh-pfc/pfc-sh7785.c | 700 +++++++++++-----------
drivers/pinctrl/sh-pfc/pfc-sh7786.c | 383 ++++++------
drivers/pinctrl/sh-pfc/pfc-shx3.c | 423 +++++++------
drivers/pinctrl/sh-pfc/pinctrl.c | 49 +-
drivers/pinctrl/sh-pfc/sh_pfc.h | 277 +++++----
24 files changed, 3275 insertions(+), 3673 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
@ 2013-07-18 1:24 ` Laurent Pinchart
2013-07-19 2:10 ` Simon Horman
` (6 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-07-18 1:24 UTC (permalink / raw)
To: linux-sh
Hi Simon,
I've received a positive test feedback for this patch series. Could you please
include it in your -devel tags to get wider test coverage ? I'll then wait a
couple of weeks and, if no problem is found, send a pull request to Linus to
get the series merged through the pinctrl tree.
On Tuesday 16 July 2013 02:10:52 Laurent Pinchart wrote:
> Hello,
>
> Here's the second version of a patch series that cleans up and refactors the
> sh-pfc driver to add support for pins with no associated GPIO port.
>
> Most configurable pins in SuperH and SH Mobile devices can be used as a
> GPIO. However, some of them have selectable functions but are not
> associated with a GPIO. Those pins must be defined in the pinmux pins array
> but not registered in the GPIOs ranges.
>
> The series first cleans up the sh-pfc driver by removing unused features (01
> to 13) and then gradually refactors the code (14 to 21) to add pin numbers
> to the sh_pfc_pin structure (22 to 24). It finally computes pin ranges
> automatically (26) and adds support for pins without a GPIO port (27).
>
> The patches have been compiled for all supported SoCs and tested on the
> KZM9G board (SH73A0) with a hack to add I2C4 pins that have no GPIO port.
> I'm lacking hardware to test R8A7778 which would be a good test candidate.
>
> The patches are based on v3.11-rc1.
>
> Changes since v1:
>
> - Split patch 01/19 into per-SoC patches smaller than the vger limit
>
> Laurent Pinchart (27):
> sh-pfc: sh7720: Remove unused input_pu range
> sh-pfc: sh7722: Remove unused input_pd and input_pu ranges
> sh-pfc: sh7723: Remove unused input_pu range
> sh-pfc: sh7724: Remove unused input_pu range
> sh-pfc: sh7757: Remove unused input_pu range
> sh-pfc: sh7785: Remove unused input_pu range
> sh-pfc: sh7786: Remove unused input_pu range
> sh-pfc: shx3: Remove unused input_pu range
> sh-pfc: Remove unused input_pd and input_pu ranges
> sh-pfc: Remove unused PORT_DATA_* macros
> sh-pfc: Remove unused macro and enum entries
> sh-pfc: Remove unneeded const keywords
> sh-pfc: Remove unused GPIO_PORT_ALL macro
> sh-pfc: Don't overallocate memory for the GPIO chip pins array
> sh-pfc: Replace pinmux_enum_id typedef with u16
> sh-pfc: Rename gpio arguments to be consistent with the rest of the
> code
> sh-pfc: Consolidate PFC SoC data macros
> sh-pfc: Consolidate pin definition macros
> sh-pfc: sh7734: Use the common GP port style macros
> sh-pfc: shx3: Remove shx3_ prefix from static symbols
> sh-pfc: Don't duplicate argument to PINMUX_GPIO macro
> sh-pfc: Add port numbers to the CPU_ALL_PORT macro
> sh-pfc: Pass the pin number down to the port function macro
> sh-pfc: Add pin number to struct sh_pfc_pin
> sh-pfc: Rename struct sh_pfc nr_pins field to nr_gpio_pins
> sh-pfc: Compute pin ranges automatically
> sh-pfc: Support pins not associated with a GPIO port
>
> drivers/pinctrl/sh-pfc/core.c | 99 ++-
> drivers/pinctrl/sh-pfc/core.h | 10 +-
> drivers/pinctrl/sh-pfc/gpio.c | 45 +-
> drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 157 ++---
> drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 47 +-
> drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 55 +-
> drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 63 +-
> drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 59 +-
> drivers/pinctrl/sh-pfc/pfc-sh7203.c | 202 ++++---
> drivers/pinctrl/sh-pfc/pfc-sh7264.c | 246 ++++----
> drivers/pinctrl/sh-pfc/pfc-sh7269.c | 285 +++++----
> drivers/pinctrl/sh-pfc/pfc-sh7372.c | 53 +-
> drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 104 ++--
> drivers/pinctrl/sh-pfc/pfc-sh7720.c | 701 +++++++++++-----------
> drivers/pinctrl/sh-pfc/pfc-sh7722.c | 747 +++++++++++------------
> drivers/pinctrl/sh-pfc/pfc-sh7723.c | 381 ++++++------
> drivers/pinctrl/sh-pfc/pfc-sh7724.c | 1093 ++++++++++++++-----------------
> drivers/pinctrl/sh-pfc/pfc-sh7734.c | 60 +-
> drivers/pinctrl/sh-pfc/pfc-sh7757.c | 709 +++++++++++-----------
> drivers/pinctrl/sh-pfc/pfc-sh7785.c | 700 +++++++++++-----------
> drivers/pinctrl/sh-pfc/pfc-sh7786.c | 383 ++++++------
> drivers/pinctrl/sh-pfc/pfc-shx3.c | 423 +++++++------
> drivers/pinctrl/sh-pfc/pinctrl.c | 49 +-
> drivers/pinctrl/sh-pfc/sh_pfc.h | 277 +++++----
> 24 files changed, 3275 insertions(+), 3673 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
2013-07-18 1:24 ` Laurent Pinchart
@ 2013-07-19 2:10 ` Simon Horman
2013-09-21 0:43 ` Simon Horman
2013-07-20 22:19 ` Linus Walleij
` (5 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2013-07-19 2:10 UTC (permalink / raw)
To: linux-sh
Hi Laurent,
sure, that sounds reasonable.
I will put the patches in a new sh-pfc/pins-with-no-gpio-port branch
and include this in devel later today. It should be included
in the renesas-devel-20130719 tag.
On Thu, Jul 18, 2013 at 03:24:24AM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> I've received a positive test feedback for this patch series. Could you please
> include it in your -devel tags to get wider test coverage ? I'll then wait a
> couple of weeks and, if no problem is found, send a pull request to Linus to
> get the series merged through the pinctrl tree.
>
> On Tuesday 16 July 2013 02:10:52 Laurent Pinchart wrote:
> > Hello,
> >
> > Here's the second version of a patch series that cleans up and refactors the
> > sh-pfc driver to add support for pins with no associated GPIO port.
> >
> > Most configurable pins in SuperH and SH Mobile devices can be used as a
> > GPIO. However, some of them have selectable functions but are not
> > associated with a GPIO. Those pins must be defined in the pinmux pins array
> > but not registered in the GPIOs ranges.
> >
> > The series first cleans up the sh-pfc driver by removing unused features (01
> > to 13) and then gradually refactors the code (14 to 21) to add pin numbers
> > to the sh_pfc_pin structure (22 to 24). It finally computes pin ranges
> > automatically (26) and adds support for pins without a GPIO port (27).
> >
> > The patches have been compiled for all supported SoCs and tested on the
> > KZM9G board (SH73A0) with a hack to add I2C4 pins that have no GPIO port.
> > I'm lacking hardware to test R8A7778 which would be a good test candidate.
> >
> > The patches are based on v3.11-rc1.
> >
> > Changes since v1:
> >
> > - Split patch 01/19 into per-SoC patches smaller than the vger limit
> >
> > Laurent Pinchart (27):
> > sh-pfc: sh7720: Remove unused input_pu range
> > sh-pfc: sh7722: Remove unused input_pd and input_pu ranges
> > sh-pfc: sh7723: Remove unused input_pu range
> > sh-pfc: sh7724: Remove unused input_pu range
> > sh-pfc: sh7757: Remove unused input_pu range
> > sh-pfc: sh7785: Remove unused input_pu range
> > sh-pfc: sh7786: Remove unused input_pu range
> > sh-pfc: shx3: Remove unused input_pu range
> > sh-pfc: Remove unused input_pd and input_pu ranges
> > sh-pfc: Remove unused PORT_DATA_* macros
> > sh-pfc: Remove unused macro and enum entries
> > sh-pfc: Remove unneeded const keywords
> > sh-pfc: Remove unused GPIO_PORT_ALL macro
> > sh-pfc: Don't overallocate memory for the GPIO chip pins array
> > sh-pfc: Replace pinmux_enum_id typedef with u16
> > sh-pfc: Rename gpio arguments to be consistent with the rest of the
> > code
> > sh-pfc: Consolidate PFC SoC data macros
> > sh-pfc: Consolidate pin definition macros
> > sh-pfc: sh7734: Use the common GP port style macros
> > sh-pfc: shx3: Remove shx3_ prefix from static symbols
> > sh-pfc: Don't duplicate argument to PINMUX_GPIO macro
> > sh-pfc: Add port numbers to the CPU_ALL_PORT macro
> > sh-pfc: Pass the pin number down to the port function macro
> > sh-pfc: Add pin number to struct sh_pfc_pin
> > sh-pfc: Rename struct sh_pfc nr_pins field to nr_gpio_pins
> > sh-pfc: Compute pin ranges automatically
> > sh-pfc: Support pins not associated with a GPIO port
> >
> > drivers/pinctrl/sh-pfc/core.c | 99 ++-
> > drivers/pinctrl/sh-pfc/core.h | 10 +-
> > drivers/pinctrl/sh-pfc/gpio.c | 45 +-
> > drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 157 ++---
> > drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 47 +-
> > drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 55 +-
> > drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 63 +-
> > drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 59 +-
> > drivers/pinctrl/sh-pfc/pfc-sh7203.c | 202 ++++---
> > drivers/pinctrl/sh-pfc/pfc-sh7264.c | 246 ++++----
> > drivers/pinctrl/sh-pfc/pfc-sh7269.c | 285 +++++----
> > drivers/pinctrl/sh-pfc/pfc-sh7372.c | 53 +-
> > drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 104 ++--
> > drivers/pinctrl/sh-pfc/pfc-sh7720.c | 701 +++++++++++-----------
> > drivers/pinctrl/sh-pfc/pfc-sh7722.c | 747 +++++++++++------------
> > drivers/pinctrl/sh-pfc/pfc-sh7723.c | 381 ++++++------
> > drivers/pinctrl/sh-pfc/pfc-sh7724.c | 1093 ++++++++++++++-----------------
> > drivers/pinctrl/sh-pfc/pfc-sh7734.c | 60 +-
> > drivers/pinctrl/sh-pfc/pfc-sh7757.c | 709 +++++++++++-----------
> > drivers/pinctrl/sh-pfc/pfc-sh7785.c | 700 +++++++++++-----------
> > drivers/pinctrl/sh-pfc/pfc-sh7786.c | 383 ++++++------
> > drivers/pinctrl/sh-pfc/pfc-shx3.c | 423 +++++++------
> > drivers/pinctrl/sh-pfc/pinctrl.c | 49 +-
> > drivers/pinctrl/sh-pfc/sh_pfc.h | 277 +++++----
> > 24 files changed, 3275 insertions(+), 3673 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
2013-07-18 1:24 ` Laurent Pinchart
2013-07-19 2:10 ` Simon Horman
@ 2013-07-20 22:19 ` Linus Walleij
2013-07-24 13:28 ` Laurent Pinchart
` (4 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2013-07-20 22:19 UTC (permalink / raw)
To: linux-sh
On Thu, Jul 18, 2013 at 3:24 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Simon,
>
> I've received a positive test feedback for this patch series. Could you please
> include it in your -devel tags to get wider test coverage ? I'll then wait a
> couple of weeks and, if no problem is found, send a pull request to Linus to
> get the series merged through the pinctrl tree.
That's very helpful, I can then pull it in and inspect the files
before and after
this train of patches, which is probably the most efficient way to review
it.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
` (2 preceding siblings ...)
2013-07-20 22:19 ` Linus Walleij
@ 2013-07-24 13:28 ` Laurent Pinchart
2013-07-26 23:14 ` Linus Walleij
` (3 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-07-24 13:28 UTC (permalink / raw)
To: linux-sh
Hi Linus,
On Sunday 21 July 2013 00:19:36 Linus Walleij wrote:
> On Thu, Jul 18, 2013 at 3:24 AM, Laurent Pinchart wrote:
> > Hi Simon,
> >
> > I've received a positive test feedback for this patch series. Could you
> > please include it in your -devel tags to get wider test coverage ? I'll
> > then wait a couple of weeks and, if no problem is found, send a pull
> > request to Linus to get the series merged through the pinctrl tree.
>
> That's very helpful, I can then pull it in and inspect the files before and
> after this train of patches, which is probably the most efficient way to
> review it.
The patches can be found in my git tree at
git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
If you have time, could you already review them ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
` (3 preceding siblings ...)
2013-07-24 13:28 ` Laurent Pinchart
@ 2013-07-26 23:14 ` Linus Walleij
2013-07-29 13:22 ` Laurent Pinchart
` (2 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2013-07-26 23:14 UTC (permalink / raw)
To: linux-sh
On Wed, Jul 24, 2013 at 3:28 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Sunday 21 July 2013 00:19:36 Linus Walleij wrote:
>> That's very helpful, I can then pull it in and inspect the files before and
>> after this train of patches, which is probably the most efficient way to
>> review it.
>
> The patches can be found in my git tree at
>
> git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
>
> If you have time, could you already review them ?
I'd like to pull this into the pinctrl tree but then I'd prefer if
they were based on
v3.11-rc1 if possible?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
` (4 preceding siblings ...)
2013-07-26 23:14 ` Linus Walleij
@ 2013-07-29 13:22 ` Laurent Pinchart
2013-07-29 14:32 ` Linus Walleij
2013-07-29 14:34 ` Laurent Pinchart
7 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-07-29 13:22 UTC (permalink / raw)
To: linux-sh
Hi Linus,
On Saturday 27 July 2013 01:14:10 Linus Walleij wrote:
> On Wed, Jul 24, 2013 at 3:28 PM, Laurent Pinchart wrote:
> > On Sunday 21 July 2013 00:19:36 Linus Walleij wrote:
> >> That's very helpful, I can then pull it in and inspect the files before
> >> and
> >> after this train of patches, which is probably the most efficient way to
> >> review it.
> >
> > The patches can be found in my git tree at
> >
> > git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
> >
> > If you have time, could you already review them ?
>
> I'd like to pull this into the pinctrl tree but then I'd prefer if they were
> based on v3.11-rc1 if possible?
Sure. I've rebased
git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
on top of v3.11-rc1.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
` (5 preceding siblings ...)
2013-07-29 13:22 ` Laurent Pinchart
@ 2013-07-29 14:32 ` Linus Walleij
2013-07-29 14:34 ` Laurent Pinchart
7 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2013-07-29 14:32 UTC (permalink / raw)
To: linux-sh
On Mon, Jul 29, 2013 at 3:22 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Saturday 27 July 2013 01:14:10 Linus Walleij wrote:
>> On Wed, Jul 24, 2013 at 3:28 PM, Laurent Pinchart wrote:
>> > On Sunday 21 July 2013 00:19:36 Linus Walleij wrote:
>> >> That's very helpful, I can then pull it in and inspect the files before
>> >> and
>> >> after this train of patches, which is probably the most efficient way to
>> >> review it.
>> >
>> > The patches can be found in my git tree at
>> >
>> > git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
>> >
>> > If you have time, could you already review them ?
>>
>> I'd like to pull this into the pinctrl tree but then I'd prefer if they were
>> based on v3.11-rc1 if possible?
>
> Sure. I've rebased
>
> git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
>
> on top of v3.11-rc1.
Bah I got confused by the other pull request.
I have pulled *this* series and pushed for-next.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
` (6 preceding siblings ...)
2013-07-29 14:32 ` Linus Walleij
@ 2013-07-29 14:34 ` Laurent Pinchart
7 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-07-29 14:34 UTC (permalink / raw)
To: linux-sh
Hi Linus,
On Monday 29 July 2013 16:32:05 Linus Walleij wrote:
> On Mon, Jul 29, 2013 at 3:22 PM, Laurent Pinchart wrote:
> > On Saturday 27 July 2013 01:14:10 Linus Walleij wrote:
> >> On Wed, Jul 24, 2013 at 3:28 PM, Laurent Pinchart wrote:
> >> > On Sunday 21 July 2013 00:19:36 Linus Walleij wrote:
> >> >> That's very helpful, I can then pull it in and inspect the files
> >> >> before and after this train of patches, which is probably the most
> >> >> efficient way to review it.
> >> >
> >> > The patches can be found in my git tree at
> >> >
> >> > git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
> >> >
> >> > If you have time, could you already review them ?
> >>
> >> I'd like to pull this into the pinctrl tree but then I'd prefer if they
> >> were based on v3.11-rc1 if possible?
> >
> > Sure. I've rebased
> >
> > git://linuxtv.org/pinchartl/fbdev.git pinmux/next/pin-no-gpio
> >
> > on top of v3.11-rc1.
>
> Bah I got confused by the other pull request.
>
> I have pulled *this* series and pushed for-next.
No worries. Feel free to pull the other one as well ;-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-07-19 2:10 ` Simon Horman
@ 2013-09-21 0:43 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2013-09-21 0:43 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-sh, linux-gpio, Linus Walleij, Kuninori Morimoto
Hi Laurent,
I am currently rebasing the renesas tree on v3.12-rc1 in preparation
for preparing pull-requests for v3.13. Should I continue to carry
sh-pfc/pins-with-no-gpio-port in devel?
On Fri, Jul 19, 2013 at 11:10:45AM +0900, Simon Horman wrote:
> Hi Laurent,
>
> sure, that sounds reasonable.
>
> I will put the patches in a new sh-pfc/pins-with-no-gpio-port branch
> and include this in devel later today. It should be included
> in the renesas-devel-20130719 tag.
>
> On Thu, Jul 18, 2013 at 03:24:24AM +0200, Laurent Pinchart wrote:
> > Hi Simon,
> >
> > I've received a positive test feedback for this patch series. Could you please
> > include it in your -devel tags to get wider test coverage ? I'll then wait a
> > couple of weeks and, if no problem is found, send a pull request to Linus to
> > get the series merged through the pinctrl tree.
> >
> > On Tuesday 16 July 2013 02:10:52 Laurent Pinchart wrote:
> > > Hello,
> > >
> > > Here's the second version of a patch series that cleans up and refactors the
> > > sh-pfc driver to add support for pins with no associated GPIO port.
> > >
> > > Most configurable pins in SuperH and SH Mobile devices can be used as a
> > > GPIO. However, some of them have selectable functions but are not
> > > associated with a GPIO. Those pins must be defined in the pinmux pins array
> > > but not registered in the GPIOs ranges.
> > >
> > > The series first cleans up the sh-pfc driver by removing unused features (01
> > > to 13) and then gradually refactors the code (14 to 21) to add pin numbers
> > > to the sh_pfc_pin structure (22 to 24). It finally computes pin ranges
> > > automatically (26) and adds support for pins without a GPIO port (27).
> > >
> > > The patches have been compiled for all supported SoCs and tested on the
> > > KZM9G board (SH73A0) with a hack to add I2C4 pins that have no GPIO port.
> > > I'm lacking hardware to test R8A7778 which would be a good test candidate.
> > >
> > > The patches are based on v3.11-rc1.
> > >
> > > Changes since v1:
> > >
> > > - Split patch 01/19 into per-SoC patches smaller than the vger limit
> > >
> > > Laurent Pinchart (27):
> > > sh-pfc: sh7720: Remove unused input_pu range
> > > sh-pfc: sh7722: Remove unused input_pd and input_pu ranges
> > > sh-pfc: sh7723: Remove unused input_pu range
> > > sh-pfc: sh7724: Remove unused input_pu range
> > > sh-pfc: sh7757: Remove unused input_pu range
> > > sh-pfc: sh7785: Remove unused input_pu range
> > > sh-pfc: sh7786: Remove unused input_pu range
> > > sh-pfc: shx3: Remove unused input_pu range
> > > sh-pfc: Remove unused input_pd and input_pu ranges
> > > sh-pfc: Remove unused PORT_DATA_* macros
> > > sh-pfc: Remove unused macro and enum entries
> > > sh-pfc: Remove unneeded const keywords
> > > sh-pfc: Remove unused GPIO_PORT_ALL macro
> > > sh-pfc: Don't overallocate memory for the GPIO chip pins array
> > > sh-pfc: Replace pinmux_enum_id typedef with u16
> > > sh-pfc: Rename gpio arguments to be consistent with the rest of the
> > > code
> > > sh-pfc: Consolidate PFC SoC data macros
> > > sh-pfc: Consolidate pin definition macros
> > > sh-pfc: sh7734: Use the common GP port style macros
> > > sh-pfc: shx3: Remove shx3_ prefix from static symbols
> > > sh-pfc: Don't duplicate argument to PINMUX_GPIO macro
> > > sh-pfc: Add port numbers to the CPU_ALL_PORT macro
> > > sh-pfc: Pass the pin number down to the port function macro
> > > sh-pfc: Add pin number to struct sh_pfc_pin
> > > sh-pfc: Rename struct sh_pfc nr_pins field to nr_gpio_pins
> > > sh-pfc: Compute pin ranges automatically
> > > sh-pfc: Support pins not associated with a GPIO port
> > >
> > > drivers/pinctrl/sh-pfc/core.c | 99 ++-
> > > drivers/pinctrl/sh-pfc/core.h | 10 +-
> > > drivers/pinctrl/sh-pfc/gpio.c | 45 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 157 ++---
> > > drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 47 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 55 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 63 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 59 +-
> > > drivers/pinctrl/sh-pfc/pfc-sh7203.c | 202 ++++---
> > > drivers/pinctrl/sh-pfc/pfc-sh7264.c | 246 ++++----
> > > drivers/pinctrl/sh-pfc/pfc-sh7269.c | 285 +++++----
> > > drivers/pinctrl/sh-pfc/pfc-sh7372.c | 53 +-
> > > drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 104 ++--
> > > drivers/pinctrl/sh-pfc/pfc-sh7720.c | 701 +++++++++++-----------
> > > drivers/pinctrl/sh-pfc/pfc-sh7722.c | 747 +++++++++++------------
> > > drivers/pinctrl/sh-pfc/pfc-sh7723.c | 381 ++++++------
> > > drivers/pinctrl/sh-pfc/pfc-sh7724.c | 1093 ++++++++++++++-----------------
> > > drivers/pinctrl/sh-pfc/pfc-sh7734.c | 60 +-
> > > drivers/pinctrl/sh-pfc/pfc-sh7757.c | 709 +++++++++++-----------
> > > drivers/pinctrl/sh-pfc/pfc-sh7785.c | 700 +++++++++++-----------
> > > drivers/pinctrl/sh-pfc/pfc-sh7786.c | 383 ++++++------
> > > drivers/pinctrl/sh-pfc/pfc-shx3.c | 423 +++++++------
> > > drivers/pinctrl/sh-pfc/pinctrl.c | 49 +-
> > > drivers/pinctrl/sh-pfc/sh_pfc.h | 277 +++++----
> > > 24 files changed, 3275 insertions(+), 3673 deletions(-)
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
@ 2013-09-21 0:43 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2013-09-21 0:43 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-sh, linux-gpio, Linus Walleij, Kuninori Morimoto
Hi Laurent,
I am currently rebasing the renesas tree on v3.12-rc1 in preparation
for preparing pull-requests for v3.13. Should I continue to carry
sh-pfc/pins-with-no-gpio-port in devel?
On Fri, Jul 19, 2013 at 11:10:45AM +0900, Simon Horman wrote:
> Hi Laurent,
>
> sure, that sounds reasonable.
>
> I will put the patches in a new sh-pfc/pins-with-no-gpio-port branch
> and include this in devel later today. It should be included
> in the renesas-devel-20130719 tag.
>
> On Thu, Jul 18, 2013 at 03:24:24AM +0200, Laurent Pinchart wrote:
> > Hi Simon,
> >
> > I've received a positive test feedback for this patch series. Could you please
> > include it in your -devel tags to get wider test coverage ? I'll then wait a
> > couple of weeks and, if no problem is found, send a pull request to Linus to
> > get the series merged through the pinctrl tree.
> >
> > On Tuesday 16 July 2013 02:10:52 Laurent Pinchart wrote:
> > > Hello,
> > >
> > > Here's the second version of a patch series that cleans up and refactors the
> > > sh-pfc driver to add support for pins with no associated GPIO port.
> > >
> > > Most configurable pins in SuperH and SH Mobile devices can be used as a
> > > GPIO. However, some of them have selectable functions but are not
> > > associated with a GPIO. Those pins must be defined in the pinmux pins array
> > > but not registered in the GPIOs ranges.
> > >
> > > The series first cleans up the sh-pfc driver by removing unused features (01
> > > to 13) and then gradually refactors the code (14 to 21) to add pin numbers
> > > to the sh_pfc_pin structure (22 to 24). It finally computes pin ranges
> > > automatically (26) and adds support for pins without a GPIO port (27).
> > >
> > > The patches have been compiled for all supported SoCs and tested on the
> > > KZM9G board (SH73A0) with a hack to add I2C4 pins that have no GPIO port.
> > > I'm lacking hardware to test R8A7778 which would be a good test candidate.
> > >
> > > The patches are based on v3.11-rc1.
> > >
> > > Changes since v1:
> > >
> > > - Split patch 01/19 into per-SoC patches smaller than the vger limit
> > >
> > > Laurent Pinchart (27):
> > > sh-pfc: sh7720: Remove unused input_pu range
> > > sh-pfc: sh7722: Remove unused input_pd and input_pu ranges
> > > sh-pfc: sh7723: Remove unused input_pu range
> > > sh-pfc: sh7724: Remove unused input_pu range
> > > sh-pfc: sh7757: Remove unused input_pu range
> > > sh-pfc: sh7785: Remove unused input_pu range
> > > sh-pfc: sh7786: Remove unused input_pu range
> > > sh-pfc: shx3: Remove unused input_pu range
> > > sh-pfc: Remove unused input_pd and input_pu ranges
> > > sh-pfc: Remove unused PORT_DATA_* macros
> > > sh-pfc: Remove unused macro and enum entries
> > > sh-pfc: Remove unneeded const keywords
> > > sh-pfc: Remove unused GPIO_PORT_ALL macro
> > > sh-pfc: Don't overallocate memory for the GPIO chip pins array
> > > sh-pfc: Replace pinmux_enum_id typedef with u16
> > > sh-pfc: Rename gpio arguments to be consistent with the rest of the
> > > code
> > > sh-pfc: Consolidate PFC SoC data macros
> > > sh-pfc: Consolidate pin definition macros
> > > sh-pfc: sh7734: Use the common GP port style macros
> > > sh-pfc: shx3: Remove shx3_ prefix from static symbols
> > > sh-pfc: Don't duplicate argument to PINMUX_GPIO macro
> > > sh-pfc: Add port numbers to the CPU_ALL_PORT macro
> > > sh-pfc: Pass the pin number down to the port function macro
> > > sh-pfc: Add pin number to struct sh_pfc_pin
> > > sh-pfc: Rename struct sh_pfc nr_pins field to nr_gpio_pins
> > > sh-pfc: Compute pin ranges automatically
> > > sh-pfc: Support pins not associated with a GPIO port
> > >
> > > drivers/pinctrl/sh-pfc/core.c | 99 ++-
> > > drivers/pinctrl/sh-pfc/core.h | 10 +-
> > > drivers/pinctrl/sh-pfc/gpio.c | 45 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 157 ++---
> > > drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 47 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 55 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 63 +-
> > > drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 59 +-
> > > drivers/pinctrl/sh-pfc/pfc-sh7203.c | 202 ++++---
> > > drivers/pinctrl/sh-pfc/pfc-sh7264.c | 246 ++++----
> > > drivers/pinctrl/sh-pfc/pfc-sh7269.c | 285 +++++----
> > > drivers/pinctrl/sh-pfc/pfc-sh7372.c | 53 +-
> > > drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 104 ++--
> > > drivers/pinctrl/sh-pfc/pfc-sh7720.c | 701 +++++++++++-----------
> > > drivers/pinctrl/sh-pfc/pfc-sh7722.c | 747 +++++++++++------------
> > > drivers/pinctrl/sh-pfc/pfc-sh7723.c | 381 ++++++------
> > > drivers/pinctrl/sh-pfc/pfc-sh7724.c | 1093 ++++++++++++++-----------------
> > > drivers/pinctrl/sh-pfc/pfc-sh7734.c | 60 +-
> > > drivers/pinctrl/sh-pfc/pfc-sh7757.c | 709 +++++++++++-----------
> > > drivers/pinctrl/sh-pfc/pfc-sh7785.c | 700 +++++++++++-----------
> > > drivers/pinctrl/sh-pfc/pfc-sh7786.c | 383 ++++++------
> > > drivers/pinctrl/sh-pfc/pfc-shx3.c | 423 +++++++------
> > > drivers/pinctrl/sh-pfc/pinctrl.c | 49 +-
> > > drivers/pinctrl/sh-pfc/sh_pfc.h | 277 +++++----
> > > 24 files changed, 3275 insertions(+), 3673 deletions(-)
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-09-21 0:43 ` Simon Horman
@ 2013-09-21 8:59 ` Linus Walleij
-1 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2013-09-21 8:59 UTC (permalink / raw)
To: Simon Horman; +Cc: Laurent Pinchart, linux-sh, linux-gpio, Kuninori Morimoto
On Sat, Sep 21, 2013 at 2:43 AM, Simon Horman <horms@verge.net.au> wrote:
> Hi Laurent,
>
> I am currently rebasing the renesas tree on v3.12-rc1 in preparation
> for preparing pull-requests for v3.13. Should I continue to carry
> sh-pfc/pins-with-no-gpio-port in devel?
Sounds like something I should carry in the pinctrl tree?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
@ 2013-09-21 8:59 ` Linus Walleij
0 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2013-09-21 8:59 UTC (permalink / raw)
To: Simon Horman; +Cc: Laurent Pinchart, linux-sh, linux-gpio, Kuninori Morimoto
On Sat, Sep 21, 2013 at 2:43 AM, Simon Horman <horms@verge.net.au> wrote:
> Hi Laurent,
>
> I am currently rebasing the renesas tree on v3.12-rc1 in preparation
> for preparing pull-requests for v3.13. Should I continue to carry
> sh-pfc/pins-with-no-gpio-port in devel?
Sounds like something I should carry in the pinctrl tree?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-09-21 8:59 ` Linus Walleij
@ 2013-09-21 18:56 ` Laurent Pinchart
-1 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-09-21 18:56 UTC (permalink / raw)
To: Linus Walleij; +Cc: Simon Horman, linux-sh, linux-gpio, Kuninori Morimoto
Hi Linus and Simon,
On Saturday 21 September 2013 10:59:20 Linus Walleij wrote:
> On Sat, Sep 21, 2013 at 2:43 AM, Simon Horman <horms@verge.net.au> wrote:
> > Hi Laurent,
> >
> > I am currently rebasing the renesas tree on v3.12-rc1 in preparation
> > for preparing pull-requests for v3.13. Should I continue to carry
> > sh-pfc/pins-with-no-gpio-port in devel?
>
> Sounds like something I should carry in the pinctrl tree?
The series has been merged in v3.12-rc1, no action is thus needed.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
@ 2013-09-21 18:56 ` Laurent Pinchart
0 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2013-09-21 18:56 UTC (permalink / raw)
To: Linus Walleij; +Cc: Simon Horman, linux-sh, linux-gpio, Kuninori Morimoto
Hi Linus and Simon,
On Saturday 21 September 2013 10:59:20 Linus Walleij wrote:
> On Sat, Sep 21, 2013 at 2:43 AM, Simon Horman <horms@verge.net.au> wrote:
> > Hi Laurent,
> >
> > I am currently rebasing the renesas tree on v3.12-rc1 in preparation
> > for preparing pull-requests for v3.13. Should I continue to carry
> > sh-pfc/pins-with-no-gpio-port in devel?
>
> Sounds like something I should carry in the pinctrl tree?
The series has been merged in v3.12-rc1, no action is thus needed.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
2013-09-21 18:56 ` Laurent Pinchart
@ 2013-09-22 12:19 ` Simon Horman
-1 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2013-09-22 12:19 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linus Walleij, linux-sh, linux-gpio, Kuninori Morimoto
On Sat, Sep 21, 2013 at 08:56:07PM +0200, Laurent Pinchart wrote:
> Hi Linus and Simon,
>
> On Saturday 21 September 2013 10:59:20 Linus Walleij wrote:
> > On Sat, Sep 21, 2013 at 2:43 AM, Simon Horman <horms@verge.net.au> wrote:
> > > Hi Laurent,
> > >
> > > I am currently rebasing the renesas tree on v3.12-rc1 in preparation
> > > for preparing pull-requests for v3.13. Should I continue to carry
> > > sh-pfc/pins-with-no-gpio-port in devel?
> >
> > Sounds like something I should carry in the pinctrl tree?
>
> The series has been merged in v3.12-rc1, no action is thus needed.
Thanks, got it.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port
@ 2013-09-22 12:19 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2013-09-22 12:19 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linus Walleij, linux-sh, linux-gpio, Kuninori Morimoto
On Sat, Sep 21, 2013 at 08:56:07PM +0200, Laurent Pinchart wrote:
> Hi Linus and Simon,
>
> On Saturday 21 September 2013 10:59:20 Linus Walleij wrote:
> > On Sat, Sep 21, 2013 at 2:43 AM, Simon Horman <horms@verge.net.au> wrote:
> > > Hi Laurent,
> > >
> > > I am currently rebasing the renesas tree on v3.12-rc1 in preparation
> > > for preparing pull-requests for v3.13. Should I continue to carry
> > > sh-pfc/pins-with-no-gpio-port in devel?
> >
> > Sounds like something I should carry in the pinctrl tree?
>
> The series has been merged in v3.12-rc1, no action is thus needed.
Thanks, got it.
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2013-09-22 12:19 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-16 0:10 [PATCH v2 00/27] sh-pfc: Support pins with no associated GPIO port Laurent Pinchart
2013-07-18 1:24 ` Laurent Pinchart
2013-07-19 2:10 ` Simon Horman
2013-09-21 0:43 ` Simon Horman
2013-09-21 0:43 ` Simon Horman
2013-09-21 8:59 ` Linus Walleij
2013-09-21 8:59 ` Linus Walleij
2013-09-21 18:56 ` Laurent Pinchart
2013-09-21 18:56 ` Laurent Pinchart
2013-09-22 12:19 ` Simon Horman
2013-09-22 12:19 ` Simon Horman
2013-07-20 22:19 ` Linus Walleij
2013-07-24 13:28 ` Laurent Pinchart
2013-07-26 23:14 ` Linus Walleij
2013-07-29 13:22 ` Laurent Pinchart
2013-07-29 14:32 ` Linus Walleij
2013-07-29 14:34 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.