* [PATCH] clk: cleanup Kconfig to remove duplicate help tags
@ 2018-10-24 22:27 Ivan Babrou
2018-11-03 1:25 ` Stephen Boyd
2018-11-04 2:57 ` Stephen Boyd
0 siblings, 2 replies; 6+ messages in thread
From: Ivan Babrou @ 2018-10-24 22:27 UTC (permalink / raw)
To: linux-clk; +Cc: trivial, mike.looijmans, sboyd, mturquette
Before:
┌── Clock driver for SiLabs 544 devices ─────────────────────────┐
│ │
│ CONFIG_COMMON_CLK_SI544: │
│ │
│ ---help--- │
│ This driver supports the Silicon Labs 544 programmable clock │
│ generator. │
After:
┌── Clock driver for SiLabs 544 devices ───────────────────────┐
│ │
│ CONFIG_COMMON_CLK_SI544: │
│ │
│ This driver supports the Silicon Labs 544 programmable clock │
│ generator. │
Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
---
drivers/clk/Kconfig | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 292056bbb30e..8b5993ae30d8 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -48,7 +48,7 @@ config COMMON_CLK_MAX77686
config COMMON_CLK_MAX9485
tristate "Maxim 9485 Programmable Clock Generator"
depends on I2C
- help
+ ---help---
This driver supports Maxim 9485 Programmable Audio Clock Generator
config COMMON_CLK_RK808
@@ -104,7 +104,6 @@ config COMMON_CLK_SI514
depends on I2C
depends on OF
select REGMAP_I2C
- help
---help---
This driver supports the Silicon Labs 514 programmable clock
generator.
@@ -113,7 +112,6 @@ config COMMON_CLK_SI544
tristate "Clock driver for SiLabs 544 devices"
depends on I2C
select REGMAP_I2C
- help
---help---
This driver supports the Silicon Labs 544 programmable clock
generator.
@@ -123,7 +121,6 @@ config COMMON_CLK_SI570
depends on I2C
depends on OF
select REGMAP_I2C
- help
---help---
This driver supports Silicon Labs 570/571/598/599 programmable
clock generators.
@@ -141,7 +138,6 @@ config COMMON_CLK_CDCE925
depends on I2C
depends on OF
select REGMAP_I2C
- help
---help---
This driver supports the TI CDCE913/925/937/949 programmable clock
synthesizer. Each chip has different number of PLLs and outputs.
@@ -157,7 +153,7 @@ config COMMON_CLK_CDCE925
config COMMON_CLK_CS2000_CP
tristate "Clock driver for CS2000 Fractional-N Clock Synthesizer &
Clock Multiplier"
depends on I2C
- help
+ ---help---
If you say yes here you get support for the CS2000 clock multiplier.
config COMMON_CLK_GEMINI
@@ -200,7 +196,6 @@ config CLK_TWL6040
config COMMON_CLK_AXI_CLKGEN
tristate "AXI clkgen driver"
depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
- help
---help---
Support for the Analog Devices axi-clkgen pcore clock generator for Xilinx
FPGAs. It is commonly used in Analog Devices' reference designs.
@@ -260,26 +255,22 @@ config COMMON_CLK_VC5
depends on I2C
depends on OF
select REGMAP_I2C
- help
---help---
This driver supports the IDT VersaClock 5 and VersaClock 6
programmable clock generators.
config COMMON_CLK_STM32MP157
def_bool COMMON_CLK && MACH_STM32MP157
- help
---help---
Support for stm32mp157 SoC family clocks
config COMMON_CLK_STM32F
def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
- help
---help---
Support for stm32f4 and stm32f7 SoC families clocks
config COMMON_CLK_STM32H7
def_bool COMMON_CLK && MACH_STM32H743
- help
---help---
Support for stm32h7 SoC family clocks
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: cleanup Kconfig to remove duplicate help tags
2018-10-24 22:27 [PATCH] clk: cleanup Kconfig to remove duplicate help tags Ivan Babrou
@ 2018-11-03 1:25 ` Stephen Boyd
2018-11-03 6:40 ` Ivan Babrou
2018-11-04 2:57 ` Stephen Boyd
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2018-11-03 1:25 UTC (permalink / raw)
To: Ivan Babrou, linux-clk; +Cc: trivial, mike.looijmans, mturquette
Quoting Ivan Babrou (2018-10-24 15:27:16)
> Before:
>
> ┌── Clock driver for SiLabs 544 devices ─────────────────────────┐
> │ │
> │ CONFIG_COMMON_CLK_SI544: │
> │ │
> │ ---help--- │
> │ This driver supports the Silicon Labs 544 programmable clock │
> │ generator. │
>
> After:
>
> ┌── Clock driver for SiLabs 544 devices ───────────────────────┐
> │ │
> │ CONFIG_COMMON_CLK_SI544: │
> │ │
> │ This driver supports the Silicon Labs 544 programmable clock │
> │ generator. │
>
> Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
What kconfigurator are you using? From
Documentation/kbuild/kconfig-language.txt it says that help and
---help--- are not actually different, so I think you should fix the
configurator you're using instead of trying to patch all the triple dash
helps out there.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: cleanup Kconfig to remove duplicate help tags
2018-11-03 1:25 ` Stephen Boyd
@ 2018-11-03 6:40 ` Ivan Babrou
0 siblings, 0 replies; 6+ messages in thread
From: Ivan Babrou @ 2018-11-03 6:40 UTC (permalink / raw)
To: sboyd; +Cc: linux-clk, trivial, mike.looijmans, mturquette
They are not different, but you only need one of them, not both in the
same config option.
The following command can find all occurrences of double usage:
$ grep -Pzo '\thelp\n\t---help---' -r *
I'm using nconfig, but I think I originally saw the issue with oldconfig.
On Fri, Nov 2, 2018 at 6:25 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Ivan Babrou (2018-10-24 15:27:16)
> > Before:
> >
> > ┌── Clock driver for SiLabs 544 devices ─────────────────────────┐
> > │ │
> > │ CONFIG_COMMON_CLK_SI544: │
> > │ │
> > │ ---help--- │
> > │ This driver supports the Silicon Labs 544 programmable clock │
> > │ generator. │
> >
> > After:
> >
> > ┌── Clock driver for SiLabs 544 devices ───────────────────────┐
> > │ │
> > │ CONFIG_COMMON_CLK_SI544: │
> > │ │
> > │ This driver supports the Silicon Labs 544 programmable clock │
> > │ generator. │
> >
> > Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
>
> What kconfigurator are you using? From
> Documentation/kbuild/kconfig-language.txt it says that help and
> ---help--- are not actually different, so I think you should fix the
> configurator you're using instead of trying to patch all the triple dash
> helps out there.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: cleanup Kconfig to remove duplicate help tags
2018-10-24 22:27 [PATCH] clk: cleanup Kconfig to remove duplicate help tags Ivan Babrou
2018-11-03 1:25 ` Stephen Boyd
@ 2018-11-04 2:57 ` Stephen Boyd
2018-11-04 7:07 ` Ivan Babrou
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2018-11-04 2:57 UTC (permalink / raw)
To: Ivan Babrou, linux-clk; +Cc: trivial, mike.looijmans, mturquette
Quoting Ivan Babrou (2018-10-24 15:27:16)
> Before:
>
> ┌── Clock driver for SiLabs 544 devices ─────────────────────────┐
> │ │
> │ CONFIG_COMMON_CLK_SI544: │
> │ │
> │ ---help--- │
> │ This driver supports the Silicon Labs 544 programmable clock │
> │ generator. │
>
> After:
>
> ┌── Clock driver for SiLabs 544 devices ───────────────────────┐
> │ │
> │ CONFIG_COMMON_CLK_SI544: │
> │ │
> │ This driver supports the Silicon Labs 544 programmable clock │
> │ generator. │
Ah ok. I was thrown off by the first hunk that didn't need to be
changed.
>
> Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
> ---
> drivers/clk/Kconfig | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 292056bbb30e..8b5993ae30d8 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -48,7 +48,7 @@ config COMMON_CLK_MAX77686
> config COMMON_CLK_MAX9485
> tristate "Maxim 9485 Programmable Clock Generator"
> depends on I2C
> - help
> + ---help---
So this one is not needed?
> This driver supports Maxim 9485 Programmable Audio Clock Generator
>
> config COMMON_CLK_RK808
> @@ -157,7 +153,7 @@ config COMMON_CLK_CDCE925
> config COMMON_CLK_CS2000_CP
> tristate "Clock driver for CS2000 Fractional-N Clock Synthesizer &
> Clock Multiplier"
> depends on I2C
> - help
> + ---help---
Same for this one.
> If you say yes here you get support for the CS2000 clock multiplier.
>
> config COMMON_CLK_GEMINI
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: cleanup Kconfig to remove duplicate help tags
2018-11-04 2:57 ` Stephen Boyd
@ 2018-11-04 7:07 ` Ivan Babrou
2018-11-05 6:40 ` Stephen Boyd
0 siblings, 1 reply; 6+ messages in thread
From: Ivan Babrou @ 2018-11-04 7:07 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-clk, trivial, mike.looijmans, mturquette
Correct, this is just for consistency inside of the file.
On Sat, Nov 3, 2018 at 7:57 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Ivan Babrou (2018-10-24 15:27:16)
> > Before:
> >
> > ┌── Clock driver for SiLabs 544 devices ─────────────────────────┐
> > │ │
> > │ CONFIG_COMMON_CLK_SI544: │
> > │ │
> > │ ---help--- │
> > │ This driver supports the Silicon Labs 544 programmable clock │
> > │ generator. │
> >
> > After:
> >
> > ┌── Clock driver for SiLabs 544 devices ───────────────────────┐
> > │ │
> > │ CONFIG_COMMON_CLK_SI544: │
> > │ │
> > │ This driver supports the Silicon Labs 544 programmable clock │
> > │ generator. │
>
> Ah ok. I was thrown off by the first hunk that didn't need to be
> changed.
>
> >
> > Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
> > ---
> > drivers/clk/Kconfig | 13 ++-----------
> > 1 file changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > index 292056bbb30e..8b5993ae30d8 100644
> > --- a/drivers/clk/Kconfig
> > +++ b/drivers/clk/Kconfig
> > @@ -48,7 +48,7 @@ config COMMON_CLK_MAX77686
> > config COMMON_CLK_MAX9485
> > tristate "Maxim 9485 Programmable Clock Generator"
> > depends on I2C
> > - help
> > + ---help---
>
> So this one is not needed?
>
> > This driver supports Maxim 9485 Programmable Audio Clock Generator
> >
> > config COMMON_CLK_RK808
> > @@ -157,7 +153,7 @@ config COMMON_CLK_CDCE925
> > config COMMON_CLK_CS2000_CP
> > tristate "Clock driver for CS2000 Fractional-N Clock Synthesizer &
> > Clock Multiplier"
> > depends on I2C
> > - help
> > + ---help---
>
> Same for this one.
>
> > If you say yes here you get support for the CS2000 clock multiplier.
> >
> > config COMMON_CLK_GEMINI
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: cleanup Kconfig to remove duplicate help tags
2018-11-04 7:07 ` Ivan Babrou
@ 2018-11-05 6:40 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2018-11-05 6:40 UTC (permalink / raw)
To: Ivan Babrou; +Cc: linux-clk, trivial, mike.looijmans, mturquette
Quoting Ivan Babrou (2018-11-04 00:07:28)
> Correct, this is just for consistency inside of the file.
Please resend with just the parts that are relevant to the patch subject
then. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-05 6:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 22:27 [PATCH] clk: cleanup Kconfig to remove duplicate help tags Ivan Babrou
2018-11-03 1:25 ` Stephen Boyd
2018-11-03 6:40 ` Ivan Babrou
2018-11-04 2:57 ` Stephen Boyd
2018-11-04 7:07 ` Ivan Babrou
2018-11-05 6:40 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.