All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/radeon: remove set but not used variable 'rdev'
@ 2018-11-08 11:53 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-11-08 11:53 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, David1.Zhou, airlied
  Cc: Yue Haibing, amd-gfx, dri-devel, linux-kernel, kernel-janitors

From: Yue Haibing <yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
 variable 'rdev' set but not used [-Wunused-but-set-variable]

It not used  any more after commit
  e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/radeon/radeon_object.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index ba2fd29..c4b2e14 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
 void radeon_bo_unref(struct radeon_bo **bo)
 {
 	struct ttm_buffer_object *tbo;
-	struct radeon_device *rdev;
 
 	if ((*bo) == NULL)
 		return;
-	rdev = (*bo)->rdev;
 	tbo = &((*bo)->tbo);
 	ttm_bo_put(tbo);
 	*bo = NULL;




^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: remove set but not used variable 'rdev'
@ 2018-11-08 11:53 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-11-08 11:53 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, David1.Zhou, airlied
  Cc: Yue Haibing, amd-gfx, dri-devel, linux-kernel, kernel-janitors

From: Yue Haibing <yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
 variable 'rdev' set but not used [-Wunused-but-set-variable]

It not used  any more after commit
  e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/radeon/radeon_object.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index ba2fd29..c4b2e14 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
 void radeon_bo_unref(struct radeon_bo **bo)
 {
 	struct ttm_buffer_object *tbo;
-	struct radeon_device *rdev;
 
 	if ((*bo) = NULL)
 		return;
-	rdev = (*bo)->rdev;
 	tbo = &((*bo)->tbo);
 	ttm_bo_put(tbo);
 	*bo = NULL;

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: remove set but not used variable 'rdev'
@ 2018-11-08 11:53 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-11-08 11:53 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, David1.Zhou, airlied
  Cc: Yue Haibing, amd-gfx, dri-devel, linux-kernel, kernel-janitors

From: Yue Haibing <yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
 variable 'rdev' set but not used [-Wunused-but-set-variable]

It not used  any more after commit
  e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/radeon/radeon_object.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index ba2fd29..c4b2e14 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
 void radeon_bo_unref(struct radeon_bo **bo)
 {
 	struct ttm_buffer_object *tbo;
-	struct radeon_device *rdev;
 
 	if ((*bo) == NULL)
 		return;
-	rdev = (*bo)->rdev;
 	tbo = &((*bo)->tbo);
 	ttm_bo_put(tbo);
 	*bo = NULL;

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: remove set but not used variable 'rdev'
@ 2018-11-08 20:33   ` Alex Deucher
  0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2018-11-08 20:33 UTC (permalink / raw)
  To: yuehaibing
  Cc: Deucher, Alexander, Christian Koenig, Chunming Zhou, Dave Airlie,
	kernel-janitors, Maling list - DRI developers, amd-gfx list,
	LKML

On Thu, Nov 8, 2018 at 9:04 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> From: Yue Haibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
> drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
>  variable 'rdev' set but not used [-Wunused-but-set-variable]
>
> It not used  any more after commit
>   e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_object.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index ba2fd29..c4b2e14 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
>  void radeon_bo_unref(struct radeon_bo **bo)
>  {
>         struct ttm_buffer_object *tbo;
> -       struct radeon_device *rdev;
>
>         if ((*bo) == NULL)
>                 return;
> -       rdev = (*bo)->rdev;
>         tbo = &((*bo)->tbo);
>         ttm_bo_put(tbo);
>         *bo = NULL;
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: remove set but not used variable 'rdev'
@ 2018-11-08 20:33   ` Alex Deucher
  0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2018-11-08 20:33 UTC (permalink / raw)
  To: yuehaibing-hv44wF8Li93QT0dZR+AlfA
  Cc: Chunming Zhou, Dave Airlie,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA, LKML,
	Maling list - DRI developers, amd-gfx list, Deucher, Alexander,
	Christian Koenig

On Thu, Nov 8, 2018 at 9:04 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> From: Yue Haibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
> drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
>  variable 'rdev' set but not used [-Wunused-but-set-variable]
>
> It not used  any more after commit
>   e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_object.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index ba2fd29..c4b2e14 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
>  void radeon_bo_unref(struct radeon_bo **bo)
>  {
>         struct ttm_buffer_object *tbo;
> -       struct radeon_device *rdev;
>
>         if ((*bo) = NULL)
>                 return;
> -       rdev = (*bo)->rdev;
>         tbo = &((*bo)->tbo);
>         ttm_bo_put(tbo);
>         *bo = NULL;
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: remove set but not used variable 'rdev'
@ 2018-11-08 20:33   ` Alex Deucher
  0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2018-11-08 20:33 UTC (permalink / raw)
  To: yuehaibing-hv44wF8Li93QT0dZR+AlfA
  Cc: Chunming Zhou, Dave Airlie,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA, LKML,
	Maling list - DRI developers, amd-gfx list, Deucher, Alexander,
	Christian Koenig

On Thu, Nov 8, 2018 at 9:04 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> From: Yue Haibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref':
> drivers/gpu/drm/radeon/radeon_object.c:317:24: warning:
>  variable 'rdev' set but not used [-Wunused-but-set-variable]
>
> It not used  any more after commit
>   e7e31600d3e2 ("drm/radeon: remove taking mclk_lock from radeon_bo_unref")
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_object.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index ba2fd29..c4b2e14 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -314,11 +314,9 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)
>  void radeon_bo_unref(struct radeon_bo **bo)
>  {
>         struct ttm_buffer_object *tbo;
> -       struct radeon_device *rdev;
>
>         if ((*bo) == NULL)
>                 return;
> -       rdev = (*bo)->rdev;
>         tbo = &((*bo)->tbo);
>         ttm_bo_put(tbo);
>         *bo = NULL;
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: remove set but not used variable 'vbi_time_out'
  2018-11-08 11:53 ` YueHaibing
  (?)
@ 2019-02-18  8:45 ` YueHaibing
  -1 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-02-18  8:45 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, David1.Zhou, airlied, daniel
  Cc: YueHaibing, amd-gfx, dri-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/si_dpm.c: In function 'si_program_response_times':
drivers/gpu/drm/radeon/si_dpm.c:3640:29: warning:
 variable 'backbias_response_time' set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/radeon/si_dpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
index 0a785ef0ab66..de8bd245497f 100644
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -3637,14 +3637,13 @@ static int si_notify_smc_display_change(struct radeon_device *rdev,
 
 static void si_program_response_times(struct radeon_device *rdev)
 {
-	u32 voltage_response_time, backbias_response_time, acpi_delay_time, vbi_time_out;
+	u32 voltage_response_time, acpi_delay_time, vbi_time_out;
 	u32 vddc_dly, acpi_dly, vbi_dly;
 	u32 reference_clock;
 
 	si_write_smc_soft_register(rdev, SI_SMC_SOFT_REGISTER_mvdd_chg_time, 1);
 
 	voltage_response_time = (u32)rdev->pm.dpm.voltage_response_time;
-	backbias_response_time = (u32)rdev->pm.dpm.backbias_response_time;
 
 	if (voltage_response_time == 0)
 		voltage_response_time = 1000;




^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: remove set but not used variable 'vbi_time_out'
@ 2019-02-18  8:45 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-02-18  8:45 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, David1.Zhou, airlied, daniel
  Cc: YueHaibing, amd-gfx, dri-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/si_dpm.c: In function 'si_program_response_times':
drivers/gpu/drm/radeon/si_dpm.c:3640:29: warning:
 variable 'backbias_response_time' set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/radeon/si_dpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
index 0a785ef0ab66..de8bd245497f 100644
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -3637,14 +3637,13 @@ static int si_notify_smc_display_change(struct radeon_device *rdev,
 
 static void si_program_response_times(struct radeon_device *rdev)
 {
-	u32 voltage_response_time, backbias_response_time, acpi_delay_time, vbi_time_out;
+	u32 voltage_response_time, acpi_delay_time, vbi_time_out;
 	u32 vddc_dly, acpi_dly, vbi_dly;
 	u32 reference_clock;
 
 	si_write_smc_soft_register(rdev, SI_SMC_SOFT_REGISTER_mvdd_chg_time, 1);
 
 	voltage_response_time = (u32)rdev->pm.dpm.voltage_response_time;
-	backbias_response_time = (u32)rdev->pm.dpm.backbias_response_time;
 
 	if (voltage_response_time = 0)
 		voltage_response_time = 1000;

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: remove set but not used variable 'vbi_time_out'
@ 2019-02-18  8:45 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2019-02-18  8:45 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, David1.Zhou, airlied, daniel
  Cc: YueHaibing, amd-gfx, dri-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/si_dpm.c: In function 'si_program_response_times':
drivers/gpu/drm/radeon/si_dpm.c:3640:29: warning:
 variable 'backbias_response_time' set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/radeon/si_dpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
index 0a785ef0ab66..de8bd245497f 100644
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -3637,14 +3637,13 @@ static int si_notify_smc_display_change(struct radeon_device *rdev,
 
 static void si_program_response_times(struct radeon_device *rdev)
 {
-	u32 voltage_response_time, backbias_response_time, acpi_delay_time, vbi_time_out;
+	u32 voltage_response_time, acpi_delay_time, vbi_time_out;
 	u32 vddc_dly, acpi_dly, vbi_dly;
 	u32 reference_clock;
 
 	si_write_smc_soft_register(rdev, SI_SMC_SOFT_REGISTER_mvdd_chg_time, 1);
 
 	voltage_response_time = (u32)rdev->pm.dpm.voltage_response_time;
-	backbias_response_time = (u32)rdev->pm.dpm.backbias_response_time;
 
 	if (voltage_response_time == 0)
 		voltage_response_time = 1000;

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-02-18  8:45 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 11:53 [PATCH -next] drm/radeon: remove set but not used variable 'rdev' YueHaibing
2018-11-08 11:53 ` YueHaibing
2018-11-08 11:53 ` YueHaibing
2018-11-08 20:33 ` Alex Deucher
2018-11-08 20:33   ` Alex Deucher
2018-11-08 20:33   ` Alex Deucher
2019-02-18  8:45 [PATCH -next] drm/radeon: remove set but not used variable 'vbi_time_out' YueHaibing
2019-02-18  8:45 ` YueHaibing
2019-02-18  8:45 ` YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.