From: Qian Cai <cai@gmx.us>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, linux-efi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
will.deacon@arm.com
Subject: Re: [PATCH] efi: permit calling efi_mem_reserve_persistent from atomic context
Date: Thu, 08 Nov 2018 15:48:37 -0500 [thread overview]
Message-ID: <1541710117.12945.3.camel@gmx.us> (raw)
In-Reply-To: <20181108180511.30239-1-ard.biesheuvel@linaro.org>
On Thu, 2018-11-08 at 19:05 +0100, Ard Biesheuvel wrote:
> Currently, efi_mem_reserve_persistent() may not be called from atomic
> context, since both the kmalloc() call and the memremap() call may
> sleep.
>
> The kmalloc() call is easy enough to fix, but the memremap() call
> needs to be moved into an init hook since we cannot control the
> memory allocation behavior of memremap() at the call site.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Qian Cai <cai@gmx.us>
WARNING: multiple messages have this Message-ID (diff)
From: cai@gmx.us (Qian Cai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] efi: permit calling efi_mem_reserve_persistent from atomic context
Date: Thu, 08 Nov 2018 15:48:37 -0500 [thread overview]
Message-ID: <1541710117.12945.3.camel@gmx.us> (raw)
In-Reply-To: <20181108180511.30239-1-ard.biesheuvel@linaro.org>
On Thu, 2018-11-08 at 19:05 +0100, Ard Biesheuvel wrote:
> Currently, efi_mem_reserve_persistent() may not be called from atomic
> context, since both the kmalloc() call and the memremap() call may
> sleep.
>
> The kmalloc() call is easy enough to fix, but the memremap() call
> needs to be moved into an init hook since we cannot control the
> memory allocation behavior of memremap() at the call site.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Qian Cai <cai@gmx.us>
next prev parent reply other threads:[~2018-11-08 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 18:05 [PATCH] efi: permit calling efi_mem_reserve_persistent from atomic context Ard Biesheuvel
2018-11-08 18:05 ` Ard Biesheuvel
2018-11-08 20:48 ` Qian Cai [this message]
2018-11-08 20:48 ` Qian Cai
2018-11-10 2:45 ` Qian Cai
2018-11-10 2:45 ` Qian Cai
2018-11-10 2:45 ` Qian Cai
2018-11-10 2:45 ` Qian Cai
2018-11-12 2:45 ` Qian Cai
2018-11-12 2:45 ` Qian Cai
2018-11-12 8:32 ` Marc Zyngier
2018-11-12 8:32 ` Marc Zyngier
2018-11-12 8:32 ` Marc Zyngier
2018-11-12 12:14 ` Qian Cai
2018-11-12 12:14 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541710117.12945.3.camel@gmx.us \
--to=cai@gmx.us \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.