All of lore.kernel.org
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Yue Haibing <yuehaibing@huawei.com>,
	<linux-fsdevel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] block: drop pointless static qualifier in bd_mount()
Date: Mon, 12 Nov 2018 02:23:47 +0000	[thread overview]
Message-ID: <1541989427-104478-1-git-send-email-yuehaibing@huawei.com> (raw)

From: Yue Haibing <yuehaibing@huawei.com>

There is no need to have the 'struct vfsmount *bd_mnt' variable static
since new value always be assigned before use it.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 fs/block_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 38b8ce0..4064622 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -810,7 +810,7 @@ static struct dentry *bd_mount(struct file_system_type *fs_type,
 void __init bdev_cache_init(void)
 {
 	int err;
-	static struct vfsmount *bd_mnt;
+	struct vfsmount *bd_mnt;
 
 	bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode),
 			0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|

WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Yue Haibing <yuehaibing@huawei.com>,
	linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH -next] block: drop pointless static qualifier in bd_mount()
Date: Mon, 12 Nov 2018 02:23:47 +0000	[thread overview]
Message-ID: <1541989427-104478-1-git-send-email-yuehaibing@huawei.com> (raw)

From: Yue Haibing <yuehaibing@huawei.com>

There is no need to have the 'struct vfsmount *bd_mnt' variable static
since new value always be assigned before use it.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 fs/block_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 38b8ce0..4064622 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -810,7 +810,7 @@ static struct dentry *bd_mount(struct file_system_type *fs_type,
 void __init bdev_cache_init(void)
 {
 	int err;
-	static struct vfsmount *bd_mnt;
+	struct vfsmount *bd_mnt;
 
 	bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode),
 			0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|

             reply	other threads:[~2018-11-12 12:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  2:23 YueHaibing [this message]
2018-11-12  2:23 ` [PATCH -next] block: drop pointless static qualifier in bd_mount() YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541989427-104478-1-git-send-email-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.