* [Fuego] [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria
@ 2018-11-14 1:10 Zhong Lu
2018-11-14 20:18 ` Tim.Bird
0 siblings, 1 reply; 4+ messages in thread
From: Zhong Lu @ 2018-11-14 1:10 UTC (permalink / raw)
To: fuego
details:get "self.op" failed because the parts has been changed by "parts = self.tguid.split(".")"
Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
---
engine/scripts/parser/prepare_chart_data.py | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/engine/scripts/parser/prepare_chart_data.py b/engine/scripts/parser/prepare_chart_data.py
index f44fe36..da1fafe 100644
--- a/engine/scripts/parser/prepare_chart_data.py
+++ b/engine/scripts/parser/prepare_chart_data.py
@@ -70,6 +70,11 @@ class flat_entry:
self.tguid = parts[6]
self.ref = parts[7]
self.result = parts[8]
+ # FIXTHIS - old files might not have the 'op' field, parse it separately
+ try:
+ self.op = parts[9]
+ except:
+ pass
# break apart tguid
parts = self.tguid.split(".")
@@ -90,12 +95,6 @@ class flat_entry:
except:
pass
- # FIXTHIS - old files might not have the 'op' field, parse it separately
- try:
- self.op = parts[9]
- except:
- pass
-
def __str__(self):
return "%s %s %s %s %s %s %s %s %s\n" % \
(self.board, self.testname, self.spec, self.build_number,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Fuego] [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria
2018-11-14 1:10 [Fuego] [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria Zhong Lu
@ 2018-11-14 20:18 ` Tim.Bird
2018-11-15 5:58 ` [Fuego] 答复: " Zhong, Lu
0 siblings, 1 reply; 4+ messages in thread
From: Tim.Bird @ 2018-11-14 20:18 UTC (permalink / raw)
To: zhongl.fnst, fuego
> -----Original Message-----
> From: Zhong Lu on Tuesday, November 13, 2018 5:10 PM
>
> details:get "self.op" failed because the parts has been changed by "parts =
> self.tguid.split(".")"
>
> Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
> ---
> engine/scripts/parser/prepare_chart_data.py | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/engine/scripts/parser/prepare_chart_data.py
> b/engine/scripts/parser/prepare_chart_data.py
> index f44fe36..da1fafe 100644
> --- a/engine/scripts/parser/prepare_chart_data.py
> +++ b/engine/scripts/parser/prepare_chart_data.py
> @@ -70,6 +70,11 @@ class flat_entry:
> self.tguid = parts[6]
> self.ref = parts[7]
> self.result = parts[8]
> + # FIXTHIS - old files might not have the 'op' field, parse it separately
> + try:
> + self.op = parts[9]
> + except:
> + pass
>
> # break apart tguid
> parts = self.tguid.split(".")
> @@ -90,12 +95,6 @@ class flat_entry:
> except:
> pass
>
> - # FIXTHIS - old files might not have the 'op' field, parse it separately
> - try:
> - self.op = parts[9]
> - except:
> - pass
> -
> def __str__(self):
> return "%s %s %s %s %s %s %s %s %s\n" % \
> (self.board, self.testname, self.spec, self.build_number,
> --
> 2.7.4
Looks good. Thanks for the fix.
I applied it, then did some testing, and noticed the FIXTHIS comment.
I don't think anything needs to be fixed here, does it?
I think the code does what the FIXTHIS describes needs to be done.
I think that can be a normal comment (without the FIXTHIS tag)
Please let me know what you think.
-- Tim
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Fuego] 答复: [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria
2018-11-14 20:18 ` Tim.Bird
@ 2018-11-15 5:58 ` Zhong, Lu
2018-11-15 23:39 ` [Fuego] " Tim.Bird
0 siblings, 1 reply; 4+ messages in thread
From: Zhong, Lu @ 2018-11-15 5:58 UTC (permalink / raw)
To: Tim.Bird, fuego
Hi
The comment "FIXTHIS" already existed in code, so we didn't delete it.
But as you said , indeed, the code already does what the FIXTHIS describes, I agree that make it be a normal comment here.
Thanks
Zhong.
> > -----Original Message-----
> > From: Zhong Lu on Tuesday, November 13, 2018 5:10 PM
> >
> > details:get "self.op" failed because the parts has been changed by
> > "parts = self.tguid.split(".")"
> >
> > Signed-off-by: Zhong Lu <zhongl.fnst@cn.fujitsu.com>
> > ---
> > engine/scripts/parser/prepare_chart_data.py | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/engine/scripts/parser/prepare_chart_data.py
> > b/engine/scripts/parser/prepare_chart_data.py
> > index f44fe36..da1fafe 100644
> > --- a/engine/scripts/parser/prepare_chart_data.py
> > +++ b/engine/scripts/parser/prepare_chart_data.py
> > @@ -70,6 +70,11 @@ class flat_entry:
> > self.tguid = parts[6]
> > self.ref = parts[7]
> > self.result = parts[8]
> > + # FIXTHIS - old files might not have the 'op' field, parse it
> separately
> > + try:
> > + self.op = parts[9]
> > + except:
> > + pass
> >
> > # break apart tguid
> > parts = self.tguid.split(".") @@ -90,12 +95,6 @@ class
> > flat_entry:
> > except:
> > pass
> >
> > - # FIXTHIS - old files might not have the 'op' field, parse it separately
> > - try:
> > - self.op = parts[9]
> > - except:
> > - pass
> > -
> > def __str__(self):
> > return "%s %s %s %s %s %s %s %s %s\n" % \
> > (self.board, self.testname, self.spec,
> > self.build_number,
> > --
> > 2.7.4
>
> Looks good. Thanks for the fix.
>
> I applied it, then did some testing, and noticed the FIXTHIS comment.
> I don't think anything needs to be fixed here, does it?
> I think the code does what the FIXTHIS describes needs to be done.
>
> I think that can be a normal comment (without the FIXTHIS tag)
>
> Please let me know what you think.
> -- Tim
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Fuego] [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria
2018-11-15 5:58 ` [Fuego] 答复: " Zhong, Lu
@ 2018-11-15 23:39 ` Tim.Bird
0 siblings, 0 replies; 4+ messages in thread
From: Tim.Bird @ 2018-11-15 23:39 UTC (permalink / raw)
To: zhongl.fnst, fuego
> -----Original Message-----
> From: Zhong,
>
> The comment "FIXTHIS" already existed in code, so we didn't delete it.
> But as you said , indeed, the code already does what the FIXTHIS describes, I
> agree that make it be a normal comment here.
Sounds good. I've removed it.
-- Tim
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-15 23:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 1:10 [Fuego] [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria Zhong Lu
2018-11-14 20:18 ` Tim.Bird
2018-11-15 5:58 ` [Fuego] 答复: " Zhong, Lu
2018-11-15 23:39 ` [Fuego] " Tim.Bird
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.