* [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
@ 2018-11-21 11:21 Li Qiang
2018-11-21 11:28 ` Marc-André Lureau
0 siblings, 1 reply; 11+ messages in thread
From: Li Qiang @ 2018-11-21 11:21 UTC (permalink / raw)
To: jasowang, mst; +Cc: qemu-devel, Li Qiang
The fcntl will change the flags directly, use qemu_set_nonblock()
instead.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
net/tap.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index cc8525f154..e8aadd8d4b 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -592,7 +592,7 @@ int net_init_bridge(const Netdev *netdev, const char *name,
return -1;
}
- fcntl(fd, F_SETFL, O_NONBLOCK);
+ qemu_set_nonblock(fd);
vnet_hdr = tap_probe_vnet_hdr(fd);
s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr);
@@ -707,7 +707,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
}
return;
}
- fcntl(vhostfd, F_SETFL, O_NONBLOCK);
+ qemu_set_nonblock(vhostfd);
}
options.opaque = (void *)(uintptr_t)vhostfd;
@@ -791,7 +791,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
return -1;
}
- fcntl(fd, F_SETFL, O_NONBLOCK);
+ qemu_set_nonblock(fd);
vnet_hdr = tap_probe_vnet_hdr(fd);
@@ -839,7 +839,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
goto free_fail;
}
- fcntl(fd, F_SETFL, O_NONBLOCK);
+ qemu_set_nonblock(fd);
if (i == 0) {
vnet_hdr = tap_probe_vnet_hdr(fd);
@@ -887,7 +887,7 @@ free_fail:
return -1;
}
- fcntl(fd, F_SETFL, O_NONBLOCK);
+ qemu_set_nonblock(fd);
vnet_hdr = tap_probe_vnet_hdr(fd);
net_init_tap_one(tap, peer, "bridge", name, ifname,
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 11:21 [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock Li Qiang
@ 2018-11-21 11:28 ` Marc-André Lureau
2018-11-21 11:34 ` Li Qiang
2018-11-21 11:57 ` Daniel P. Berrangé
0 siblings, 2 replies; 11+ messages in thread
From: Marc-André Lureau @ 2018-11-21 11:28 UTC (permalink / raw)
To: Li Qiang; +Cc: Jason Wang, Michael S. Tsirkin, QEMU
Hi
On Wed, Nov 21, 2018 at 3:22 PM Li Qiang <liq3ea@gmail.com> wrote:
>
> The fcntl will change the flags directly, use qemu_set_nonblock()
> instead.
qemu_set_nonblock() will preserve the existing flags. And on windows,
it will register the FD to the event loop.
that's a reasonable thing to do, is this fixing an actual bug?
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> net/tap.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/net/tap.c b/net/tap.c
> index cc8525f154..e8aadd8d4b 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -592,7 +592,7 @@ int net_init_bridge(const Netdev *netdev, const char *name,
> return -1;
> }
>
> - fcntl(fd, F_SETFL, O_NONBLOCK);
> + qemu_set_nonblock(fd);
> vnet_hdr = tap_probe_vnet_hdr(fd);
> s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr);
>
> @@ -707,7 +707,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
> }
> return;
> }
> - fcntl(vhostfd, F_SETFL, O_NONBLOCK);
> + qemu_set_nonblock(vhostfd);
> }
> options.opaque = (void *)(uintptr_t)vhostfd;
>
> @@ -791,7 +791,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
> return -1;
> }
>
> - fcntl(fd, F_SETFL, O_NONBLOCK);
> + qemu_set_nonblock(fd);
>
> vnet_hdr = tap_probe_vnet_hdr(fd);
>
> @@ -839,7 +839,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
> goto free_fail;
> }
>
> - fcntl(fd, F_SETFL, O_NONBLOCK);
> + qemu_set_nonblock(fd);
>
> if (i == 0) {
> vnet_hdr = tap_probe_vnet_hdr(fd);
> @@ -887,7 +887,7 @@ free_fail:
> return -1;
> }
>
> - fcntl(fd, F_SETFL, O_NONBLOCK);
> + qemu_set_nonblock(fd);
> vnet_hdr = tap_probe_vnet_hdr(fd);
>
> net_init_tap_one(tap, peer, "bridge", name, ifname,
> --
> 2.11.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 11:28 ` Marc-André Lureau
@ 2018-11-21 11:34 ` Li Qiang
2018-11-21 11:57 ` Daniel P. Berrangé
1 sibling, 0 replies; 11+ messages in thread
From: Li Qiang @ 2018-11-21 11:34 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Jason Wang, mst, Qemu Developers
Marc-André Lureau <marcandre.lureau@gmail.com> 于2018年11月21日周三 下午7:28写道：
> Hi
>
> On Wed, Nov 21, 2018 at 3:22 PM Li Qiang <liq3ea@gmail.com> wrote:
> >
> > The fcntl will change the flags directly, use qemu_set_nonblock()
> > instead.
>
> qemu_set_nonblock() will preserve the existing flags. And on windows,
> it will register the FD to the event loop.
>
Oh, I don't consider the windows behavior. I'm not sure is this the
expected behavior.
> that's a reasonable thing to do, is this fixing an actual bug?
>
No, I just think there is no reason to change other flags in linux.
Thanks,
Li Qiang
>
> >
> > Signed-off-by: Li Qiang <liq3ea@gmail.com>
> > ---
> > net/tap.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/net/tap.c b/net/tap.c
> > index cc8525f154..e8aadd8d4b 100644
> > --- a/net/tap.c
> > +++ b/net/tap.c
> > @@ -592,7 +592,7 @@ int net_init_bridge(const Netdev *netdev, const char
> *name,
> > return -1;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> > s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr);
> >
> > @@ -707,7 +707,7 @@ static void net_init_tap_one(const NetdevTapOptions
> *tap, NetClientState *peer,
> > }
> > return;
> > }
> > - fcntl(vhostfd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(vhostfd);
> > }
> > options.opaque = (void *)(uintptr_t)vhostfd;
> >
> > @@ -791,7 +791,7 @@ int net_init_tap(const Netdev *netdev, const char
> *name,
> > return -1;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> >
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> >
> > @@ -839,7 +839,7 @@ int net_init_tap(const Netdev *netdev, const char
> *name,
> > goto free_fail;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> >
> > if (i == 0) {
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> > @@ -887,7 +887,7 @@ free_fail:
> > return -1;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> >
> > net_init_tap_one(tap, peer, "bridge", name, ifname,
> > --
> > 2.11.0
> >
> >
>
>
> --
> Marc-André Lureau
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 11:28 ` Marc-André Lureau
2018-11-21 11:34 ` Li Qiang
@ 2018-11-21 11:57 ` Daniel P. Berrangé
2018-11-21 12:23 ` Michael S. Tsirkin
1 sibling, 1 reply; 11+ messages in thread
From: Daniel P. Berrangé @ 2018-11-21 11:57 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Li Qiang, Jason Wang, QEMU, Michael S. Tsirkin
On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Nov 21, 2018 at 3:22 PM Li Qiang <liq3ea@gmail.com> wrote:
> >
> > The fcntl will change the flags directly, use qemu_set_nonblock()
> > instead.
>
> qemu_set_nonblock() will preserve the existing flags. And on windows,
> it will register the FD to the event loop.
> that's a reasonable thing to do, is this fixing an actual bug?
tap.c is only built with CONFIG_POSIX. Win32 is completely separate
in tap-win32.c. So the event loop reg doesn't apply.
I agree it is good to preserve fcntl flags though, so this patch
looks desirable.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> >
> > Signed-off-by: Li Qiang <liq3ea@gmail.com>
> > ---
> > net/tap.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/net/tap.c b/net/tap.c
> > index cc8525f154..e8aadd8d4b 100644
> > --- a/net/tap.c
> > +++ b/net/tap.c
> > @@ -592,7 +592,7 @@ int net_init_bridge(const Netdev *netdev, const char *name,
> > return -1;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> > s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr);
> >
> > @@ -707,7 +707,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
> > }
> > return;
> > }
> > - fcntl(vhostfd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(vhostfd);
> > }
> > options.opaque = (void *)(uintptr_t)vhostfd;
> >
> > @@ -791,7 +791,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
> > return -1;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> >
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> >
> > @@ -839,7 +839,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
> > goto free_fail;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> >
> > if (i == 0) {
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> > @@ -887,7 +887,7 @@ free_fail:
> > return -1;
> > }
> >
> > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > + qemu_set_nonblock(fd);
> > vnet_hdr = tap_probe_vnet_hdr(fd);
> >
> > net_init_tap_one(tap, peer, "bridge", name, ifname,
> > --
> > 2.11.0
> >
> >
>
>
> --
> Marc-André Lureau
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 11:57 ` Daniel P. Berrangé
@ 2018-11-21 12:23 ` Michael S. Tsirkin
2018-11-21 14:21 ` Markus Armbruster
2018-11-21 17:30 ` Eric Blake
0 siblings, 2 replies; 11+ messages in thread
From: Michael S. Tsirkin @ 2018-11-21 12:23 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Marc-André Lureau, Li Qiang, Jason Wang, QEMU
On Wed, Nov 21, 2018 at 11:57:18AM +0000, Daniel P. Berrangé wrote:
> On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang <liq3ea@gmail.com> wrote:
> > >
> > > The fcntl will change the flags directly, use qemu_set_nonblock()
> > > instead.
> >
> > qemu_set_nonblock() will preserve the existing flags. And on windows,
> > it will register the FD to the event loop.
> > that's a reasonable thing to do, is this fixing an actual bug?
>
> tap.c is only built with CONFIG_POSIX. Win32 is completely separate
> in tap-win32.c. So the event loop reg doesn't apply.
>
> I agree it is good to preserve fcntl flags though, so this patch
> looks desirable.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Sure
Acked-by: Michael S. Tsirkin <mst@redhat.com>
but really not for this release I guess as we are in freeze.
So thanks! And pls remember to ping after the release.
>
> >
> > >
> > > Signed-off-by: Li Qiang <liq3ea@gmail.com>
> > > ---
> > > net/tap.c | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/net/tap.c b/net/tap.c
> > > index cc8525f154..e8aadd8d4b 100644
> > > --- a/net/tap.c
> > > +++ b/net/tap.c
> > > @@ -592,7 +592,7 @@ int net_init_bridge(const Netdev *netdev, const char *name,
> > > return -1;
> > > }
> > >
> > > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > > + qemu_set_nonblock(fd);
> > > vnet_hdr = tap_probe_vnet_hdr(fd);
> > > s = net_tap_fd_init(peer, "bridge", name, fd, vnet_hdr);
> > >
> > > @@ -707,7 +707,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
> > > }
> > > return;
> > > }
> > > - fcntl(vhostfd, F_SETFL, O_NONBLOCK);
> > > + qemu_set_nonblock(vhostfd);
> > > }
> > > options.opaque = (void *)(uintptr_t)vhostfd;
> > >
> > > @@ -791,7 +791,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
> > > return -1;
> > > }
> > >
> > > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > > + qemu_set_nonblock(fd);
> > >
> > > vnet_hdr = tap_probe_vnet_hdr(fd);
> > >
> > > @@ -839,7 +839,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
> > > goto free_fail;
> > > }
> > >
> > > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > > + qemu_set_nonblock(fd);
> > >
> > > if (i == 0) {
> > > vnet_hdr = tap_probe_vnet_hdr(fd);
> > > @@ -887,7 +887,7 @@ free_fail:
> > > return -1;
> > > }
> > >
> > > - fcntl(fd, F_SETFL, O_NONBLOCK);
> > > + qemu_set_nonblock(fd);
> > > vnet_hdr = tap_probe_vnet_hdr(fd);
> > >
> > > net_init_tap_one(tap, peer, "bridge", name, ifname,
> > > --
> > > 2.11.0
> > >
> > >
> >
> >
> > --
> > Marc-André Lureau
> >
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 12:23 ` Michael S. Tsirkin
@ 2018-11-21 14:21 ` Markus Armbruster
2018-11-21 17:30 ` Eric Blake
1 sibling, 0 replies; 11+ messages in thread
From: Markus Armbruster @ 2018-11-21 14:21 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Daniel P. Berrangé,
Li Qiang, Jason Wang, Marc-André Lureau, QEMU
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Wed, Nov 21, 2018 at 11:57:18AM +0000, Daniel P. Berrangé wrote:
>> On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote:
>> > Hi
>> >
>> > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang <liq3ea@gmail.com> wrote:
>> > >
>> > > The fcntl will change the flags directly, use qemu_set_nonblock()
>> > > instead.
>> >
>> > qemu_set_nonblock() will preserve the existing flags. And on windows,
>> > it will register the FD to the event loop.
>> > that's a reasonable thing to do, is this fixing an actual bug?
>>
>> tap.c is only built with CONFIG_POSIX. Win32 is completely separate
>> in tap-win32.c. So the event loop reg doesn't apply.
>>
>> I agree it is good to preserve fcntl flags though, so this patch
>> looks desirable.
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Sure
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> but really not for this release I guess as we are in freeze.
That's fair.
> So thanks! And pls remember to ping after the release.
I strongly recommend maintainers do not use patch submitters as
substitutes for git branches. Just create a branch for collecting stuff
for the next development cycle, merge the thing, say thank you, and let
the patch submitter move on.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 12:23 ` Michael S. Tsirkin
2018-11-21 14:21 ` Markus Armbruster
@ 2018-11-21 17:30 ` Eric Blake
2018-11-21 17:39 ` Michael S. Tsirkin
1 sibling, 1 reply; 11+ messages in thread
From: Eric Blake @ 2018-11-21 17:30 UTC (permalink / raw)
To: Michael S. Tsirkin, Daniel P. Berrangé
Cc: Li Qiang, Jason Wang, Marc-André Lureau, QEMU
On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:
>>
>> I agree it is good to preserve fcntl flags though, so this patch
>> looks desirable.
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Sure
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> but really not for this release I guess as we are in freeze.
We're in freeze, so the criteria is: Does this fix a bug that we would
otherwise not want in 3.1. If the code is pre-existing (that is, if 3.0
was released with the same problem), or then delaying the patch to 4.0
is an easier call to make. If the problem is new to 3.1, then fixing it
for -rc3 is still reasonable with maintainer discretion (although once
-rc3 lands, we want as little as possible to go into -rc4, even if our
track record says we will be unable to avoid -rc4 altogether).
I think that losing flags is likely enough to be a noticeable bug worth
fixing for 3.1, but I did not research when the problem was introduced,
so I don't have a strong preference for 3.1 vs. 4.0.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 17:30 ` Eric Blake
@ 2018-11-21 17:39 ` Michael S. Tsirkin
2018-11-22 2:22 ` Jason Wang
0 siblings, 1 reply; 11+ messages in thread
From: Michael S. Tsirkin @ 2018-11-21 17:39 UTC (permalink / raw)
To: Eric Blake
Cc: Daniel P. Berrangé,
Li Qiang, Jason Wang, Marc-André Lureau, QEMU
On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote:
> On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:
>
> > >
> > > I agree it is good to preserve fcntl flags though, so this patch
> > > looks desirable.
> > >
> > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> >
> > Sure
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > but really not for this release I guess as we are in freeze.
>
> We're in freeze, so the criteria is: Does this fix a bug that we would
> otherwise not want in 3.1. If the code is pre-existing (that is, if 3.0 was
> released with the same problem), or then delaying the patch to 4.0 is an
> easier call to make. If the problem is new to 3.1, then fixing it for -rc3
> is still reasonable with maintainer discretion (although once -rc3 lands, we
> want as little as possible to go into -rc4, even if our track record says we
> will be unable to avoid -rc4 altogether).
>
> I think that losing flags is likely enough to be a noticeable bug worth
> fixing for 3.1, but I did not research when the problem was introduced, so I
> don't have a strong preference for 3.1 vs. 4.0.
Maintainer in this case is Jason, so it's up to him.
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-21 17:39 ` Michael S. Tsirkin
@ 2018-11-22 2:22 ` Jason Wang
2019-03-10 11:26 ` Li Qiang
0 siblings, 1 reply; 11+ messages in thread
From: Jason Wang @ 2018-11-22 2:22 UTC (permalink / raw)
To: Michael S. Tsirkin, Eric Blake; +Cc: Li Qiang, Marc-André Lureau, QEMU
On 2018/11/22 上午1:39, Michael S. Tsirkin wrote:
> On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote:
>> On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:
>>
>>>> I agree it is good to preserve fcntl flags though, so this patch
>>>> looks desirable.
>>>>
>>>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>>> Sure
>>>
>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>>
>>> but really not for this release I guess as we are in freeze.
>> We're in freeze, so the criteria is: Does this fix a bug that we would
>> otherwise not want in 3.1. If the code is pre-existing (that is, if 3.0 was
>> released with the same problem), or then delaying the patch to 4.0 is an
>> easier call to make. If the problem is new to 3.1, then fixing it for -rc3
>> is still reasonable with maintainer discretion (although once -rc3 lands, we
>> want as little as possible to go into -rc4, even if our track record says we
>> will be unable to avoid -rc4 altogether).
>>
>> I think that losing flags is likely enough to be a noticeable bug worth
>> fixing for 3.1, but I did not research when the problem was introduced, so I
>> don't have a strong preference for 3.1 vs. 4.0.
> Maintainer in this case is Jason, so it's up to him
I've queued this for 4.0.
Thanks
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
2018-11-22 2:22 ` Jason Wang
@ 2019-03-10 11:26 ` Li Qiang
2019-03-11 9:35 ` Jason Wang
0 siblings, 1 reply; 11+ messages in thread
From: Li Qiang @ 2019-03-10 11:26 UTC (permalink / raw)
To: Jason Wang; +Cc: Michael S. Tsirkin, Eric Blake, Marc-André Lureau, QEMU
Hi Jason,
What's the status of this patch? I don't see it in upstream.
Thanks,
Li Qiang
Jason Wang <jasowang@redhat.com> 于2018年11月22日周四 上午10:22写道：
>
> On 2018/11/22 上午1:39, Michael S. Tsirkin wrote:
> > On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote:
> >> On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:
> >>
> >>>> I agree it is good to preserve fcntl flags though, so this patch
> >>>> looks desirable.
> >>>>
> >>>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> >>> Sure
> >>>
> >>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >>>
> >>> but really not for this release I guess as we are in freeze.
> >> We're in freeze, so the criteria is: Does this fix a bug that we would
> >> otherwise not want in 3.1. If the code is pre-existing (that is, if
> 3.0 was
> >> released with the same problem), or then delaying the patch to 4.0 is an
> >> easier call to make. If the problem is new to 3.1, then fixing it for
> -rc3
> >> is still reasonable with maintainer discretion (although once -rc3
> lands, we
> >> want as little as possible to go into -rc4, even if our track record
> says we
> >> will be unable to avoid -rc4 altogether).
> >>
> >> I think that losing flags is likely enough to be a noticeable bug worth
> >> fixing for 3.1, but I did not research when the problem was introduced,
> so I
> >> don't have a strong preference for 3.1 vs. 4.0.
> > Maintainer in this case is Jason, so it's up to him
>
>
> I've queued this for 4.0.
>
> Thanks
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-03-11 9:35 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-21 11:21 [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock Li Qiang
2018-11-21 11:28 ` Marc-André Lureau
2018-11-21 11:34 ` Li Qiang
2018-11-21 11:57 ` Daniel P. Berrangé
2018-11-21 12:23 ` Michael S. Tsirkin
2018-11-21 14:21 ` Markus Armbruster
2018-11-21 17:30 ` Eric Blake
2018-11-21 17:39 ` Michael S. Tsirkin
2018-11-22 2:22 ` Jason Wang
2019-03-10 11:26 ` Li Qiang
2019-03-11 9:35 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.