All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
@ 2018-11-27 17:00 ` Nicholas Mc Guire
  0 siblings, 0 replies; 7+ messages in thread
From: Nicholas Mc Guire @ 2018-11-27 17:00 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Bartosz Golaszewski, Matthias Brugger, Sergio Paracuellos,
	linux-gpio, linux-kernel, linux-arm-kernel, linux-mediatek,
	Nicholas Mc Guire

The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
for the dev_err() messages). The probe function should return an error
if one of the banks failed to initialize properly indicated by
not returning non-0.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
---

V2: A logic error spoted by Sean Wang <sean.wang@kernel.org> the
    success case is 0 and thus returning early should be on on 
    ret!=0 and not on !ret - thanks for catching this stupid mistake !

Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
GPIOLIB=y, GPIO_MT7621=y

Patch is against 4.20-rc3 (localversion-next is next-20181121)

 drivers/gpio/gpio-mt7621.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index 1ec95bc..68fca8b 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
 	struct device_node *np = dev->of_node;
 	struct mtk *mtk;
 	int i;
+	int ret;
 
 	mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
 	if (!mtk)
@@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, mtk);
 	mediatek_gpio_irq_chip.name = dev_name(dev);
 
-	for (i = 0; i < MTK_BANK_CNT; i++)
-		mediatek_gpio_bank_probe(dev, np, i);
+	for (i = 0; i < MTK_BANK_CNT; i++) {
+		ret = mediatek_gpio_bank_probe(dev, np, i);
+		if (ret)
+			return ret;
+	}
 
 	return 0;
 }
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
@ 2018-11-27 17:00 ` Nicholas Mc Guire
  0 siblings, 0 replies; 7+ messages in thread
From: Nicholas Mc Guire @ 2018-11-27 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
for the dev_err() messages). The probe function should return an error
if one of the banks failed to initialize properly indicated by
not returning non-0.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
---

V2: A logic error spoted by Sean Wang <sean.wang@kernel.org> the
    success case is 0 and thus returning early should be on on 
    ret!=0 and not on !ret - thanks for catching this stupid mistake !

Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
GPIOLIB=y, GPIO_MT7621=y

Patch is against 4.20-rc3 (localversion-next is next-20181121)

 drivers/gpio/gpio-mt7621.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index 1ec95bc..68fca8b 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
 	struct device_node *np = dev->of_node;
 	struct mtk *mtk;
 	int i;
+	int ret;
 
 	mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
 	if (!mtk)
@@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, mtk);
 	mediatek_gpio_irq_chip.name = dev_name(dev);
 
-	for (i = 0; i < MTK_BANK_CNT; i++)
-		mediatek_gpio_bank_probe(dev, np, i);
+	for (i = 0; i < MTK_BANK_CNT; i++) {
+		ret = mediatek_gpio_bank_probe(dev, np, i);
+		if (ret)
+			return ret;
+	}
 
 	return 0;
 }
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
  2018-11-27 17:00 ` Nicholas Mc Guire
@ 2018-11-27 20:38   ` Sean Wang
  -1 siblings, 0 replies; 7+ messages in thread
From: Sean Wang @ 2018-11-27 20:38 UTC (permalink / raw)
  To: hofrat
  Cc: Linus Walleij, sergio.paracuellos, linux-gpio, linux-kernel,
	bgolaszewski, linux-mediatek, Matthias Brugger, linux-arm-kernel

Nicholas Mc Guire <hofrat@osadl.org> 於 2018年11月27日 週二 上午9:07寫道：
>
> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>

Acked-by: Sean Wang <sean.wang@kernel.org>

> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> ---
>
> V2: A logic error spoted by Sean Wang <sean.wang@kernel.org> the
>     success case is 0 and thus returning early should be on on
>     ret!=0 and not on !ret - thanks for catching this stupid mistake !
>
> Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
> GPIOLIB=y, GPIO_MT7621=y
>
> Patch is against 4.20-rc3 (localversion-next is next-20181121)
>
>  drivers/gpio/gpio-mt7621.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
> index 1ec95bc..68fca8b 100644
> --- a/drivers/gpio/gpio-mt7621.c
> +++ b/drivers/gpio/gpio-mt7621.c
> @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
>         struct device_node *np = dev->of_node;
>         struct mtk *mtk;
>         int i;
> +       int ret;
>
>         mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
>         if (!mtk)
> @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, mtk);
>         mediatek_gpio_irq_chip.name = dev_name(dev);
>
> -       for (i = 0; i < MTK_BANK_CNT; i++)
> -               mediatek_gpio_bank_probe(dev, np, i);
> +       for (i = 0; i < MTK_BANK_CNT; i++) {
> +               ret = mediatek_gpio_bank_probe(dev, np, i);
> +               if (ret)
> +                       return ret;
> +       }
>
>         return 0;
>  }
> --
> 2.1.4
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
@ 2018-11-27 20:38   ` Sean Wang
  0 siblings, 0 replies; 7+ messages in thread
From: Sean Wang @ 2018-11-27 20:38 UTC (permalink / raw)
  To: linux-arm-kernel

Nicholas Mc Guire <hofrat@osadl.org> ? 2018?11?27? ?? ??9:07???
>
> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>

Acked-by: Sean Wang <sean.wang@kernel.org>

> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> ---
>
> V2: A logic error spoted by Sean Wang <sean.wang@kernel.org> the
>     success case is 0 and thus returning early should be on on
>     ret!=0 and not on !ret - thanks for catching this stupid mistake !
>
> Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
> GPIOLIB=y, GPIO_MT7621=y
>
> Patch is against 4.20-rc3 (localversion-next is next-20181121)
>
>  drivers/gpio/gpio-mt7621.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
> index 1ec95bc..68fca8b 100644
> --- a/drivers/gpio/gpio-mt7621.c
> +++ b/drivers/gpio/gpio-mt7621.c
> @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
>         struct device_node *np = dev->of_node;
>         struct mtk *mtk;
>         int i;
> +       int ret;
>
>         mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);
>         if (!mtk)
> @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, mtk);
>         mediatek_gpio_irq_chip.name = dev_name(dev);
>
> -       for (i = 0; i < MTK_BANK_CNT; i++)
> -               mediatek_gpio_bank_probe(dev, np, i);
> +       for (i = 0; i < MTK_BANK_CNT; i++) {
> +               ret = mediatek_gpio_bank_probe(dev, np, i);
> +               if (ret)
> +                       return ret;
> +       }
>
>         return 0;
>  }
> --
> 2.1.4
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
  2018-11-27 17:00 ` Nicholas Mc Guire
  (?)
@ 2018-12-07  9:48   ` Linus Walleij
  -1 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2018-12-07  9:48 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Bartosz Golaszewski, Matthias Brugger, Sergio Paracuellos,
	open list:GPIO SUBSYSTEM, linux-kernel, Linux ARM,
	moderated list:ARM/Mediatek SoC support

On Tue, Nov 27, 2018 at 6:06 PM Nicholas Mc Guire <hofrat@osadl.org> wrote:

> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")

Patch applied with Sean's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
@ 2018-12-07  9:48   ` Linus Walleij
  0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2018-12-07  9:48 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Bartosz Golaszewski, Matthias Brugger, Sergio Paracuellos,
	open list:GPIO SUBSYSTEM, linux-kernel, Linux ARM,
	moderated list:ARM/Mediatek SoC support

On Tue, Nov 27, 2018 at 6:06 PM Nicholas Mc Guire <hofrat@osadl.org> wrote:

> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")

Patch applied with Sean's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack
@ 2018-12-07  9:48   ` Linus Walleij
  0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2018-12-07  9:48 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Sergio Paracuellos, open list:GPIO SUBSYSTEM, linux-kernel,
	Bartosz Golaszewski, moderated list:ARM/Mediatek SoC support,
	Matthias Brugger, Linux ARM

On Tue, Nov 27, 2018 at 6:06 PM Nicholas Mc Guire <hofrat@osadl.org> wrote:

> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> for the dev_err() messages). The probe function should return an error
> if one of the banks failed to initialize properly indicated by
> not returning non-0.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")

Patch applied with Sean's ACK.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-12-07  9:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 17:00 [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Nicholas Mc Guire
2018-11-27 17:00 ` Nicholas Mc Guire
2018-11-27 20:38 ` Sean Wang
2018-11-27 20:38   ` Sean Wang
2018-12-07  9:48 ` Linus Walleij
2018-12-07  9:48   ` Linus Walleij
2018-12-07  9:48   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.