All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'
@ 2018-11-29  2:36 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-29  2:36 UTC (permalink / raw)
  To: David S. Miller, Subash Abhinov Kasiviswanathan, YueHaibing
  Cc: netdev, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function 'rmnet_map_do_flow_control':
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
 variable 'cmd' set but not used [-Wunused-but-set-variable]
  struct rmnet_map_control_command *cmd;

'cmd' not used anymore now, should also be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
index 8990307..f6cf59a 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
@@ -20,14 +20,12 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb,
 				    struct rmnet_port *port,
 				    int enable)
 {
-	struct rmnet_map_control_command *cmd;
 	struct rmnet_endpoint *ep;
 	struct net_device *vnd;
 	u8 mux_id;
 	int r;
 
 	mux_id = RMNET_MAP_GET_MUX_ID(skb);
-	cmd = RMNET_MAP_GET_CMD_START(skb);
 
 	if (mux_id >= RMNET_MAX_LOGICAL_EP) {
 		kfree_skb(skb);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'
@ 2018-11-29  2:36 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-29  2:36 UTC (permalink / raw)
  To: David S. Miller, Subash Abhinov Kasiviswanathan, YueHaibing
  Cc: netdev, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function 'rmnet_map_do_flow_control':
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
 variable 'cmd' set but not used [-Wunused-but-set-variable]
  struct rmnet_map_control_command *cmd;

'cmd' not used anymore now, should also be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
index 8990307..f6cf59a 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
@@ -20,14 +20,12 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb,
 				    struct rmnet_port *port,
 				    int enable)
 {
-	struct rmnet_map_control_command *cmd;
 	struct rmnet_endpoint *ep;
 	struct net_device *vnd;
 	u8 mux_id;
 	int r;
 
 	mux_id = RMNET_MAP_GET_MUX_ID(skb);
-	cmd = RMNET_MAP_GET_CMD_START(skb);
 
 	if (mux_id >= RMNET_MAX_LOGICAL_EP) {
 		kfree_skb(skb);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'
  2018-11-29  2:36 ` YueHaibing
@ 2018-11-29  2:43   ` Subash Abhinov Kasiviswanathan
  -1 siblings, 0 replies; 6+ messages in thread
From: Subash Abhinov Kasiviswanathan @ 2018-11-29  2:43 UTC (permalink / raw)
  To: YueHaibing; +Cc: David S. Miller, netdev, kernel-janitors

On 2018-11-28 19:36, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function
> 'rmnet_map_do_flow_control':
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
>  variable 'cmd' set but not used [-Wunused-but-set-variable]
>   struct rmnet_map_control_command *cmd;
> 
> 'cmd' not used anymore now, should also be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> index 8990307..f6cf59a 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> @@ -20,14 +20,12 @@ static u8 rmnet_map_do_flow_control(struct sk_buff 
> *skb,
>  				    struct rmnet_port *port,
>  				    int enable)
>  {
> -	struct rmnet_map_control_command *cmd;
>  	struct rmnet_endpoint *ep;
>  	struct net_device *vnd;
>  	u8 mux_id;
>  	int r;
> 
>  	mux_id = RMNET_MAP_GET_MUX_ID(skb);
> -	cmd = RMNET_MAP_GET_CMD_START(skb);
> 
>  	if (mux_id >= RMNET_MAX_LOGICAL_EP) {
>  		kfree_skb(skb);

Thanks for cleaning these up.

Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'
@ 2018-11-29  2:43   ` Subash Abhinov Kasiviswanathan
  0 siblings, 0 replies; 6+ messages in thread
From: Subash Abhinov Kasiviswanathan @ 2018-11-29  2:43 UTC (permalink / raw)
  To: YueHaibing; +Cc: David S. Miller, netdev, kernel-janitors

On 2018-11-28 19:36, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function
> 'rmnet_map_do_flow_control':
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
>  variable 'cmd' set but not used [-Wunused-but-set-variable]
>   struct rmnet_map_control_command *cmd;
> 
> 'cmd' not used anymore now, should also be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> index 8990307..f6cf59a 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
> @@ -20,14 +20,12 @@ static u8 rmnet_map_do_flow_control(struct sk_buff 
> *skb,
>  				    struct rmnet_port *port,
>  				    int enable)
>  {
> -	struct rmnet_map_control_command *cmd;
>  	struct rmnet_endpoint *ep;
>  	struct net_device *vnd;
>  	u8 mux_id;
>  	int r;
> 
>  	mux_id = RMNET_MAP_GET_MUX_ID(skb);
> -	cmd = RMNET_MAP_GET_CMD_START(skb);
> 
>  	if (mux_id >= RMNET_MAX_LOGICAL_EP) {
>  		kfree_skb(skb);

Thanks for cleaning these up.

Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'
  2018-11-29  2:36 ` YueHaibing
@ 2018-12-01  1:24   ` David Miller
  -1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-12-01  1:24 UTC (permalink / raw)
  To: yuehaibing; +Cc: subashab, netdev, kernel-janitors

From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 29 Nov 2018 02:36:32 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function 'rmnet_map_do_flow_control':
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
>  variable 'cmd' set but not used [-Wunused-but-set-variable]
>   struct rmnet_map_control_command *cmd;
> 
> 'cmd' not used anymore now, should also be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'
@ 2018-12-01  1:24   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-12-01  1:24 UTC (permalink / raw)
  To: yuehaibing; +Cc: subashab, netdev, kernel-janitors

From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 29 Nov 2018 02:36:32 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function 'rmnet_map_do_flow_control':
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
>  variable 'cmd' set but not used [-Wunused-but-set-variable]
>   struct rmnet_map_control_command *cmd;
> 
> 'cmd' not used anymore now, should also be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-01 12:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29  2:36 [PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd' YueHaibing
2018-11-29  2:36 ` YueHaibing
2018-11-29  2:43 ` Subash Abhinov Kasiviswanathan
2018-11-29  2:43   ` Subash Abhinov Kasiviswanathan
2018-12-01  1:24 ` David Miller
2018-12-01  1:24   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.