* [PATCH 1/1] app/eventdev: detect deadlock for timer event producer
@ 2018-11-29 19:18 Erik Gabriel Carrillo
2018-12-01 15:12 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Erik Gabriel Carrillo @ 2018-11-29 19:18 UTC (permalink / raw)
To: pbhagavatula; +Cc: jerin.jacob, dev
If timer events get dropped for some reason, the thread that launched
producer and worker cores will never exit, because the deadlock check
doesn't currently apply to the event timer adapter case. This commit
fixes this.
Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
---
app/test-eventdev/test_perf_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
index 8618775..f99a6a6 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -327,7 +327,8 @@ perf_launch_lcores(struct evt_test *test, struct evt_options *opt,
}
if (new_cycles - dead_lock_cycles > dead_lock_sample &&
- opt->prod_type == EVT_PROD_TYPE_SYNT) {
+ (opt->prod_type == EVT_PROD_TYPE_SYNT ||
+ opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) {
remaining = t->outstand_pkts - processed_pkts(t);
if (dead_lock_remaining == remaining) {
rte_event_dev_dump(opt->dev_id, stdout);
--
2.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] app/eventdev: detect deadlock for timer event producer
2018-11-29 19:18 [PATCH 1/1] app/eventdev: detect deadlock for timer event producer Erik Gabriel Carrillo
@ 2018-12-01 15:12 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2018-12-01 15:12 UTC (permalink / raw)
To: Erik Gabriel Carrillo; +Cc: Bhagavatula, Pavan, dev
-----Original Message-----
> Date: Thu, 29 Nov 2018 13:18:51 -0600
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: pbhagavatula@caviumnetworks.com
> CC: jerin.jacob@caviumnetworks.com, dev@dpdk.org
> Subject: [PATCH 1/1] app/eventdev: detect deadlock for timer event producer
> X-Mailer: git-send-email 1.7.10
>
> If timer events get dropped for some reason, the thread that launched
> producer and worker cores will never exit, because the deadlock check
> doesn't currently apply to the event timer adapter case. This commit
> fixes this.
Please add Fixes:
With above changes,
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> app/test-eventdev/test_perf_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
> index 8618775..f99a6a6 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -327,7 +327,8 @@ perf_launch_lcores(struct evt_test *test, struct evt_options *opt,
> }
>
> if (new_cycles - dead_lock_cycles > dead_lock_sample &&
> - opt->prod_type == EVT_PROD_TYPE_SYNT) {
> + (opt->prod_type == EVT_PROD_TYPE_SYNT ||
> + opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) {
> remaining = t->outstand_pkts - processed_pkts(t);
> if (dead_lock_remaining == remaining) {
> rte_event_dev_dump(opt->dev_id, stdout);
> --
> 2.6.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-01 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 19:18 [PATCH 1/1] app/eventdev: detect deadlock for timer event producer Erik Gabriel Carrillo
2018-12-01 15:12 ` Jerin Jacob
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.