* [PATCH] ARM: imx: update the cpu power up timing setting
@ 2018-12-03 2:45 ` Anson Huang
0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2018-12-03 2:45 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, Fabio Estevam, linux,
linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
The sw2iso count should cover ARM LDO ramp-up time,
the MAX ARM LDO ramp-up time may be up to more than
100us on some boards, this patch sets sw2iso to 0xf
(~384us) which is the reset value, and it is much
more safe to cover different boards, since we have
observed that some customer boards failed with current
setting of 0x2.
Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/mach-imx/cpuidle-imx6sx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c
index 243a108..fd0053e 100644
--- a/arch/arm/mach-imx/cpuidle-imx6sx.c
+++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
@@ -110,7 +110,7 @@ int __init imx6sx_cpuidle_init(void)
* except for power up sw2iso which need to be
* larger than LDO ramp up time.
*/
- imx_gpc_set_arm_power_up_timing(2, 1);
+ imx_gpc_set_arm_power_up_timing(0xf, 1);
imx_gpc_set_arm_power_down_timing(1, 1);
return cpuidle_register(&imx6sx_cpuidle_driver, NULL);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: imx: update the cpu power up timing setting
@ 2018-12-03 2:45 ` Anson Huang
0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2018-12-03 2:45 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, Fabio Estevam, linux,
linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
The sw2iso count should cover ARM LDO ramp-up time,
the MAX ARM LDO ramp-up time may be up to more than
100us on some boards, this patch sets sw2iso to 0xf
(~384us) which is the reset value, and it is much
more safe to cover different boards, since we have
observed that some customer boards failed with current
setting of 0x2.
Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/mach-imx/cpuidle-imx6sx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c
index 243a108..fd0053e 100644
--- a/arch/arm/mach-imx/cpuidle-imx6sx.c
+++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
@@ -110,7 +110,7 @@ int __init imx6sx_cpuidle_init(void)
* except for power up sw2iso which need to be
* larger than LDO ramp up time.
*/
- imx_gpc_set_arm_power_up_timing(2, 1);
+ imx_gpc_set_arm_power_up_timing(0xf, 1);
imx_gpc_set_arm_power_down_timing(1, 1);
return cpuidle_register(&imx6sx_cpuidle_driver, NULL);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: imx: update the cpu power up timing setting
2018-12-03 2:45 ` Anson Huang
@ 2018-12-03 11:42 ` Fabio Estevam
-1 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-12-03 11:42 UTC (permalink / raw)
To: Yongcai Huang
Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
Russell King - ARM Linux,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, NXP Linux Team
On Mon, Dec 3, 2018 at 12:45 AM Anson Huang <anson.huang@nxp.com> wrote:
>
> The sw2iso count should cover ARM LDO ramp-up time,
> the MAX ARM LDO ramp-up time may be up to more than
> 100us on some boards, this patch sets sw2iso to 0xf
> (~384us) which is the reset value, and it is much
> more safe to cover different boards, since we have
> observed that some customer boards failed with current
> setting of 0x2.
>
> Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: imx: update the cpu power up timing setting
@ 2018-12-03 11:42 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-12-03 11:42 UTC (permalink / raw)
To: Yongcai Huang
Cc: Sascha Hauer, Russell King - ARM Linux, linux-kernel,
NXP Linux Team, Sascha Hauer, Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Mon, Dec 3, 2018 at 12:45 AM Anson Huang <anson.huang@nxp.com> wrote:
>
> The sw2iso count should cover ARM LDO ramp-up time,
> the MAX ARM LDO ramp-up time may be up to more than
> 100us on some boards, this patch sets sw2iso to 0xf
> (~384us) which is the reset value, and it is much
> more safe to cover different boards, since we have
> observed that some customer boards failed with current
> setting of 0x2.
>
> Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: imx: update the cpu power up timing setting
2018-12-03 11:42 ` Fabio Estevam
@ 2018-12-03 12:03 ` Fabio Estevam
-1 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-12-03 12:03 UTC (permalink / raw)
To: Yongcai Huang
Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
Russell King - ARM Linux,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, NXP Linux Team
On Mon, Dec 3, 2018 at 9:42 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Mon, Dec 3, 2018 at 12:45 AM Anson Huang <anson.huang@nxp.com> wrote:
> >
> > The sw2iso count should cover ARM LDO ramp-up time,
> > the MAX ARM LDO ramp-up time may be up to more than
> > 100us on some boards, this patch sets sw2iso to 0xf
> > (~384us) which is the reset value, and it is much
> > more safe to cover different boards, since we have
> > observed that some customer boards failed with current
> > setting of 0x2.
> >
> > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Minor nit that maybe Shawn can fix while applying it: Subject should
contain imx6sx as this change only affect this SoC.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: imx: update the cpu power up timing setting
@ 2018-12-03 12:03 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-12-03 12:03 UTC (permalink / raw)
To: Yongcai Huang
Cc: Sascha Hauer, Russell King - ARM Linux, linux-kernel,
NXP Linux Team, Sascha Hauer, Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Mon, Dec 3, 2018 at 9:42 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Mon, Dec 3, 2018 at 12:45 AM Anson Huang <anson.huang@nxp.com> wrote:
> >
> > The sw2iso count should cover ARM LDO ramp-up time,
> > the MAX ARM LDO ramp-up time may be up to more than
> > 100us on some boards, this patch sets sw2iso to 0xf
> > (~384us) which is the reset value, and it is much
> > more safe to cover different boards, since we have
> > observed that some customer boards failed with current
> > setting of 0x2.
> >
> > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Minor nit that maybe Shawn can fix while applying it: Subject should
contain imx6sx as this change only affect this SoC.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: imx: update the cpu power up timing setting
2018-12-03 12:03 ` Fabio Estevam
@ 2018-12-04 3:18 ` Anson Huang
-1 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2018-12-04 3:18 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
Russell King - ARM Linux,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, dl-linux-imx
Hi, Fabio
Best Regards!
Anson Huang
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: 2018年12月3日 20:03
> To: Anson Huang <anson.huang@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>; Fabio
> Estevam <fabio.estevam@nxp.com>; Russell King - ARM Linux
> <linux@armlinux.org.uk>; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] ARM: imx: update the cpu power up timing setting
>
> On Mon, Dec 3, 2018 at 9:42 AM Fabio Estevam <festevam@gmail.com>
> wrote:
> >
> > On Mon, Dec 3, 2018 at 12:45 AM Anson Huang <anson.huang@nxp.com>
> wrote:
> > >
> > > The sw2iso count should cover ARM LDO ramp-up time, the MAX ARM LDO
> > > ramp-up time may be up to more than 100us on some boards, this patch
> > > sets sw2iso to 0xf
> > > (~384us) which is the reset value, and it is much more safe to cover
> > > different boards, since we have observed that some customer boards
> > > failed with current setting of 0x2.
> > >
> > > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for
> > > i.mx6sx")
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Minor nit that maybe Shawn can fix while applying it: Subject should contain
> imx6sx as this change only affect this SoC.
I sent out the V2 patch to easy Shawn's work. Thanks.
Anson.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: imx: update the cpu power up timing setting
@ 2018-12-04 3:18 ` Anson Huang
0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2018-12-04 3:18 UTC (permalink / raw)
To: Fabio Estevam
Cc: Sascha Hauer, Russell King - ARM Linux, linux-kernel,
dl-linux-imx, Sascha Hauer, Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi, Fabio
Best Regards!
Anson Huang
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: 2018年12月3日 20:03
> To: Anson Huang <anson.huang@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>; Fabio
> Estevam <fabio.estevam@nxp.com>; Russell King - ARM Linux
> <linux@armlinux.org.uk>; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] ARM: imx: update the cpu power up timing setting
>
> On Mon, Dec 3, 2018 at 9:42 AM Fabio Estevam <festevam@gmail.com>
> wrote:
> >
> > On Mon, Dec 3, 2018 at 12:45 AM Anson Huang <anson.huang@nxp.com>
> wrote:
> > >
> > > The sw2iso count should cover ARM LDO ramp-up time, the MAX ARM LDO
> > > ramp-up time may be up to more than 100us on some boards, this patch
> > > sets sw2iso to 0xf
> > > (~384us) which is the reset value, and it is much more safe to cover
> > > different boards, since we have observed that some customer boards
> > > failed with current setting of 0x2.
> > >
> > > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for
> > > i.mx6sx")
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Minor nit that maybe Shawn can fix while applying it: Subject should contain
> imx6sx as this change only affect this SoC.
I sent out the V2 patch to easy Shawn's work. Thanks.
Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-12-04 3:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 2:45 [PATCH] ARM: imx: update the cpu power up timing setting Anson Huang
2018-12-03 2:45 ` Anson Huang
2018-12-03 11:42 ` Fabio Estevam
2018-12-03 11:42 ` Fabio Estevam
2018-12-03 12:03 ` Fabio Estevam
2018-12-03 12:03 ` Fabio Estevam
2018-12-04 3:18 ` Anson Huang
2018-12-04 3:18 ` Anson Huang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.