* [PATCH] arm64: dts: rockchip: fix include reference
@ 2017-05-19 12:14 Arnd Bergmann
[not found] ` <20170519121434.1118129-1-arnd-r2nGTMty4D4@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-05-19 12:14 UTC (permalink / raw)
To: arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Arnd Bergmann,
Heiko Stuebner, linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA
The way we handle include paths for DT has changed a bit, which
broke a file that had an unconventional way to reference a common
header file:
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:10: fatal error: include/dt-bindings/input/linux-event-codes.h: No such file or directory
This removes the leading "include/" from the path name, which fixes it.
Fixes: d5d332d3f7e8 ("devicetree: Move include prefixes from arch to separate directory")
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
---
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
index 658bb9dc9dfd..7bd31066399b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
@@ -44,7 +44,7 @@
/dts-v1/;
#include "rk3399-gru.dtsi"
-#include <include/dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/input/linux-event-codes.h>
/*
* Kevin-specific things
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: fix include reference
[not found] ` <20170519121434.1118129-1-arnd-r2nGTMty4D4@public.gmane.org>
@ 2017-05-19 12:47 ` Heiko Stuebner
2017-05-19 15:11 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Stuebner @ 2017-05-19 12:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A,
linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Arnd,
Am Freitag, 19. Mai 2017, 14:14:34 CEST schrieb Arnd Bergmann:
> The way we handle include paths for DT has changed a bit, which
> broke a file that had an unconventional way to reference a common
> header file:
>
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:10: fatal error: include/dt-bindings/input/linux-event-codes.h: No such file or directory
>
> This removes the leading "include/" from the path name, which fixes it.
>
> Fixes: d5d332d3f7e8 ("devicetree: Move include prefixes from arch to separate directory")
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
This mimics the patch from Ian Campbell [0], which I also pointed at in
the "devicetree: Move include prefixes from arch to separate directory"
thread and I had originally hoped that both would get applied together.
In any case, both patches look good, so this as well gets a
Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
The other one also got a
Reviewed-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
It seems I don't have any other fixes for 4.12 at the moment, so
do you want to apply any of the two yourself, or should this make
a round through my tree? (Both ways are fine by me)
Heiko
[0] https://patchwork.kernel.org/patch/9724957/
> ---
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> index 658bb9dc9dfd..7bd31066399b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -44,7 +44,7 @@
>
> /dts-v1/;
> #include "rk3399-gru.dtsi"
> -#include <include/dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/input/linux-event-codes.h>
>
> /*
> * Kevin-specific things
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: fix include reference
2017-05-19 12:47 ` Heiko Stuebner
@ 2017-05-19 15:11 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-05-19 15:11 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, arm-soc, Linux ARM
On Fri, May 19, 2017 at 2:47 PM, Heiko Stuebner <heiko@sntech.de> wrote:
> Hi Arnd,
>
> Am Freitag, 19. Mai 2017, 14:14:34 CEST schrieb Arnd Bergmann:
>> The way we handle include paths for DT has changed a bit, which
>> broke a file that had an unconventional way to reference a common
>> header file:
>>
>> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:10: fatal error: include/dt-bindings/input/linux-event-codes.h: No such file or directory
>>
>> This removes the leading "include/" from the path name, which fixes it.
>>
>> Fixes: d5d332d3f7e8 ("devicetree: Move include prefixes from arch to separate directory")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This mimics the patch from Ian Campbell [0], which I also pointed at in
> the "devicetree: Move include prefixes from arch to separate directory"
> thread and I had originally hoped that both would get applied together.
>
> In any case, both patches look good, so this as well gets a
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> The other one also got a
> Reviewed-by: Brian Norris <briannorris@chromium.org>
>
> It seems I don't have any other fixes for 4.12 at the moment, so
> do you want to apply any of the two yourself, or should this make
> a round through my tree? (Both ways are fine by me)
>
>
> Heiko
>
> [0] https://patchwork.kernel.org/patch/9724957/
Ok, thanks!
I already applied my version to the fixes branch as I saw that we have
the build regression after Olof applied his patch.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: rockchip: fix include reference
@ 2017-05-19 15:11 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-05-19 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 19, 2017 at 2:47 PM, Heiko Stuebner <heiko@sntech.de> wrote:
> Hi Arnd,
>
> Am Freitag, 19. Mai 2017, 14:14:34 CEST schrieb Arnd Bergmann:
>> The way we handle include paths for DT has changed a bit, which
>> broke a file that had an unconventional way to reference a common
>> header file:
>>
>> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:10: fatal error: include/dt-bindings/input/linux-event-codes.h: No such file or directory
>>
>> This removes the leading "include/" from the path name, which fixes it.
>>
>> Fixes: d5d332d3f7e8 ("devicetree: Move include prefixes from arch to separate directory")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This mimics the patch from Ian Campbell [0], which I also pointed at in
> the "devicetree: Move include prefixes from arch to separate directory"
> thread and I had originally hoped that both would get applied together.
>
> In any case, both patches look good, so this as well gets a
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> The other one also got a
> Reviewed-by: Brian Norris <briannorris@chromium.org>
>
> It seems I don't have any other fixes for 4.12 at the moment, so
> do you want to apply any of the two yourself, or should this make
> a round through my tree? (Both ways are fine by me)
>
>
> Heiko
>
> [0] https://patchwork.kernel.org/patch/9724957/
Ok, thanks!
I already applied my version to the fixes branch as I saw that we have
the build regression after Olof applied his patch.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-19 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 12:14 [PATCH] arm64: dts: rockchip: fix include reference Arnd Bergmann
[not found] ` <20170519121434.1118129-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-05-19 12:47 ` Heiko Stuebner
2017-05-19 15:11 ` Arnd Bergmann
2017-05-19 15:11 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.