* [PATCH -next] drm/ast: Remove set but not used variable 'bo'
@ 2018-12-08 8:36 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-08 8:36 UTC (permalink / raw)
To: Dave Airlie, David Airlie, Sam Bobroff, Daniel Vetter
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/ast/ast_fb.c: In function 'astfb_create':
drivers/gpu/drm/ast/ast_fb.c:194:17: warning:
variable 'bo' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit 312fec1405dd ("drm: Initial KMS
driver for AST (ASpeed Technologies) 2000 series (v2)")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/ast/ast_fb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index de26df0..c2e4136 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -191,7 +191,6 @@ static int astfb_create(struct drm_fb_helper *helper,
int size, ret;
void *sysram;
struct drm_gem_object *gobj = NULL;
- struct ast_bo *bo = NULL;
mode_cmd.width = sizes->surface_width;
mode_cmd.height = sizes->surface_height;
mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7)/8);
@@ -206,7 +205,6 @@ static int astfb_create(struct drm_fb_helper *helper,
DRM_ERROR("failed to create fbcon backing object %d\n", ret);
return ret;
}
- bo = gem_to_ast_bo(gobj);
sysram = vmalloc(size);
if (!sysram)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH -next] drm/ast: Remove set but not used variable 'bo'
@ 2018-12-08 8:36 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-08 8:36 UTC (permalink / raw)
To: Dave Airlie, David Airlie, Sam Bobroff, Daniel Vetter
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/ast/ast_fb.c: In function 'astfb_create':
drivers/gpu/drm/ast/ast_fb.c:194:17: warning:
variable 'bo' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit 312fec1405dd ("drm: Initial KMS
driver for AST (ASpeed Technologies) 2000 series (v2)")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/ast/ast_fb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index de26df0..c2e4136 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -191,7 +191,6 @@ static int astfb_create(struct drm_fb_helper *helper,
int size, ret;
void *sysram;
struct drm_gem_object *gobj = NULL;
- struct ast_bo *bo = NULL;
mode_cmd.width = sizes->surface_width;
mode_cmd.height = sizes->surface_height;
mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7)/8);
@@ -206,7 +205,6 @@ static int astfb_create(struct drm_fb_helper *helper,
DRM_ERROR("failed to create fbcon backing object %d\n", ret);
return ret;
}
- bo = gem_to_ast_bo(gobj);
sysram = vmalloc(size);
if (!sysram)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH -next] drm/ast: Remove set but not used variable 'bo'
@ 2018-12-08 8:36 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-08 8:36 UTC (permalink / raw)
To: Dave Airlie, David Airlie, Sam Bobroff, Daniel Vetter
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/ast/ast_fb.c: In function 'astfb_create':
drivers/gpu/drm/ast/ast_fb.c:194:17: warning:
variable 'bo' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit 312fec1405dd ("drm: Initial KMS
driver for AST (ASpeed Technologies) 2000 series (v2)")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/ast/ast_fb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index de26df0..c2e4136 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -191,7 +191,6 @@ static int astfb_create(struct drm_fb_helper *helper,
int size, ret;
void *sysram;
struct drm_gem_object *gobj = NULL;
- struct ast_bo *bo = NULL;
mode_cmd.width = sizes->surface_width;
mode_cmd.height = sizes->surface_height;
mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7)/8);
@@ -206,7 +205,6 @@ static int astfb_create(struct drm_fb_helper *helper,
DRM_ERROR("failed to create fbcon backing object %d\n", ret);
return ret;
}
- bo = gem_to_ast_bo(gobj);
sysram = vmalloc(size);
if (!sysram)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/ast: Remove set but not used variable 'bo'
2018-12-08 8:36 ` YueHaibing
@ 2018-12-10 10:27 ` Daniel Vetter
-1 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2018-12-10 10:27 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, Sam Bobroff, Daniel Vetter, dri-devel,
linux-kernel, kernel-janitors
On Sat, Dec 08, 2018 at 08:36:25AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/ast/ast_fb.c: In function 'astfb_create':
> drivers/gpu/drm/ast/ast_fb.c:194:17: warning:
> variable 'bo' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit 312fec1405dd ("drm: Initial KMS
> driver for AST (ASpeed Technologies) 2000 series (v2)")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
-Daniel
> ---
> drivers/gpu/drm/ast/ast_fb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index de26df0..c2e4136 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -191,7 +191,6 @@ static int astfb_create(struct drm_fb_helper *helper,
> int size, ret;
> void *sysram;
> struct drm_gem_object *gobj = NULL;
> - struct ast_bo *bo = NULL;
> mode_cmd.width = sizes->surface_width;
> mode_cmd.height = sizes->surface_height;
> mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7)/8);
> @@ -206,7 +205,6 @@ static int astfb_create(struct drm_fb_helper *helper,
> DRM_ERROR("failed to create fbcon backing object %d\n", ret);
> return ret;
> }
> - bo = gem_to_ast_bo(gobj);
>
> sysram = vmalloc(size);
> if (!sysram)
>
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/ast: Remove set but not used variable 'bo'
@ 2018-12-10 10:27 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2018-12-10 10:27 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, Sam Bobroff, Daniel Vetter, dri-devel,
linux-kernel, kernel-janitors
On Sat, Dec 08, 2018 at 08:36:25AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/ast/ast_fb.c: In function 'astfb_create':
> drivers/gpu/drm/ast/ast_fb.c:194:17: warning:
> variable 'bo' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit 312fec1405dd ("drm: Initial KMS
> driver for AST (ASpeed Technologies) 2000 series (v2)")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
-Daniel
> ---
> drivers/gpu/drm/ast/ast_fb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index de26df0..c2e4136 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -191,7 +191,6 @@ static int astfb_create(struct drm_fb_helper *helper,
> int size, ret;
> void *sysram;
> struct drm_gem_object *gobj = NULL;
> - struct ast_bo *bo = NULL;
> mode_cmd.width = sizes->surface_width;
> mode_cmd.height = sizes->surface_height;
> mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7)/8);
> @@ -206,7 +205,6 @@ static int astfb_create(struct drm_fb_helper *helper,
> DRM_ERROR("failed to create fbcon backing object %d\n", ret);
> return ret;
> }
> - bo = gem_to_ast_bo(gobj);
>
> sysram = vmalloc(size);
> if (!sysram)
>
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-10 10:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-08 8:36 [PATCH -next] drm/ast: Remove set but not used variable 'bo' YueHaibing
2018-12-08 8:36 ` YueHaibing
2018-12-08 8:36 ` YueHaibing
2018-12-10 10:27 ` Daniel Vetter
2018-12-10 10:27 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.