* [igt-dev] [PATCH i-g-t] tests/i915/module_load: Add probe subtest
@ 2018-12-11 13:02 Arkadiusz Hiler
2018-12-11 13:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arkadiusz Hiler @ 2018-12-11 13:02 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
The subtest is intended to be run as the very first thing on a machine with
i915 blacklisted. It is supposed to be a catch-all for warnings/issues that
happen during the initial module load.
If i915 turns out to be already loaded, the subtest simply skips.
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/i915/module_load.c | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/tests/i915/module_load.c b/tests/i915/module_load.c
index 7fe83520..14552990 100644
--- a/tests/i915/module_load.c
+++ b/tests/i915/module_load.c
@@ -324,8 +324,48 @@ hda_dynamic_debug(bool enable)
fclose(fp);
}
+static void
+reprobe_connectors(int fd)
+{
+ int i, ret;
+ struct drm_mode_get_connector conn;
+
+ drmModeResPtr res = drmModeGetResources(fd);
+ if (!res)
+ return;
+
+ for (i = 0; i < res->count_connectors; ++i) {
+ memset(&conn, 0, sizeof(conn));
+ conn.connector_id = res->connectors[i];
+ ret = drmIoctl(fd, DRM_IOCTL_MODE_GETCONNECTOR, &conn);
+ igt_assert_neq(ret, -EFAULT);
+ }
+
+ drmModeFreeResources(res);
+}
+
igt_main
{
+ /* This subtest is intended to be run as the very first thing on a
+ * machine with i915 blacklisted. It is supposed to be a catch-all for
+ * warnings/issues that happen during the initial module load. */
+ igt_subtest("probe") {
+ int fd;
+
+ if (igt_kmod_is_loaded("i915"))
+ igt_skip("i915 already loaded\n");
+
+ /* modprobe happens here */
+ fd = __drm_open_driver(DRIVER_INTEL);
+ igt_assert(fd > 0);
+
+ /* connectors probing happens during boot because vtconsole,
+ * so let's mimic that */
+ reprobe_connectors(fd);
+
+ close(fd);
+ }
+
igt_subtest("reload") {
int load_error;
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/module_load: Add probe subtest
2018-12-11 13:02 [igt-dev] [PATCH i-g-t] tests/i915/module_load: Add probe subtest Arkadiusz Hiler
@ 2018-12-11 13:32 ` Patchwork
2018-12-11 13:41 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-12-11 14:47 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-12-11 13:32 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: tests/i915/module_load: Add probe subtest
URL : https://patchwork.freedesktop.org/series/53893/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5295 -> IGTPW_2142
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2142 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2142, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53893/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2142:
### IGT changes ###
#### Warnings ####
* igt@prime_vgem@basic-fence-flip:
- fi-hsw-4770: PASS -> SKIP +2
Known issues
------------
Here are the changes found in IGTPW_2142 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
#### Possible fixes ####
* igt@i915_selftest@live_coherency:
- fi-gdg-551: DMESG-FAIL [fdo#107164] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- {fi-kbl-7500u}: FAIL [fdo#108767] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-cfl-8109u: INCOMPLETE [fdo#106070] / [fdo#108126] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#107164]: https://bugs.freedesktop.org/show_bug.cgi?id=107164
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108126]: https://bugs.freedesktop.org/show_bug.cgi?id=108126
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
Participating hosts (49 -> 44)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4745 -> IGTPW_2142
CI_DRM_5295: b94537deaa09d831c7e191da57aed98cc11fd49b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2142: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2142/
IGT_4745: 3b52e8a5809a4e860350c59476a456745cd9fee0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@i915_module_load@probe
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2142/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/module_load: Add probe subtest
2018-12-11 13:02 [igt-dev] [PATCH i-g-t] tests/i915/module_load: Add probe subtest Arkadiusz Hiler
2018-12-11 13:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-12-11 13:41 ` Chris Wilson
2018-12-11 14:47 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2018-12-11 13:41 UTC (permalink / raw)
To: Arkadiusz Hiler, igt-dev; +Cc: Petri Latvala
Quoting Arkadiusz Hiler (2018-12-11 13:02:06)
> The subtest is intended to be run as the very first thing on a machine with
> i915 blacklisted. It is supposed to be a catch-all for warnings/issues that
> happen during the initial module load.
>
> If i915 turns out to be already loaded, the subtest simply skips.
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> tests/i915/module_load.c | 40 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/tests/i915/module_load.c b/tests/i915/module_load.c
> index 7fe83520..14552990 100644
> --- a/tests/i915/module_load.c
> +++ b/tests/i915/module_load.c
> @@ -324,8 +324,48 @@ hda_dynamic_debug(bool enable)
> fclose(fp);
> }
>
> +static void
> +reprobe_connectors(int fd)
> +{
> + int i, ret;
> + struct drm_mode_get_connector conn;
> +
> + drmModeResPtr res = drmModeGetResources(fd);
> + if (!res)
> + return;
> +
> + for (i = 0; i < res->count_connectors; ++i) {
> + memset(&conn, 0, sizeof(conn));
> + conn.connector_id = res->connectors[i];
> + ret = drmIoctl(fd, DRM_IOCTL_MODE_GETCONNECTOR, &conn);
> + igt_assert_neq(ret, -EFAULT);
drmIoctl(GETCONNECTOR) returns 0 or -1.
There's an interesting compat issue with struct drm_mode_get_connector
and needs padding for 32b userspace on 64b kernel. Worth double checking
if that's been fixed in the headers or not, and if not provide a compat
struct, which can be zeroed inside the block with just a local C99
instantiation.
> + }
> +
> + drmModeFreeResources(res);
res is a global? Now a dangling pointer.
Since all you want is connectors[], you can just do GETRESOURCES and
just get the connectors[] into an onstack array. Give it 32 or 64 u32
and add a fixme if we ever need more (or do just a malloc for the large
array).
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/module_load: Add probe subtest
2018-12-11 13:02 [igt-dev] [PATCH i-g-t] tests/i915/module_load: Add probe subtest Arkadiusz Hiler
2018-12-11 13:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-11 13:41 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-12-11 14:47 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-12-11 14:47 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: tests/i915/module_load: Add probe subtest
URL : https://patchwork.freedesktop.org/series/53893/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5295_full -> IGTPW_2142_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53893/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2142_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-apl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] +1
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5
- shard-glk: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232] +1
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +7
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145] +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +4
* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: PASS -> DMESG-FAIL [fdo#108950]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@kms_color@pipe-c-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: DMESG-FAIL [fdo#103232] / [fdo#103558] / [fdo#105602] -> PASS
- shard-kbl: DMESG-FAIL [fdo#103232] / [fdo#103558] / [fdo#105602] -> PASS
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +16
* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-glk: FAIL [fdo#103184] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: DMESG-FAIL [fdo#103167] / [fdo#103558] / [fdo#105602] -> PASS
- shard-apl: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +7
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +3
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-kbl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +17
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-glk: FAIL [fdo#103166] -> PASS +1
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@perf@blocking:
- shard-hsw: FAIL [fdo#102252] -> PASS
* igt@prime_vgem@fence-wait-blt:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4745 -> IGTPW_2142
* Piglit: piglit_4509 -> None
CI_DRM_5295: b94537deaa09d831c7e191da57aed98cc11fd49b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2142: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2142/
IGT_4745: 3b52e8a5809a4e860350c59476a456745cd9fee0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2142/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-11 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 13:02 [igt-dev] [PATCH i-g-t] tests/i915/module_load: Add probe subtest Arkadiusz Hiler
2018-12-11 13:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-11 13:41 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-12-11 14:47 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.