From: frowand.list@gmail.com To: robh+dt@kernel.org, Michael Bringmann <mwb@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman <mpe@ellerman.id.au>, Tyrel Datwyler <tyreld@linux.vnet.ibm.com>, Thomas Falcon <tlfalcon@linux.vnet.ibm.com>, Juliet Kim <minkim@us.ibm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] of: phandle_cache, fix refcounts, remove stale entry Date: Sun, 16 Dec 2018 23:56:34 -0800 [thread overview] Message-ID: <1545033396-24485-1-git-send-email-frowand.list@gmail.com> (raw) From: Frank Rowand <frank.rowand@sony.com> Non-overlay dynamic devicetree node removal may leave the node in the phandle cache. Subsequent calls to of_find_node_by_phandle() will incorrectly find the stale entry. This bug exposed the foloowing phandle cache refcount bug. The refcount of phandle_cache entries is not incremented while in the cache, allowing use after free error after kfree() of the cached entry. Changes since v1: - make __of_free_phandle_cache() static - add WARN_ON(1) for unexpected condition in of_find_node_by_phandle() Frank Rowand (2): of: of_node_get()/of_node_put() nodes held in phandle cache of: __of_detach_node() - remove node from phandle cache drivers/of/base.c | 100 ++++++++++++++++++++++++++++++++++++------------ drivers/of/dynamic.c | 3 ++ drivers/of/of_private.h | 4 ++ 3 files changed, 82 insertions(+), 25 deletions(-) -- Frank Rowand <frank.rowand@sony.com>
WARNING: multiple messages have this Message-ID (diff)
From: frowand.list@gmail.com To: robh+dt@kernel.org, Michael Bringmann <mwb@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org Cc: devicetree@vger.kernel.org, Thomas Falcon <tlfalcon@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, Juliet Kim <minkim@us.ibm.com>, Tyrel Datwyler <tyreld@linux.vnet.ibm.com> Subject: [PATCH v2 0/2] of: phandle_cache, fix refcounts, remove stale entry Date: Sun, 16 Dec 2018 23:56:34 -0800 [thread overview] Message-ID: <1545033396-24485-1-git-send-email-frowand.list@gmail.com> (raw) From: Frank Rowand <frank.rowand@sony.com> Non-overlay dynamic devicetree node removal may leave the node in the phandle cache. Subsequent calls to of_find_node_by_phandle() will incorrectly find the stale entry. This bug exposed the foloowing phandle cache refcount bug. The refcount of phandle_cache entries is not incremented while in the cache, allowing use after free error after kfree() of the cached entry. Changes since v1: - make __of_free_phandle_cache() static - add WARN_ON(1) for unexpected condition in of_find_node_by_phandle() Frank Rowand (2): of: of_node_get()/of_node_put() nodes held in phandle cache of: __of_detach_node() - remove node from phandle cache drivers/of/base.c | 100 ++++++++++++++++++++++++++++++++++++------------ drivers/of/dynamic.c | 3 ++ drivers/of/of_private.h | 4 ++ 3 files changed, 82 insertions(+), 25 deletions(-) -- Frank Rowand <frank.rowand@sony.com>
next reply other threads:[~2018-12-17 7:56 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-17 7:56 frowand.list [this message] 2018-12-17 7:56 ` [PATCH v2 0/2] of: phandle_cache, fix refcounts, remove stale entry frowand.list 2018-12-17 7:56 ` [PATCH v2 1/2] of: of_node_get()/of_node_put() nodes held in phandle cache frowand.list 2018-12-17 7:56 ` frowand.list 2018-12-17 10:43 ` Michael Ellerman 2018-12-17 10:43 ` Michael Ellerman 2018-12-17 7:56 ` [PATCH v2 2/2] of: __of_detach_node() - remove node from " frowand.list 2018-12-17 7:56 ` frowand.list 2018-12-17 10:52 ` Michael Ellerman 2018-12-17 10:52 ` Michael Ellerman 2018-12-18 18:57 ` Frank Rowand 2018-12-18 18:57 ` Frank Rowand 2018-12-18 20:01 ` Rob Herring 2018-12-18 20:01 ` Rob Herring 2018-12-18 20:09 ` Frank Rowand 2018-12-18 20:09 ` Frank Rowand 2018-12-18 20:33 ` Frank Rowand 2018-12-18 20:33 ` Frank Rowand 2018-12-18 20:58 ` Rob Herring 2018-12-18 20:58 ` Rob Herring 2018-12-18 23:44 ` Michael Ellerman 2018-12-18 23:44 ` Michael Ellerman 2018-12-18 23:44 ` Michael Ellerman 2018-12-18 15:43 ` [PATCH v2 0/2] of: phandle_cache, fix refcounts, remove stale entry Rob Herring 2018-12-18 15:43 ` Rob Herring 2018-12-18 23:46 ` Michael Ellerman 2018-12-18 23:46 ` Michael Ellerman 2018-12-18 23:46 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1545033396-24485-1-git-send-email-frowand.list@gmail.com \ --to=frowand.list@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=minkim@us.ibm.com \ --cc=mpe@ellerman.id.au \ --cc=mwb@linux.vnet.ibm.com \ --cc=robh+dt@kernel.org \ --cc=tlfalcon@linux.vnet.ibm.com \ --cc=tyreld@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.