All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: ebiggers@kernel.org,
	James Morris James Morris <jmorris@namei.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Peter Huewe <peterhuewe@gmx.de>,
	David Howells <dhowells@redhat.com>,
	keyrings@vger.kernel.org,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string
Date: Mon, 17 Dec 2018 20:29:18 +0000	[thread overview]
Message-ID: <1545078558.10804.19.camel@linux.ibm.com> (raw)
In-Reply-To: <CAHk-=wjPhKNKRq24wXL3wvqUgfyriDjYNXUPCumbH=64ZMXrSw@mail.gmail.com>

On Mon, 2018-12-17 at 12:02 -0800, Linus Torvalds wrote:
> Talking about the conflicting ones: Opt_hash checks that
> Opt_policydigest isn't set. But Opt_policydigest doesn't check that
> Opt_hash isn't set, so you can mix the two if you just do it in the
> right order.
> 
> But that's a separate bug, and doesn't seem to be a huge deal.
> 
> But it *is* an example of how bogus all of this stuff is. Clearly
> people weren't really paying attention when writing any of this code.

A file signature is more restrictive than just a file hash. I'll clean
up this and the other ugliness.

Mimi

WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: ebiggers@kernel.org,
	James Morris James Morris <jmorris@namei.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Peter Huewe <peterhuewe@gmx.de>,
	David Howells <dhowells@redhat.com>,
	keyrings@vger.kernel.org,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string
Date: Mon, 17 Dec 2018 15:29:18 -0500	[thread overview]
Message-ID: <1545078558.10804.19.camel@linux.ibm.com> (raw)
In-Reply-To: <CAHk-=wjPhKNKRq24wXL3wvqUgfyriDjYNXUPCumbH=64ZMXrSw@mail.gmail.com>

On Mon, 2018-12-17 at 12:02 -0800, Linus Torvalds wrote:
> Talking about the conflicting ones: Opt_hash checks that
> Opt_policydigest isn't set. But Opt_policydigest doesn't check that
> Opt_hash isn't set, so you can mix the two if you just do it in the
> right order.
> 
> But that's a separate bug, and doesn't seem to be a huge deal.
> 
> But it *is* an example of how bogus all of this stuff is. Clearly
> people weren't really paying attention when writing any of this code.

A file signature is more restrictive than just a file hash. I'll clean
up this and the other ugliness.

Mimi


  reply	other threads:[~2018-12-17 20:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-03 15:48 general protection fault in keyctl_pkey_params_get syzbot
2018-11-03 15:48 ` syzbot
2018-11-03 17:30 ` [PATCH] KEYS: fix parsing invalid pkey info string Eric Biggers
2018-11-03 17:30   ` Eric Biggers
2018-11-28 23:20   ` Eric Biggers
2018-11-28 23:20     ` Eric Biggers
2018-12-06 18:26     ` Eric Biggers
2018-12-06 18:26       ` Eric Biggers
2018-12-17 18:12     ` [PATCH RESEND] " Eric Biggers
2018-12-17 18:12       ` Eric Biggers
2018-12-17 18:43       ` Linus Torvalds
2018-12-17 18:43         ` Linus Torvalds
2018-12-17 18:49         ` Linus Torvalds
2018-12-17 18:49           ` Linus Torvalds
2018-12-17 19:06           ` Linus Torvalds
2018-12-17 19:06             ` Linus Torvalds
2018-12-17 19:39             ` Linus Torvalds
2018-12-17 19:39               ` Linus Torvalds
2018-12-17 19:51               ` James Bottomley
2018-12-17 19:51                 ` James Bottomley
2018-12-17 20:02                 ` Linus Torvalds
2018-12-17 20:02                   ` Linus Torvalds
2018-12-17 20:29                   ` Mimi Zohar [this message]
2018-12-17 20:29                     ` Mimi Zohar
2018-12-18  0:44                   ` James Bottomley
2018-12-18  0:44                     ` James Bottomley
2018-12-31 22:45                   ` Eric Biggers
2018-12-31 22:45                     ` Eric Biggers
2019-01-01 21:08                     ` Linus Torvalds
2019-01-01 21:08                       ` Linus Torvalds
2018-12-17 20:21             ` Mimi Zohar
2018-12-17 20:21               ` Mimi Zohar
2018-12-17 20:31               ` Linus Torvalds
2018-12-17 20:31                 ` Linus Torvalds
2018-12-18 12:34         ` Dmitry Vyukov
2018-12-18 12:34           ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545078558.10804.19.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=dhowells@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=torvalds@linux-foundation.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.