* [PATCH] nvme-pci: fix the wrong setting of nr_maps
@ 2018-12-24 3:15 ` Jianchao Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jianchao Wang @ 2018-12-24 3:15 UTC (permalink / raw)
To: keith.busch, axboe, hch, sagi, linux-nvme, linux-kernel
We only set the nr_maps to 3 if poll queues are supported.
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 5a0bf6a..cc65fa8 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2294,7 +2294,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
dev->tagset.nr_maps = 2; /* default + read */
if (dev->io_queues[HCTX_TYPE_POLL])
dev->tagset.nr_maps++;
- dev->tagset.nr_maps = HCTX_MAX_TYPES;
dev->tagset.timeout = NVME_IO_TIMEOUT;
dev->tagset.numa_node = dev_to_node(dev->dev);
dev->tagset.queue_depth =
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] nvme-pci: fix the wrong setting of nr_maps
@ 2018-12-24 3:15 ` Jianchao Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jianchao Wang @ 2018-12-24 3:15 UTC (permalink / raw)
We only set the nr_maps to 3 if poll queues are supported.
Signed-off-by: Jianchao Wang <jianchao.w.wang at oracle.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 5a0bf6a..cc65fa8 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2294,7 +2294,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
dev->tagset.nr_maps = 2; /* default + read */
if (dev->io_queues[HCTX_TYPE_POLL])
dev->tagset.nr_maps++;
- dev->tagset.nr_maps = HCTX_MAX_TYPES;
dev->tagset.timeout = NVME_IO_TIMEOUT;
dev->tagset.numa_node = dev_to_node(dev->dev);
dev->tagset.queue_depth =
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: fix the wrong setting of nr_maps
2018-12-24 3:15 ` Jianchao Wang
@ 2019-01-04 18:11 ` Christoph Hellwig
-1 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2019-01-04 18:11 UTC (permalink / raw)
To: Jianchao Wang; +Cc: keith.busch, axboe, hch, sagi, linux-nvme, linux-kernel
Thanks, this looks like some sort of merge error.
Applied to nvme-4.21.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme-pci: fix the wrong setting of nr_maps
@ 2019-01-04 18:11 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2019-01-04 18:11 UTC (permalink / raw)
Thanks, this looks like some sort of merge error.
Applied to nvme-4.21.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-04 18:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-24 3:15 [PATCH] nvme-pci: fix the wrong setting of nr_maps Jianchao Wang
2018-12-24 3:15 ` Jianchao Wang
2019-01-04 18:11 ` Christoph Hellwig
2019-01-04 18:11 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.