Re: [Qemu-devel] [PATCH v3 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20181218175122.3229-1-philmd@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20181218175122.3229-1-philmd@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v3 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
df72d7a migration: Use strnlen() for fixed-size string
18211fe migration: Use QEMU_NONSTRING for non NUL-terminated arrays
f5a08ba hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays
7d31f0c block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays
5ac217b qemu/compiler: Define QEMU_NONSTRING

=== OUTPUT BEGIN ===
Checking PATCH 1/5: qemu/compiler: Define QEMU_NONSTRING...
WARNING: architecture specific defines should be avoided
#50: FILE: include/qemu/compiler.h:163:
+#if __has_attribute(nonstring)

total: 0 errors, 1 warnings, 21 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays...
Checking PATCH 3/5: hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays...
ERROR: space prohibited before open square bracket '['
#64: FILE: include/hw/acpi/acpi-defs.h:46:
+    uint8_t  oem_id [6] QEMU_NONSTRING; /* OEM identification */

WARNING: Block comments use a leading /* on a separate line
#74: FILE: include/hw/acpi/acpi-defs.h:65:
+    uint8_t  oem_id [6] QEMU_NONSTRING; /* OEM identification */ \

ERROR: space prohibited before open square bracket '['
#74: FILE: include/hw/acpi/acpi-defs.h:65:
+    uint8_t  oem_id [6] QEMU_NONSTRING; /* OEM identification */ \

WARNING: Block comments use a leading /* on a separate line
#75: FILE: include/hw/acpi/acpi-defs.h:66:
+    uint8_t  oem_table_id [8] QEMU_NONSTRING; /* OEM table identification */ \

ERROR: space prohibited before open square bracket '['
#75: FILE: include/hw/acpi/acpi-defs.h:66:
+    uint8_t  oem_table_id [8] QEMU_NONSTRING; /* OEM table identification */ \

WARNING: Block comments use a leading /* on a separate line
#78: FILE: include/hw/acpi/acpi-defs.h:68:
+    uint8_t  asl_compiler_id [4] QEMU_NONSTRING; /* ASL compiler vendor ID */ \

ERROR: space prohibited before open square bracket '['
#78: FILE: include/hw/acpi/acpi-defs.h:68:
+    uint8_t  asl_compiler_id [4] QEMU_NONSTRING; /* ASL compiler vendor ID */ \

total: 4 errors, 3 warnings, 39 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/5: migration: Use QEMU_NONSTRING for non NUL-terminated arrays...
Checking PATCH 5/5: migration: Use strnlen() for fixed-size string...
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20181218175122.3229-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com