All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	qemu-block@nongnu.org, 1803872@bugs.launchpad.net,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Howard Spoelstra" <hsp.cat7@gmail.com>,
	"Jeff Cody" <jcody@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Eric Blake" <eblake@redhat.com>,
	"Ben Pye" <ben@curlybracket.co.uk>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Liu Yuan" <namei.unix@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation
Date: Tue, 18 Dec 2018 18:51:17 +0100	[thread overview]
Message-ID: <20181218175122.3229-1-philmd@redhat.com> (raw)

GCC 8 new warning prevents builds to success since quite some time.
First report on the mailing list is in July 2018:
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html

Various intents has been sent to fix this:
- Incorrectly using g_strlcpy()
  https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html
  https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html
- Using assert() and strpadcpy()
  https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
- Use #pragma GCC diagnostic ignored "-Wstringop-truncation"
  https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- adding an inline wrapper with said pragma in there
  https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- -Wno-stringop-truncation is the makefile
  https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- Use the 'nonstring' attribute
  https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04493.html

This series add the QEMU_NONSTRING definition and use it.

Regards,

Phil.

Philippe Mathieu-Daudé (5):
  qemu/compiler: Define QEMU_NONSTRING
  block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays
  hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays
  migration: Use QEMU_NONSTRING for non NUL-terminated arrays
  migration: Use strnlen() for fixed-size string

 block/sheepdog.c            |  2 +-
 hw/acpi/core.c              |  8 ++++----
 include/hw/acpi/acpi-defs.h |  8 ++++----
 include/qemu/compiler.h     | 15 +++++++++++++++
 migration/global_state.c    |  4 ++--
 5 files changed, 26 insertions(+), 11 deletions(-)

-- 
2.17.2

             reply	other threads:[~2018-12-18 17:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 17:51 Philippe Mathieu-Daudé [this message]
2018-12-18 17:51 ` [Qemu-devel] [PATCH v3 1/5] qemu/compiler: Define QEMU_NONSTRING Philippe Mathieu-Daudé
2018-12-18 18:29   ` Eric Blake
2018-12-18 19:28     ` Philippe Mathieu-Daudé
2018-12-18 17:51 ` [Qemu-devel] [PATCH v3 2/5] block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays Philippe Mathieu-Daudé
2018-12-18 18:30   ` Eric Blake
2018-12-18 23:09   ` Michael S. Tsirkin
2018-12-19  9:22     ` Philippe Mathieu-Daudé
2018-12-18 17:51 ` [Qemu-devel] [PATCH v3 3/5] hw/acpi: " Philippe Mathieu-Daudé
2018-12-19  9:15   ` Igor Mammedov
2018-12-19  9:20     ` Philippe Mathieu-Daudé
2018-12-19  9:57       ` Igor Mammedov
2018-12-19 10:10   ` Andrew Jones
2018-12-19 12:43     ` Philippe Mathieu-Daudé
2018-12-19 13:00       ` Andrew Jones
2018-12-20 15:18         ` Igor Mammedov
2018-12-20 16:29           ` Philippe Mathieu-Daudé
2018-12-18 17:51 ` [Qemu-devel] [PATCH v3 4/5] migration: " Philippe Mathieu-Daudé
2019-01-02 11:41   ` Dr. David Alan Gilbert
2018-12-18 17:51 ` [Qemu-devel] [PATCH v3 5/5] migration: Use strnlen() for fixed-size string Philippe Mathieu-Daudé
2018-12-18 23:16   ` Michael S. Tsirkin
2018-12-19  9:24     ` Philippe Mathieu-Daudé
2018-12-18 17:54 ` [Qemu-devel] [PATCH v3 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation Philippe Mathieu-Daudé
2018-12-18 23:08 ` Michael S. Tsirkin
2018-12-24 23:09 ` no-reply
  -- strict thread matches above, loose matches on Subject: below --
2018-11-18 13:45 [Qemu-devel] [Bug 1803872] [NEW] gcc 8.2 reports stringop-truncation when building qemu Amir Gonnen
2018-11-18 14:52 ` [Qemu-devel] [Bug 1803872] " Amir Gonnen
2018-12-18 12:42 ` [Qemu-devel] [Bug 1803872] Re: [PATCH v2 3/3] migration: Replace strncpy() by strpadcpy(pad='\0') elmarco
2018-12-18 19:29 ` [Qemu-devel] [Bug 1803872] Re: [PATCH v3 4/5] migration: Use QEMU_NONSTRING for non NUL-terminated arrays Eric Blake
2018-12-18 19:33 ` [Qemu-devel] [Bug 1803872] Re: [PATCH v3 5/5] migration: Use strnlen() for fixed-size string Eric Blake
2018-12-18 21:24   ` [Qemu-devel] " Paolo Bonzini
2018-12-18 21:36 ` [Qemu-devel] [Bug 1803872] Re: [PATCH v3 4/5] migration: Use QEMU_NONSTRING for non NUL-terminated arrays Eric Blake
2019-04-24  6:01 ` [Qemu-devel] [Bug 1803872] Re: gcc 8.2 reports stringop-truncation when building qemu Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218175122.3229-1-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=1803872@bugs.launchpad.net \
    --cc=armbru@redhat.com \
    --cc=ben@curlybracket.co.uk \
    --cc=berrange@redhat.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hsp.cat7@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=namei.unix@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.