* [PATCH] arm64/hisilicon: fix SDcard detection
@ 2019-01-09 18:01 ` Vincent Guittot
0 siblings, 0 replies; 8+ messages in thread
From: Vincent Guittot @ 2019-01-09 18:01 UTC (permalink / raw)
To: xuwei5, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, linus.walleij
Cc: Vincent Guittot
commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
Since this change, hikey960 SDcard is not detected anymore because flags
are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
of high, fixes the problem.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 4643546..4ef1642 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -582,7 +582,7 @@
sd-uhs-sdr104;
disable-wp;
cd-inverted;
- cd-gpios = <&gpio25 3 0>;
+ cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&sd_pmx_func
&sd_clk_cfg_func
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] arm64/hisilicon: fix SDcard detection
@ 2019-01-09 18:01 ` Vincent Guittot
0 siblings, 0 replies; 8+ messages in thread
From: Vincent Guittot @ 2019-01-09 18:01 UTC (permalink / raw)
To: xuwei5, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, linus.walleij
Cc: Vincent Guittot
commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
Since this change, hikey960 SDcard is not detected anymore because flags
are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
of high, fixes the problem.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 4643546..4ef1642 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -582,7 +582,7 @@
sd-uhs-sdr104;
disable-wp;
cd-inverted;
- cd-gpios = <&gpio25 3 0>;
+ cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&sd_pmx_func
&sd_clk_cfg_func
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64/hisilicon: fix SDcard detection
2019-01-09 18:01 ` Vincent Guittot
(?)
@ 2019-01-09 18:27 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2019-01-09 18:27 UTC (permalink / raw)
To: Vincent Guittot
Cc: Xu Wei, Rob Herring, Mark Rutland, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
Hi Vincent!
On Wed, Jan 9, 2019 at 7:01 PM Vincent Guittot
<vincent.guittot@linaro.org> wrote:
> commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
>
> Since this change, hikey960 SDcard is not detected anymore because flags
> are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
> of high, fixes the problem.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Please check if this patch fixes your problem:
https://marc.info/?l=linux-mmc&m=154637189021211&w=2
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -582,7 +582,7 @@
> sd-uhs-sdr104;
> disable-wp;
> cd-inverted;
> - cd-gpios = <&gpio25 3 0>;
> + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
This is also a good change, but the old device tree should
continue to work so we need to fix the real bug.
If you also remove "cd-inverted" above, this patch should
hopefully still work and be fine to apply as well.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64/hisilicon: fix SDcard detection
@ 2019-01-09 18:27 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2019-01-09 18:27 UTC (permalink / raw)
To: Vincent Guittot
Cc: Xu Wei, Rob Herring, Mark Rutland, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
Hi Vincent!
On Wed, Jan 9, 2019 at 7:01 PM Vincent Guittot
<vincent.guittot@linaro.org> wrote:
> commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
>
> Since this change, hikey960 SDcard is not detected anymore because flags
> are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
> of high, fixes the problem.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Please check if this patch fixes your problem:
https://marc.info/?l=linux-mmc&m=154637189021211&w=2
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -582,7 +582,7 @@
> sd-uhs-sdr104;
> disable-wp;
> cd-inverted;
> - cd-gpios = <&gpio25 3 0>;
> + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
This is also a good change, but the old device tree should
continue to work so we need to fix the real bug.
If you also remove "cd-inverted" above, this patch should
hopefully still work and be fine to apply as well.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64/hisilicon: fix SDcard detection
@ 2019-01-09 18:27 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2019-01-09 18:27 UTC (permalink / raw)
To: Vincent Guittot
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Xu Wei, Rob Herring, Linux ARM
Hi Vincent!
On Wed, Jan 9, 2019 at 7:01 PM Vincent Guittot
<vincent.guittot@linaro.org> wrote:
> commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
>
> Since this change, hikey960 SDcard is not detected anymore because flags
> are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
> of high, fixes the problem.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Please check if this patch fixes your problem:
https://marc.info/?l=linux-mmc&m=154637189021211&w=2
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -582,7 +582,7 @@
> sd-uhs-sdr104;
> disable-wp;
> cd-inverted;
> - cd-gpios = <&gpio25 3 0>;
> + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
This is also a good change, but the old device tree should
continue to work so we need to fix the real bug.
If you also remove "cd-inverted" above, this patch should
hopefully still work and be fine to apply as well.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64/hisilicon: fix SDcard detection
2019-01-09 18:27 ` Linus Walleij
(?)
@ 2019-01-09 19:08 ` Vincent Guittot
-1 siblings, 0 replies; 8+ messages in thread
From: Vincent Guittot @ 2019-01-09 19:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Xu Wei, Rob Herring, Mark Rutland, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, 9 Jan 2019 at 19:28, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Hi Vincent!
>
> On Wed, Jan 9, 2019 at 7:01 PM Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
>
> > commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> > has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
> >
> > Since this change, hikey960 SDcard is not detected anymore because flags
> > are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
> > of high, fixes the problem.
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Please check if this patch fixes your problem:
> https://marc.info/?l=linux-mmc&m=154637189021211&w=2
This fix the problem
>
> > --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > @@ -582,7 +582,7 @@
> > sd-uhs-sdr104;
> > disable-wp;
> > cd-inverted;
> > - cd-gpios = <&gpio25 3 0>;
> > + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
>
> This is also a good change, but the old device tree should
> continue to work so we need to fix the real bug.
>
> If you also remove "cd-inverted" above, this patch should
> hopefully still work and be fine to apply as well.
ok. I'm going to send an update
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64/hisilicon: fix SDcard detection
@ 2019-01-09 19:08 ` Vincent Guittot
0 siblings, 0 replies; 8+ messages in thread
From: Vincent Guittot @ 2019-01-09 19:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Xu Wei, Rob Herring, Mark Rutland, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, 9 Jan 2019 at 19:28, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Hi Vincent!
>
> On Wed, Jan 9, 2019 at 7:01 PM Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
>
> > commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> > has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
> >
> > Since this change, hikey960 SDcard is not detected anymore because flags
> > are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
> > of high, fixes the problem.
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Please check if this patch fixes your problem:
> https://marc.info/?l=linux-mmc&m=154637189021211&w=2
This fix the problem
>
> > --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > @@ -582,7 +582,7 @@
> > sd-uhs-sdr104;
> > disable-wp;
> > cd-inverted;
> > - cd-gpios = <&gpio25 3 0>;
> > + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
>
> This is also a good change, but the old device tree should
> continue to work so we need to fix the real bug.
>
> If you also remove "cd-inverted" above, this patch should
> hopefully still work and be fine to apply as well.
ok. I'm going to send an update
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64/hisilicon: fix SDcard detection
@ 2019-01-09 19:08 ` Vincent Guittot
0 siblings, 0 replies; 8+ messages in thread
From: Vincent Guittot @ 2019-01-09 19:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Xu Wei, Rob Herring, Linux ARM
On Wed, 9 Jan 2019 at 19:28, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Hi Vincent!
>
> On Wed, Jan 9, 2019 at 7:01 PM Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
>
> > commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> > has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags.
> >
> > Since this change, hikey960 SDcard is not detected anymore because flags
> > are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead
> > of high, fixes the problem.
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Please check if this patch fixes your problem:
> https://marc.info/?l=linux-mmc&m=154637189021211&w=2
This fix the problem
>
> > --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > @@ -582,7 +582,7 @@
> > sd-uhs-sdr104;
> > disable-wp;
> > cd-inverted;
> > - cd-gpios = <&gpio25 3 0>;
> > + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
>
> This is also a good change, but the old device tree should
> continue to work so we need to fix the real bug.
>
> If you also remove "cd-inverted" above, this patch should
> hopefully still work and be fine to apply as well.
ok. I'm going to send an update
>
> Yours,
> Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-09 19:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-09 18:01 [PATCH] arm64/hisilicon: fix SDcard detection Vincent Guittot
2019-01-09 18:01 ` Vincent Guittot
2019-01-09 18:27 ` Linus Walleij
2019-01-09 18:27 ` Linus Walleij
2019-01-09 18:27 ` Linus Walleij
2019-01-09 19:08 ` Vincent Guittot
2019-01-09 19:08 ` Vincent Guittot
2019-01-09 19:08 ` Vincent Guittot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.