* [Qemu-devel] [PATCH] configure: Only build the s390-ccw bios if the compiler supports -march=z900
@ 2019-01-14 12:23 Thomas Huth
2019-01-14 12:37 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2019-01-14 12:23 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel; +Cc: qemu-s390x
We want to build our s390-ccw bios with -march=z900 so that it also
works with the oldest s390x CPU that we support with TCG. However,
Clang on s390x does not support -march=z900 anymore, so we can not
use this compiler to build the s390-ccw bios. Thus add a proper test
to the configure script to see whether the compiler is usable.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 05b7e85..df34974 100755
--- a/configure
+++ b/configure
@@ -5906,7 +5906,10 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
fi
if test "$cpu" = "s390x" ; then
- roms="$roms s390-ccw"
+ # Only build the s390-ccw bios if the compiler supports -march=z900
+ if "$cc" -dumpspecs 2>/dev/null | grep -q "march=z900"; then
+ roms="$roms s390-ccw"
+ fi
fi
# Probe for the need for relocating the user-only binary.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Only build the s390-ccw bios if the compiler supports -march=z900
2019-01-14 12:23 [Qemu-devel] [PATCH] configure: Only build the s390-ccw bios if the compiler supports -march=z900 Thomas Huth
@ 2019-01-14 12:37 ` Peter Maydell
2019-01-14 12:43 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2019-01-14 12:37 UTC (permalink / raw)
To: Thomas Huth; +Cc: Cornelia Huck, QEMU Developers, qemu-s390x
On Mon, 14 Jan 2019 at 12:24, Thomas Huth <thuth@redhat.com> wrote:
>
> We want to build our s390-ccw bios with -march=z900 so that it also
> works with the oldest s390x CPU that we support with TCG. However,
> Clang on s390x does not support -march=z900 anymore, so we can not
> use this compiler to build the s390-ccw bios. Thus add a proper test
> to the configure script to see whether the compiler is usable.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 05b7e85..df34974 100755
> --- a/configure
> +++ b/configure
> @@ -5906,7 +5906,10 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
> fi
>
> if test "$cpu" = "s390x" ; then
> - roms="$roms s390-ccw"
> + # Only build the s390-ccw bios if the compiler supports -march=z900
> + if "$cc" -dumpspecs 2>/dev/null | grep -q "march=z900"; then
> + roms="$roms s390-ccw"
> + fi
> fi
clang doesn't support -dumpspecs at all, so you're implicitly
saying "not clang" by doing the check this way... If you
want to check "does the compiler supoprt -march=z900" why
not do a test compile with that in the compile flags ?
write_c_skeleton
if compile_prog "-march=z900" ""; then
roms="$roms s390-ccw"
fi
?
(untested)
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Only build the s390-ccw bios if the compiler supports -march=z900
2019-01-14 12:37 ` Peter Maydell
@ 2019-01-14 12:43 ` Thomas Huth
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-01-14 12:43 UTC (permalink / raw)
To: Peter Maydell; +Cc: Cornelia Huck, QEMU Developers, qemu-s390x
On 2019-01-14 13:37, Peter Maydell wrote:
> On Mon, 14 Jan 2019 at 12:24, Thomas Huth <thuth@redhat.com> wrote:
>>
>> We want to build our s390-ccw bios with -march=z900 so that it also
>> works with the oldest s390x CPU that we support with TCG. However,
>> Clang on s390x does not support -march=z900 anymore, so we can not
>> use this compiler to build the s390-ccw bios. Thus add a proper test
>> to the configure script to see whether the compiler is usable.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> configure | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 05b7e85..df34974 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5906,7 +5906,10 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
>> fi
>>
>> if test "$cpu" = "s390x" ; then
>> - roms="$roms s390-ccw"
>> + # Only build the s390-ccw bios if the compiler supports -march=z900
>> + if "$cc" -dumpspecs 2>/dev/null | grep -q "march=z900"; then
>> + roms="$roms s390-ccw"
>> + fi
>> fi
>
> clang doesn't support -dumpspecs at all, so you're implicitly
> saying "not clang" by doing the check this way... If you
> want to check "does the compiler supoprt -march=z900" why
> not do a test compile with that in the compile flags ?
>
> write_c_skeleton
> if compile_prog "-march=z900" ""; then
> roms="$roms s390-ccw"
> fi
>
> ?
Good idea, that seems to work fine, too. I'll send a v2...
Thanks,
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 12:23 [Qemu-devel] [PATCH] configure: Only build the s390-ccw bios if the compiler supports -march=z900 Thomas Huth
2019-01-14 12:37 ` Peter Maydell
2019-01-14 12:43 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.