From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "David S. Miller" <davem@davemloft.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Willem de Bruijn <willemb@google.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
Date: Thu, 17 Jan 2019 20:20:38 +0900 [thread overview]
Message-ID: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> (raw)
While I'm looking into how to account standard tx counters on XDP tx
processing, I found several bugs around XDP tx and napi_tx.
Patch1: Fix oops on error path. Patch2 depends on this.
Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
Patch3: Minor fix patch5 depends on.
Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
Also patch5 depends on this.
Patch5: Fix memory corruption on processing xdp_frames while XDP is being
disabled.
Patch6: Minor fix patch7 depends on.
Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
queue is reused for XDP and vise versa.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Toshiaki Makita (7):
virtio_net: Don't enable NAPI when interface is down
virtio_net: Don't call free_old_xmit_skbs for xdp_frames
virtio_net: Fix not restoring real_num_rx_queues
virtio_net: Fix out of bounds access of sq
virtio_net: Don't process redirected XDP frames when XDP is disabled
virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
virtio_net: Differentiate sk_buff and xdp_frame on freeing
drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
1 file changed, 109 insertions(+), 45 deletions(-)
--
1.8.3.1
next reply other threads:[~2019-01-17 11:22 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 11:20 Toshiaki Makita [this message]
2019-01-17 11:20 ` [PATCH net 1/7] virtio_net: Don't enable NAPI when interface is down Toshiaki Makita
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 12:38 ` Jason Wang
2019-01-17 12:38 ` Jason Wang
2019-01-17 11:20 ` [PATCH net 2/7] virtio_net: Don't call free_old_xmit_skbs for xdp_frames Toshiaki Makita
2019-01-17 12:39 ` Jason Wang
2019-01-17 12:39 ` Jason Wang
2019-01-18 1:44 ` Toshiaki Makita
2019-01-18 1:44 ` Toshiaki Makita
2019-01-18 3:50 ` Jason Wang
2019-01-18 3:50 ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 3/7] virtio_net: Fix not restoring real_num_rx_queues Toshiaki Makita
2019-01-17 12:39 ` Jason Wang
2019-01-17 12:39 ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 4/7] virtio_net: Fix out of bounds access of sq Toshiaki Makita
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 12:42 ` Jason Wang
2019-01-17 12:42 ` Jason Wang
2019-01-17 11:20 ` [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled Toshiaki Makita
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 12:53 ` Jason Wang
2019-01-17 12:53 ` Jason Wang
2019-01-17 13:05 ` Jason Wang
2019-01-18 1:56 ` Toshiaki Makita
2019-01-18 3:52 ` Jason Wang
2019-01-18 4:02 ` Toshiaki Makita
2019-01-18 4:02 ` Toshiaki Makita
2019-01-18 3:52 ` Jason Wang
2019-01-18 1:56 ` Toshiaki Makita
2019-01-17 13:05 ` Jason Wang
2019-01-17 11:20 ` [PATCH net 6/7] virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs Toshiaki Makita
2019-01-17 12:56 ` Jason Wang
2019-01-17 13:39 ` Jesper Dangaard Brouer
2019-01-17 13:39 ` Jesper Dangaard Brouer
2019-01-17 12:56 ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 7/7] virtio_net: Differentiate sk_buff and xdp_frame on freeing Toshiaki Makita
2019-01-17 13:04 ` Jason Wang
2019-01-17 13:04 ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 14:55 ` [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx Michael S. Tsirkin
2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-18 2:01 ` Toshiaki Makita
2019-01-18 2:01 ` Toshiaki Makita
-- strict thread matches above, loose matches on Subject: below --
2019-01-17 11:20 Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.