All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "David S. Miller" <davem@davemloft.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
	netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Jesper Dangaard Brouer <brouer@redhat.com>
Subject: [PATCH net 6/7] virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
Date: Thu, 17 Jan 2019 20:20:44 +0900	[thread overview]
Message-ID: <1547724045-2726-7-git-send-email-makita.toshiaki@lab.ntt.co.jp> (raw)
In-Reply-To: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>

put_page() can work as a fallback for freeing xdp_frames, but the
appropriate way is to use xdp_return_frame().

Fixes: cac320c850ef ("virtio_net: convert to use generic xdp_frame and xdp_return_frame API")
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
---
 drivers/net/virtio_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index ae93f0e..996de69 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2668,7 +2668,7 @@ static void free_unused_bufs(struct virtnet_info *vi)
 			if (!is_xdp_raw_buffer_queue(vi, i))
 				dev_kfree_skb(buf);
 			else
-				put_page(virt_to_head_page(buf));
+				xdp_return_frame(buf);
 		}
 	}
 
-- 
1.8.3.1



  parent reply	other threads:[~2019-01-17 11:24 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 11:20 [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 1/7] virtio_net: Don't enable NAPI when interface is down Toshiaki Makita
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 12:38   ` Jason Wang
2019-01-17 12:38   ` Jason Wang
2019-01-17 11:20 ` [PATCH net 2/7] virtio_net: Don't call free_old_xmit_skbs for xdp_frames Toshiaki Makita
2019-01-17 12:39   ` Jason Wang
2019-01-17 12:39   ` Jason Wang
2019-01-18  1:44     ` Toshiaki Makita
2019-01-18  1:44     ` Toshiaki Makita
2019-01-18  3:50       ` Jason Wang
2019-01-18  3:50       ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 3/7] virtio_net: Fix not restoring real_num_rx_queues Toshiaki Makita
2019-01-17 12:39   ` Jason Wang
2019-01-17 12:39   ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 4/7] virtio_net: Fix out of bounds access of sq Toshiaki Makita
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 12:42   ` Jason Wang
2019-01-17 12:42   ` Jason Wang
2019-01-17 11:20 ` [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled Toshiaki Makita
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 12:53   ` Jason Wang
2019-01-17 12:53   ` Jason Wang
2019-01-17 13:05     ` Jason Wang
2019-01-18  1:56       ` Toshiaki Makita
2019-01-18  3:52         ` Jason Wang
2019-01-18  4:02           ` Toshiaki Makita
2019-01-18  4:02           ` Toshiaki Makita
2019-01-18  3:52         ` Jason Wang
2019-01-18  1:56       ` Toshiaki Makita
2019-01-17 13:05     ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita [this message]
2019-01-17 12:56   ` [PATCH net 6/7] virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs Jason Wang
2019-01-17 13:39     ` Jesper Dangaard Brouer
2019-01-17 13:39     ` Jesper Dangaard Brouer
2019-01-17 12:56   ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 11:20 ` [PATCH net 7/7] virtio_net: Differentiate sk_buff and xdp_frame on freeing Toshiaki Makita
2019-01-17 13:04   ` Jason Wang
2019-01-17 13:04   ` Jason Wang
2019-01-17 11:20 ` Toshiaki Makita
2019-01-17 14:55 ` [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx Michael S. Tsirkin
2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-18  2:01   ` Toshiaki Makita
2019-01-18  2:01   ` Toshiaki Makita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547724045-2726-7-git-send-email-makita.toshiaki@lab.ntt.co.jp \
    --to=makita.toshiaki@lab.ntt.co.jp \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.