All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2] bnep: Fix using uninitialized variable
@ 2015-05-29 10:04 Andrei Emeltchenko
  2015-06-01 10:11 ` Andrei Emeltchenko
  2015-06-01 11:00 ` Szymon Janc
  0 siblings, 2 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2015-05-29 10:04 UTC (permalink / raw)
  To: linux-bluetooth

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

---
 profiles/network/bnep.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/profiles/network/bnep.c b/profiles/network/bnep.c
index 59599e4..9bf0b18 100644
--- a/profiles/network/bnep.c
+++ b/profiles/network/bnep.c
@@ -634,8 +634,11 @@ static int bnep_server_add_legacy(int sk, uint16_t dst, char *bridge,
 		bnep_del_from_bridge(iface, bridge);
 		bnep_conndel(addr);
 		rsp = BNEP_CONN_NOT_ALLOWED;
+		goto reply;
 	}
 
+	rsp = BNEP_SUCCESS;
+
 reply:
 	if (bnep_send_ctrl_rsp(sk, BNEP_SETUP_CONN_RSP, rsp) < 0) {
 		err = -errno;
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] bnep: Fix using uninitialized variable
  2015-05-29 10:04 [PATCHv2] bnep: Fix using uninitialized variable Andrei Emeltchenko
@ 2015-06-01 10:11 ` Andrei Emeltchenko
  2015-06-01 11:00 ` Szymon Janc
  1 sibling, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2015-06-01 10:11 UTC (permalink / raw)
  To: linux-bluetooth

ping

On Fri, May 29, 2015 at 01:04:19PM +0300, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> ---
>  profiles/network/bnep.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/profiles/network/bnep.c b/profiles/network/bnep.c
> index 59599e4..9bf0b18 100644
> --- a/profiles/network/bnep.c
> +++ b/profiles/network/bnep.c
> @@ -634,8 +634,11 @@ static int bnep_server_add_legacy(int sk, uint16_t dst, char *bridge,
>  		bnep_del_from_bridge(iface, bridge);
>  		bnep_conndel(addr);
>  		rsp = BNEP_CONN_NOT_ALLOWED;
> +		goto reply;
>  	}
>  
> +	rsp = BNEP_SUCCESS;
> +
>  reply:
>  	if (bnep_send_ctrl_rsp(sk, BNEP_SETUP_CONN_RSP, rsp) < 0) {
>  		err = -errno;
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] bnep: Fix using uninitialized variable
  2015-05-29 10:04 [PATCHv2] bnep: Fix using uninitialized variable Andrei Emeltchenko
  2015-06-01 10:11 ` Andrei Emeltchenko
@ 2015-06-01 11:00 ` Szymon Janc
  1 sibling, 0 replies; 3+ messages in thread
From: Szymon Janc @ 2015-06-01 11:00 UTC (permalink / raw)
  To: Andrei Emeltchenko; +Cc: linux-bluetooth

Hi Andrei,

On Friday 29 of May 2015 13:04:19 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> ---
>  profiles/network/bnep.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/profiles/network/bnep.c b/profiles/network/bnep.c
> index 59599e4..9bf0b18 100644
> --- a/profiles/network/bnep.c
> +++ b/profiles/network/bnep.c
> @@ -634,8 +634,11 @@ static int bnep_server_add_legacy(int sk, uint16_t dst,
> char *bridge, bnep_del_from_bridge(iface, bridge);
>  		bnep_conndel(addr);
>  		rsp = BNEP_CONN_NOT_ALLOWED;
> +		goto reply;
>  	}
> 
> +	rsp = BNEP_SUCCESS;
> +
>  reply:
>  	if (bnep_send_ctrl_rsp(sk, BNEP_SETUP_CONN_RSP, rsp) < 0) {
>  		err = -errno;

Patch applied. Thanks.

-- 
BR
Szymon Janc

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-01 11:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-29 10:04 [PATCHv2] bnep: Fix using uninitialized variable Andrei Emeltchenko
2015-06-01 10:11 ` Andrei Emeltchenko
2015-06-01 11:00 ` Szymon Janc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.