[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Hi all, 

Pinctrl, GPIO, I2C, MMC, ETH are converted.

Convert PMIC is the same of warp7 but i have a some erros, si this log :
U-Boot SPL 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49 +0100)
Trying to boot from USB SDP
SDP: initialize...
SDP: handle requests...
Downloading file of size 556397 to 0x877fffc0... done
Jumping to header at 0x877fffc0
Header Tag is not an IMX image

U-Boot 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49 +0100)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 43C
Reset cause: POR
Model: TechNexion PICO-IMX7D Board and PI baseboard
Board: i.MX7D PICOSOM
DRAM:  512 MiB
read error from device: 9df65458 register: 0x3!
PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
read error from device: 9df65458 register: 0x69!
write error to device: 9df65458 register: 0x23!
write error to device: 9df65458 register: 0x31!
write error to device: 9df65458 register: 0x21!
write error to device: 9df65458 register: 0x2f!
read error from device: 9df65458 register: 0x2e!
write error to device: 9df65458 register: 0x2e!
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
Loading Environment from MMC... OK
In:    serial at 30a70000
Out:   serial at 30a70000
Err:   serial at 30a70000
Net:   
Warning: ethernet at 30be0000 using MAC address from ROM
eth0: ethernet at 30be0000
Hit any key to stop autoboot:  0

USB is convert but update u-boot with dfu log a error :

=> dfu 0 mmc 0
Request would exceed designated area!
#Deferred dfu_flush() failed!=>

Thanks a advance for your help.

Best Regards, 

Joris Offouga

Joris Offouga (9):
  Arm: dts: imx7d-pico: Import Linux pico-pi dts
  Arm: imx7d-pico: Add DT file hooks
  pico-pi-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
  arm: imx7d-pico-pi: Convert to DM MMC initialization
  pico-pi-imx7d: defconfig: Switch to DM for I2C
  pico-imx7d-pico: defconfig: Switch to DM for UART
  pico-imx7d: Convert to DM PMIC
  arm: pico-pi-imx7d: Convert to DM USB
  pico-imx7d: Convert to DM Ethernet

 arch/arm/dts/Makefile                    |   3 +-
 arch/arm/dts/imx7d-pico-pi.dts           | 102 ++++++
 arch/arm/dts/imx7d-pico.dtsi             | 588 +++++++++++++++++++++++++++++++
 board/technexion/pico-imx7d/pico-imx7d.c | 105 +-----
 configs/pico-pi-imx7d_defconfig          |  17 +-
 include/configs/pico-imx7d.h             |  11 -
 6 files changed, 726 insertions(+), 100 deletions(-)
 create mode 100644 arch/arm/dts/imx7d-pico-pi.dts
 create mode 100644 arch/arm/dts/imx7d-pico.dtsi

-- 
2.7.4

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Joris Offouga]

This patch imports the Linux kernel base board imx7d-pico.dtsi and specific
dts for imx7d-pico-pi

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 arch/arm/dts/imx7d-pico-pi.dts |  93 +++++++
 arch/arm/dts/imx7d-pico.dtsi   | 588 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 681 insertions(+)
 create mode 100644 arch/arm/dts/imx7d-pico-pi.dts
 create mode 100644 arch/arm/dts/imx7d-pico.dtsi

diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
new file mode 100644
index 0000000..66ca590
--- /dev/null
+++ b/arch/arm/dts/imx7d-pico-pi.dts
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+//
+// Copyright 2017 NXP
+
+#include "imx7d-pico.dtsi"
+
+/ {
+	model = "TechNexion PICO-IMX7D Board and PI baseboard";
+	compatible = "technexion,imx7d-pico-pi", "fsl,imx7d";
+
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_leds>;
+
+		led {
+			label = "gpio-led";
+			gpios = <&gpio2 6 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
+	sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "imx7-sgtl5000";
+		simple-audio-card,format = "i2s";
+		simple-audio-card,bitclock-master = <&dailink_master>;
+		simple-audio-card,frame-master = <&dailink_master>;
+		simple-audio-card,cpu {
+			sound-dai = <&sai1>;
+		};
+
+		dailink_master: simple-audio-card,codec {
+			sound-dai = <&sgtl5000>;
+			clocks = <&clks IMX7D_AUDIO_MCLK_ROOT_CLK>;
+		};
+	};
+};
+
+&i2c1 {
+	sgtl5000: codec at a {
+		#sound-dai-cells = <0>;
+		reg = <0x0a>;
+		compatible = "fsl,sgtl5000";
+		clocks = <&clks IMX7D_AUDIO_MCLK_ROOT_CLK>;
+		VDDA-supply = <&reg_2p5v>;
+		VDDIO-supply = <&reg_vref_1v8>;
+	};
+};
+
+&i2c4 {
+	polytouch: touchscreen at 38 {
+		compatible = "edt,edt-ft5x06";
+		reg = <0x38>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_touchscreen>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+		reset-gpios = <&gpio2 4 GPIO_ACTIVE_LOW>;
+		touchscreen-size-x = <800>;
+		touchscreen-size-y = <480>;
+	};
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX7D_PAD_EPDC_DATA00__GPIO2_IO0		0x14
+			MX7D_PAD_EPDC_DATA01__GPIO2_IO1		0x14
+			MX7D_PAD_EPDC_DATA02__GPIO2_IO2		0x14
+			MX7D_PAD_EPDC_DATA03__GPIO2_IO3		0x14
+			MX7D_PAD_EPDC_DATA05__GPIO2_IO5		0x14
+			MX7D_PAD_EPDC_DATA12__GPIO2_IO12	0x14
+			MX7D_PAD_EPDC_DATA07__GPIO2_IO7		0x14
+		>;
+	};
+
+	pinctrl_gpio_leds: gpioledsgrp {
+		fsl,pins = <
+			MX7D_PAD_EPDC_DATA06__GPIO2_IO6		0x14
+		>;
+	};
+
+	pinctrl_touchscreen: touchscreengrp {
+		fsl,pins = <
+			MX7D_PAD_EPDC_DATA04__GPIO2_IO4		0x14
+			MX7D_PAD_EPDC_DATA13__GPIO2_IO13	0x14
+		>;
+	};
+
+};
\ No newline at end of file
diff --git a/arch/arm/dts/imx7d-pico.dtsi b/arch/arm/dts/imx7d-pico.dtsi
new file mode 100644
index 0000000..d0c589b
--- /dev/null
+++ b/arch/arm/dts/imx7d-pico.dtsi
@@ -0,0 +1,588 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+//
+// Copyright 2017 NXP
+
+/dts-v1/;
+
+#include "imx7d.dtsi"
+
+/ {
+	/* Will be filled by the bootloader */
+	memory at 80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0>;
+	};
+
+	reg_wlreg_on: regulator-wlreg_on {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_wlreg_on>;
+		regulator-name = "wlreg_on";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio4 16 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	reg_2p5v: regulator-2p5v {
+		compatible = "regulator-fixed";
+		regulator-name = "2P5V";
+		regulator-min-microvolt = <2500000>;
+		regulator-max-microvolt = <2500000>;
+		regulator-always-on;
+	};
+
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	reg_usb_otg1_vbus: regulator-usb-otg1-vbus {
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_usbotg1_pwr>;
+		compatible = "regulator-fixed";
+		regulator-name = "usb_otg1_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 5 GPIO_ACTIVE_LOW>;
+	};
+
+	reg_usb_otg2_vbus: regulator-usb-otg2-vbus {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_otg2_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
+
+	reg_vref_1v8: regulator-vref-1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "vref-1v8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
+	usdhc2_pwrseq: usdhc2_pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
+		clock-names = "ext_clock";
+	};
+};
+
+&clks {
+	assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>,
+			  <&clks IMX7D_CLKO2_ROOT_DIV>;
+	assigned-clock-parents = <&clks IMX7D_CKIL>;
+	assigned-clock-rates = <0>, <32768>;
+};
+
+&ecspi3 {
+	cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_ecspi3>;
+	status = "okay";
+};
+
+&fec1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_enet1>;
+	assigned-clocks = <&clks IMX7D_ENET1_TIME_ROOT_SRC>,
+			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
+	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
+	assigned-clock-rates = <0>, <100000000>;
+	phy-mode = "rgmii";
+	phy-handle = <&ethphy0>;
+	fsl,magic-packet;
+	phy-reset-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy at 1 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <1>;
+			status = "okay";
+		};
+	};
+};
+
+&flexcan1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_can1>;
+	status = "okay";
+};
+
+&flexcan2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_can2>;
+	status = "okay";
+};
+
+&i2c1 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+};
+
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+};
+
+&i2c4 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c4>;
+	status = "okay";
+
+	pmic: pfuze3000 at 8 {
+		compatible = "fsl,pfuze3000";
+		reg = <0x08>;
+
+		regulators {
+			sw1a_reg: sw1a {
+				regulator-min-microvolt = <700000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <6250>;
+			};
+			/* use sw1c_reg to align with pfuze100/pfuze200 */
+			sw1c_reg: sw1b {
+				regulator-min-microvolt = <700000>;
+				regulator-max-microvolt = <1475000>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <6250>;
+			};
+
+			sw2_reg: sw2 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1850000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			sw3a_reg: sw3 {
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <1650000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			swbst_reg: swbst {
+				regulator-min-microvolt = <5000000>;
+				regulator-max-microvolt = <5150000>;
+			};
+
+			snvs_reg: vsnvs {
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			vref_reg: vrefddr {
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			vgen1_reg: vldo1 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vgen2_reg: vldo2 {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <1550000>;
+			};
+
+			vgen3_reg: vccsd {
+				regulator-min-microvolt = <2850000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vgen4_reg: v33 {
+				regulator-min-microvolt = <2850000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vgen5_reg: vldo3 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vgen6_reg: vldo4 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&sai1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_sai1>;
+	assigned-clocks = <&clks IMX7D_SAI1_ROOT_SRC>,
+			  <&clks IMX7D_SAI1_ROOT_CLK>;
+	assigned-clock-parents = <&clks IMX7D_PLL_AUDIO_POST_DIV>;
+	assigned-clock-rates = <0>, <24576000>;
+	status = "okay";
+};
+
+
+&pwm1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm1>;
+	status = "okay";
+};
+
+&pwm2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm2>;
+	status = "okay";
+};
+
+&pwm3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm3>;
+	status = "okay";
+};
+
+&pwm4 { /* Backlight */
+	status = "okay";
+};
+
+&uart5 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart5>;
+	assigned-clocks = <&clks IMX7D_UART5_ROOT_SRC>;
+	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
+	status = "okay";
+};
+
+&uart6 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart6>;
+	assigned-clocks = <&clks IMX7D_UART6_ROOT_SRC>;
+	assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
+	uart-has-rtscts;
+	status = "okay";
+};
+
+&uart7 { /* Bluetooth */
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart7>;
+	assigned-clocks = <&clks IMX7D_UART7_ROOT_SRC>;
+	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
+	uart-has-rtscts;
+	status = "okay";
+};
+
+&usbotg1 {
+	vbus-supply = <&reg_usb_otg1_vbus>;
+	dr_mode = "otg";
+	status = "okay";
+};
+
+&usbotg2 {
+	vbus-supply = <&reg_usb_otg2_vbus>;
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usdhc1 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	tuning-step = <2>;
+	vmmc-supply = <&reg_3p3v>;
+	wakeup-source;
+	no-1-8-v;
+	keep-power-in-suspend;
+	status = "okay";
+};
+
+&usdhc2 { /* Wifi SDIO */
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc2 &pinctrl_wifi_clk>;
+	no-1-8-v;
+	non-removable;
+	keep-power-in-suspend;
+	wakeup-source;
+	vmmc-supply = <&reg_wlreg_on>;
+	mmc-pwrseq = <&usdhc2_pwrseq>;
+	status = "okay";
+};
+
+&usdhc3 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	assigned-clocks = <&clks IMX7D_USDHC3_ROOT_CLK>;
+	assigned-clock-rates = <400000000>;
+	bus-width = <8>;
+	no-1-8-v;
+	fsl,tuning-step = <2>;
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl_ecspi3: ecspi3grp {
+		fsl,pins = <
+			MX7D_PAD_I2C1_SCL__ECSPI3_MISO		0x2
+			MX7D_PAD_I2C1_SDA__ECSPI3_MOSI		0x2
+			MX7D_PAD_I2C2_SCL__ECSPI3_SCLK		0x2
+			MX7D_PAD_I2C2_SDA__GPIO4_IO11		0x14
+		>;
+	};
+
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX7D_PAD_UART1_TX_DATA__I2C1_SDA	0x4000007f
+			MX7D_PAD_UART1_RX_DATA__I2C1_SCL	0x4000007f
+		>;
+	};
+
+	pinctrl_i2c2: i2c2grp {
+		fsl,pins = <
+			MX7D_PAD_UART2_TX_DATA__I2C2_SDA	0x4000007f
+			MX7D_PAD_UART2_RX_DATA__I2C2_SCL	0x4000007f
+		>;
+	};
+
+	pinctrl_enet1: enet1grp {
+		fsl,pins = <
+			MX7D_PAD_SD2_CD_B__ENET1_MDIO			0x3
+			MX7D_PAD_SD2_WP__ENET1_MDC			0x3
+			MX7D_PAD_ENET1_RGMII_TXC__ENET1_RGMII_TXC	0x1
+			MX7D_PAD_ENET1_RGMII_TD0__ENET1_RGMII_TD0	0x1
+			MX7D_PAD_ENET1_RGMII_TD1__ENET1_RGMII_TD1	0x1
+			MX7D_PAD_ENET1_RGMII_TD2__ENET1_RGMII_TD2	0x1
+			MX7D_PAD_ENET1_RGMII_TD3__ENET1_RGMII_TD3	0x1
+			MX7D_PAD_ENET1_RGMII_TX_CTL__ENET1_RGMII_TX_CTL	0x1
+			MX7D_PAD_ENET1_RGMII_RXC__ENET1_RGMII_RXC	0x1
+			MX7D_PAD_ENET1_RGMII_RD0__ENET1_RGMII_RD0	0x1
+			MX7D_PAD_ENET1_RGMII_RD1__ENET1_RGMII_RD1	0x1
+			MX7D_PAD_ENET1_RGMII_RD2__ENET1_RGMII_RD2	0x1
+			MX7D_PAD_ENET1_RGMII_RD3__ENET1_RGMII_RD3	0x1
+			MX7D_PAD_ENET1_RGMII_RX_CTL__ENET1_RGMII_RX_CTL	0x1
+			MX7D_PAD_SD3_RESET_B__GPIO6_IO11                0x1  /* Ethernet reset */
+		>;
+	};
+
+	pinctrl_can1: can1frp {
+		fsl,pins = <
+			MX7D_PAD_SAI1_RX_DATA__FLEXCAN1_RX	0x59
+			MX7D_PAD_SAI1_TX_BCLK__FLEXCAN1_TX	0x59
+		>;
+	};
+
+	pinctrl_can2: can2frp {
+		fsl,pins = <
+			MX7D_PAD_SAI1_TX_SYNC__FLEXCAN2_RX	0x59
+			MX7D_PAD_SAI1_TX_DATA__FLEXCAN2_TX	0x59
+		>;
+	};
+
+	pinctrl_i2c4: i2c4grp {
+		fsl,pins = <
+			MX7D_PAD_SAI1_RX_BCLK__I2C4_SDA		0x4000007f
+			MX7D_PAD_SAI1_RX_SYNC__I2C4_SCL		0x4000007f
+		>;
+	};
+
+	pinctrl_pwm1: pwm1 {
+		fsl,pins = <
+			MX7D_PAD_GPIO1_IO08__PWM1_OUT   0x7f
+		>;
+	};
+
+	pinctrl_pwm2: pwm2 {
+		fsl,pins = <
+			MX7D_PAD_GPIO1_IO09__PWM2_OUT   0x7f
+		>;
+	};
+
+	pinctrl_pwm3: pwm3 {
+		fsl,pins = <
+			MX7D_PAD_GPIO1_IO10__PWM3_OUT   0x7f
+		>;
+	};
+
+	pinctrl_reg_wlreg_on: regregongrp {
+		fsl,pins = <
+			MX7D_PAD_ECSPI1_SCLK__GPIO4_IO16	0x59
+		>;
+	};
+
+	pinctrl_sai1: sai1grp {
+		fsl,pins = <
+			MX7D_PAD_ENET1_RX_CLK__SAI1_TX_BCLK	0x1f
+			MX7D_PAD_ENET1_CRS__SAI1_TX_SYNC	0x1f
+			MX7D_PAD_ENET1_COL__SAI1_TX_DATA0	0x30
+			MX7D_PAD_ENET1_TX_CLK__SAI1_RX_DATA0	0x1f
+		>;
+	};
+
+	pinctrl_uart5: uart5grp {
+		fsl,pins = <
+			MX7D_PAD_I2C4_SDA__UART5_DCE_TX		0x79
+			MX7D_PAD_I2C4_SCL__UART5_DCE_RX		0x79
+		>;
+	};
+
+	pinctrl_uart6: uart6grp {
+		fsl,pins = <
+			MX7D_PAD_EPDC_DATA08__UART6_DCE_RX	0x79
+			MX7D_PAD_EPDC_DATA09__UART6_DCE_TX	0x79
+			MX7D_PAD_EPDC_DATA10__UART6_DCE_RTS	0x79
+			MX7D_PAD_EPDC_DATA11__UART6_DCE_CTS	0x79
+		>;
+	};
+
+	pinctrl_uart7: uart7grp {
+		fsl,pins = <
+			MX7D_PAD_ECSPI2_MOSI__UART7_DCE_TX	0x79
+			MX7D_PAD_ECSPI2_SCLK__UART7_DCE_RX	0x79
+			MX7D_PAD_ECSPI2_SS0__UART7_DCE_CTS	0x79
+			MX7D_PAD_ECSPI2_MISO__UART7_DCE_RTS	0x79
+		>;
+	};
+
+	pinctrl_usbotg1_pwr: usbotg_pwr {
+		fsl,pins = <
+			MX7D_PAD_UART3_TX_DATA__GPIO4_IO5	0x14
+		>;
+	};
+
+	pinctrl_usdhc1: usdhc1grp {
+		fsl,pins = <
+			MX7D_PAD_SD1_CMD__SD1_CMD		0x59
+			MX7D_PAD_SD1_CLK__SD1_CLK		0x19
+			MX7D_PAD_SD1_DATA0__SD1_DATA0		0x59
+			MX7D_PAD_SD1_DATA1__SD1_DATA1		0x59
+			MX7D_PAD_SD1_DATA2__SD1_DATA2		0x59
+			MX7D_PAD_SD1_DATA3__SD1_DATA3		0x59
+			MX7D_PAD_SD1_CD_B__GPIO5_IO0		0x15
+		>;
+	};
+
+	pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
+		fsl,pins = <
+			MX7D_PAD_SD1_CMD__SD1_CMD		0x5a
+			MX7D_PAD_SD1_CLK__SD1_CLK		0x1a
+			MX7D_PAD_SD1_DATA0__SD1_DATA0		0x5a
+			MX7D_PAD_SD1_DATA1__SD1_DATA1		0x5a
+			MX7D_PAD_SD1_DATA2__SD1_DATA2		0x5a
+			MX7D_PAD_SD1_DATA3__SD1_DATA3		0x5a
+			MX7D_PAD_SD1_CD_B__GPIO5_IO0		0x15
+		>;
+	};
+
+	pinctrl_usdhc1_200mhz: usdhc1grp_200mhz {
+		fsl,pins = <
+			MX7D_PAD_SD1_CMD__SD1_CMD		0x5b
+			MX7D_PAD_SD1_CLK__SD1_CLK		0x1b
+			MX7D_PAD_SD1_DATA0__SD1_DATA0		0x5b
+			MX7D_PAD_SD1_DATA1__SD1_DATA1		0x5b
+			MX7D_PAD_SD1_DATA2__SD1_DATA2		0x5b
+			MX7D_PAD_SD1_DATA3__SD1_DATA3		0x5b
+			MX7D_PAD_SD1_CD_B__GPIO5_IO0		0x15
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX7D_PAD_SD2_CMD__SD2_CMD		0x59
+			MX7D_PAD_SD2_CLK__SD2_CLK		0x19
+			MX7D_PAD_SD2_DATA0__SD2_DATA0		0x59
+			MX7D_PAD_SD2_DATA1__SD2_DATA1		0x59
+			MX7D_PAD_SD2_DATA2__SD2_DATA2		0x59
+			MX7D_PAD_SD2_DATA3__SD2_DATA3		0x59
+		>;
+	};
+
+	pinctrl_usdhc3: usdhc3grp {
+		fsl,pins = <
+			MX7D_PAD_SD3_CMD__SD3_CMD		0x59
+			MX7D_PAD_SD3_CLK__SD3_CLK		0x19
+			MX7D_PAD_SD3_DATA0__SD3_DATA0		0x59
+			MX7D_PAD_SD3_DATA1__SD3_DATA1		0x59
+			MX7D_PAD_SD3_DATA2__SD3_DATA2		0x59
+			MX7D_PAD_SD3_DATA3__SD3_DATA3		0x59
+			MX7D_PAD_SD3_DATA4__SD3_DATA4		0x59
+			MX7D_PAD_SD3_DATA5__SD3_DATA5		0x59
+			MX7D_PAD_SD3_DATA6__SD3_DATA6		0x59
+			MX7D_PAD_SD3_DATA7__SD3_DATA7		0x59
+		>;
+	};
+
+	pinctrl_usdhc3_100mhz: usdhc3grp_100mhz {
+		fsl,pins = <
+			MX7D_PAD_SD3_CMD__SD3_CMD		0x5a
+			MX7D_PAD_SD3_CLK__SD3_CLK		0x1a
+			MX7D_PAD_SD3_DATA0__SD3_DATA0		0x5a
+			MX7D_PAD_SD3_DATA1__SD3_DATA1		0x5a
+			MX7D_PAD_SD3_DATA2__SD3_DATA2		0x5a
+			MX7D_PAD_SD3_DATA3__SD3_DATA3		0x5a
+			MX7D_PAD_SD3_DATA4__SD3_DATA4		0x5a
+			MX7D_PAD_SD3_DATA5__SD3_DATA5		0x5a
+			MX7D_PAD_SD3_DATA6__SD3_DATA6		0x5a
+			MX7D_PAD_SD3_DATA7__SD3_DATA7		0x5a
+		>;
+	};
+
+	pinctrl_usdhc3_200mhz: usdhc3grp_200mhz {
+		fsl,pins = <
+			MX7D_PAD_SD3_CMD__SD3_CMD		0x5b
+			MX7D_PAD_SD3_CLK__SD3_CLK		0x1b
+			MX7D_PAD_SD3_DATA0__SD3_DATA0		0x5b
+			MX7D_PAD_SD3_DATA1__SD3_DATA1		0x5b
+			MX7D_PAD_SD3_DATA2__SD3_DATA2		0x5b
+			MX7D_PAD_SD3_DATA3__SD3_DATA3		0x5b
+			MX7D_PAD_SD3_DATA4__SD3_DATA4		0x5b
+			MX7D_PAD_SD3_DATA5__SD3_DATA5		0x5b
+			MX7D_PAD_SD3_DATA6__SD3_DATA6		0x5b
+			MX7D_PAD_SD3_DATA7__SD3_DATA7		0x5b
+		>;
+	};
+};
+
+&iomuxc_lpsr {
+	pinctrl_wifi_clk: wificlkgrp {
+		fsl,pins = <
+			MX7D_PAD_LPSR_GPIO1_IO03__CCM_CLKO2	0x7d
+		>;
+	};
+
+	pinctrl_wdog: wdoggrp {
+		fsl,pins = <
+			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x74
+		>;
+	};
+};
\ No newline at end of file
-- 
2.7.4

[U-Boot] [RFC 2/9] Arm: imx7d-pico: Add DT file hooks

[Joris Offouga]

This patch adds DT file hooks for imx7d-pico-pi.dtb

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 arch/arm/dts/Makefile           | 3 ++-
 configs/pico-pi-imx7d_defconfig | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index b2ca87d..5c87877 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -462,7 +462,8 @@ dtb-$(CONFIG_MX6ULL) += imx6ull-14x14-evk.dtb
 
 dtb-$(CONFIG_MX7) += imx7-colibri.dtb \
 	imx7d-sdb.dtb \
-	imx7d-sdb-qspi.dtb
+	imx7d-sdb-qspi.dtb \
+	imx7d-pico-pi.dtb
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index 8e48ba7..ce43393 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -16,11 +16,13 @@ CONFIG_NR_DRAM_BANKS=1
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
 CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd"
 CONFIG_DEFAULT_FDT_FILE="imx7d-pico-pi.dtb"
+CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-pi"
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_USB_HOST_SUPPORT=y
 CONFIG_SPL_USB_GADGET=y
 CONFIG_SPL_USB_SDP_SUPPORT=y
+CONFIG_OF_CONTROL=y
 # CONFIG_CMD_BOOTD is not set
 CONFIG_CMD_BOOTMENU=y
 # CONFIG_CMD_IMI is not set
@@ -57,4 +59,3 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0525
 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
-CONFIG_OF_LIBFDT=y
-- 
2.7.4

[U-Boot] [RFC 3/9] pico-pi-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7

[Joris Offouga]

This patch is necessary for convert pico-pi-imx7 to dm driver model

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 configs/pico-pi-imx7d_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index ce43393..80f5739 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -23,6 +23,9 @@ CONFIG_SPL_USB_HOST_SUPPORT=y
 CONFIG_SPL_USB_GADGET=y
 CONFIG_SPL_USB_SDP_SUPPORT=y
 CONFIG_OF_CONTROL=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX7=y
+CONFIG_DM_GPIO=y
 # CONFIG_CMD_BOOTD is not set
 CONFIG_CMD_BOOTMENU=y
 # CONFIG_CMD_IMI is not set
-- 
2.7.4

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Joris Offouga]

Furthermore this patch create un alias for mmc0 to usdch3 because before the
convertion he was the only one described in the pico-imx7d.c.

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 arch/arm/dts/imx7d-pico-pi.dts           |  4 ++++
 board/technexion/pico-imx7d/pico-imx7d.c | 36 --------------------------------
 configs/pico-pi-imx7d_defconfig          |  1 +
 3 files changed, 5 insertions(+), 36 deletions(-)

diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
index 66ca590..d4aca96 100644
--- a/arch/arm/dts/imx7d-pico-pi.dts
+++ b/arch/arm/dts/imx7d-pico-pi.dts
@@ -8,6 +8,10 @@
 	model = "TechNexion PICO-IMX7D Board and PI baseboard";
 	compatible = "technexion,imx7d-pico-pi", "fsl,imx7d";
 
+	aliases {
+		mmc0 = &usdhc3;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
index 53e1469..48e90b0 100644
--- a/board/technexion/pico-imx7d/pico-imx7d.c
+++ b/board/technexion/pico-imx7d/pico-imx7d.c
@@ -28,9 +28,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define UART_PAD_CTRL  (PAD_CTL_DSE_3P3V_49OHM | \
 	PAD_CTL_PUS_PU100KOHM | PAD_CTL_HYS)
 
-#define USDHC_PAD_CTRL (PAD_CTL_DSE_3P3V_32OHM | PAD_CTL_SRE_SLOW | \
-	PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PUS_PU47KOHM)
-
 #define ENET_PAD_CTRL  (PAD_CTL_PUS_PU100KOHM | PAD_CTL_DSE_3P3V_49OHM)
 #define ENET_PAD_CTRL_MII  (PAD_CTL_DSE_3P3V_32OHM)
 
@@ -118,20 +115,6 @@ static iomux_v3_cfg_t const uart5_pads[] = {
 	MX7D_PAD_I2C4_SDA__UART5_DCE_TX | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
-static iomux_v3_cfg_t const usdhc3_emmc_pads[] = {
-	MX7D_PAD_SD3_CLK__SD3_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_CMD__SD3_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA1__SD3_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA2__SD3_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA3__SD3_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA4__SD3_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA5__SD3_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA6__SD3_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_SD3_DATA7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX7D_PAD_GPIO1_IO14__GPIO1_IO14 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-};
-
 #ifdef CONFIG_FEC_MXC
 static iomux_v3_cfg_t const fec1_pads[] = {
 	MX7D_PAD_SD2_CD_B__ENET1_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL_MII),
@@ -216,25 +199,6 @@ static void setup_iomux_uart(void)
 	imx_iomux_v3_setup_multiple_pads(uart5_pads, ARRAY_SIZE(uart5_pads));
 }
 
-static struct fsl_esdhc_cfg usdhc_cfg[1] = {
-	{USDHC3_BASE_ADDR},
-};
-
-int board_mmc_getcd(struct mmc *mmc)
-{
-	/* Assume uSDHC3 emmc is always present */
-	return 1;
-}
-
-int board_mmc_init(bd_t *bis)
-{
-	imx_iomux_v3_setup_multiple_pads(
-			usdhc3_emmc_pads, ARRAY_SIZE(usdhc3_emmc_pads));
-	usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);
-
-	return fsl_esdhc_initialize(bis, &usdhc_cfg[0]);
-}
-
 int board_early_init_f(void)
 {
 	setup_iomux_uart();
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index 80f5739..0d1c56b 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -23,6 +23,7 @@ CONFIG_SPL_USB_HOST_SUPPORT=y
 CONFIG_SPL_USB_GADGET=y
 CONFIG_SPL_USB_SDP_SUPPORT=y
 CONFIG_OF_CONTROL=y
+CONFIG_DM_MMC=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX7=y
 CONFIG_DM_GPIO=y
-- 
2.7.4

[U-Boot] [RFC 5/9] pico-pi-imx7d: defconfig: Switch to DM for I2C

[Joris Offouga]

This commit switches to DM I2C for pico-pi-imx7d.

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 board/technexion/pico-imx7d/pico-imx7d.c | 24 ------------------------
 configs/pico-pi-imx7d_defconfig          |  1 +
 include/configs/pico-imx7d.h             |  5 -----
 3 files changed, 1 insertion(+), 29 deletions(-)

diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
index 48e90b0..cd7d5b1 100644
--- a/board/technexion/pico-imx7d/pico-imx7d.c
+++ b/board/technexion/pico-imx7d/pico-imx7d.c
@@ -33,26 +33,6 @@ DECLARE_GLOBAL_DATA_PTR;
 
 #define ENET_RX_PAD_CTRL  (PAD_CTL_PUS_PU100KOHM | PAD_CTL_DSE_3P3V_49OHM)
 
-#define I2C_PAD_CTRL    (PAD_CTL_DSE_3P3V_32OHM | PAD_CTL_SRE_SLOW | \
-	PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PUS_PU100KOHM)
-
-#ifdef CONFIG_SYS_I2C_MXC
-#define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
-/* I2C4 for PMIC */
-static struct i2c_pads_info i2c_pad_info4 = {
-	.scl = {
-		.i2c_mode = MX7D_PAD_SAI1_RX_SYNC__I2C4_SCL | PC,
-		.gpio_mode = MX7D_PAD_SAI1_RX_SYNC__GPIO6_IO16 | PC,
-		.gp = IMX_GPIO_NR(6, 16),
-	},
-	.sda = {
-		.i2c_mode = MX7D_PAD_SAI1_RX_BCLK__I2C4_SDA | PC,
-		.gpio_mode = MX7D_PAD_SAI1_RX_BCLK__GPIO6_IO17 | PC,
-		.gp = IMX_GPIO_NR(6, 17),
-	},
-};
-#endif
-
 int dram_init(void)
 {
 	gd->ram_size = imx_ddr_size();
@@ -203,10 +183,6 @@ int board_early_init_f(void)
 {
 	setup_iomux_uart();
 
-#ifdef CONFIG_SYS_I2C_MXC
-	setup_i2c(3, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info4);
-#endif
-
 	return 0;
 }
 
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index 0d1c56b..dd8af7f 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -27,6 +27,7 @@ CONFIG_DM_MMC=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX7=y
 CONFIG_DM_GPIO=y
+CONFIG_DM_I2C=y
 # CONFIG_CMD_BOOTD is not set
 CONFIG_CMD_BOOTMENU=y
 # CONFIG_CMD_IMI is not set
diff --git a/include/configs/pico-imx7d.h b/include/configs/pico-imx7d.h
index 1884c58..82c105b 100644
--- a/include/configs/pico-imx7d.h
+++ b/include/configs/pico-imx7d.h
@@ -117,12 +117,7 @@
 	(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
 
 /* I2C configs */
-#define CONFIG_SYS_I2C
 #define CONFIG_SYS_I2C_MXC
-#define CONFIG_SYS_I2C_MXC_I2C1
-#define CONFIG_SYS_I2C_MXC_I2C2
-#define CONFIG_SYS_I2C_MXC_I2C3
-#define CONFIG_SYS_I2C_MXC_I2C4
 #define CONFIG_SYS_I2C_SPEED		100000
 
 /* PMIC */
-- 
2.7.4

[U-Boot] [RFC 6/9] pico-imx7d-pico: defconfig: Switch to DM for UART

[Joris Offouga]

This commit switches to DM UART for pico-imx7d-pico.

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 arch/arm/dts/imx7d-pico-pi.dts  | 4 ++++
 configs/pico-pi-imx7d_defconfig | 1 +
 2 files changed, 5 insertions(+)

diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
index d4aca96..806a2f9 100644
--- a/arch/arm/dts/imx7d-pico-pi.dts
+++ b/arch/arm/dts/imx7d-pico-pi.dts
@@ -12,6 +12,10 @@
 		mmc0 = &usdhc3;
 	};
 
+	chosen {
+         stdout-path = &uart5;
+    };
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index dd8af7f..868abb0 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -28,6 +28,7 @@ CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX7=y
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
+CONFIG_DM_SERIAL=y
 # CONFIG_CMD_BOOTD is not set
 CONFIG_CMD_BOOTMENU=y
 # CONFIG_CMD_IMI is not set
-- 
2.7.4

[U-Boot] [RFC 7/9] pico-imx7d: Convert to DM PMIC

[Joris Offouga]

This patch converts the pico-pi-imx7d to use the DM PMIC model.

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 board/technexion/pico-imx7d/pico-imx7d.c | 44 ++++++++++++--------------------
 configs/pico-pi-imx7d_defconfig          |  6 +++++
 include/configs/pico-imx7d.h             |  6 -----
 3 files changed, 23 insertions(+), 33 deletions(-)

diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
index cd7d5b1..095242d 100644
--- a/board/technexion/pico-imx7d/pico-imx7d.c
+++ b/board/technexion/pico-imx7d/pico-imx7d.c
@@ -40,47 +40,37 @@ int dram_init(void)
 	return 0;
 }
 
-#ifdef CONFIG_POWER
-#define I2C_PMIC	3
+#ifdef CONFIG_DM_PMIC
 int power_init_board(void)
 {
-	struct pmic *p;
-	int ret;
-	unsigned int reg, rev_id;
+	struct udevice *dev;
+	int ret=0, dev_id=0, rev_id=0, reg=0;
 
-	ret = power_pfuze3000_init(I2C_PMIC);
-	if (ret)
-		return ret;
+	ret = pmic_get("pfuze3000", &dev);
+	if (ret == -ENODEV)
+		return 0;
+	if (ret != 0)
 
-	p = pmic_get("PFUZE3000");
-	ret = pmic_probe(p);
-	if (ret)
-		return ret;
-
-	pmic_reg_read(p, PFUZE3000_DEVICEID, &reg);
-	pmic_reg_read(p, PFUZE3000_REVID, &rev_id);
-	printf("PMIC:  PFUZE3000 DEV_ID=0x%x REV_ID=0x%x\n", reg, rev_id);
+	dev_id = pmic_reg_read(dev, PFUZE3000_DEVICEID);
+	rev_id = pmic_reg_read(dev, PFUZE3000_REVID);
+	printf("PMIC:  PFUZE3000 DEV_ID=0x%x REV_ID=0x%x\n", dev_id, rev_id);
 
 	/* disable Low Power Mode during standby mode */
-	pmic_reg_read(p, PFUZE3000_LDOGCTL, &reg);
-	reg |= 0x1;
-	pmic_reg_write(p, PFUZE3000_LDOGCTL, reg);
+	pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);
 
 	/* SW1A/1B mode set to APS/APS */
-	reg = 0x8;
-	pmic_reg_write(p, PFUZE3000_SW1AMODE, reg);
-	pmic_reg_write(p, PFUZE3000_SW1BMODE, reg);
+	pmic_reg_write(dev, PFUZE3000_SW1AMODE, 0x8);
+	pmic_reg_write(dev, PFUZE3000_SW1BMODE, 0x8);
 
 	/* SW1A/1B standby voltage set to 1.025V */
-	reg = 0xd;
-	pmic_reg_write(p, PFUZE3000_SW1ASTBY, reg);
-	pmic_reg_write(p, PFUZE3000_SW1BSTBY, reg);
+	pmic_reg_write(dev, PFUZE3000_SW1ASTBY, 0xd);
+	pmic_reg_write(dev, PFUZE3000_SW1BSTBY, 0xd);
 
 	/* decrease SW1B normal voltage to 0.975V */
-	pmic_reg_read(p, PFUZE3000_SW1BVOLT, &reg);
+	reg = pmic_reg_read(dev, PFUZE3000_SW1BVOLT);
 	reg &= ~0x1f;
 	reg |= PFUZE3000_SW1AB_SETP(975);
-	pmic_reg_write(p, PFUZE3000_SW1BVOLT, reg);
+	pmic_reg_write(dev, PFUZE3000_SW1BVOLT, reg);
 
 	return 0;
 }
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index 868abb0..24467bd 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -29,6 +29,12 @@ CONFIG_PINCTRL_IMX7=y
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_SERIAL=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_PFUZE100=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_PFUZE100=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
 # CONFIG_CMD_BOOTD is not set
 CONFIG_CMD_BOOTMENU=y
 # CONFIG_CMD_IMI is not set
diff --git a/include/configs/pico-imx7d.h b/include/configs/pico-imx7d.h
index 82c105b..577cd13 100644
--- a/include/configs/pico-imx7d.h
+++ b/include/configs/pico-imx7d.h
@@ -120,12 +120,6 @@
 #define CONFIG_SYS_I2C_MXC
 #define CONFIG_SYS_I2C_SPEED		100000
 
-/* PMIC */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-#define CONFIG_POWER_PFUZE3000
-#define CONFIG_POWER_PFUZE3000_I2C_ADDR	0x08
-
 /* FLASH and environment organization */
 #define CONFIG_ENV_SIZE			SZ_8K
 
-- 
2.7.4

[U-Boot] [RFC 8/9] arm: pico-pi-imx7d: Convert to DM USB

[Joris Offouga]

Furthermore this patch create a aliase for usb0 to usbotg1.
This usb is used for mass storage and dfu.

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 arch/arm/dts/imx7d-pico-pi.dts  | 1 +
 configs/pico-pi-imx7d_defconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
index 806a2f9..347f165 100644
--- a/arch/arm/dts/imx7d-pico-pi.dts
+++ b/arch/arm/dts/imx7d-pico-pi.dts
@@ -10,6 +10,7 @@
 
 	aliases {
 		mmc0 = &usdhc3;
+		usb0 = &usbotg1;
 	};
 
 	chosen {
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index 24467bd..7f5c2e8 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -29,6 +29,7 @@ CONFIG_PINCTRL_IMX7=y
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_SERIAL=y
+CONFIG_DM_USB=y
 CONFIG_DM_PMIC=y
 CONFIG_DM_PMIC_PFUZE100=y
 CONFIG_DM_REGULATOR=y
-- 
2.7.4

[U-Boot] [RFC 9/9] pico-imx7d: Convert to DM Ethernet

[Joris Offouga]

Furthermore this patch fix request gpio_direction_ouput with gpio_request
require because DM GPIO is enable

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 board/technexion/pico-imx7d/pico-imx7d.c | 1 +
 configs/pico-pi-imx7d_defconfig          | 1 +
 2 files changed, 2 insertions(+)

diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
index 095242d..cfe6ce3 100644
--- a/board/technexion/pico-imx7d/pico-imx7d.c
+++ b/board/technexion/pico-imx7d/pico-imx7d.c
@@ -111,6 +111,7 @@ static void setup_iomux_fec(void)
 {
 	imx_iomux_v3_setup_multiple_pads(fec1_pads, ARRAY_SIZE(fec1_pads));
 
+	gpio_request(FEC1_RST_GPIO, "phy_rst");
 	gpio_direction_output(FEC1_RST_GPIO, 0);
 	udelay(500);
 	gpio_set_value(FEC1_RST_GPIO, 1);
diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
index 7f5c2e8..ab34382 100644
--- a/configs/pico-pi-imx7d_defconfig
+++ b/configs/pico-pi-imx7d_defconfig
@@ -29,6 +29,7 @@ CONFIG_PINCTRL_IMX7=y
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_SERIAL=y
+CONFIG_DM_ETH=y
 CONFIG_DM_USB=y
 CONFIG_DM_PMIC=y
 CONFIG_DM_PMIC_PFUZE100=y
-- 
2.7.4

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Bryan O'Donoghue]

On 20/01/2019 21:18, Joris Offouga wrote:
> This patch imports the Linux kernel base board imx7d-pico.dtsi and specific
> dts for imx7d-pico-pi

I recommend including the upstream Linux SHA in the commit log to make 
it easier to validate against and also if any changes/bugfixes go in 
upstream makes it easier to cherry-pick onto the local dts in u-boot.

---
bod

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[jorisoffouga]

Le 21/01/2019 à 10:52, Bryan O'Donoghue a écrit :
>
>
> On 20/01/2019 21:18, Joris Offouga wrote:
>> This patch imports the Linux kernel base board imx7d-pico.dtsi and 
>> specific
>> dts for imx7d-pico-pi
>
> I recommend including the upstream Linux SHA in the commit log to make 
> it easier to validate against and also if any changes/bugfixes go in 
> upstream makes it easier to cherry-pick onto the local dts in u-boot.
>
Indeed, i add to v2.

I have a problem with pmic, can you watch the patch corresponding to the 
pmic ?

https://patchwork.ozlabs.org/patch/1028229/

Best regards,

Joris  Offouga

> ---
> bod
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Bryan O'Donoghue]

On 21/01/2019 10:34, jorisoffouga wrote:
> 
> Le 21/01/2019 à 10:52, Bryan O'Donoghue a écrit :
>>
>>
>> On 20/01/2019 21:18, Joris Offouga wrote:
>>> This patch imports the Linux kernel base board imx7d-pico.dtsi and 
>>> specific
>>> dts for imx7d-pico-pi
>>
>> I recommend including the upstream Linux SHA in the commit log to make 
>> it easier to validate against and also if any changes/bugfixes go in 
>> upstream makes it easier to cherry-pick onto the local dts in u-boot.
>>
> Indeed, i add to v2.
> 
> I have a problem with pmic, can you watch the patch corresponding to the 
> pmic ?
> 
> https://patchwork.ozlabs.org/patch/1028229/

Let me add Jun, he's better place than me to help with this.

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Offouga Joris]

> Le 21 janv. 2019 à 11:58, Bryan O'Donoghue <bryan.odonoghue@linaro.org> a écrit :
> 
> 
> 
>> On 21/01/2019 10:34, jorisoffouga wrote:
>>> Le 21/01/2019 à 10:52, Bryan O'Donoghue a écrit :
>>> 
>>> 
>>>> On 20/01/2019 21:18, Joris Offouga wrote:
>>>> This patch imports the Linux kernel base board imx7d-pico.dtsi and specific
>>>> dts for imx7d-pico-pi
>>> 
>>> I recommend including the upstream Linux SHA in the commit log to make it easier to validate against and also if any changes/bugfixes go in upstream makes it easier to cherry-pick onto the local dts in u-boot.
>>> 
>> Indeed, i add to v2.
>> I have a problem with pmic, can you watch the patch corresponding to the pmic ?
>> https://patchwork.ozlabs.org/patch/1028229/
> 
> Let me add Jun, he's better place than me to help with this.
Thanks , i'm waiting for this help 
Joris 

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Bryan O'Donoghue]

On 21/01/2019 12:02, Offouga Joris wrote:
> 
> 
>> Le 21 janv. 2019 à 11:58, Bryan O'Donoghue <bryan.odonoghue@linaro.org> a écrit :
>>
>>
>>
>>> On 21/01/2019 10:34, jorisoffouga wrote:
>>>> Le 21/01/2019 à 10:52, Bryan O'Donoghue a écrit :
>>>>
>>>>
>>>>> On 20/01/2019 21:18, Joris Offouga wrote:
>>>>> This patch imports the Linux kernel base board imx7d-pico.dtsi and specific
>>>>> dts for imx7d-pico-pi
>>>>
>>>> I recommend including the upstream Linux SHA in the commit log to make it easier to validate against and also if any changes/bugfixes go in upstream makes it easier to cherry-pick onto the local dts in u-boot.
>>>>
>>> Indeed, i add to v2.
>>> I have a problem with pmic, can you watch the patch corresponding to the pmic ?
>>> https://patchwork.ozlabs.org/patch/1028229/
>>
>> Let me add Jun, he's better place than me to help with this.
> Thanks , i'm waiting for this help
> Joris

Hi Joris,

I've been told that this board exhibits this same problem even without 
the DM conversion.

"PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
read error from device: 9df65458 register: 0x69!
write error to device: 9df65458 register: 0x23!
write error to device: 9df65458 register: 0x31!"

I suggest trying to do a git bisect on the existing non-DM code to 
root-cause where the error creeps in.

---
bod

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Offouga Joris]

> Le 28 janv. 2019 à 07:53, Jun Nie <jun.nie@linaro.org> a écrit :
> 
> Joris Offouga <offougajoris@gmail.com> 于2019年1月25日周五 下午8:27写道：
>> 
>> 
>>>> Le 25/01/2019 à 02:19, Jun Nie a écrit :
>>>> Joris Offouga <offougajoris@gmail.com> 于2019年1月24日周四 下午9:07写道：
>>>> 
>>>>>> Le 24/01/2019 à 13:54, Jun Nie a écrit :
>>>>>> Joris Offouga <offougajoris@gmail.com> 于2019年1月24日周四 下午6:30写道：
>>>>>> Le 24/01/2019 à 11:02, Jun Nie a écrit :
>>>>>>>>>> Hi Joris,
>>>>>>>>>> 
>>>>>>>>>> I've been told that this board exhibits this same problem even without
>>>>>>>>>> the DM conversion.
>>>>>>>>>> 
>>>>>>>>>> "PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
>>>>>>>>>> read error from device: 9df65458 register: 0x69!
>>>>>>>>>> write error to device: 9df65458 register: 0x23!
>>>>>>>>>> write error to device: 9df65458 register: 0x31!"
>>>>>>>>> The result before DM conversion is :
>>>>>>>>> 
>>>>>>>>> PMIC:  PFUZE3000 DEV_ID=0x30 REV_ID=0x11
>>>>>>>>> 
>>>>>>>>> Did you have this problem with the warp7 ?
>>>>>>>> No.
>>>>>>>> 
>>>>>>>> Jun - do you see the above error on the pico ?
>>>>>>> No. The only line I see about PMIC is:
>>>>>>> PMIC:  PFUZE3000 DEV_ID=0x30 REV_ID=0x11
>>>>>>> 
>>>>>>> Jun
>>>>>> Yes it is the line that appears before the conversion
>>>>>> 
>>>>>> Jun - do you have the pico board ?
>>>>>> 
>>>>>> Can you help me with the conversion ?
>>>>>> 
>>>>>> Joris
>>>>> OK, I can try it. Where can I find a git branch with these patches?
>>>> Non,  fork the repo and I create a branch on my repo you go?
>>>> 
>>>> If you have a preference, tell me
>>> Right, you create a branch, I will clone and test on it.
>> 
>> I create a branch pico-imx7d/convert_dm on my github repo :
>> 
>> https://github.com/jorisoffouga/u-boot/tree/pico-imx7d/convert_dm
> 
> Hi Joris,
> 
> I burn u-boot.img to offset 69KB, but SPL does not boot into u-boot
> according to log. Not sure
Hi Jun 

You have the same behavior as me. For the spl I think it should copy Otavio and Fabio who put it in place. 


> 
> U-Boot SPL 2019.01-00273-g3006f29-dirty (Jan 27 2019 - 22:19:00 +0800)
> Trying to boot from MMC1
> 
> If I replace SPL with DCD file for early initilization, I see below
> log. Suppose it is due to i2c failure.
> 
> 4474 U-Boot 2019.01-00274-gca08248-dirty (Jan 27 2019 - 22:28:17 +0800)
> 4475
> 4476 CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
> 4477 CPU:   Commercial temperature grade (0C to 95C) at 27C
> 4478 Reset cause: POR
> 4479 Model: TechNexion PICO-IMX7D Board and PI baseboard
> 4480 Board: i.MX7D PICOSOM
> 4481 DRAM:  512 MiB
> 4482 read error from device: 9df54458 register: 0x3!
> 4483 PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
> 4484 read error from device: 9df54458 register: 0x69!
> 4485 write error to device: 9df54458 register: 0x23!
> 4486 write error to device: 9df54458 register: 0x31!
> 4487 write error to device: 9df54458 register: 0x21!
> 4488 write error to device: 9df54458 register: 0x2f!
> 4489 read error from device: 9df54458 register: 0x2e!
> 4490 write error to device: 9df54458 register: 0x2e!
> 4491 MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
> 4492 Loading Environment from MMC... OK
> 4493 In:    serial at 30a70000
> 4494 Out:   serial at 30a70000
> 4495 Err:   serial at 30a70000
> 4496 Net:   gpio at 30250000: dir_output: error: gpio GPIO6_11 not reserved
> 4497 gpio at 30250000: set_value: error: gpio GPIO6_11 not reserved
> 4498 Board Net Initialization Failed
> 4499 No ethernet found.
> 4500 Hit any key to stop autoboot:  2 ^H^H^H 1 ^H^H^H 0
> 4501 Saving Environment to MMC... Writing to MMC(0)... OK
> 4502 switch to partitions #0, OK
> 4503 mmc0(part 0) is current device
> 4504 Scanning mmc 0:1...
> 4505 Found U-Boot script /boot.scr
> 4506 830 bytes read in 3 ms (269.5 KiB/s)
> 4507 ## Executing script at 80800000
> 
> Jun
Joris 
> 
>>> 
>>> Jun
>> Joris
>>> 
>>>> Joris
>>>> 
>>>>> Jun

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Fabio Estevam]

Hi Bryan and Joris,

On Wed, Jan 23, 2019 at 7:53 AM Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:

> Hi Joris,
>
> I've been told that this board exhibits this same problem even without
> the DM conversion.
>
> "PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
> read error from device: 9df65458 register: 0x69!
> write error to device: 9df65458 register: 0x23!
> write error to device: 9df65458 register: 0x31!"

I cannot reproduce the error here on U-Boot master:

U-Boot SPL 2019.01-00410-g748ad078ee (Jan 30 2019 - 23:02:31 -0200)
Trying to boot from MMC1


U-Boot 2019.01-00410-g748ad078ee (Jan 30 2019 - 23:02:31 -0200)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 47C
Reset cause: POR
Board: i.MX7D PICOSOM
I2C:   ready
DRAM:  512 MiB
PMIC:  PFUZE3000 DEV_ID=0x30 REV_ID=0x11
MMC:   FSL_SDHC: 0
Loading Environment from MMC... OK
Video: 800x480x24
In:    serial
Out:   serial
Err:   serial
Net:   FEC0
Hit any key to stop autoboot:  0

Are you sure the PMIC problem happens prior to the DM conversion?

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Offouga Joris]

Hi Fabio

> Le 31 janv. 2019 à 02:16, Fabio Estevam <festevam@gmail.com> a écrit :
> 
> Hi Bryan and Joris,
> 
> On Wed, Jan 23, 2019 at 7:53 AM Bryan O'Donoghue
> <bryan.odonoghue@linaro.org> wrote:
> 
>> Hi Joris,
>> 
>> I've been told that this board exhibits this same problem even without
>> the DM conversion.
>> 
>> "PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
>> read error from device: 9df65458 register: 0x69!
>> write error to device: 9df65458 register: 0x23!
>> write error to device: 9df65458 register: 0x31!"
> 
> I cannot reproduce the error here on U-Boot master:
> 
> U-Boot SPL 2019.01-00410-g748ad078ee (Jan 30 2019 - 23:02:31 -0200)
> Trying to boot from MMC1
> 
> 
> U-Boot 2019.01-00410-g748ad078ee (Jan 30 2019 - 23:02:31 -0200)
> 
> CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
> CPU:   Commercial temperature grade (0C to 95C) at 47C
> Reset cause: POR
> Board: i.MX7D PICOSOM
> I2C:   ready
> DRAM:  512 MiB
> PMIC:  PFUZE3000 DEV_ID=0x30 REV_ID=0x11
> MMC:   FSL_SDHC: 0
> Loading Environment from MMC... OK
> Video: 800x480x24
> In:    serial
> Out:   serial
> Err:   serial
> Net:   FEC0
> Hit any key to stop autoboot:  0
> 
> Are you sure the PMIC problem happens prior to the DM conversion?
The PMIC problem occurs after the dm conversion 

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Otavio Salvador]

On Thu, Jan 31, 2019 at 1:59 AM Offouga Joris <offougajoris@gmail.com> wrote:
> The PMIC problem occurs after the dm conversion

It'd be good if you could rework the things I commented on the
patchset and refresh the patches on top of imx/master so we can all be
on same page.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Offouga Joris]

> On 31 Jan 2019, at 12:36, Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:
> 
>> On Thu, Jan 31, 2019 at 1:59 AM Offouga Joris <offougajoris@gmail.com> wrote:
>> The PMIC problem occurs after the dm conversion
> 
> It'd be good if you could rework the things I commented on the
> patchset and refresh the patches on top of imx/master so we can all be
> on same page.
Yes I fix them and I send patche without RFC ? 
> 
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Otavio Salvador]

On Thu, Jan 31, 2019 at 9:54 AM Offouga Joris <offougajoris@gmail.com> wrote:
> > On 31 Jan 2019, at 12:36, Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:
> >> On Thu, Jan 31, 2019 at 1:59 AM Offouga Joris <offougajoris@gmail.com> wrote:
> >> The PMIC problem occurs after the dm conversion
> >
> > It'd be good if you could rework the things I commented on the
> > patchset and refresh the patches on top of imx/master so we can all be
> > on same page.
>
> Yes I fix them and I send patche without RFC ?

Not yet, we need to fix the PMIC error before sending it. Please fix
the branch so we can keep contributing there until it is good to be
send here ;-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Joris Offouga]

Le 31/01/2019 à 13:39, Otavio Salvador a écrit :
> On Thu, Jan 31, 2019 at 9:54 AM Offouga Joris <offougajoris@gmail.com> wrote:
>>> On 31 Jan 2019, at 12:36, Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:
>>>> On Thu, Jan 31, 2019 at 1:59 AM Offouga Joris <offougajoris@gmail.com> wrote:
>>>> The PMIC problem occurs after the dm conversion
>>> It'd be good if you could rework the things I commented on the
>>> patchset and refresh the patches on top of imx/master so we can all be
>>> on same page.
>> Yes I fix them and I send patche without RFC ?
> Not yet, we need to fix the PMIC error before sending it. Please fix
> the branch so we can keep contributing there until it is good to be
> send here ;-)

I update the branche on my repo :)

https://github.com/jorisoffouga/u-boot/tree/pico-imx7d/convert_dm

The patches on top of u-boot master

Best Regards,

Joris

>

[U-Boot] [RFC 1/9] Arm: dts: imx7d-pico: Import Linux pico-pi dts

[Fabio Estevam]

Hi Joris,

On Thu, Jan 31, 2019 at 1:20 PM Joris Offouga <offougajoris@gmail.com> wrote:

> I update the branche on my repo :)
>
> https://github.com/jorisoffouga/u-boot/tree/pico-imx7d/convert_dm
>
> The patches on top of u-boot master

I tested your series and I was able to reproduce the PMIC error.

I tried to debug it and could not fix the error yet. Also tested the
warp7 board, which uses the same PMIC and it has been converted to DM
without issues.

Maybe you could resend this series without the PMIC part for now and
we can work to add it as soon as we figure it out.

Thanks for your work!

[U-Boot] [RFC 3/9] pico-pi-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7

[Fabio Estevam]

On Sun, Jan 20, 2019 at 7:41 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> This patch is necessary for convert pico-pi-imx7 to dm driver model
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> ---
>  configs/pico-pi-imx7d_defconfig | 3 +++

Please also convert configs/pico-imx7d_defconfig and
configs/pico-hobbit-imx7d_defconfig

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Fabio Estevam]

On Sun, Jan 20, 2019 at 7:52 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> Furthermore this patch create un alias for mmc0 to usdch3 because before the
> convertion he was the only one described in the pico-imx7d.c.
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> ---
>  arch/arm/dts/imx7d-pico-pi.dts           |  4 ++++
>  board/technexion/pico-imx7d/pico-imx7d.c | 36 --------------------------------
>  configs/pico-pi-imx7d_defconfig          |  1 +
>  3 files changed, 5 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
> index 66ca590..d4aca96 100644
> --- a/arch/arm/dts/imx7d-pico-pi.dts
> +++ b/arch/arm/dts/imx7d-pico-pi.dts
> @@ -8,6 +8,10 @@
>         model = "TechNexion PICO-IMX7D Board and PI baseboard";
>         compatible = "technexion,imx7d-pico-pi", "fsl,imx7d";
>
> +       aliases {
> +               mmc0 = &usdhc3;
> +       };
> +
>         leds {
>                 compatible = "gpio-leds";
>                 pinctrl-names = "default";
> diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
> index 53e1469..48e90b0 100644
> --- a/board/technexion/pico-imx7d/pico-imx7d.c
> +++ b/board/technexion/pico-imx7d/pico-imx7d.c
> @@ -28,9 +28,6 @@ DECLARE_GLOBAL_DATA_PTR;
>  #define UART_PAD_CTRL  (PAD_CTL_DSE_3P3V_49OHM | \
>         PAD_CTL_PUS_PU100KOHM | PAD_CTL_HYS)
>
> -#define USDHC_PAD_CTRL (PAD_CTL_DSE_3P3V_32OHM | PAD_CTL_SRE_SLOW | \
> -       PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PUS_PU47KOHM)
> -
>  #define ENET_PAD_CTRL  (PAD_CTL_PUS_PU100KOHM | PAD_CTL_DSE_3P3V_49OHM)
>  #define ENET_PAD_CTRL_MII  (PAD_CTL_DSE_3P3V_32OHM)
>
> @@ -118,20 +115,6 @@ static iomux_v3_cfg_t const uart5_pads[] = {
>         MX7D_PAD_I2C4_SDA__UART5_DCE_TX | MUX_PAD_CTRL(UART_PAD_CTRL),
>  };
>
> -static iomux_v3_cfg_t const usdhc3_emmc_pads[] = {
> -       MX7D_PAD_SD3_CLK__SD3_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_CMD__SD3_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA1__SD3_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA2__SD3_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA3__SD3_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA4__SD3_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA5__SD3_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA6__SD3_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_SD3_DATA7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -       MX7D_PAD_GPIO1_IO14__GPIO1_IO14 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
> -};
> -
>  #ifdef CONFIG_FEC_MXC
>  static iomux_v3_cfg_t const fec1_pads[] = {
>         MX7D_PAD_SD2_CD_B__ENET1_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL_MII),
> @@ -216,25 +199,6 @@ static void setup_iomux_uart(void)
>         imx_iomux_v3_setup_multiple_pads(uart5_pads, ARRAY_SIZE(uart5_pads));
>  }
>
> -static struct fsl_esdhc_cfg usdhc_cfg[1] = {
> -       {USDHC3_BASE_ADDR},
> -};
> -
> -int board_mmc_getcd(struct mmc *mmc)
> -{
> -       /* Assume uSDHC3 emmc is always present */
> -       return 1;
> -}
> -
> -int board_mmc_init(bd_t *bis)
> -{
> -       imx_iomux_v3_setup_multiple_pads(
> -                       usdhc3_emmc_pads, ARRAY_SIZE(usdhc3_emmc_pads));
> -       usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);
> -
> -       return fsl_esdhc_initialize(bis, &usdhc_cfg[0]);
> -}
> -
>  int board_early_init_f(void)
>  {
>         setup_iomux_uart();
> diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
> index 80f5739..0d1c56b 100644
> --- a/configs/pico-pi-imx7d_defconfig
> +++ b/configs/pico-pi-imx7d_defconfig
> @@ -23,6 +23,7 @@ CONFIG_SPL_USB_HOST_SUPPORT=y
>  CONFIG_SPL_USB_GADGET=y
>  CONFIG_SPL_USB_SDP_SUPPORT=y
>  CONFIG_OF_CONTROL=y
> +CONFIG_DM_MMC=y

After converting to the other imx7d pico defconfigs you can add:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Offouga Joris]

Hi Fabio 

I am preparing the next and I hope to be able to send it soon. give me the instructions to follow and I will add them

Joris 

> On 14 Feb 2019, at 13:14, Fabio Estevam <festevam@gmail.com> wrote:
> 
>> On Sun, Jan 20, 2019 at 7:52 PM Joris Offouga <offougajoris@gmail.com> wrote:
>> 
>> Furthermore this patch create un alias for mmc0 to usdch3 because before the
>> convertion he was the only one described in the pico-imx7d.c.
>> 
>> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
>> ---
>> arch/arm/dts/imx7d-pico-pi.dts           |  4 ++++
>> board/technexion/pico-imx7d/pico-imx7d.c | 36 --------------------------------
>> configs/pico-pi-imx7d_defconfig          |  1 +
>> 3 files changed, 5 insertions(+), 36 deletions(-)
>> 
>> diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
>> index 66ca590..d4aca96 100644
>> --- a/arch/arm/dts/imx7d-pico-pi.dts
>> +++ b/arch/arm/dts/imx7d-pico-pi.dts
>> @@ -8,6 +8,10 @@
>>        model = "TechNexion PICO-IMX7D Board and PI baseboard";
>>        compatible = "technexion,imx7d-pico-pi", "fsl,imx7d";
>> 
>> +       aliases {
>> +               mmc0 = &usdhc3;
>> +       };
>> +
>>        leds {
>>                compatible = "gpio-leds";
>>                pinctrl-names = "default";
>> diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
>> index 53e1469..48e90b0 100644
>> --- a/board/technexion/pico-imx7d/pico-imx7d.c
>> +++ b/board/technexion/pico-imx7d/pico-imx7d.c
>> @@ -28,9 +28,6 @@ DECLARE_GLOBAL_DATA_PTR;
>> #define UART_PAD_CTRL  (PAD_CTL_DSE_3P3V_49OHM | \
>>        PAD_CTL_PUS_PU100KOHM | PAD_CTL_HYS)
>> 
>> -#define USDHC_PAD_CTRL (PAD_CTL_DSE_3P3V_32OHM | PAD_CTL_SRE_SLOW | \
>> -       PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PUS_PU47KOHM)
>> -
>> #define ENET_PAD_CTRL  (PAD_CTL_PUS_PU100KOHM | PAD_CTL_DSE_3P3V_49OHM)
>> #define ENET_PAD_CTRL_MII  (PAD_CTL_DSE_3P3V_32OHM)
>> 
>> @@ -118,20 +115,6 @@ static iomux_v3_cfg_t const uart5_pads[] = {
>>        MX7D_PAD_I2C4_SDA__UART5_DCE_TX | MUX_PAD_CTRL(UART_PAD_CTRL),
>> };
>> 
>> -static iomux_v3_cfg_t const usdhc3_emmc_pads[] = {
>> -       MX7D_PAD_SD3_CLK__SD3_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_CMD__SD3_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA1__SD3_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA2__SD3_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA3__SD3_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA4__SD3_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA5__SD3_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA6__SD3_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_SD3_DATA7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -       MX7D_PAD_GPIO1_IO14__GPIO1_IO14 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>> -};
>> -
>> #ifdef CONFIG_FEC_MXC
>> static iomux_v3_cfg_t const fec1_pads[] = {
>>        MX7D_PAD_SD2_CD_B__ENET1_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL_MII),
>> @@ -216,25 +199,6 @@ static void setup_iomux_uart(void)
>>        imx_iomux_v3_setup_multiple_pads(uart5_pads, ARRAY_SIZE(uart5_pads));
>> }
>> 
>> -static struct fsl_esdhc_cfg usdhc_cfg[1] = {
>> -       {USDHC3_BASE_ADDR},
>> -};
>> -
>> -int board_mmc_getcd(struct mmc *mmc)
>> -{
>> -       /* Assume uSDHC3 emmc is always present */
>> -       return 1;
>> -}
>> -
>> -int board_mmc_init(bd_t *bis)
>> -{
>> -       imx_iomux_v3_setup_multiple_pads(
>> -                       usdhc3_emmc_pads, ARRAY_SIZE(usdhc3_emmc_pads));
>> -       usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);
>> -
>> -       return fsl_esdhc_initialize(bis, &usdhc_cfg[0]);
>> -}
>> -
>> int board_early_init_f(void)
>> {
>>        setup_iomux_uart();
>> diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
>> index 80f5739..0d1c56b 100644
>> --- a/configs/pico-pi-imx7d_defconfig
>> +++ b/configs/pico-pi-imx7d_defconfig
>> @@ -23,6 +23,7 @@ CONFIG_SPL_USB_HOST_SUPPORT=y
>> CONFIG_SPL_USB_GADGET=y
>> CONFIG_SPL_USB_SDP_SUPPORT=y
>> CONFIG_OF_CONTROL=y
>> +CONFIG_DM_MMC=y
> 
> After converting to the other imx7d pico defconfigs you can add:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

[U-Boot] [RFC 5/9] pico-pi-imx7d: defconfig: Switch to DM for I2C

[Fabio Estevam]

On Sun, Jan 20, 2019 at 7:33 PM Joris Offouga <offougajoris@gmail.com> wrote:

> diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
> index 0d1c56b..dd8af7f 100644
> --- a/configs/pico-pi-imx7d_defconfig
> +++ b/configs/pico-pi-imx7d_defconfig
> @@ -27,6 +27,7 @@ CONFIG_DM_MMC=y
>  CONFIG_PINCTRL=y
>  CONFIG_PINCTRL_IMX7=y
>  CONFIG_DM_GPIO=y
> +CONFIG_DM_I2C=y

Please remove CONFIG_SPL_I2C_SUPPORT=y in order to avoid a build warning.

[U-Boot] [RFC 6/9] pico-imx7d-pico: defconfig: Switch to DM for UART

[Fabio Estevam]

On Sun, Jan 20, 2019 at 7:56 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> This commit switches to DM UART for pico-imx7d-pico.
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> ---
>  arch/arm/dts/imx7d-pico-pi.dts  | 4 ++++
>  configs/pico-pi-imx7d_defconfig | 1 +
>  2 files changed, 5 insertions(+)
>
> diff --git a/arch/arm/dts/imx7d-pico-pi.dts b/arch/arm/dts/imx7d-pico-pi.dts
> index d4aca96..806a2f9 100644
> --- a/arch/arm/dts/imx7d-pico-pi.dts
> +++ b/arch/arm/dts/imx7d-pico-pi.dts
> @@ -12,6 +12,10 @@
>                 mmc0 = &usdhc3;
>         };
>
> +       chosen {
> +         stdout-path = &uart5;
> +    };
> +
>         leds {
>                 compatible = "gpio-leds";
>                 pinctrl-names = "default";
> diff --git a/configs/pico-pi-imx7d_defconfig b/configs/pico-pi-imx7d_defconfig
> index dd8af7f..868abb0 100644
> --- a/configs/pico-pi-imx7d_defconfig
> +++ b/configs/pico-pi-imx7d_defconfig
> @@ -28,6 +28,7 @@ CONFIG_PINCTRL=y
>  CONFIG_PINCTRL_IMX7=y
>  CONFIG_DM_GPIO=y
>  CONFIG_DM_I2C=y
> +CONFIG_DM_SERIAL=y

After converting the other imx7 pico defconfigs you can add:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[U-Boot] [RFC 7/9] pico-imx7d: Convert to DM PMIC

[Fabio Estevam]

On Sun, Jan 20, 2019 at 8:14 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> This patch converts the pico-pi-imx7d to use the DM PMIC model.
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> ---
>  board/technexion/pico-imx7d/pico-imx7d.c | 44 ++++++++++++--------------------
>  configs/pico-pi-imx7d_defconfig          |  6 +++++
>  include/configs/pico-imx7d.h             |  6 -----
>  3 files changed, 23 insertions(+), 33 deletions(-)
>
> diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
> index cd7d5b1..095242d 100644
> --- a/board/technexion/pico-imx7d/pico-imx7d.c
> +++ b/board/technexion/pico-imx7d/pico-imx7d.c
> @@ -40,47 +40,37 @@ int dram_init(void)
>         return 0;
>  }
>
> -#ifdef CONFIG_POWER
> -#define I2C_PMIC       3
> +#ifdef CONFIG_DM_PMIC
>  int power_init_board(void)
>  {
> -       struct pmic *p;
> -       int ret;
> -       unsigned int reg, rev_id;
> +       struct udevice *dev;
> +       int ret=0, dev_id=0, rev_id=0, reg=0;
>
> -       ret = power_pfuze3000_init(I2C_PMIC);
> -       if (ret)
> -               return ret;
> +       ret = pmic_get("pfuze3000", &dev);
> +       if (ret == -ENODEV)
> +               return 0;
> +       if (ret != 0)
>
> -       p = pmic_get("PFUZE3000");
> -       ret = pmic_probe(p);
> -       if (ret)
> -               return ret;
> -
> -       pmic_reg_read(p, PFUZE3000_DEVICEID, &reg);
> -       pmic_reg_read(p, PFUZE3000_REVID, &rev_id);
> -       printf("PMIC:  PFUZE3000 DEV_ID=0x%x REV_ID=0x%x\n", reg, rev_id);
> +       dev_id = pmic_reg_read(dev, PFUZE3000_DEVICEID);
> +       rev_id = pmic_reg_read(dev, PFUZE3000_REVID);
> +       printf("PMIC:  PFUZE3000 DEV_ID=0x%x REV_ID=0x%x\n", dev_id, rev_id);
>
>         /* disable Low Power Mode during standby mode */
> -       pmic_reg_read(p, PFUZE3000_LDOGCTL, &reg);
> -       reg |= 0x1;
> -       pmic_reg_write(p, PFUZE3000_LDOGCTL, reg);
> +       pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);

The mask 0 does not look correct. I will fix it in the warp board code as well.

You could simply write:
pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 1, 1);

or keep using pmic_reg_read(), modify and pmic_reg_write().

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Fabio Estevam]

Hi Joris,

On Thu, Feb 14, 2019 at 10:15 AM Offouga Joris <offougajoris@gmail.com> wrote:
>
> Hi Fabio
>
> I am preparing the next and I hope to be able to send it soon. give me the instructions to follow and I will add them

Please check the series I have just sent converting pico-mx6ul boards.

If you have any questions, just let me know.

Regards,

Fabio Estevam

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Joris Offouga]

Le 14/02/2019 à 13:58, Fabio Estevam a écrit :
> Hi Joris,
>
> On Thu, Feb 14, 2019 at 10:15 AM Offouga Joris <offougajoris@gmail.com> wrote:
>> Hi Fabio
>>
>> I am preparing the next and I hope to be able to send it soon. give me the instructions to follow and I will add them
> Please check the series I have just sent converting pico-mx6ul boards.
>
> If you have any questions, just let me know.

Since I do not convert the pmic, I do not convert the i2c either ?

Regards,

Joris Offouga

>
> Regards,
>
> Fabio Estevam

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Fabio Estevam]

Hi Joris,

On Thu, Feb 14, 2019 at 2:42 PM Joris Offouga <offougajoris@gmail.com> wrote:

> Since I do not convert the pmic, I do not convert the i2c either ?

I think it is OK to convert I2C now.

Thanks

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Joris Offouga]

Hi Fabio
> On 14 Feb 2019, at 17:48, Fabio Estevam <festevam@gmail.com> wrote:
> 
> Hi Joris,
> 
>> On Thu, Feb 14, 2019 at 2:42 PM Joris Offouga <offougajoris@gmail.com> wrote:
>> 
>> Since I do not convert the pmic, I do not convert the i2c either ?
> 
> I think it is OK to convert I2C now.
it is not possible to convert that i2c and do not convert the pmic. on 
the other hand, even without pmic and usb conversion there is always the 
dfu error when i try to update u-boot via sudo dfu-util -D 
u-boot-dtb.img -a u-boot .

See this error :
Request would exceed designated area!
#Deferred dfu_flush() failed!=>

Thanks for your help

> 
> Thanks

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Fabio Estevam]

Hi Joris,

On Thu, Feb 14, 2019 at 8:46 PM Joris Offouga <offougajoris@gmail.com> wrote:

> it is not possible to convert that i2c and do not convert the pmic. on

Ok, we can skip I2C and PMIC for now.

> the other hand, even without pmic and usb conversion there is always the
> dfu error when i try to update u-boot via sudo dfu-util -D
> u-boot-dtb.img -a u-boot .
>
> See this error :
> Request would exceed designated area!
> #Deferred dfu_flush() failed!=>

Do you only see this error after the DM conversion?

I haven't tried dfu yet on your tree. Will try it tomorrow.

[U-Boot] [RFC 4/9] arm: imx7d-pico-pi: Convert to DM MMC initialization

[Joris Offouga]

Le 15/02/2019 à 00:08, Fabio Estevam a écrit :
> Hi Joris,
>
> On Thu, Feb 14, 2019 at 8:46 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
>> it is not possible to convert that i2c and do not convert the pmic. on
> Ok, we can skip I2C and PMIC for now.
>
>> the other hand, even without pmic and usb conversion there is always the
>> dfu error when i try to update u-boot via sudo dfu-util -D
>> u-boot-dtb.img -a u-boot .
>>
>> See this error :
>> Request would exceed designated area!
>> #Deferred dfu_flush() failed!=>
> Do you only see this error after the DM conversion?
Yes it's only after DM conversion
>
> I haven't tried dfu yet on your tree. Will try it tomorrow.
Ok thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 10/03/2019 à 15:24, Fabio Estevam a écrit :
> Hi Joris,
>
> On Sat, Mar 9, 2019 at 7:21 PM Offouga Joris <offougajoris@gmail.com> wrote:
>
>> Hi Fabio,
>>
>> I revert the commit about add lcd and on u-boot master and u-boot imx i have the u-boot is flashed correctly in usb and dfu.
>>
>> do you agree that I send the revert of the commit?
> Yes, please revert it for now and resubmit your series that converts
> pico mx7 to DM.

Ok, i send revert add lcd

>
> So the only issue now is the I2C errors?
No, I have not solved the problem of the spl that can not find the 
u-boot-dtb.img in the emmc.

I think the problem comes from the dfu_alt_info we already talked about 
it but the solution with raw u-boot 0x45 800 does not work do you have 
another idea?

Thanks,

Joris Offouga

>
> Thanks,
>
> Fabio Estevam

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Joris,

On Sat, Mar 9, 2019 at 7:21 PM Offouga Joris <offougajoris@gmail.com> wrote:

> Hi Fabio,
>
> I revert the commit about add lcd and on u-boot master and u-boot imx i have the u-boot is flashed correctly in usb and dfu.
>
> do you agree that I send the revert of the commit?

Yes, please revert it for now and resubmit your series that converts
pico mx7 to DM.

So the only issue now is the I2C errors?

Thanks,

Fabio Estevam

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Offouga Joris]

> Le 28 févr. 2019 à 23:06, Offouga Joris <offougajoris@gmail.com> a écrit :
> 
> 
> 
>> Le 28 févr. 2019 à 21:38, Fabio Estevam <festevam@gmail.com> a écrit :
>> 
>> Hi Joris,
>> 
>>> On Sat, Feb 16, 2019 at 1:25 PM Fabio Estevam <festevam@gmail.com> wrote:
>>> 
>>> Just run a "git bisect" and the problem comes from:
>>> 
>>> commit 9e3c0174da842dd88f5feaffbf843ba332233897 (refs/bisect/bad)
>>> Author: Fabio Estevam <festevam@gmail.com>
>>> Date:   Tue Dec 11 16:40:38 2018 -0200
>>> 
>>>   pico-imx7d: Add LCD support
>>> 
>>>   Add support for the VXT VL050-8048NT-C01 panel connected through
>>>   the 24 bit parallel LCDIF interface.
>>> 
>>>   Signed-off-by: Fabio Estevam <festevam@gmail.com>
>>>   Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> 
>>> It used to work at some point as I could see the splashscreen logo in
>>> the screen.
>> 
>> Just a quick update: if I boot from eMMC I don't see this video
>> related hang. I only see the hang when I boot from USB.
> I do not have the screen connected when I do my tests and I disabled CONFIG_VIDEO because it lacks the GPIOs for the screen in the current device tree

Hi Fabio, 

I revert the commit about add lcd and on u-boot master and u-boot imx i have the u-boot is flashed correctly in usb and dfu. 

do you agree that I send the revert of the commit?

Best Regards, 
Joris

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Offouga Joris]

> Le 28 févr. 2019 à 21:38, Fabio Estevam <festevam@gmail.com> a écrit :
> 
> Hi Joris,
> 
>> On Sat, Feb 16, 2019 at 1:25 PM Fabio Estevam <festevam@gmail.com> wrote:
>> 
>> Just run a "git bisect" and the problem comes from:
>> 
>> commit 9e3c0174da842dd88f5feaffbf843ba332233897 (refs/bisect/bad)
>> Author: Fabio Estevam <festevam@gmail.com>
>> Date:   Tue Dec 11 16:40:38 2018 -0200
>> 
>>    pico-imx7d: Add LCD support
>> 
>>    Add support for the VXT VL050-8048NT-C01 panel connected through
>>    the 24 bit parallel LCDIF interface.
>> 
>>    Signed-off-by: Fabio Estevam <festevam@gmail.com>
>>    Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> 
>> It used to work at some point as I could see the splashscreen logo in
>> the screen.
> 
> Just a quick update: if I boot from eMMC I don't see this video
> related hang. I only see the hang when I boot from USB.
I do not have the screen connected when I do my tests and I disabled CONFIG_VIDEO because it lacks the GPIOs for the screen in the current device tree

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Joris,

On Sat, Feb 16, 2019 at 1:25 PM Fabio Estevam <festevam@gmail.com> wrote:

> Just run a "git bisect" and the problem comes from:
>
> commit 9e3c0174da842dd88f5feaffbf843ba332233897 (refs/bisect/bad)
> Author: Fabio Estevam <festevam@gmail.com>
> Date:   Tue Dec 11 16:40:38 2018 -0200
>
>     pico-imx7d: Add LCD support
>
>     Add support for the VXT VL050-8048NT-C01 panel connected through
>     the 24 bit parallel LCDIF interface.
>
>     Signed-off-by: Fabio Estevam <festevam@gmail.com>
>     Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> It used to work at some point as I could see the splashscreen logo in
> the screen.

Just a quick update: if I boot from eMMC I don't see this video
related hang. I only see the hang when I boot from USB.

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Joris,

On Tue, Feb 19, 2019 at 4:24 PM Offouga Joris <offougajoris@gmail.com> wrote:

> Hi Fabio,
> Have you been able to solve your bug? I think that the coming must come from yours and that with the conversion dm that I have in local it must persist

Unfortunately, I haven't had a chance to debug this further.

If you make progress, please let us know.

Regards,

Fabio Estevam

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Offouga Joris]

> Le 16 févr. 2019 à 16:43, Fabio Estevam <festevam@gmail.com> a écrit :
> 
>> On Sat, Feb 16, 2019 at 1:41 PM Joris Offouga <offougajoris@gmail.com> wrote:
>> 
>> I reversed your commit but the block is still there, but even with
>> 
>> your commit on the top of the u-boot master.
>> 
>> I don't have the block with imx_usb_loader just when I try to boot from
>> the emmc
> 
> Ops, it seems we have different issues going on.
Hi Fabio, 
Have you been able to solve your bug? I think that the coming must come from yours and that with the conversion dm that I have in local it must persist 

Best Regards 

Joris 
> 
> I think you would need to run "git bisect" to find out what breaks
> your boot case.

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

On Sat, Feb 16, 2019 at 1:41 PM Joris Offouga <offougajoris@gmail.com> wrote:

> I reversed your commit but the block is still there, but even with
>
> your commit on the top of the u-boot master.
>
> I don't have the block with imx_usb_loader just when I try to boot from
> the emmc

Ops, it seems we have different issues going on.

I think you would need to run "git bisect" to find out what breaks
your boot case.

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 16/02/2019 à 16:25, Fabio Estevam a écrit :
> On Sat, Feb 16, 2019 at 1:14 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
>> Actually on the top of u-boot-imx there is a blocking when loading u-boot-dtb.img with imx_usb_loader.
> Just run a "git bisect" and the problem comes from:
>
> commit 9e3c0174da842dd88f5feaffbf843ba332233897 (refs/bisect/bad)
> Author: Fabio Estevam <festevam@gmail.com>
> Date:   Tue Dec 11 16:40:38 2018 -0200
>
>      pico-imx7d: Add LCD support
>
>      Add support for the VXT VL050-8048NT-C01 panel connected through
>      the 24 bit parallel LCDIF interface.
>
>      Signed-off-by: Fabio Estevam <festevam@gmail.com>
>      Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> It used to work at some point as I could see the splashscreen logo in
> the screen.
>
> Please revert it from your tree and see if it works for you.
>
> I will need to investigate why my commit broke the boot, but for now
> just revert it locally so that you can continue the DM conversion.

I reversed your commit but the block is still there, but even with

your commit on the top of the u-boot master.

I don't have the block with imx_usb_loader just when I try to boot from 
the emmc

>
> Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

On Sat, Feb 16, 2019 at 1:14 PM Joris Offouga <offougajoris@gmail.com> wrote:

> Actually on the top of u-boot-imx there is a blocking when loading u-boot-dtb.img with imx_usb_loader.

Just run a "git bisect" and the problem comes from:

commit 9e3c0174da842dd88f5feaffbf843ba332233897 (refs/bisect/bad)
Author: Fabio Estevam <festevam@gmail.com>
Date:   Tue Dec 11 16:40:38 2018 -0200

    pico-imx7d: Add LCD support

    Add support for the VXT VL050-8048NT-C01 panel connected through
    the 24 bit parallel LCDIF interface.

    Signed-off-by: Fabio Estevam <festevam@gmail.com>
    Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

It used to work at some point as I could see the splashscreen logo in
the screen.

Please revert it from your tree and see if it works for you.

I will need to investigate why my commit broke the boot, but for now
just revert it locally so that you can continue the DM conversion.

Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 16/02/2019 à 15:54, Fabio Estevam a écrit :
> On Sat, Feb 16, 2019 at 12:52 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
>> Ok, thanks for your help :).
>>
>> I worked new commits do you want me to update the RFC in v2?
> Please generate your series against the latest u-boot-imx tree.
>
> However, I observed the hang when I use the latest u-boot or
> u-boot-imx tree, so we will need to fix the hang problem first.

Actually on the top of u-boot-imx there is a blocking when loading 
u-boot-dtb.img with imx_usb_loader.

I show you my log:

U-Boot SPL 2019.04-rc1-dirty (Feb 16 2019 - 16:10:56 +0100)
Trying to boot from USB SDP
SDP: initialize...
SDP: handle requests...
Downloading file of size 530520 to 0x877fffc0... done
Jumping to header at 0x877fffc0
\x14Header Tag is not an IMX image

I will send the series with the status rfc and not patch you are from okay ?

Thanks

>
> Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

On Sat, Feb 16, 2019 at 12:52 PM Joris Offouga <offougajoris@gmail.com> wrote:

> Ok, thanks for your help :).
>
> I worked new commits do you want me to update the RFC in v2?

Please generate your series against the latest u-boot-imx tree.

However, I observed the hang when I use the latest u-boot or
u-boot-imx tree, so we will need to fix the hang problem first.

Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 16/02/2019 à 15:42, Fabio Estevam a écrit :
> Hi Joris,
Hi Fabio,
>
> On Sat, Feb 16, 2019 at 12:38 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
>> By doing this the SPL still does not find the U-Boot binary always this
>> same log:
>>
>>     U-Boot SPL 2019.04-rc1-00142-g7fe4b77-dirty (Feb 16 2019 - 13:58:30
>> +0100)
>> Trying to boot from MMC1
> Yes, just tried it and I saw the same here.
>
> I started from scratch and used top of tree U-Boot.
>
> When I load it via USB I see a hang:
>
> CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
> CPU:   Commercial temperature grade (0C to 95C) at 50C
> Reset cause: POR
> Board: i.MX7D PICOSOM
> I2C:   ready
> DRAM:  512 MiB
> ...
>
> So this is a regression and I will try to bisect it.

Ok, thanks for your help :).

I worked new commits do you want me to update the RFC in v2?

Best Regards,

Joris

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Joris,

On Sat, Feb 16, 2019 at 12:38 PM Joris Offouga <offougajoris@gmail.com> wrote:

> By doing this the SPL still does not find the U-Boot binary always this
> same log:
>
>    U-Boot SPL 2019.04-rc1-00142-g7fe4b77-dirty (Feb 16 2019 - 13:58:30
> +0100)
> Trying to boot from MMC1

Yes, just tried it and I saw the same here.

I started from scratch and used top of tree U-Boot.

When I load it via USB I see a hang:

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 50C
Reset cause: POR
Board: i.MX7D PICOSOM
I2C:   ready
DRAM:  512 MiB
...

So this is a regression and I will try to bisect it.

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 16/02/2019 à 14:58, Fabio Estevam a écrit :
> On Sat, Feb 16, 2019 at 11:02 AM Joris Offouga <offougajoris@gmail.com> wrote:
>
>> Yes , download with dfu it's okay but after rebooting the SPL does not
>> load.
> Does it boot if you flash SPL and u-boot-dtb.img via "ums 0 mmc 0" command?

By doing this the SPL still does not find the U-Boot binary always this 
same log:

   U-Boot SPL 2019.04-rc1-00142-g7fe4b77-dirty (Feb 16 2019 - 13:58:30 
+0100)
Trying to boot from MMC1

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

On Sat, Feb 16, 2019 at 11:02 AM Joris Offouga <offougajoris@gmail.com> wrote:

> Yes , download with dfu it's okay but after rebooting the SPL does not
> load.

Does it boot if you flash SPL and u-boot-dtb.img via "ums 0 mmc 0" command?

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 16/02/2019 à 13:46, Fabio Estevam a écrit :
> On Sat, Feb 16, 2019 at 10:34 AM Joris Offouga <offougajoris@gmail.com> wrote:
>>
>> Le 16/02/2019 à 13:17, Fabio Estevam a écrit :
>>> Hi Joris,
>>>
>>> On Sat, Feb 16, 2019 at 9:06 AM Offouga Joris <offougajoris@gmail.com> wrote:
>>>
>>>> Hi Fabio
>>>>
>>>> I followed Lukasz's advice and I increased the size of the U-Boot in the dfu_alt_info and there is no more error. However, once the SPL and U-Boot are changed and the board  reboots with the jumper in Boot from emmc, the SPL can not load the U-Boot.
>>> What is the U-Boot size you used in the dfu_alt_info?
>> "u-boot raw 0x8a 0x1000"
> The original setting was correct:
> u-boot-dtb.img needs to be flashed at the position 69kB of the eMMC.
>
> Originally we had:
>
> u-boot raw 0x8a 0x400;
>
> which means: 0x8a = 138 * 0x400 = 138 * 1024 = 138 sectors. Each
> sector is 512 bytes, so 138*0.5k = 69kB
>
> Could you also try:
>
> u-boot raw 0x45 0x800
>
> Does it make any difference?

Yes , download with dfu it's okay but after rebooting the SPL does not 
load.

For u-boot, dm-spl, this does not work only if the SPL is converted to 
DM too, because the add-on in the uscdh3 node did not change the problem 
of loading the U-Boot

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

On Sat, Feb 16, 2019 at 10:34 AM Joris Offouga <offougajoris@gmail.com> wrote:
>
>
> Le 16/02/2019 à 13:17, Fabio Estevam a écrit :
> > Hi Joris,
> >
> > On Sat, Feb 16, 2019 at 9:06 AM Offouga Joris <offougajoris@gmail.com> wrote:
> >
> >> Hi Fabio
> >>
> >> I followed Lukasz's advice and I increased the size of the U-Boot in the dfu_alt_info and there is no more error. However, once the SPL and U-Boot are changed and the board  reboots with the jumper in Boot from emmc, the SPL can not load the U-Boot.
> > What is the U-Boot size you used in the dfu_alt_info?
>
> "u-boot raw 0x8a 0x1000"

The original setting was correct:
u-boot-dtb.img needs to be flashed at the position 69kB of the eMMC.

Originally we had:

u-boot raw 0x8a 0x400;

which means: 0x8a = 138 * 0x400 = 138 * 1024 = 138 sectors. Each
sector is 512 bytes, so 138*0.5k = 69kB

Could you also try:

u-boot raw 0x45 0x800

Does it make any difference?

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 16/02/2019 à 13:17, Fabio Estevam a écrit :
> Hi Joris,
>
> On Sat, Feb 16, 2019 at 9:06 AM Offouga Joris <offougajoris@gmail.com> wrote:
>
>> Hi Fabio
>>
>> I followed Lukasz's advice and I increased the size of the U-Boot in the dfu_alt_info and there is no more error. However, once the SPL and U-Boot are changed and the board  reboots with the jumper in Boot from emmc, the SPL can not load the U-Boot.
> What is the U-Boot size you used in the dfu_alt_info?

"u-boot raw 0x8a 0x1000"

>
> What is the error you see in SPL now?
See this log :
U-Boot SPL 2019.04-rc1-00142-g7fe4b77-dirty (Feb 15 2019 - 20:11:50 +0100)
Trying to boot from MMC1
>
> Thanks
Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

On Sat, Feb 16, 2019 at 10:17 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Joris,
>
> On Sat, Feb 16, 2019 at 9:06 AM Offouga Joris <offougajoris@gmail.com> wrote:
>
> > Hi Fabio
> >
> > I followed Lukasz's advice and I increased the size of the U-Boot in the dfu_alt_info and there is no more error. However, once the SPL and U-Boot are changed and the board  reboots with the jumper in Boot from emmc, the SPL can not load the U-Boot.
>
> What is the U-Boot size you used in the dfu_alt_info?
>
> What is the error you see in SPL now?

Also, imx7 is missing the u-boot,dm-spl properties.

Take a look at imx6ul, for example:

git grep u-boot,dm-spl | grep mx6ul

And see if doing the same for mx7 works.

Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Joris,

On Sat, Feb 16, 2019 at 9:06 AM Offouga Joris <offougajoris@gmail.com> wrote:

> Hi Fabio
>
> I followed Lukasz's advice and I increased the size of the U-Boot in the dfu_alt_info and there is no more error. However, once the SPL and U-Boot are changed and the board  reboots with the jumper in Boot from emmc, the SPL can not load the U-Boot.

What is the U-Boot size you used in the dfu_alt_info?

What is the error you see in SPL now?

Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Offouga Joris]

> Le 15 févr. 2019 à 12:50, Lukasz Majewski <lukma@denx.de> a écrit :
> 
> Hi Fabio,
> 
>> Hi Lukasz,
>> 
>> On Wed, Jan 23, 2019 at 7:01 PM Joris Offouga
>> <offougajoris@gmail.com> wrote:
>> 
>>> Hi Lukasz,
>>> 
>>>> Please check if malloc pool size (in Kconfig) is large enough to
>>>> handle DFU requests.  
>>> The dfu request is smaller than the size of malloc pool size  
>>>> 
>>>> Otherwise, please #define DEBUG in ./drivers/dfu.c and dfu_mmc.c
>>>> and share output.  
>>> 
>>> This is a log when dfu failed :
>>> 
>>> blk_find_device: if_type=6, devnum=0: usdhc at 30b40000.blk, 6, 2
>>> blk_find_device: if_type=6, devnum=0: usdhc at 30b50000.blk, 6, 1
>>> blk_find_device: if_type=6, devnum=0: usdhc at 30b60000.blk, 6, 0
>>> Request would exceed designated area!
> 
> Please carefully check the eMMC partition size (as defined in
> dfu_alt_info) and the size of sent data.

Hi Fabio

I followed Lukasz's advice and I increased the size of the U-Boot in the dfu_alt_info and there is no more error. However, once the SPL and U-Boot are changed and the board  reboots with the jumper in Boot from emmc, the SPL can not load the U-Boot.

Best Regards 

Joris Offouga 
> This error happens when one wants to write bigger file than the
> reported space on the partition.
> 
> Please look at drivers/dfu/dfu_mmc.c Line: 44
> 
>>> dfu_write_buffer_drain: Write error!
>>> #Deferred dfu_flush() failed!reset_config:
>>> unbind function 'dfu'/9ef6e678
>>> g_dnl_unbind: calling usb_gadget_disconnect for controller
>>> 'ci_udc'  
>> 
>> Do you have any idea on this issue, please?
>> 
>> This DFU bug is one of the items that is blocking the DM conversion of
>> this board.
>> 
>> Thanks
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Lukasz Majewski]

Hi Fabio,

> Hi Lukasz,
> 
> On Wed, Jan 23, 2019 at 7:01 PM Joris Offouga
> <offougajoris@gmail.com> wrote:
> 
> > Hi Lukasz,
> >  
> > > Please check if malloc pool size (in Kconfig) is large enough to
> > > handle DFU requests.  
> > The dfu request is smaller than the size of malloc pool size  
> > >
> > > Otherwise, please #define DEBUG in ./drivers/dfu.c and dfu_mmc.c
> > > and share output.  
> >
> > This is a log when dfu failed :
> >
> > blk_find_device: if_type=6, devnum=0: usdhc at 30b40000.blk, 6, 2
> > blk_find_device: if_type=6, devnum=0: usdhc at 30b50000.blk, 6, 1
> > blk_find_device: if_type=6, devnum=0: usdhc at 30b60000.blk, 6, 0
> > Request would exceed designated area!

Please carefully check the eMMC partition size (as defined in
dfu_alt_info) and the size of sent data.

This error happens when one wants to write bigger file than the
reported space on the partition.

Please look at drivers/dfu/dfu_mmc.c Line: 44

> > dfu_write_buffer_drain: Write error!
> > #Deferred dfu_flush() failed!reset_config:
> > unbind function 'dfu'/9ef6e678
> > g_dnl_unbind: calling usb_gadget_disconnect for controller
> > 'ci_udc'  
> 
> Do you have any idea on this issue, please?
> 
> This DFU bug is one of the items that is blocking the DM conversion of
> this board.
> 
> Thanks




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/0019c5f8/attachment.sig>

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Lukasz,

On Wed, Jan 23, 2019 at 7:01 PM Joris Offouga <offougajoris@gmail.com> wrote:

> Hi Lukasz,
>
> > Please check if malloc pool size (in Kconfig) is large enough to handle
> > DFU requests.
> The dfu request is smaller than the size of malloc pool size
> >
> > Otherwise, please #define DEBUG in ./drivers/dfu.c and dfu_mmc.c and
> > share output.
>
> This is a log when dfu failed :
>
> blk_find_device: if_type=6, devnum=0: usdhc at 30b40000.blk, 6, 2
> blk_find_device: if_type=6, devnum=0: usdhc at 30b50000.blk, 6, 1
> blk_find_device: if_type=6, devnum=0: usdhc at 30b60000.blk, 6, 0
> Request would exceed designated area!
> dfu_write_buffer_drain: Write error!
> #Deferred dfu_flush() failed!reset_config:
> unbind function 'dfu'/9ef6e678
> g_dnl_unbind: calling usb_gadget_disconnect for controller 'ci_udc'

Do you have any idea on this issue, please?

This DFU bug is one of the items that is blocking the DM conversion of
this board.

Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Fabio Estevam]

Hi Joris,

On Sun, Jan 20, 2019 at 7:17 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> Hi all,
>
> Pinctrl, GPIO, I2C, MMC, ETH are converted.

The series looks good. I have sent comments for every patch and you
could repost them to the list.

I recommend to not convert PMIC and USB until we address the issues
you reported.

Thanks

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Le 22/01/2019 à 10:47, Lukasz Majewski a écrit :
> On Sun, 20 Jan 2019 23:38:32 +0100
> Joris Offouga <offougajoris@gmail.com> wrote:
>
>> Hi all,
>>
>> Pinctrl, GPIO, I2C, MMC, ETH are converted.
>>
>> Convert PMIC is the same of warp7 but i have a some erros, si this
>> log : U-Boot SPL 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49
>> +0100) Trying to boot from USB SDP
>> SDP: initialize...
>> SDP: handle requests...
>> Downloading file of size 556397 to 0x877fffc0... done
>> Jumping to header at 0x877fffc0
>> Header Tag is not an IMX image
>>
>> U-Boot 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49 +0100)
>>
>> CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
>> CPU:   Commercial temperature grade (0C to 95C) at 43C
>> Reset cause: POR
>> Model: TechNexion PICO-IMX7D Board and PI baseboard
>> Board: i.MX7D PICOSOM
>> DRAM:  512 MiB
>> read error from device: 9df65458 register: 0x3!
>> PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
>> read error from device: 9df65458 register: 0x69!
>> write error to device: 9df65458 register: 0x23!
>> write error to device: 9df65458 register: 0x31!
>> write error to device: 9df65458 register: 0x21!
>> write error to device: 9df65458 register: 0x2f!
>> read error from device: 9df65458 register: 0x2e!
>> write error to device: 9df65458 register: 0x2e!
>> MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
>> Loading Environment from MMC... OK
>> In:    serial at 30a70000
>> Out:   serial at 30a70000
>> Err:   serial at 30a70000
>> Net:
>> Warning: ethernet at 30be0000 using MAC address from ROM
>> eth0: ethernet at 30be0000
>> Hit any key to stop autoboot:  0
>>
>> USB is convert but update u-boot with dfu log a error :
>>
>> => dfu 0 mmc 0
>> Request would exceed designated area!
>> #Deferred dfu_flush() failed!=>

Hi Lukasz,

> Please check if malloc pool size (in Kconfig) is large enough to handle
> DFU requests.
The dfu request is smaller than the size of malloc pool size
>
> Otherwise, please #define DEBUG in ./drivers/dfu.c and dfu_mmc.c and
> share output.

This is a log when dfu failed :

blk_find_device: if_type=6, devnum=0: usdhc at 30b40000.blk, 6, 2
blk_find_device: if_type=6, devnum=0: usdhc at 30b50000.blk, 6, 1
blk_find_device: if_type=6, devnum=0: usdhc at 30b60000.blk, 6, 0
Request would exceed designated area!
dfu_write_buffer_drain: Write error!
#Deferred dfu_flush() failed!reset_config:
unbind function 'dfu'/9ef6e678
g_dnl_unbind: calling usb_gadget_disconnect for controller 'ci_udc'

Best Regards,

Joris Offouga

>
>> Thanks a advance for your help.
>>
>> Best Regards,
>>
>> Joris Offouga
>>
>> Joris Offouga (9):
>>    Arm: dts: imx7d-pico: Import Linux pico-pi dts
>>    Arm: imx7d-pico: Add DT file hooks
>>    pico-pi-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
>>    arm: imx7d-pico-pi: Convert to DM MMC initialization
>>    pico-pi-imx7d: defconfig: Switch to DM for I2C
>>    pico-imx7d-pico: defconfig: Switch to DM for UART
>>    pico-imx7d: Convert to DM PMIC
>>    arm: pico-pi-imx7d: Convert to DM USB
>>    pico-imx7d: Convert to DM Ethernet
>>
>>   arch/arm/dts/Makefile                    |   3 +-
>>   arch/arm/dts/imx7d-pico-pi.dts           | 102 ++++++
>>   arch/arm/dts/imx7d-pico.dtsi             | 588
>> +++++++++++++++++++++++++++++++
>> board/technexion/pico-imx7d/pico-imx7d.c | 105 +-----
>> configs/pico-pi-imx7d_defconfig          |  17 +-
>> include/configs/pico-imx7d.h             |  11 - 6 files changed, 726
>> insertions(+), 100 deletions(-) create mode 100644
>> arch/arm/dts/imx7d-pico-pi.dts create mode 100644
>> arch/arm/dts/imx7d-pico.dtsi
>>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Lukasz Majewski]

On Sun, 20 Jan 2019 23:38:32 +0100
Joris Offouga <offougajoris@gmail.com> wrote:

> Hi all, 
> 
> Pinctrl, GPIO, I2C, MMC, ETH are converted.
> 
> Convert PMIC is the same of warp7 but i have a some erros, si this
> log : U-Boot SPL 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49
> +0100) Trying to boot from USB SDP
> SDP: initialize...
> SDP: handle requests...
> Downloading file of size 556397 to 0x877fffc0... done
> Jumping to header at 0x877fffc0
> Header Tag is not an IMX image
> 
> U-Boot 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49 +0100)
> 
> CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
> CPU:   Commercial temperature grade (0C to 95C) at 43C
> Reset cause: POR
> Model: TechNexion PICO-IMX7D Board and PI baseboard
> Board: i.MX7D PICOSOM
> DRAM:  512 MiB
> read error from device: 9df65458 register: 0x3!
> PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
> read error from device: 9df65458 register: 0x69!
> write error to device: 9df65458 register: 0x23!
> write error to device: 9df65458 register: 0x31!
> write error to device: 9df65458 register: 0x21!
> write error to device: 9df65458 register: 0x2f!
> read error from device: 9df65458 register: 0x2e!
> write error to device: 9df65458 register: 0x2e!
> MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
> Loading Environment from MMC... OK
> In:    serial at 30a70000
> Out:   serial at 30a70000
> Err:   serial at 30a70000
> Net:   
> Warning: ethernet at 30be0000 using MAC address from ROM
> eth0: ethernet at 30be0000
> Hit any key to stop autoboot:  0
> 
> USB is convert but update u-boot with dfu log a error :
> 
> => dfu 0 mmc 0  
> Request would exceed designated area!
> #Deferred dfu_flush() failed!=>

Please check if malloc pool size (in Kconfig) is large enough to handle
DFU requests.

Otherwise, please #define DEBUG in ./drivers/dfu.c and dfu_mmc.c and
share output.

> 
> Thanks a advance for your help.
> 
> Best Regards, 
> 
> Joris Offouga
> 
> Joris Offouga (9):
>   Arm: dts: imx7d-pico: Import Linux pico-pi dts
>   Arm: imx7d-pico: Add DT file hooks
>   pico-pi-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
>   arm: imx7d-pico-pi: Convert to DM MMC initialization
>   pico-pi-imx7d: defconfig: Switch to DM for I2C
>   pico-imx7d-pico: defconfig: Switch to DM for UART
>   pico-imx7d: Convert to DM PMIC
>   arm: pico-pi-imx7d: Convert to DM USB
>   pico-imx7d: Convert to DM Ethernet
> 
>  arch/arm/dts/Makefile                    |   3 +-
>  arch/arm/dts/imx7d-pico-pi.dts           | 102 ++++++
>  arch/arm/dts/imx7d-pico.dtsi             | 588
> +++++++++++++++++++++++++++++++
> board/technexion/pico-imx7d/pico-imx7d.c | 105 +-----
> configs/pico-pi-imx7d_defconfig          |  17 +-
> include/configs/pico-imx7d.h             |  11 - 6 files changed, 726
> insertions(+), 100 deletions(-) create mode 100644
> arch/arm/dts/imx7d-pico-pi.dts create mode 100644
> arch/arm/dts/imx7d-pico.dtsi
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190122/e890ca77/attachment.sig>

[U-Boot] [RFC 0/9] Convert Pico-Pi i.MX7D to DM

[Joris Offouga]

Hi all, 

Pinctrl, GPIO, I2C, MMC, ETH are converted.

Convert PMIC is the same of warp7 but i have a some erros, si this log :
U-Boot SPL 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49 +0100)
Trying to boot from USB SDP
SDP: initialize...
SDP: handle requests...
Downloading file of size 556397 to 0x877fffc0... done
Jumping to header at 0x877fffc0
Header Tag is not an IMX image

U-Boot 2019.01-00197-ga524e5d-dirty (Jan 20 2019 - 21:09:49 +0100)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 43C
Reset cause: POR
Model: TechNexion PICO-IMX7D Board and PI baseboard
Board: i.MX7D PICOSOM
DRAM:  512 MiB
read error from device: 9df65458 register: 0x3!
PMIC:  PFUZE3000 DEV_ID=0x0 REV_ID=0xfffffffb
read error from device: 9df65458 register: 0x69!
write error to device: 9df65458 register: 0x23!
write error to device: 9df65458 register: 0x31!
write error to device: 9df65458 register: 0x21!
write error to device: 9df65458 register: 0x2f!
read error from device: 9df65458 register: 0x2e!
write error to device: 9df65458 register: 0x2e!
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
Loading Environment from MMC... OK
In:    serial at 30a70000
Out:   serial at 30a70000
Err:   serial at 30a70000
Net:   
Warning: ethernet at 30be0000 using MAC address from ROM
eth0: ethernet at 30be0000
Hit any key to stop autoboot:  0

USB is convert but update u-boot with dfu log a error :

=> dfu 0 mmc 0
Request would exceed designated area!
#Deferred dfu_flush() failed!=>

Thanks a advance for your help.

Best Regards, 

Joris Offouga

Joris Offouga (9):
  Arm: dts: imx7d-pico: Import Linux pico-pi dts
  Arm: imx7d-pico: Add DT file hooks
  pico-pi-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
  arm: imx7d-pico-pi: Convert to DM MMC initialization
  pico-pi-imx7d: defconfig: Switch to DM for I2C
  pico-imx7d-pico: defconfig: Switch to DM for UART
  pico-imx7d: Convert to DM PMIC
  arm: pico-pi-imx7d: Convert to DM USB
  pico-imx7d: Convert to DM Ethernet

 arch/arm/dts/Makefile                    |   3 +-
 arch/arm/dts/imx7d-pico-pi.dts           | 102 ++++++
 arch/arm/dts/imx7d-pico.dtsi             | 588 +++++++++++++++++++++++++++++++
 board/technexion/pico-imx7d/pico-imx7d.c | 105 +-----
 configs/pico-pi-imx7d_defconfig          |  17 +-
 include/configs/pico-imx7d.h             |  11 -
 6 files changed, 726 insertions(+), 100 deletions(-)
 create mode 100644 arch/arm/dts/imx7d-pico-pi.dts
 create mode 100644 arch/arm/dts/imx7d-pico.dtsi

-- 
2.7.4