[PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Lucas Stach]

The GPCv2 sits between most of the peripherals and the GIC and
functions as a wakeup controller for the CPU cores.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d25ab50d6b88..ff56451bfd27 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -11,8 +11,7 @@
 #include "imx8mq-pinfunc.h"
 
 / {
-	/* This should really be the GPC, but we need a driver for this first */
-	interrupt-parent = <&gic>;
+	interrupt-parent = <&gpc>;
 
 	#address-cells = <2>;
 	#size-cells = <2>;
@@ -257,6 +256,9 @@
 			gpc: gpc@303a0000 {
 				compatible = "fsl,imx8mq-gpc";
 				reg = <0x303a0000 0x10000>;
+				interrupt-parent = <&gic>;
+				interrupt-controller;
+				#interrupt-cells = <3>;
 
 				pgc {
 					#address-cells = <1>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] arm64: imx8mq: select GPCv2 irqchip driver

[Lucas Stach]

The system is unable to boot without this driver being present,
as most of the peripherals are connected to this IRQ controller.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm64/Kconfig.platforms | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index bb0d78d1ca4d..e9ce095af6c7 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -149,6 +149,7 @@ config ARCH_MXC
 	select CONFIG_PM
 	select PM_GENERIC_DOMAINS
 	select IMX_GPCV2_PM_DOMAINS
+	select IMX_GPCV2
 	help
 	  This enables support for the ARMv8 based SoCs in the
 	  NXP i.MX family.
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: imx8mq: select GPCv2 irqchip driver

[Fabio Estevam]

Hi Lucas,

On Tue, Jan 15, 2019 at 9:05 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> The system is unable to boot without this driver being present,
> as most of the peripherals are connected to this IRQ controller.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm64/Kconfig.platforms | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index bb0d78d1ca4d..e9ce095af6c7 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -149,6 +149,7 @@ config ARCH_MXC
>         select CONFIG_PM
>         select PM_GENERIC_DOMAINS
>         select IMX_GPCV2_PM_DOMAINS
> +       select IMX_GPCV2

This one does not apply against Shawn's tree or linux-next.

Please respin it and you can add:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Shawn Guo]

On Tue, Jan 15, 2019 at 12:04:45PM +0100, Lucas Stach wrote:
> The GPCv2 sits between most of the peripherals and the GIC and
> functions as a wakeup controller for the CPU cores.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied this one, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Shawn Guo]

On Wed, Jan 16, 2019 at 06:51:39PM +0800, Shawn Guo wrote:
> On Tue, Jan 15, 2019 at 12:04:45PM +0100, Lucas Stach wrote:
> > The GPCv2 sits between most of the peripherals and the GIC and
> > functions as a wakeup controller for the CPU cores.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> 
> Applied this one, thanks.

It seems that applying this patch alone causes trouble for people
playing -next.  So dropped it for now.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Fabio Estevam]

Hi Daniel,

On Mon, Jan 21, 2019 at 3:25 PM Daniel Baluta <daniel.baluta@nxp.com> wrote:

> Hi Fabio,
>
> Your patch helps.

Thanks for testing. I will send it as a formal patch.

> Now the console works. Anyhow, it seems that now there
> is a problem with the network card.
>
> [    0.831454] mdio_bus 30be0000.ethernet-1:00: error -2 loading PHY driver module for ID 0x004dd074
> [    0.840796] fec 30be0000.ethernet: Dropping the link to regulator.0
> [    0.847212] fec: probe of 30be0000.ethernet failed with error -2
>
> Booting fails now because kernel isn't able to mount to nfs rootfs.
>
> [  111.652134] VFS: Unable to mount root fs via NFS, trying floppy.
> [  111.658510] VFS: Cannot open root device "nfs" or unknown-block(2,0): error -6
>
> This problem is similar with the one met on i.MX 8QXP.

Does this patch help?
https://www.spinics.net/lists/netdev/msg545573.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Lucas Stach]

Am Montag, den 21.01.2019, 15:30 -0200 schrieb Fabio Estevam:
> Hi Daniel,
> 
> > On Mon, Jan 21, 2019 at 3:25 PM Daniel Baluta <daniel.baluta@nxp.com> wrote:
> 
> > Hi Fabio,
> > 
> > Your patch helps.
> 
> Thanks for testing. I will send it as a formal patch.

If you look closely that's exactly the patch 2/2 from this series.

Regards,
Lucas

> 
> > Now the console works. Anyhow, it seems that now there
> > is a problem with the network card.
> > 
> > [    0.831454] mdio_bus 30be0000.ethernet-1:00: error -2 loading PHY driver module for ID 0x004dd074
> > [    0.840796] fec 30be0000.ethernet: Dropping the link to regulator.0
> > [    0.847212] fec: probe of 30be0000.ethernet failed with error -2
> > 
> > Booting fails now because kernel isn't able to mount to nfs rootfs.
> > 
> > [  111.652134] VFS: Unable to mount root fs via NFS, trying floppy.
> > [  111.658510] VFS: Cannot open root device "nfs" or unknown-block(2,0): error -6
> > 
> > This problem is similar with the one met on i.MX 8QXP.
> 
> Does this patch help?
> https://www.spinics.net/lists/netdev/msg545573.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Fabio Estevam]

Hi Lucas,

On Mon, Jan 21, 2019 at 3:31 PM Lucas Stach <l.stach@pengutronix.de> wrote:

> If you look closely that's exactly the patch 2/2 from this series.

Oh, that's true :-)

After your patch gets applied I will also make the mx8m pinctrl driver
to be selected.

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Lucas Stach]

Am Montag, den 21.01.2019, 15:34 -0200 schrieb Fabio Estevam:
> Hi Lucas,
> 
> > On Mon, Jan 21, 2019 at 3:31 PM Lucas Stach <l.stach@pengutronix.de> wrote:
> 
> > If you look closely that's exactly the patch 2/2 from this series.
> 
> Oh, that's true :-)
> 
> After your patch gets applied I will also make the mx8m pinctrl driver
> to be selected.

I guess the judges are still out on whether this should only be enabled
in the defconfig or selected from the (really broad) ARCH_MXC symbol. 

My preference is also to have the select, but that means we my end up
with a lot of drivers force-enabled that may not be relevant for the
SoC the kernel is configured to run on. Like all the i.MX8M stuff being
useless on i.MX8X.

Regards,
Lucas 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Daniel Baluta]

On Mon, 2019-01-21 at 18:31 +0100, Lucas Stach wrote:
> Am Montag, den 21.01.2019, 15:30 -0200 schrieb Fabio Estevam:
> > Hi Daniel,
> > 
> > > On Mon, Jan 21, 2019 at 3:25 PM Daniel Baluta <
> > > daniel.baluta@nxp.com> wrote:
> > > Hi Fabio,
> > > 
> > > Your patch helps.
> > 
> > Thanks for testing. I will send it as a formal patch.
> 
> If you look closely that's exactly the patch 2/2 from this series.
> 
> Regards,
> Lucas
> 
> > 
> > > Now the console works. Anyhow, it seems that now there
> > > is a problem with the network card.
> > > 
> > > [    0.831454] mdio_bus 30be0000.ethernet-1:00: error -2 loading
> > > PHY driver module for ID 0x004dd074
> > > [    0.840796] fec 30be0000.ethernet: Dropping the link to
> > > regulator.0
> > > [    0.847212] fec: probe of 30be0000.ethernet failed with error
> > > -2
> > > 
> > > Booting fails now because kernel isn't able to mount to nfs
> > > rootfs.
> > > 
> > > [  111.652134] VFS: Unable to mount root fs via NFS, trying
> > > floppy.
> > > [  111.658510] VFS: Cannot open root device "nfs" or unknown-
> > > block(2,0): error -6
> > > 
> > > This problem is similar with the one met on i.MX 8QXP.
> > 
> > Does this patch help?
> > 
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg545573.html&amp;data=02%7C01%7Cdaniel.baluta%40nxp.com%7Cb3055410508f4333003b08d67fc64cc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636836887005112836&amp;sdata=7qSMs76%2B%2Fjdgeu0VWvrj36gTx%2B1tXPLwN8ZoYYmAeLE%3D&amp;reserved=0

Yes, with this patch and 2/2 i.mx8m boots fine.

So, Mani I think this should also fix the problem on i.MX8 QXP.

Can you give it a try?

To sum up you need these two patches:

1) https://www.spinics.net/lists/netdev/msg545573.html

2) https://patchwork.codeaurora.org/patch/700169/

thanks,
Daniel.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Daniel Baluta]

On Mon, 2019-01-21 at 19:59 +0200, Daniel Baluta wrote:
> On Mon, 2019-01-21 at 18:31 +0100, Lucas Stach wrote:
> > Am Montag, den 21.01.2019, 15:30 -0200 schrieb Fabio Estevam:
> > > Hi Daniel,
> > > 
> > > > On Mon, Jan 21, 2019 at 3:25 PM Daniel Baluta <
> > > > daniel.baluta@nxp.com> wrote:
> > > > Hi Fabio,
> > > > 
> > > > Your patch helps.
> > > 
> > > Thanks for testing. I will send it as a formal patch.
> > 
> > If you look closely that's exactly the patch 2/2 from this series.
> > 
> > Regards,
> > Lucas
> > 
> > > 
> > > > Now the console works. Anyhow, it seems that now there
> > > > is a problem with the network card.
> > > > 
> > > > [    0.831454] mdio_bus 30be0000.ethernet-1:00: error -2
> > > > loading
> > > > PHY driver module for ID 0x004dd074
> > > > [    0.840796] fec 30be0000.ethernet: Dropping the link to
> > > > regulator.0
> > > > [    0.847212] fec: probe of 30be0000.ethernet failed with
> > > > error
> > > > -2
> > > > 
> > > > Booting fails now because kernel isn't able to mount to nfs
> > > > rootfs.
> > > > 
> > > > [  111.652134] VFS: Unable to mount root fs via NFS, trying
> > > > floppy.
> > > > [  111.658510] VFS: Cannot open root device "nfs" or unknown-
> > > > block(2,0): error -6
> > > > 
> > > > This problem is similar with the one met on i.MX 8QXP.
> > > 
> > > Does this patch help?
> > > 
> 
> 
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg545573.html&amp;data=02%7C01%7Cdaniel.baluta%40nxp.com%7Cb3055410508f4333003b08d67fc64cc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636836887005112836&amp;sdata=7qSMs76%2B%2Fjdgeu0VWvrj36gTx%2B1tXPLwN8ZoYYmAeLE%3D&amp;reserved=0
> 
> Yes, with this patch and 2/2 i.mx8m boots fine.
> 
> So, Mani I think this should also fix the problem on i.MX8 QXP.
> 
> Can you give it a try?
> 
> To sum up you need these two patches:
> 
> 1) https://www.spinics.net/lists/netdev/msg545573.html
> 
> 2) https://patchwork.codeaurora.org/patch/700169/
> 

Also, Fabio super thanks for your help! You saved us some 
long debugging hours! :)




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Manivannan Sadhasivam]

Hi Daniel,

On Mon, Jan 21, 2019 at 05:59:42PM +0000, Daniel Baluta wrote:
> On Mon, 2019-01-21 at 18:31 +0100, Lucas Stach wrote:
> > Am Montag, den 21.01.2019, 15:30 -0200 schrieb Fabio Estevam:
> > > Hi Daniel,
> > > 
> > > > On Mon, Jan 21, 2019 at 3:25 PM Daniel Baluta <
> > > > daniel.baluta@nxp.com> wrote:
> > > > Hi Fabio,
> > > > 
> > > > Your patch helps.
> > > 
> > > Thanks for testing. I will send it as a formal patch.
> > 
> > If you look closely that's exactly the patch 2/2 from this series.
> > 
> > Regards,
> > Lucas
> > 
> > > 
> > > > Now the console works. Anyhow, it seems that now there
> > > > is a problem with the network card.
> > > > 
> > > > [    0.831454] mdio_bus 30be0000.ethernet-1:00: error -2 loading
> > > > PHY driver module for ID 0x004dd074
> > > > [    0.840796] fec 30be0000.ethernet: Dropping the link to
> > > > regulator.0
> > > > [    0.847212] fec: probe of 30be0000.ethernet failed with error
> > > > -2
> > > > 
> > > > Booting fails now because kernel isn't able to mount to nfs
> > > > rootfs.
> > > > 
> > > > [  111.652134] VFS: Unable to mount root fs via NFS, trying
> > > > floppy.
> > > > [  111.658510] VFS: Cannot open root device "nfs" or unknown-
> > > > block(2,0): error -6
> > > > 
> > > > This problem is similar with the one met on i.MX 8QXP.
> > > 
> > > Does this patch help?
> > > 
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg545573.html&amp;data=02%7C01%7Cdaniel.baluta%40nxp.com%7Cb3055410508f4333003b08d67fc64cc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636836887005112836&amp;sdata=7qSMs76%2B%2Fjdgeu0VWvrj36gTx%2B1tXPLwN8ZoYYmAeLE%3D&amp;reserved=0
> 
> Yes, with this patch and 2/2 i.mx8m boots fine.
> 

Thanks for sharing the patches!

> So, Mani I think this should also fix the problem on i.MX8 QXP.
> 
> Can you give it a try?
> 
> To sum up you need these two patches:
> 
> 1) https://www.spinics.net/lists/netdev/msg545573.html
> 
> 2) https://patchwork.codeaurora.org/patch/700169/
> 

My issue was not related to above mentioned patches but anyhow I solved
it using the kernel command line parameters you gave. Regarding NFS, I'm
not close yet to have network support on my board. Will give it a shot
once I add onboard Ethernet/WiFi support.

Thanks once again!

Regards,
Mani

> thanks,
> Daniel.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8mq: properly describe IRQ hierarchy

[Manivannan Sadhasivam]

Hi Daniel,

On Tue, Jan 22, 2019 at 09:11:29AM +0530, Manivannan Sadhasivam wrote:
> Hi Daniel,
> 
> On Mon, Jan 21, 2019 at 05:59:42PM +0000, Daniel Baluta wrote:
> > On Mon, 2019-01-21 at 18:31 +0100, Lucas Stach wrote:
> > > Am Montag, den 21.01.2019, 15:30 -0200 schrieb Fabio Estevam:
> > > > Hi Daniel,
> > > > 
> > > > > On Mon, Jan 21, 2019 at 3:25 PM Daniel Baluta <
> > > > > daniel.baluta@nxp.com> wrote:
> > > > > Hi Fabio,
> > > > > 
> > > > > Your patch helps.
> > > > 
> > > > Thanks for testing. I will send it as a formal patch.
> > > 
> > > If you look closely that's exactly the patch 2/2 from this series.
> > > 
> > > Regards,
> > > Lucas
> > > 
> > > > 
> > > > > Now the console works. Anyhow, it seems that now there
> > > > > is a problem with the network card.
> > > > > 
> > > > > [    0.831454] mdio_bus 30be0000.ethernet-1:00: error -2 loading
> > > > > PHY driver module for ID 0x004dd074
> > > > > [    0.840796] fec 30be0000.ethernet: Dropping the link to
> > > > > regulator.0
> > > > > [    0.847212] fec: probe of 30be0000.ethernet failed with error
> > > > > -2
> > > > > 
> > > > > Booting fails now because kernel isn't able to mount to nfs
> > > > > rootfs.
> > > > > 
> > > > > [  111.652134] VFS: Unable to mount root fs via NFS, trying
> > > > > floppy.
> > > > > [  111.658510] VFS: Cannot open root device "nfs" or unknown-
> > > > > block(2,0): error -6
> > > > > 
> > > > > This problem is similar with the one met on i.MX 8QXP.
> > > > 
> > > > Does this patch help?
> > > > 
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg545573.html&amp;data=02%7C01%7Cdaniel.baluta%40nxp.com%7Cb3055410508f4333003b08d67fc64cc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636836887005112836&amp;sdata=7qSMs76%2B%2Fjdgeu0VWvrj36gTx%2B1tXPLwN8ZoYYmAeLE%3D&amp;reserved=0
> > 
> > Yes, with this patch and 2/2 i.mx8m boots fine.
> > 
> 
> Thanks for sharing the patches!
> 
> > So, Mani I think this should also fix the problem on i.MX8 QXP.
> > 
> > Can you give it a try?
> > 
> > To sum up you need these two patches:
> > 
> > 1) https://www.spinics.net/lists/netdev/msg545573.html
> > 

Just tested the above patch and it fixes the PHY driver issue on my
IMX8QXP board.

Thanks,
Mani

> > 2) https://patchwork.codeaurora.org/patch/700169/
> > 
> 
> My issue was not related to above mentioned patches but anyhow I solved
> it using the kernel command line parameters you gave. Regarding NFS, I'm
> not close yet to have network support on my board. Will give it a shot
> once I add onboard Ethernet/WiFi support.
> 
> Thanks once again!
> 
> Regards,
> Mani
> 
> > thanks,
> > Daniel.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel