From: Chris Wilson <chris@chris-wilson.co.uk>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v8 4/7] drm/i915: use a macro to define MOCS entries
Date: Tue, 22 Jan 2019 21:37:02 +0000 [thread overview]
Message-ID: <154819302240.693.17503698005476212636@skylake-alporthouse-com> (raw)
In-Reply-To: <CAKi4VAK+WqspnLO7JXA=Kp6S78YPMv2=aUY=Ri8ha4JJZ6d2mw@mail.gmail.com>
Quoting Lucas De Marchi (2019-01-22 21:33:25)
> On Tue, Jan 22, 2019 at 6:32 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Lucas De Marchi (2019-01-22 05:12:24)
> > > Let's use a macro to make tables smaller and at the same time allow us
> > > to add fields that apply to all entries in future.
> > >
> > > For the sake of readability, I'm calling an exception on 80 chars limit.
> > > Lines are aligned for easy comparison of the entry values.
> >
> > > + MOCS_ENTRY(I915_MOCS_UNCACHED, LE_1_UC | LE_TC_2_LLC_ELLC, \
> > > + L3_1_UC), \
> >
> > MOCS_ENTRY(I915_MOCS_UNCACHED,
> > LE_1_UC | LE_TC_2_LLC_ELLC, L3_1_UC), \
>
> My intention was to split the lines for each *value*, so it's easy to
> see what control_value vs l3cc_value is set to
> (too difficult to spot mistakes on adding a comma rather than a |).
>
> But I'm not strongly against your version, so I'll switch to that.
Have another new line :)
Because you are right as I confused that \ for a |.
MOCS_ENTRY(I915_MOCS_UNCACHED, \
LE_1_UC | LE_TC_2_LLC_ELLC, \
L3_1_UC), \
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-22 21:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 5:12 [PATCH v8 0/7] Define MOCS table for Icelake Lucas De Marchi
2019-01-22 5:12 ` [PATCH v8 1/7] drm/i915: initialize unused MOCS entries to PTE Lucas De Marchi
2019-01-22 14:28 ` Chris Wilson
2019-01-23 18:33 ` Lis, Tomasz
2019-01-23 18:39 ` Lucas De Marchi
2019-01-22 5:12 ` [PATCH v8 2/7] drm/i915: Simplify MOCS table definition Lucas De Marchi
2019-01-23 18:34 ` Lis, Tomasz
2019-01-22 5:12 ` [PATCH v8 3/7] drm/i915/skl: Rework MOCS tables to keep common part in a define Lucas De Marchi
2019-01-22 14:30 ` Chris Wilson
2019-01-23 18:34 ` Lis, Tomasz
2019-01-22 5:12 ` [PATCH v8 4/7] drm/i915: use a macro to define MOCS entries Lucas De Marchi
2019-01-22 14:32 ` Chris Wilson
2019-01-22 21:33 ` Lucas De Marchi
2019-01-22 21:37 ` Chris Wilson [this message]
2019-01-23 18:51 ` Lucas De Marchi
2019-01-23 18:43 ` Lis, Tomasz
2019-01-22 5:12 ` [PATCH v8 5/7] drm/i915: keep track of used entries in MOCS table Lucas De Marchi
2019-01-22 14:40 ` Chris Wilson
2019-01-23 21:50 ` Lucas De Marchi
2019-01-23 18:48 ` Lis, Tomasz
2019-01-22 5:12 ` [PATCH v8 6/7] drm/i915: cache number of MOCS entries Lucas De Marchi
2019-01-22 14:34 ` Chris Wilson
2019-01-23 19:02 ` Lis, Tomasz
2019-01-22 5:12 ` [PATCH v8 7/7] drm/i915/icl: Define MOCS table for Icelake Lucas De Marchi
2019-01-23 19:07 ` Lis, Tomasz
2019-01-22 5:22 ` ✗ Fi.CI.CHECKPATCH: warning for Define MOCS table for Icelake (rev2) Patchwork
2019-01-22 5:40 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-22 6:49 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154819302240.693.17503698005476212636@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.