* [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay
@ 2019-01-23 12:05 ` Chaotian Jing
0 siblings, 0 replies; 5+ messages in thread
From: Chaotian Jing @ 2019-01-23 12:05 UTC (permalink / raw)
To: Ulf Hansson
Cc: Matthias Brugger, Chaotian Jing, Ryder Lee, Yong Mao, jjian zhou,
Sean Wang, linux-mmc, linux-arm-kernel, linux-mediatek,
linux-kernel, srv_heupstream
to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
register.
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 8afeaf8..833ef05 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
if (timing == MMC_TIMING_MMC_HS400 &&
host->dev_comp->hs400_tune)
- sdr_set_field(host->base + PAD_CMD_TUNE,
+ sdr_set_field(host->base + tune_reg,
MSDC_PAD_TUNE_CMDRRDLY,
host->hs400_cmd_int_delay);
dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay
@ 2019-01-23 12:05 ` Chaotian Jing
0 siblings, 0 replies; 5+ messages in thread
From: Chaotian Jing @ 2019-01-23 12:05 UTC (permalink / raw)
To: Ulf Hansson
Cc: Matthias Brugger, Chaotian Jing, Ryder Lee, Yong Mao, jjian zhou,
Sean Wang, linux-mmc, linux-arm-kernel, linux-mediatek,
linux-kernel, srv_heupstream
to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
register.
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 8afeaf8..833ef05 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
if (timing == MMC_TIMING_MMC_HS400 &&
host->dev_comp->hs400_tune)
- sdr_set_field(host->base + PAD_CMD_TUNE,
+ sdr_set_field(host->base + tune_reg,
MSDC_PAD_TUNE_CMDRRDLY,
host->hs400_cmd_int_delay);
dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay
@ 2019-01-23 12:05 ` Chaotian Jing
0 siblings, 0 replies; 5+ messages in thread
From: Chaotian Jing @ 2019-01-23 12:05 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-arm-kernel, Ryder Lee, srv_heupstream, Sean Wang,
linux-mmc, linux-kernel, Yong Mao, linux-mediatek, Chaotian Jing,
Matthias Brugger, jjian zhou
to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
register.
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 8afeaf8..833ef05 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
if (timing == MMC_TIMING_MMC_HS400 &&
host->dev_comp->hs400_tune)
- sdr_set_field(host->base + PAD_CMD_TUNE,
+ sdr_set_field(host->base + tune_reg,
MSDC_PAD_TUNE_CMDRRDLY,
host->hs400_cmd_int_delay);
dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
--
1.8.1.1.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay
2019-01-23 12:05 ` Chaotian Jing
@ 2019-01-28 12:03 ` Ulf Hansson
-1 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2019-01-28 12:03 UTC (permalink / raw)
To: Chaotian Jing
Cc: Matthias Brugger, Ryder Lee, Yong Mao, jjian zhou, Sean Wang,
linux-mmc, Linux ARM, linux-mediatek, Linux Kernel Mailing List,
srv_heupstream
On Wed, 23 Jan 2019 at 13:05, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>
> to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
> register.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
Applied for fixes, adding a fixes+stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 8afeaf8..833ef05 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
>
> if (timing == MMC_TIMING_MMC_HS400 &&
> host->dev_comp->hs400_tune)
> - sdr_set_field(host->base + PAD_CMD_TUNE,
> + sdr_set_field(host->base + tune_reg,
> MSDC_PAD_TUNE_CMDRRDLY,
> host->hs400_cmd_int_delay);
> dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
> --
> 1.8.1.1.dirty
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay
@ 2019-01-28 12:03 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2019-01-28 12:03 UTC (permalink / raw)
To: Chaotian Jing
Cc: Ryder Lee, srv_heupstream, Sean Wang, linux-mmc,
Linux Kernel Mailing List, Yong Mao, linux-mediatek, Linux ARM,
Matthias Brugger, jjian zhou
On Wed, 23 Jan 2019 at 13:05, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>
> to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
> register.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
Applied for fixes, adding a fixes+stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 8afeaf8..833ef05 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
>
> if (timing == MMC_TIMING_MMC_HS400 &&
> host->dev_comp->hs400_tune)
> - sdr_set_field(host->base + PAD_CMD_TUNE,
> + sdr_set_field(host->base + tune_reg,
> MSDC_PAD_TUNE_CMDRRDLY,
> host->hs400_cmd_int_delay);
> dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
> --
> 1.8.1.1.dirty
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-28 12:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 12:05 [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay Chaotian Jing
2019-01-23 12:05 ` Chaotian Jing
2019-01-23 12:05 ` Chaotian Jing
2019-01-28 12:03 ` Ulf Hansson
2019-01-28 12:03 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.