* : [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream
@ 2019-01-28 10:20 Meng.Li
2019-01-28 10:20 ` [PATCH] " Meng.Li
2019-01-29 18:20 ` [yocto] " Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Meng.Li @ 2019-01-28 10:20 UTC (permalink / raw)
To: richard.purdie; +Cc: yocto, poky
From: Limeng <Meng.Li@windriver.com>
Hi Richard,
Could you please help to merge this patch into meta/recipes-bsp/u-boot, branch is master?
There are 2 CVE issues fixing in latest u-boot upstream, so
update commit id to involve these fixing patches.
thanks,
Limeng
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] u-boot: update commit id to the latest one of u-boot upstream
2019-01-28 10:20 : [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream Meng.Li
@ 2019-01-28 10:20 ` Meng.Li
2019-01-28 11:09 ` [yocto] " Alexander Kanavin
2019-01-29 18:20 ` [yocto] " Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Meng.Li @ 2019-01-28 10:20 UTC (permalink / raw)
To: richard.purdie; +Cc: yocto, poky
From: MengLi <meng.li@windriver.com>
There are 2 CVE issues fixing in latest u-boot upstream, so
update commit id to involve these fixing patches.
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
meta/recipes-bsp/u-boot/u-boot-common.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/u-boot/u-boot-common.inc b/meta/recipes-bsp/u-boot/u-boot-common.inc
index 6f4a10b..3648d47 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common.inc
@@ -8,7 +8,7 @@ PE = "1"
# We use the revision in order to avoid having to fetch it from the
# repo during parse
-SRCREV = "0157013f4a4945bbdb70bb4d98d680e0845fd784"
+SRCREV = "d01806a8fcbdaedcc67cead56ece572021d97ab7"
SRC_URI = "git://git.denx.de/u-boot.git"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] u-boot: update commit id to the latest one of u-boot upstream
2019-01-28 10:20 ` [PATCH] " Meng.Li
@ 2019-01-28 11:09 ` Alexander Kanavin
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kanavin @ 2019-01-28 11:09 UTC (permalink / raw)
To: Meng.Li; +Cc: Yocto discussion list, Poky Project
On Mon, 28 Jan 2019 at 11:20, <Meng.Li@windriver.com> wrote:
> There are 2 CVE issues fixing in latest u-boot upstream, so
> update commit id to involve these fixing patches.
We generally don't update commit id's to something random, as that
means picking a source tree in the middle of a development cycle. If
you want to update a component, please use a commit that has a version
tag attached to it.
Also, the patch needs to go to oe-core mailing list.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] [PATCH] u-boot: update commit id to the latest one of u-boot upstream
@ 2019-01-28 11:09 ` Alexander Kanavin
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kanavin @ 2019-01-28 11:09 UTC (permalink / raw)
To: Meng.Li; +Cc: Yocto discussion list, Poky Project
On Mon, 28 Jan 2019 at 11:20, <Meng.Li@windriver.com> wrote:
> There are 2 CVE issues fixing in latest u-boot upstream, so
> update commit id to involve these fixing patches.
We generally don't update commit id's to something random, as that
means picking a source tree in the middle of a development cycle. If
you want to update a component, please use a commit that has a version
tag attached to it.
Also, the patch needs to go to oe-core mailing list.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: : [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream
2019-01-28 10:20 : [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream Meng.Li
@ 2019-01-29 18:20 ` Tom Rini
2019-01-29 18:20 ` [yocto] " Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2019-01-29 18:20 UTC (permalink / raw)
To: Meng.Li; +Cc: yocto, poky
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
On Mon, Jan 28, 2019 at 06:20:02PM +0800, Meng.Li@windriver.com wrote:
> From: Limeng <Meng.Li@windriver.com>
>
> Hi Richard,
>
> Could you please help to merge this patch into meta/recipes-bsp/u-boot, branch is master?
>
> There are 2 CVE issues fixing in latest u-boot upstream, so
> update commit id to involve these fixing patches.
With my U-Boot maintainer hat on, NAK. While there are two CVEs that
have been addressed now (and present for a long while) I would say both:
- The issues themselves are not so catastrophic that you should move to
a pre-release (I haven't even tagged v2019.04-rc1 yet!) to get them
nor blindly back-port the changes. I intentionally didn't apply them
to the last release as I expected unintended consequences. Surprise!
There have been unintended consequences of those changes and I haven't
pulled in the changes for that just yet.
- Even once the patches to address the CVEs are addressed, I don't see
why you would move to "top of tree" rather than as is normal practice
backport the changes. Simon's fix here is a clear series in patchwork
(as well as git history) to apply as needed, if after evaluating the
CVEs it's something that you feel should be addressed in this way and
not with the workaround (telling U-Boot to load at most $X bytes).
Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] : [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream
@ 2019-01-29 18:20 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2019-01-29 18:20 UTC (permalink / raw)
To: Meng.Li; +Cc: yocto, poky
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
On Mon, Jan 28, 2019 at 06:20:02PM +0800, Meng.Li@windriver.com wrote:
> From: Limeng <Meng.Li@windriver.com>
>
> Hi Richard,
>
> Could you please help to merge this patch into meta/recipes-bsp/u-boot, branch is master?
>
> There are 2 CVE issues fixing in latest u-boot upstream, so
> update commit id to involve these fixing patches.
With my U-Boot maintainer hat on, NAK. While there are two CVEs that
have been addressed now (and present for a long while) I would say both:
- The issues themselves are not so catastrophic that you should move to
a pre-release (I haven't even tagged v2019.04-rc1 yet!) to get them
nor blindly back-port the changes. I intentionally didn't apply them
to the last release as I expected unintended consequences. Surprise!
There have been unintended consequences of those changes and I haven't
pulled in the changes for that just yet.
- Even once the patches to address the CVEs are addressed, I don't see
why you would move to "top of tree" rather than as is normal practice
backport the changes. Simon's fix here is a clear series in patchwork
(as well as git history) to apply as needed, if after evaluating the
CVEs it's something that you feel should be addressed in this way and
not with the workaround (telling U-Boot to load at most $X bytes).
Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-29 18:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28 10:20 : [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream Meng.Li
2019-01-28 10:20 ` [PATCH] " Meng.Li
2019-01-28 11:09 ` Alexander Kanavin
2019-01-28 11:09 ` [yocto] " Alexander Kanavin
2019-01-29 18:20 ` : [meta]: [recipes-bsp]: " Tom Rini
2019-01-29 18:20 ` [yocto] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.