From: Stephen Boyd <sboyd@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>, jbrunet@baylibre.com
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: meson: Add G12A AO Clock + Reset Controller
Date: Tue, 05 Feb 2019 14:18:21 -0800 [thread overview]
Message-ID: <154940510132.169292.12584338453129084603@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190204091331.9298-3-narmstrong@baylibre.com>
Quoting Neil Armstrong (2019-02-04 01:13:30)
> + * Register offsets from the data sheet must be multiplied by 4.
> + */
> +#define AO_RTI_STATUS_REG3 0x0C
> +#define AO_RTI_PWR_CNTL_REG0 0x10
> +#define AO_RTI_GEN_CNTL_REG0 0x40
> +#define AO_CLK_GATE0 0x4c
> +#define AO_CLK_GATE0_SP 0x50
> +#define AO_OSCIN_CNTL 0x58
> +#define AO_CEC_CLK_CNTL_REG0 0x74
> +#define AO_CEC_CLK_CNTL_REG1 0x78
> +#define AO_SAR_CLK 0x90
> +#define AO_RTC_ALT_CLK_CNTL0 0x94
> +#define AO_RTC_ALT_CLK_CNTL1 0x98
> +
> +#define AXG_AO_GATE(_name, _reg, _bit) \
> +static struct clk_regmap g12a_aoclk_##_name = { \
> + .data = &(struct clk_regmap_gate_data) { \
> + .offset = (_reg), \
> + .bit_idx = (_bit), \
> + }, \
> + .hw.init = &(struct clk_init_data) { \
> + .name = "g12a_ao_" #_name, \
> + .ops = &clk_regmap_gate_ops, \
> + .parent_names = (const char *[]){ IN_PREFIX "mpeg-clk" }, \
> + .num_parents = 1, \
> + .flags = CLK_IGNORE_UNUSED, \
Can you please add a comment explaining why CLK_IGNORE_UNUSED is here?
It will help future readers know what's going on with this special flag.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 2/2] clk: meson: Add G12A AO Clock + Reset Controller
Date: Tue, 05 Feb 2019 14:18:21 -0800 [thread overview]
Message-ID: <154940510132.169292.12584338453129084603@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190204091331.9298-3-narmstrong@baylibre.com>
Quoting Neil Armstrong (2019-02-04 01:13:30)
> + * Register offsets from the data sheet must be multiplied by 4.
> + */
> +#define AO_RTI_STATUS_REG3 0x0C
> +#define AO_RTI_PWR_CNTL_REG0 0x10
> +#define AO_RTI_GEN_CNTL_REG0 0x40
> +#define AO_CLK_GATE0 0x4c
> +#define AO_CLK_GATE0_SP 0x50
> +#define AO_OSCIN_CNTL 0x58
> +#define AO_CEC_CLK_CNTL_REG0 0x74
> +#define AO_CEC_CLK_CNTL_REG1 0x78
> +#define AO_SAR_CLK 0x90
> +#define AO_RTC_ALT_CLK_CNTL0 0x94
> +#define AO_RTC_ALT_CLK_CNTL1 0x98
> +
> +#define AXG_AO_GATE(_name, _reg, _bit) \
> +static struct clk_regmap g12a_aoclk_##_name = { \
> + .data = &(struct clk_regmap_gate_data) { \
> + .offset = (_reg), \
> + .bit_idx = (_bit), \
> + }, \
> + .hw.init = &(struct clk_init_data) { \
> + .name = "g12a_ao_" #_name, \
> + .ops = &clk_regmap_gate_ops, \
> + .parent_names = (const char *[]){ IN_PREFIX "mpeg-clk" }, \
> + .num_parents = 1, \
> + .flags = CLK_IGNORE_UNUSED, \
Can you please add a comment explaining why CLK_IGNORE_UNUSED is here?
It will help future readers know what's going on with this special flag.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 2/2] clk: meson: Add G12A AO Clock + Reset Controller
Date: Tue, 05 Feb 2019 14:18:21 -0800 [thread overview]
Message-ID: <154940510132.169292.12584338453129084603@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190204091331.9298-3-narmstrong@baylibre.com>
Quoting Neil Armstrong (2019-02-04 01:13:30)
> + * Register offsets from the data sheet must be multiplied by 4.
> + */
> +#define AO_RTI_STATUS_REG3 0x0C
> +#define AO_RTI_PWR_CNTL_REG0 0x10
> +#define AO_RTI_GEN_CNTL_REG0 0x40
> +#define AO_CLK_GATE0 0x4c
> +#define AO_CLK_GATE0_SP 0x50
> +#define AO_OSCIN_CNTL 0x58
> +#define AO_CEC_CLK_CNTL_REG0 0x74
> +#define AO_CEC_CLK_CNTL_REG1 0x78
> +#define AO_SAR_CLK 0x90
> +#define AO_RTC_ALT_CLK_CNTL0 0x94
> +#define AO_RTC_ALT_CLK_CNTL1 0x98
> +
> +#define AXG_AO_GATE(_name, _reg, _bit) \
> +static struct clk_regmap g12a_aoclk_##_name = { \
> + .data = &(struct clk_regmap_gate_data) { \
> + .offset = (_reg), \
> + .bit_idx = (_bit), \
> + }, \
> + .hw.init = &(struct clk_init_data) { \
> + .name = "g12a_ao_" #_name, \
> + .ops = &clk_regmap_gate_ops, \
> + .parent_names = (const char *[]){ IN_PREFIX "mpeg-clk" }, \
> + .num_parents = 1, \
> + .flags = CLK_IGNORE_UNUSED, \
Can you please add a comment explaining why CLK_IGNORE_UNUSED is here?
It will help future readers know what's going on with this special flag.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-02-05 22:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 9:13 [PATCH 0/2] clk: meson: Add G12A AO Clock + Reset Controller Neil Armstrong
2019-02-04 9:13 ` Neil Armstrong
2019-02-04 9:13 ` Neil Armstrong
2019-02-04 9:13 ` [PATCH 1/2] dt-bindings: clk: add G12A AO Clock and Reset Bindings Neil Armstrong
2019-02-04 9:13 ` Neil Armstrong
2019-02-04 9:13 ` Neil Armstrong
2019-02-07 15:10 ` Jerome Brunet
2019-02-07 15:10 ` Jerome Brunet
2019-02-07 15:10 ` Jerome Brunet
2019-02-07 15:10 ` Jerome Brunet
2019-02-07 20:10 ` Neil Armstrong
2019-02-07 20:10 ` Neil Armstrong
2019-02-07 20:10 ` Neil Armstrong
2019-02-04 9:13 ` [PATCH 2/2] clk: meson: Add G12A AO Clock + Reset Controller Neil Armstrong
2019-02-04 9:13 ` Neil Armstrong
2019-02-04 9:13 ` Neil Armstrong
2019-02-05 22:18 ` Stephen Boyd [this message]
2019-02-05 22:18 ` Stephen Boyd
2019-02-05 22:18 ` Stephen Boyd
2019-02-06 19:41 ` Neil Armstrong
2019-02-06 19:41 ` Neil Armstrong
2019-02-06 19:41 ` Neil Armstrong
2019-02-07 15:11 ` [PATCH 0/2] " Jerome Brunet
2019-02-07 15:11 ` Jerome Brunet
2019-02-07 15:11 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154940510132.169292.12584338453129084603@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.