All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
	Eero Tamminen <eero.t.tamminen@intel.com>,
	3.14pi@ukr.net
Subject: Re: [IGT 2/2] tools/intel_gpu_top: Add file output capability
Date: Fri, 08 Feb 2019 12:14:51 +0000	[thread overview]
Message-ID: <154962809155.3378.17136464262426711419@skylake-alporthouse-com> (raw)
In-Reply-To: <20190208120351.18505-2-tvrtko.ursulin@linux.intel.com>

Quoting Tvrtko Ursulin (2019-02-08 12:03:51)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> A new -o command switch enables logging to a file.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108689
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Cc: 3.14pi@ukr.net
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

> -       if (output_mode == INTERACTIVE && isatty(1) != 1)
> +       if (output_mode == INTERACTIVE && (output_path || isatty(1) != 1))
>                 output_mode = STDOUT;
>  
> +       if (output_path) {

if (output_path && strcmp(output_path, "-")) { ?

"-o -" is common enough for forcing output even on the terminal.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
	Eero Tamminen <eero.t.tamminen@intel.com>,
	3.14pi@ukr.net, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [IGT 2/2] tools/intel_gpu_top: Add file output capability
Date: Fri, 08 Feb 2019 12:14:51 +0000	[thread overview]
Message-ID: <154962809155.3378.17136464262426711419@skylake-alporthouse-com> (raw)
In-Reply-To: <20190208120351.18505-2-tvrtko.ursulin@linux.intel.com>

Quoting Tvrtko Ursulin (2019-02-08 12:03:51)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> A new -o command switch enables logging to a file.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108689
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Cc: 3.14pi@ukr.net
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

> -       if (output_mode == INTERACTIVE && isatty(1) != 1)
> +       if (output_mode == INTERACTIVE && (output_path || isatty(1) != 1))
>                 output_mode = STDOUT;
>  
> +       if (output_path) {

if (output_path && strcmp(output_path, "-")) { ?

"-o -" is common enough for forcing output even on the terminal.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-02-08 12:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 12:03 [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging Tvrtko Ursulin
2019-02-08 12:03 ` [igt-dev] " Tvrtko Ursulin
2019-02-08 12:03 ` [IGT 2/2] tools/intel_gpu_top: Add file output capability Tvrtko Ursulin
2019-02-08 12:03   ` [igt-dev] " Tvrtko Ursulin
2019-02-08 12:14   ` Chris Wilson [this message]
2019-02-08 12:14     ` Chris Wilson
2019-02-08 12:10 ` [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging Chris Wilson
2019-02-08 12:10   ` [igt-dev] " Chris Wilson
2019-02-08 12:29 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-02-25 10:04   ` Tvrtko Ursulin
2019-02-08 13:58 ` [IGT 1/2] " Eero Tamminen
2019-02-08 13:58   ` [igt-dev] " Eero Tamminen
2019-02-11  9:49   ` Tvrtko Ursulin
2019-02-11  9:49     ` [igt-dev] " Tvrtko Ursulin
2019-02-12  9:31     ` Eero Tamminen
2019-02-12  9:31       ` [igt-dev] " Eero Tamminen via igt-dev
2019-02-08 14:11 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
2019-02-11 11:45 [IGT 1/2] " Tvrtko Ursulin
2019-02-11 11:45 ` [IGT 2/2] tools/intel_gpu_top: Add file output capability Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154962809155.3378.17136464262426711419@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=3.14pi@ukr.net \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=eero.t.tamminen@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.