From: Frederic Chen <frederic.chen@mediatek.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@iki.fi> Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, hans.verkuil@cisco.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [RFC PATCH V0 3/7] [media] dt-bindings: mt8183: Added DIP-SMEM dt-bindings Date: Tue, 12 Feb 2019 17:50:00 +0800 [thread overview] Message-ID: <1549965000.29488.4.camel@mtksdccf07> (raw) In-Reply-To: <20190209182034.GC4505@pendragon.ideasonboard.com> Dear Laurent and Sakari, On Sat, 2019-02-09 at 20:20 +0200, Laurent Pinchart wrote: > Hello Frederic, > > On Sat, Feb 09, 2019 at 05:59:35PM +0200, Sakari Ailus wrote: > > Hi Frederic, > > > > Thanks for the patchset. > > > > Could you also cc the devicetree list, please? > > > > On Fri, Feb 01, 2019 at 07:21:27PM +0800, Frederic Chen wrote: > > > This patch adds the DT binding documentation for the shared memory > > > between DIP (Digital Image Processing) unit of the camera ISP system > > > and the co-processor in Mediatek SoCs. > > > > > > Signed-off-by: Frederic Chen <frederic.chen@mediatek.com> > > > --- > > > .../bindings/media/mediatek,dip_smem.txt | 29 ++++++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/mediatek,dip_smem.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,dip_smem.txt b/Documentation/devicetree/bindings/media/mediatek,dip_smem.txt > > > new file mode 100644 > > > index 0000000..5533721 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/mediatek,dip_smem.txt > > > @@ -0,0 +1,29 @@ > > > +Mediatek ISP Shared Memory Device > > > + > > > +Mediatek ISP Shared Memory Device is used to manage shared memory > > > +among CPU, ISP IPs and coprocessor. It is associated with a reserved > > > +memory region (Please see Documentation\devicetree\bindings\ > > > +reserved-memory\mediatek,reserve-memory-isp_smem.txt) and > > > > s/\\/\//g; > > > > > +and provide the context to allocate memory with dma addresses. > > Does this represent a real device (as in IP core) in the SoC ? There > seems to be no driver associated with the compatible string defined > herein in this patch series, what is this node used for ? It does not represent a real device. It is used for creating the DIP-specific vb2 buffer allocation context (implemented in /drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-smem-drv.c). The compatible string has been renamed as “mediatek,dip_smem” in this patch series and I will correct it in this binding document. > > > > +Required properties: > > > +- compatible: Should be "mediatek,isp_smem" > > > > s/Should/Shall/ > > > > > + > > > +- iommus: should point to the respective IOMMU block with master port > > > > s/should/shall/ > > > > > + as argument. Please set the ports which may be accessed > > > + through the common path. You can see > > > + Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > + for the detail. > > > + > > > +- mediatek,larb: must contain the local arbiters in the current Socs. > > > > Perhaps "SoCs"? > > > > > + Please set the larb of camsys for Pass 1 and imgsys for DIP, or both > > > + if you are using all the camera function. You can see > > > + Documentation/devicetree/bindings/memory-controllers/ > > > + mediatek,smi-larb.txt for the detail. > > > + > > > +Example: > > > + isp_smem: isp_smem { > > > + compatible = "mediatek,isp_smem"; > > > + mediatek,larb = <&larb5>; > > > + iommus = <&iommu M4U_PORT_CAM_IMGI>; > > > + }; > Sincerely, Frederic Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Frederic Chen <frederic.chen@mediatek.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@iki.fi> Cc: <devicetree@vger.kernel.org>, <hans.verkuil@cisco.com>, <laurent.pinchart+renesas@ideasonboard.com>, <tfiga@chromium.org>, <matthias.bgg@gmail.com>, <mchehab@kernel.org>, <linux-mediatek@lists.infradead.org>, <linux-arm-kernel@lists.infradead.org>, <Sean.Cheng@mediatek.com>, <sj.huang@mediatek.com>, <christie.yu@mediatek.com>, <holmes.chiou@mediatek.com>, <Jerry-ch.Chen@mediatek.com>, <jungo.lin@mediatek.com>, <Rynn.Wu@mediatek.com>, <linux-media@vger.kernel.org>, <srv_heupstream@mediatek.com> Subject: Re: [RFC PATCH V0 3/7] [media] dt-bindings: mt8183: Added DIP-SMEM dt-bindings Date: Tue, 12 Feb 2019 17:50:00 +0800 [thread overview] Message-ID: <1549965000.29488.4.camel@mtksdccf07> (raw) In-Reply-To: <20190209182034.GC4505@pendragon.ideasonboard.com> Dear Laurent and Sakari, On Sat, 2019-02-09 at 20:20 +0200, Laurent Pinchart wrote: > Hello Frederic, > > On Sat, Feb 09, 2019 at 05:59:35PM +0200, Sakari Ailus wrote: > > Hi Frederic, > > > > Thanks for the patchset. > > > > Could you also cc the devicetree list, please? > > > > On Fri, Feb 01, 2019 at 07:21:27PM +0800, Frederic Chen wrote: > > > This patch adds the DT binding documentation for the shared memory > > > between DIP (Digital Image Processing) unit of the camera ISP system > > > and the co-processor in Mediatek SoCs. > > > > > > Signed-off-by: Frederic Chen <frederic.chen@mediatek.com> > > > --- > > > .../bindings/media/mediatek,dip_smem.txt | 29 ++++++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/mediatek,dip_smem.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,dip_smem.txt b/Documentation/devicetree/bindings/media/mediatek,dip_smem.txt > > > new file mode 100644 > > > index 0000000..5533721 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/mediatek,dip_smem.txt > > > @@ -0,0 +1,29 @@ > > > +Mediatek ISP Shared Memory Device > > > + > > > +Mediatek ISP Shared Memory Device is used to manage shared memory > > > +among CPU, ISP IPs and coprocessor. It is associated with a reserved > > > +memory region (Please see Documentation\devicetree\bindings\ > > > +reserved-memory\mediatek,reserve-memory-isp_smem.txt) and > > > > s/\\/\//g; > > > > > +and provide the context to allocate memory with dma addresses. > > Does this represent a real device (as in IP core) in the SoC ? There > seems to be no driver associated with the compatible string defined > herein in this patch series, what is this node used for ? It does not represent a real device. It is used for creating the DIP-specific vb2 buffer allocation context (implemented in /drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-smem-drv.c). The compatible string has been renamed as “mediatek,dip_smem” in this patch series and I will correct it in this binding document. > > > > +Required properties: > > > +- compatible: Should be "mediatek,isp_smem" > > > > s/Should/Shall/ > > > > > + > > > +- iommus: should point to the respective IOMMU block with master port > > > > s/should/shall/ > > > > > + as argument. Please set the ports which may be accessed > > > + through the common path. You can see > > > + Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > + for the detail. > > > + > > > +- mediatek,larb: must contain the local arbiters in the current Socs. > > > > Perhaps "SoCs"? > > > > > + Please set the larb of camsys for Pass 1 and imgsys for DIP, or both > > > + if you are using all the camera function. You can see > > > + Documentation/devicetree/bindings/memory-controllers/ > > > + mediatek,smi-larb.txt for the detail. > > > + > > > +Example: > > > + isp_smem: isp_smem { > > > + compatible = "mediatek,isp_smem"; > > > + mediatek,larb = <&larb5>; > > > + iommus = <&iommu M4U_PORT_CAM_IMGI>; > > > + }; > Sincerely, Frederic Chen
next prev parent reply other threads:[~2019-02-12 9:50 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-01 11:21 [RFC PATCH V0 0/7] media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` [RFC PATCH V0 1/7] [media] dt-bindings: mt8183: Add binding for DIP shared memory Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-09 15:59 ` Sakari Ailus 2019-02-09 15:59 ` Sakari Ailus 2019-02-09 15:59 ` Sakari Ailus 2019-02-09 18:17 ` Laurent Pinchart 2019-02-09 18:17 ` Laurent Pinchart 2019-02-09 18:17 ` Laurent Pinchart 2019-02-12 9:37 ` Frederic Chen 2019-02-12 9:37 ` Frederic Chen 2019-02-12 9:37 ` Frederic Chen 2019-02-13 3:41 ` Tomasz Figa 2019-02-13 3:41 ` Tomasz Figa 2019-02-13 3:41 ` Tomasz Figa 2019-02-01 11:21 ` [RFC PATCH V0 2/7] dts: arm64: mt8183: Add DIP shared memory node Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` [RFC PATCH V0 3/7] [media] dt-bindings: mt8183: Added DIP-SMEM dt-bindings Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-09 15:59 ` Sakari Ailus 2019-02-09 15:59 ` Sakari Ailus 2019-02-09 15:59 ` Sakari Ailus 2019-02-09 18:20 ` Laurent Pinchart 2019-02-09 18:20 ` Laurent Pinchart 2019-02-09 18:20 ` Laurent Pinchart 2019-02-12 9:50 ` Frederic Chen [this message] 2019-02-12 9:50 ` Frederic Chen 2019-02-01 11:21 ` [RFC PATCH V0 4/7] [media] dt-bindings: mt8183: Added DIP dt-bindings Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` [RFC PATCH V0 5/7] dts: arm64: mt8183: Add DIP nodes Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` [RFC PATCH V0 6/7] media: platform: Add Mediatek DIP driver KConfig Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-01 11:21 ` [RFC PATCH V0 7/7] [media] platform: mtk-isp: Add Mediatek DIP driver Frederic Chen 2019-02-01 11:21 ` Frederic Chen 2019-02-07 19:08 ` Brian Norris 2019-02-07 19:08 ` Brian Norris 2019-02-07 19:08 ` Brian Norris [not found] ` <1550756198.11724.86.camel@mtksdccf07> 2019-02-23 6:18 ` Frederic Chen 2019-02-23 6:18 ` Frederic Chen 2019-02-23 6:18 ` Frederic Chen 2019-02-28 3:24 ` Brian Norris 2019-02-28 3:24 ` Brian Norris 2019-02-28 3:24 ` Brian Norris 2019-03-06 17:07 ` Frederic Chen 2019-03-06 17:07 ` Frederic Chen 2019-03-06 17:07 ` Frederic Chen 2019-03-14 8:46 ` [RFC PATCH V0 0/7] media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC Hans Verkuil 2019-03-14 8:46 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1549965000.29488.4.camel@mtksdccf07 \ --to=frederic.chen@mediatek.com \ --cc=Jerry-ch.Chen@mediatek.com \ --cc=Rynn.Wu@mediatek.com \ --cc=Sean.Cheng@mediatek.com \ --cc=christie.yu@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=hans.verkuil@cisco.com \ --cc=holmes.chiou@mediatek.com \ --cc=jungo.lin@mediatek.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@iki.fi \ --cc=sj.huang@mediatek.com \ --cc=srv_heupstream@mediatek.com \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.