From: Philipp Zabel <p.zabel@pengutronix.de> To: Steve Longerbeam <slongerbeam@gmail.com>, linux-media@vger.kernel.org Cc: Tim Harvey <tharvey@gateworks.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, "open list:DRM DRIVERS FOR FREESCALE IMX" <dri-devel@lists.freedesktop.org>, open list <linux-kernel@vger.kernel.org>, "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>, "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org> Subject: Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding Date: Tue, 12 Feb 2019 12:34:22 +0100 [thread overview] Message-ID: <1549971262.4800.5.camel@pengutronix.de> (raw) In-Reply-To: <440e12af-33ea-5eac-e570-8afa74e3133c@gmail.com> Hi Steve, On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote: [...] > > Should we support YUV BT.601 <-> YUV REC.709 conversions? That would > > require separate encodings for input and output. > > How about if we pass the input and output encodings to the init ic task > functions, but for now require they be the same? We can support > transcoding in a later series. [...] > Again, I think for now, just include input/output quantization but > require full range for RGB and limited range for YUV. Yes, that is fine. I'd just like to avoid unnecessary interface changes between ipu-v3 and imx-media. So if we have to change it right now, why not plan ahead. > But that really balloons the arguments to ipu_ic_task_init_*(). Should > we create an ipu_ic_task_init structure? I wonder if we should just expose struct ic_csc_params and provide a helper to fill it given colorspace and V4L2 encoding/quantization parameters. Something like: struct ipu_ic_csc_params csc; imx_media_init_ic_csc_params(&csc, in_cs, in_encoding, in_quantization, out_cs, out_encoding, out_quantization); ipu_ic_task_init(ic, in_width, in_height, out_width, out_height, &csc); // or ipu_ic_task_init_rsc(ic, rsc, &csc); regards Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de> To: Steve Longerbeam <slongerbeam@gmail.com>, linux-media@vger.kernel.org Cc: Tim Harvey <tharvey@gateworks.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, "open list:DRM DRIVERS FOR FREESCALE IMX" <dri-devel@lists.freedesktop.org>, open list <linux-kernel@vger.kernel.org>, "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>, "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org> Subject: Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding Date: Tue, 12 Feb 2019 11:34:22 +0000 [thread overview] Message-ID: <1549971262.4800.5.camel@pengutronix.de> (raw) In-Reply-To: <440e12af-33ea-5eac-e570-8afa74e3133c@gmail.com> Hi Steve, On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote: [...] > > Should we support YUV BT.601 <-> YUV REC.709 conversions? That would > > require separate encodings for input and output. > > How about if we pass the input and output encodings to the init ic task > functions, but for now require they be the same? We can support > transcoding in a later series. [...] > Again, I think for now, just include input/output quantization but > require full range for RGB and limited range for YUV. Yes, that is fine. I'd just like to avoid unnecessary interface changes between ipu-v3 and imx-media. So if we have to change it right now, why not plan ahead. > But that really balloons the arguments to ipu_ic_task_init_*(). Should > we create an ipu_ic_task_init structure? I wonder if we should just expose struct ic_csc_params and provide a helper to fill it given colorspace and V4L2 encoding/quantization parameters. Something like: struct ipu_ic_csc_params csc; imx_media_init_ic_csc_params(&csc, in_cs, in_encoding, in_quantization, out_cs, out_encoding, out_quantization); ipu_ic_task_init(ic, in_width, in_height, out_width, out_height, &csc); // or ipu_ic_task_init_rsc(ic, rsc, &csc); regards Philipp
next prev parent reply other threads:[~2019-02-12 11:34 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-09 1:47 [PATCH v4 0/4] media: imx: Add support for BT.709 encoding Steve Longerbeam 2019-02-09 1:47 ` [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices Steve Longerbeam 2019-02-09 1:47 ` Steve Longerbeam 2019-02-11 9:58 ` Philipp Zabel 2019-02-11 9:58 ` Philipp Zabel 2019-02-11 18:24 ` Steve Longerbeam 2019-02-11 18:24 ` Steve Longerbeam 2019-02-12 10:17 ` Philipp Zabel 2019-02-12 10:17 ` Philipp Zabel 2019-02-12 17:42 ` Steve Longerbeam 2019-02-12 17:42 ` Steve Longerbeam 2019-02-13 10:35 ` Philipp Zabel 2019-02-13 10:35 ` Philipp Zabel 2019-02-14 18:54 ` Steve Longerbeam 2019-02-14 18:54 ` Steve Longerbeam 2019-02-11 23:33 ` Steve Longerbeam 2019-02-11 23:33 ` Steve Longerbeam 2019-02-09 1:47 ` [PATCH v4 2/4] gpu: ipu-v3: ipu-ic: Simplify selection of encoding matrix Steve Longerbeam 2019-02-09 1:47 ` Steve Longerbeam 2019-02-11 10:00 ` Philipp Zabel 2019-02-11 10:00 ` Philipp Zabel 2019-02-09 1:47 ` [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding Steve Longerbeam 2019-02-09 1:47 ` Steve Longerbeam 2019-02-09 1:47 ` Steve Longerbeam 2019-02-11 10:12 ` Philipp Zabel 2019-02-11 10:12 ` Philipp Zabel 2019-02-11 10:12 ` Philipp Zabel 2019-02-12 1:20 ` Steve Longerbeam 2019-02-12 1:20 ` Steve Longerbeam 2019-02-12 1:20 ` Steve Longerbeam 2019-02-12 11:34 ` Philipp Zabel [this message] 2019-02-12 11:34 ` Philipp Zabel 2019-02-12 11:34 ` Philipp Zabel 2019-02-12 17:50 ` Steve Longerbeam 2019-02-12 17:50 ` Steve Longerbeam 2019-02-12 17:50 ` Steve Longerbeam 2019-02-09 1:47 ` [PATCH v4 4/4] media: imx: Allow BT.709 encoding for IC routes Steve Longerbeam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1549971262.4800.5.camel@pengutronix.de \ --to=p.zabel@pengutronix.de \ --cc=b.zolnierkie@samsung.com \ --cc=devel@driverdev.osuosl.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=slongerbeam@gmail.com \ --cc=tharvey@gateworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.